)]}'
{"nova/conf/wsgi.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3466e2bfe7d4e814cb9a87efb66824c4bae70d45","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def list_opts():"},{"line_number":107,"context_line":"    # Because of bug 1395819 in oslo.config we cannot pass in the OptGroup."},{"line_number":108,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":109,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":110,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":111,"context_line":"    return (wsgi_group.name, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_134c5d41","line":110,"range":{"start_line":107,"start_character":0,"end_line":110,"end_character":68},"updated":"2016-01-19 14:48:35.000000000","message":"That\u0027s not up-to-date anymore. We can use the OptGroup directly below:\n\n    return {wsgi_group: ALL_OPTS}","commit_id":"1325bf619d8b9490114108607343674298672238"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3466e2bfe7d4e814cb9a87efb66824c4bae70d45","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":109,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":110,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":111,"context_line":"    return (wsgi_group.name, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_d3e7a53e","line":111,"updated":"2016-01-19 14:48:35.000000000","message":"We need a reno file for config option deprecations (which we do when we move them to a new group) [1].\n\n[1] http://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed","commit_id":"1325bf619d8b9490114108607343674298672238"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"34657310d1231e4a8d10e78c6dffac3560b73475","unresolved":false,"context_lines":[{"line_number":72,"context_line":"              \"Keystone v3 API with big service catalogs).\","},{"line_number":73,"context_line":"         deprecated_group\u003d\u0027DEFAULT\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"wsgi_keep_alive_opt \u003d cfg.BoolOpt(\u0027wsgi_keep_alive\u0027,"},{"line_number":76,"context_line":"         default\u003dTrue,"},{"line_number":77,"context_line":"         help\u003d\"If False, closes the client socket connection \""},{"line_number":78,"context_line":"              \"explicitly.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_089e7e07","line":75,"updated":"2016-02-09 14:32:43.000000000","message":"I wonder if we should rename this to keep_alive, now its in a group, but that can be a follow on.","commit_id":"29604111be433d0baae05252eece0cd42d09e3ce"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d39c3fa659d3adff1a98539c67ed9ad945016e4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"              \"Keystone v3 API with big service catalogs).\","},{"line_number":73,"context_line":"         deprecated_group\u003d\u0027DEFAULT\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"wsgi_keep_alive_opt \u003d cfg.BoolOpt(\u0027wsgi_keep_alive\u0027,"},{"line_number":76,"context_line":"         default\u003dTrue,"},{"line_number":77,"context_line":"         help\u003d\"If False, closes the client socket connection \""},{"line_number":78,"context_line":"              \"explicitly.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_e0d140fd","line":75,"in_reply_to":"5a5ae5dd_089e7e07","updated":"2016-02-15 11:56:31.000000000","message":"Done in a follow-up change","commit_id":"29604111be433d0baae05252eece0cd42d09e3ce"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"aaabee2d1e104986b2cae234b90f7fd502984ddb","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            ]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def register_opts(conf):"},{"line_number":103,"context_line":"    conf.register_opts(ALL_OPTS)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_691d270f","line":102,"updated":"2016-02-15 07:42:45.000000000","message":"\u0027conf.register_group(wsgi_group)\u0027 should be added.","commit_id":"29604111be433d0baae05252eece0cd42d09e3ce"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d39c3fa659d3adff1a98539c67ed9ad945016e4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            ]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def register_opts(conf):"},{"line_number":103,"context_line":"    conf.register_opts(ALL_OPTS)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_e0cae04e","line":102,"in_reply_to":"dae33548_691d270f","updated":"2016-02-15 11:56:31.000000000","message":"Done","commit_id":"29604111be433d0baae05252eece0cd42d09e3ce"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"aaabee2d1e104986b2cae234b90f7fd502984ddb","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def register_opts(conf):"},{"line_number":103,"context_line":"    conf.register_opts(ALL_OPTS)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_e9d77721","line":103,"updated":"2016-02-15 07:42:45.000000000","message":"This should be \u0027conf.register_opts(ALL_OPTS, group\u003dwsgi_group)\u0027","commit_id":"29604111be433d0baae05252eece0cd42d09e3ce"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d39c3fa659d3adff1a98539c67ed9ad945016e4","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def register_opts(conf):"},{"line_number":103,"context_line":"    conf.register_opts(ALL_OPTS)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_a0b0d8de","line":103,"in_reply_to":"dae33548_e9d77721","updated":"2016-02-15 11:56:31.000000000","message":"Done","commit_id":"29604111be433d0baae05252eece0cd42d09e3ce"}],"releasenotes/notes/add-wsgi-config-to-wsgi-group-712b8cd9ada65b2e.yaml":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"34657310d1231e4a8d10e78c6dffac3560b73475","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - All WSGI configuration options have been added to the \u0027wsgi\u0027 group."},{"line_number":4,"context_line":"    They should no longer be included in the \u0027DEFAULT\u0027 group."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a5ae5dd_c8af062a","line":4,"updated":"2016-02-09 14:32:43.000000000","message":"Nit: I feel like this should list out all the moved options, but maybe thats too verbose?","commit_id":"29604111be433d0baae05252eece0cd42d09e3ce"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"902b1826ed6632dce17549487d11eb34506acabe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - All WSGI configuration options have been added to the \u0027wsgi\u0027 group."},{"line_number":4,"context_line":"    They should no longer be included in the \u0027DEFAULT\u0027 group."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a5ae5dd_26560b07","line":4,"in_reply_to":"5a5ae5dd_c8af062a","updated":"2016-02-09 14:52:49.000000000","message":"actually, this is specific enough, as it mentions the name of the new group.","commit_id":"29604111be433d0baae05252eece0cd42d09e3ce"}]}