)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"226c8662a4b3337c04026ea1c67343d1eee2d913","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"        utils.execute(*cmd, run_as_root\u003dTrue)"},{"line_number":1345,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":1346,"context_line":"        raise exception.VirtualInterfacePlugException("},{"line_number":1347,"context_line":"            _(\"Plug vif failed because command gave exit code %(exit_code)d:\""},{"line_number":1348,"context_line":"              \" %(cmd)s\\n\""},{"line_number":1349,"context_line":"              \"Stdout: %(stdout)s\\n\""},{"line_number":1350,"context_line":"              \"Stderr: %(stderr)s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_ee921257","line":1347,"range":{"start_line":1347,"start_character":15,"end_line":1347,"end_character":23},"updated":"2016-01-12 14:35:01.000000000","message":"How about \u0027Failed creating veth pair because...\u0027","commit_id":"a35ece999ab3bfaea4dd9cc3f288efc97da59d76"}],"nova/tests/unit/network/test_linux_net.py":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"64518e5330f8ee3f40ccd63401a0ec0f2f6a2be7","unresolved":false,"context_lines":[{"line_number":1289,"context_line":"        self._create_veth_pair(calls)"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"    def test_create_veth_pair_fail_to_up(self):"},{"line_number":1292,"context_line":"        # HNOV-482"},{"line_number":1293,"context_line":"        calls \u003d ["},{"line_number":1294,"context_line":"            mock.call(\u0027ip\u0027, \u0027link\u0027, \u0027add\u0027, \u0027fake-dev1\u0027, \u0027type\u0027, \u0027veth\u0027,"},{"line_number":1295,"context_line":"                      \u0027peer\u0027, \u0027name\u0027, \u0027fake-dev2\u0027, run_as_root\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_c7bfe8ce","line":1292,"range":{"start_line":1292,"start_character":8,"end_line":1292,"end_character":18},"updated":"2016-01-12 17:35:46.000000000","message":"what is that?\nIt seems like an internal bug tracker ticket ;)","commit_id":"4126974ef3ab9fb9fbfea3d077fc1e39664ce3bd"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"5e3e692ec110d949b70a1d6bd0b7ce5d756bf507","unresolved":false,"context_lines":[{"line_number":1289,"context_line":"        self._create_veth_pair(calls)"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"    def test_create_veth_pair_fail_to_up(self):"},{"line_number":1292,"context_line":"        # HNOV-482"},{"line_number":1293,"context_line":"        calls \u003d ["},{"line_number":1294,"context_line":"            mock.call(\u0027ip\u0027, \u0027link\u0027, \u0027add\u0027, \u0027fake-dev1\u0027, \u0027type\u0027, \u0027veth\u0027,"},{"line_number":1295,"context_line":"                      \u0027peer\u0027, \u0027name\u0027, \u0027fake-dev2\u0027, run_as_root\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_105f7342","line":1292,"range":{"start_line":1292,"start_character":8,"end_line":1292,"end_character":18},"in_reply_to":"da6ed579_c7bfe8ce","updated":"2016-01-12 20:20:02.000000000","message":"oooops nothing to see here, move along","commit_id":"4126974ef3ab9fb9fbfea3d077fc1e39664ce3bd"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3806bea7a67dbed42dd98c9c807032343e63ee01","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        try:"},{"line_number":767,"context_line":"            func(instance, vif)"},{"line_number":768,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":769,"context_line":"            raise exception.VirtualInterfacePlugException(cause\u003de)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"    def unplug_bridge(self, instance, vif):"},{"line_number":772,"context_line":"        \"\"\"No manual unplugging required.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_834aae24","line":769,"updated":"2016-04-19 11:08:09.000000000","message":"Do we need to catch this exception somewhere in a higher layer of nova? Can it cause HTTP500 to be returned on a API?","commit_id":"1f94bd0dad9c3a820627b208a04b2cc7897f0aa4"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"ffea37ce49a7bbd60aacd52e606a39ac85959282","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        try:"},{"line_number":767,"context_line":"            func(instance, vif)"},{"line_number":768,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":769,"context_line":"            raise exception.VirtualInterfacePlugException(cause\u003de)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"    def unplug_bridge(self, instance, vif):"},{"line_number":772,"context_line":"        \"\"\"No manual unplugging required.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_9f9ef661","line":769,"in_reply_to":"1a122d0e_834aae24","updated":"2016-04-21 14:23:59.000000000","message":"it\u0027s already thrown by line 757 so it should already be caught; at least we are no more broken now","commit_id":"1f94bd0dad9c3a820627b208a04b2cc7897f0aa4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"922c5afd385ebca5811d211c47273d0ae9bf7e90","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        try:"},{"line_number":767,"context_line":"            func(instance, vif)"},{"line_number":768,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":769,"context_line":"            raise exception.VirtualInterfacePlugException(cause\u003de)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"    def unplug_bridge(self, instance, vif):"},{"line_number":772,"context_line":"        \"\"\"No manual unplugging required.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_18ddd014","line":769,"in_reply_to":"1a122d0e_9f9ef661","updated":"2016-05-18 12:46:14.000000000","message":"I found it to be expected only in nova.compute.manager.init_instance [1] but I guess this exception can happen not only at service startup but during normal instance boot. Does it handled as a generic exception (NovaException) there?\n\nBut I agree that we are not more broken than before.\n\n[1] https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L966","commit_id":"1f94bd0dad9c3a820627b208a04b2cc7897f0aa4"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"edae08aa96864fc2e4e8a464239adf58e3dd3ca2","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        try:"},{"line_number":756,"context_line":"            linux_net.create_tap_dev(dev)"},{"line_number":757,"context_line":"            utils.execute(\u0027vrouter-port-control\u0027, cmd_args, run_as_root\u003dTrue)"},{"line_number":758,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":759,"context_line":"            LOG.exception(_LE(\"Failed while plugging vif\"), instance\u003dinstance)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    def plug(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_d0afb292","side":"PARENT","line":758,"updated":"2016-08-08 09:44:19.000000000","message":"Some of plug_.*() methods here like this one already except  processutils.ProcessExecutionError and won\u0027t re-raise the error. Not sure if that\u0027s what plug() expects from them.","commit_id":"1cb9195aa8e8525c6f8c723bf02d1d29311925cf"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"8c58aca7418a471f4106421e6a45710b72e848f6","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        try:"},{"line_number":756,"context_line":"            linux_net.create_tap_dev(dev)"},{"line_number":757,"context_line":"            utils.execute(\u0027vrouter-port-control\u0027, cmd_args, run_as_root\u003dTrue)"},{"line_number":758,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":759,"context_line":"            LOG.exception(_LE(\"Failed while plugging vif\"), instance\u003dinstance)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    def plug(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_d916b1a6","side":"PARENT","line":758,"in_reply_to":"9ad45d7e_d0afb292","updated":"2016-08-08 13:38:26.000000000","message":"Yeah, me either, I think it\u0027s safer to reraise since we\u0027re unsure. Currently a ProcessExecutionError brings the service down, anything is an improvement on that I think. If it turns out we don\u0027t want the request to fail either, that can be a follow-up patch.","commit_id":"1cb9195aa8e8525c6f8c723bf02d1d29311925cf"}]}