)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1a4ca33f427c4f853386b6d36525fbf68363a147","unresolved":false,"context_lines":[{"line_number":992,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING,"},{"line_number":993,"context_line":"                   \u0027do_system_metadata\u0027: False,"},{"line_number":994,"context_line":"                   \u0027do_metadata\u0027: False}"},{"line_number":995,"context_line":"        building_insts \u003d self.conductor_api.instance_get_all_by_filters("},{"line_number":996,"context_line":"            context, filters)"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"        for instance in building_insts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F%2B%2BY%3D","line":995,"updated":"2013-04-09 05:45:44.000000000","message":"Should this just be selecting instances on its own host?","commit_id":"2cc18629d3ab551252051e70fd37f882d7dd23af"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"8ac53944533043f39c1e0e98a15bf9173c7706c7","unresolved":false,"context_lines":[{"line_number":992,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING,"},{"line_number":993,"context_line":"                   \u0027do_system_metadata\u0027: False,"},{"line_number":994,"context_line":"                   \u0027do_metadata\u0027: False}"},{"line_number":995,"context_line":"        building_insts \u003d self.conductor_api.instance_get_all_by_filters("},{"line_number":996,"context_line":"            context, filters)"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"        for instance in building_insts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F%2BwE%3D","line":995,"in_reply_to":"AAAAOn%2F%2F%2B%2BY%3D","updated":"2013-04-09 10:04:38.000000000","message":"I think Josh might be right here?","commit_id":"2cc18629d3ab551252051e70fd37f882d7dd23af"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cf402f147f1787d84ddef623c80461ed516d69a3","unresolved":false,"context_lines":[{"line_number":992,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING,"},{"line_number":993,"context_line":"                   \u0027do_system_metadata\u0027: False,"},{"line_number":994,"context_line":"                   \u0027do_metadata\u0027: False}"},{"line_number":995,"context_line":"        building_insts \u003d self.conductor_api.instance_get_all_by_filters("},{"line_number":996,"context_line":"            context, filters)"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"        for instance in building_insts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F%2BkA%3D","line":995,"in_reply_to":"AAAAOn%2F%2F%2BwE%3D","updated":"2013-04-09 13:33:54.000000000","message":"Yeah, I think so too.","commit_id":"2cc18629d3ab551252051e70fd37f882d7dd23af"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d4bd43bb3714d4bf9c619e15c50fc0d8bcacba89","unresolved":false,"context_lines":[{"line_number":990,"context_line":"            return"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING}"},{"line_number":993,"context_line":"        building_insts \u003d self.conductor_api.instance_get_all_by_filters("},{"line_number":994,"context_line":"            context, filters)"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"        for instance in building_insts:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F%2BAc%3D","side":"PARENT","line":993,"updated":"2013-04-09 19:01:09.000000000","message":"Future optimization:  Ditch the joins of info_cache and security_groups, too.","commit_id":"a91724b5eb67d6a2636a894fe630a5f5f24f8ea0"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"a874b3f5642498571c42b5af610c5e0b1df9bd82","unresolved":false,"context_lines":[{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING,"},{"line_number":993,"context_line":"                   \u0027host\u0027: self.host,"},{"line_number":994,"context_line":"                   \u0027do_system_metadata\u0027: False,"},{"line_number":995,"context_line":"                   \u0027do_metadata\u0027: False}"},{"line_number":996,"context_line":"        building_insts \u003d self.conductor_api.instance_get_all_by_filters("},{"line_number":997,"context_line":"            context, filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F96Q%3D","line":994,"updated":"2013-04-09 20:31:29.000000000","message":"The 2 \u0027do_\u0027 flags aren\u0027t really filters per se..they\u0027re more like commands.  Perhaps add \u0027commands\u0027 or \u0027soft_joins\u0027 as a separate kwarg to instance_get_all_by_filters?","commit_id":"07176382c2f582929f15d78374dfe0571143d5e3"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"2ee2b505d53f1a2c61d964aabdfe3d6d2ba30c3a","unresolved":false,"context_lines":[{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING,"},{"line_number":993,"context_line":"                   \u0027host\u0027: self.host,"},{"line_number":994,"context_line":"                   \u0027do_system_metadata\u0027: False,"},{"line_number":995,"context_line":"                   \u0027do_metadata\u0027: False}"},{"line_number":996,"context_line":"        building_insts \u003d self.conductor_api.instance_get_all_by_filters("},{"line_number":997,"context_line":"            context, filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F910%3D","line":994,"in_reply_to":"AAAAOn%2F%2F928%3D","updated":"2013-04-09 21:12:18.000000000","message":"Hmm, probably not worth that level of effort if we are going to gradually strangle out uses of this soft joining.","commit_id":"07176382c2f582929f15d78374dfe0571143d5e3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"05ed2c13ea165990398dd877333d2372ee5b996d","unresolved":false,"context_lines":[{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING,"},{"line_number":993,"context_line":"                   \u0027host\u0027: self.host,"},{"line_number":994,"context_line":"                   \u0027do_system_metadata\u0027: False,"},{"line_number":995,"context_line":"                   \u0027do_metadata\u0027: False}"},{"line_number":996,"context_line":"        building_insts \u003d self.conductor_api.instance_get_all_by_filters("},{"line_number":997,"context_line":"            context, filters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F928%3D","line":994,"in_reply_to":"AAAAOn%2F%2F96Q%3D","updated":"2013-04-09 21:00:02.000000000","message":"Well, that means we have to populate that API change all the way through conductor, etc. I can do that, it just didn\u0027t seem to be that much of a departure from the rest of the filters, but maybe it is...","commit_id":"07176382c2f582929f15d78374dfe0571143d5e3"}]}