)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"132d8dc6a0b4355d1b1a0638f40cffaa357bcdf5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdanms@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-04-09 17:01:03 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change DB API instance functions for selective metadata fetching"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes the DB API for instance_get_all() variants able to take do_metadata"},{"line_number":10,"context_line":"and do_sys_meta flags, which control whether we got to the trouble of pulling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOn%2F%2F9dc%3D","line":7,"updated":"2013-04-10 03:31:03.000000000","message":"Missing full stop :).","commit_id":"6486610a6e1af1365364f141ba72ff9106027a90"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"132d8dc6a0b4355d1b1a0638f40cffaa357bcdf5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes the DB API for instance_get_all() variants able to take do_metadata"},{"line_number":10,"context_line":"and do_sys_meta flags, which control whether we got to the trouble of pulling"},{"line_number":11,"context_line":"those bits out of the database before we return the instances."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related to bug 1164737"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOn%2F%2F9dU%3D","line":11,"updated":"2013-04-10 03:31:03.000000000","message":"I had to read this twice to understand it. If I may suggest, for clarity:\n\n\u0027Add do_metadata and do_sys_metadata flags to the DB API for instance_get_all() and variants. These flags control whether the relevant bits are extracted from the database or left unset.\u0027","commit_id":"6486610a6e1af1365364f141ba72ff9106027a90"}],"nova/conductor/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"c9b9327e2f124894895898057c412b446392d20d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return self._manager.instance_get_all(context)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def instance_get_all_by_host(self, context, host, do_metadata\u003dTrue,"},{"line_number":80,"context_line":"                                 do_sys_meta\u003dTrue):"},{"line_number":81,"context_line":"        return self._manager.instance_get_all_by_host(context, host,"},{"line_number":82,"context_line":"                                                      do_metadata\u003ddo_metadata,"},{"line_number":83,"context_line":"                                                      do_sys_meta\u003ddo_sys_meta)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2F%2BAA%3D","line":80,"updated":"2013-04-09 19:03:39.000000000","message":"I think instance_get_all() accepts a list of things to join.  If there\u0027s more things to not join, I worry about the argument list growing.  I think we should standardize on some way.  I tend to prefer the list.  Just a thought.","commit_id":"38b8aba83309c5ae2a9062aecae47d5bddd1bd79"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"132d8dc6a0b4355d1b1a0638f40cffaa357bcdf5","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def instance_get_all_by_host(self, context, host, columns_to_join\u003dNone):"},{"line_number":80,"context_line":"        return self._manager.instance_get_all_by_host(context, host,"},{"line_number":81,"context_line":"                                                      columns_to_join)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def instance_get_all_by_host_and_node(self, context, host, node):"},{"line_number":84,"context_line":"        return self._manager.instance_get_all_by_host(context, host, node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2F9dQ%3D","line":81,"updated":"2013-04-10 03:31:03.000000000","message":"None of the changes in this file seem to match the intent of the commit message.","commit_id":"6486610a6e1af1365364f141ba72ff9106027a90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f53811e7c91f3731cc1a0a7ba72cfcba9e5a4b04","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def instance_get_all_by_host(self, context, host, columns_to_join\u003dNone):"},{"line_number":80,"context_line":"        return self._manager.instance_get_all_by_host(context, host,"},{"line_number":81,"context_line":"                                                      columns_to_join)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def instance_get_all_by_host_and_node(self, context, host, node):"},{"line_number":84,"context_line":"        return self._manager.instance_get_all_by_host(context, host, node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2F89U%3D","line":81,"in_reply_to":"AAAAOn%2F%2F9dQ%3D","updated":"2013-04-10 13:44:45.000000000","message":"They match the intent, not the letter. This time around, the do_ flags were replaced with the columns_to_join to better match existing convention in the file. So yeah, the commit message needs updating.","commit_id":"6486610a6e1af1365364f141ba72ff9106027a90"}],"nova/conductor/manager.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"132d8dc6a0b4355d1b1a0638f40cffaa357bcdf5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class ConductorManager(manager.Manager):"},{"line_number":50,"context_line":"    \"\"\"Mission: TBD.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    RPC_API_VERSION \u003d \u00271.47\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":55,"context_line":"        super(ConductorManager, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2F9dA%3D","line":52,"updated":"2013-04-10 03:31:03.000000000","message":"I\u0027m still new to the RPC stuff, but when you bump this, don\u0027t you need to take all the current unversioned methods that are not affected, and clamp their version to 1.46, so that you don\u0027t get a spurious hard dependency on 1.47? OR does that only happen in the rpcapi.py file?","commit_id":"6486610a6e1af1365364f141ba72ff9106027a90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f53811e7c91f3731cc1a0a7ba72cfcba9e5a4b04","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class ConductorManager(manager.Manager):"},{"line_number":50,"context_line":"    \"\"\"Mission: TBD.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    RPC_API_VERSION \u003d \u00271.47\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":55,"context_line":"        super(ConductorManager, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2F88w%3D","line":52,"in_reply_to":"AAAAOn%2F%2F9dA%3D","updated":"2013-04-10 13:44:45.000000000","message":"No, unversioned methods are 1.0. This version tells clients that they can expect this level of functionality (and compatibility with older clients as well). Effectively telling them that this manager is \"new enough\" to support the columns_to_join functionality.","commit_id":"6486610a6e1af1365364f141ba72ff9106027a90"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"132d8dc6a0b4355d1b1a0638f40cffaa357bcdf5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        return jsonutils.to_primitive(self.db.instance_get_all(context))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def instance_get_all_by_host(self, context, host, node\u003dNone,"},{"line_number":113,"context_line":"                                 columns_to_join\u003dNone):"},{"line_number":114,"context_line":"        if node is not None:"},{"line_number":115,"context_line":"            result \u003d self.db.instance_get_all_by_host_and_node("},{"line_number":116,"context_line":"                context.elevated(), host, node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2F9dM%3D","line":113,"updated":"2013-04-10 03:31:03.000000000","message":"Same as for api.py - how is this connected to the commit message?","commit_id":"6486610a6e1af1365364f141ba72ff9106027a90"}]}