)]}'
{"nova/pci/stats.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ce5ab1791ba5178b031c96c3a99e26b99dcf3723","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        # Don\u0027t add a device that doesn\u0027t have a matching device spec."},{"line_number":92,"context_line":"        # This can happen during initial sync up with the controller"},{"line_number":93,"context_line":"        devspec \u003d self.dev_filter.get_devspec(dev)"},{"line_number":94,"context_line":"        if not devspec:"},{"line_number":95,"context_line":"            return"},{"line_number":96,"context_line":"        tags \u003d devspec.get_tags()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_84327ff0","line":93,"updated":"2016-03-09 19:48:46.000000000","message":"Looks like whitelist.get_pci_device_devspec won\u0027t be used anymore.  It would be better to remove it from nova/pci/whitelist.py.","commit_id":"4be8f84754f4d57b621a3e458846d15a6932a396"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"d5d394e45a5822b9235c55621e011146784b527f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        # Don\u0027t add a device that doesn\u0027t have a matching device spec."},{"line_number":92,"context_line":"        # This can happen during initial sync up with the controller"},{"line_number":93,"context_line":"        devspec \u003d self.dev_filter.get_devspec(dev)"},{"line_number":94,"context_line":"        if not devspec:"},{"line_number":95,"context_line":"            return"},{"line_number":96,"context_line":"        tags \u003d devspec.get_tags()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_5f46824f","line":93,"in_reply_to":"5aef4532_444197a8","updated":"2016-03-09 20:04:26.000000000","message":"My bad, did a quick grep in the code and miss the one in neutronv2 api.\n\nI guess fixing it in neutronv2 api would be helpful.  Maybe in a subsequent patch (perhaps not needed in this one).","commit_id":"4be8f84754f4d57b621a3e458846d15a6932a396"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"622ad4108f1dd2e142121cd486cd5cc0d230259d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        # Don\u0027t add a device that doesn\u0027t have a matching device spec."},{"line_number":92,"context_line":"        # This can happen during initial sync up with the controller"},{"line_number":93,"context_line":"        devspec \u003d self.dev_filter.get_devspec(dev)"},{"line_number":94,"context_line":"        if not devspec:"},{"line_number":95,"context_line":"            return"},{"line_number":96,"context_line":"        tags \u003d devspec.get_tags()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_444197a8","line":93,"in_reply_to":"5aef4532_84327ff0","updated":"2016-03-09 20:00:20.000000000","message":"It is still used by nova/network/neutronv2/api.py:_populate_neutron_binding_profile(). Do you suggest to store Whitelist object in api.py as well?","commit_id":"4be8f84754f4d57b621a3e458846d15a6932a396"}]}