)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"8bfb7b9811620435402c831cc1c5de9748db8a20","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                                         size, sparse\u003dself.sparse)"},{"line_number":632,"context_line":"            if self.ephemeral_key_uuid is not None:"},{"line_number":633,"context_line":"                encrypt_lvm_image()"},{"line_number":634,"context_line":"            # NOTE: by calling convert_image_unsafe here we\u0027re"},{"line_number":635,"context_line":"            # telling qemu-img convert to do format detection on the input,"},{"line_number":636,"context_line":"            # because we don\u0027t know what the format is. For example,"},{"line_number":637,"context_line":"            # we might have downloaded a qcow2 image, or created an"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_5f7de6e5","line":634,"range":{"start_line":634,"start_character":18,"end_line":634,"end_character":19},"updated":"2016-01-13 06:07:38.000000000","message":"I think you may add the author name here","commit_id":"a9c8dee7ec81d6331c3699a2dda3a57b48ecfe5c"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1895f06da97b0a5248bb28f20148556d485dfbb3","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                                         size, sparse\u003dself.sparse)"},{"line_number":632,"context_line":"            if self.ephemeral_key_uuid is not None:"},{"line_number":633,"context_line":"                encrypt_lvm_image()"},{"line_number":634,"context_line":"            # NOTE: by calling convert_image_unsafe here we\u0027re"},{"line_number":635,"context_line":"            # telling qemu-img convert to do format detection on the input,"},{"line_number":636,"context_line":"            # because we don\u0027t know what the format is. For example,"},{"line_number":637,"context_line":"            # we might have downloaded a qcow2 image, or created an"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_9fb6fd88","line":634,"range":{"start_line":634,"start_character":18,"end_line":634,"end_character":19},"in_reply_to":"da6ed579_5f7de6e5","updated":"2016-01-13 06:42:02.000000000","message":"That is the convention but it\u0027s optional.  Also this is a stable review, that means that the backported code should, where possible, match the commit in master.\n\nSo it\u0027d need to be fixed in master not here.","commit_id":"a9c8dee7ec81d6331c3699a2dda3a57b48ecfe5c"},{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"8bfb7b9811620435402c831cc1c5de9748db8a20","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            # audited this, all current sources have been sanity checked,"},{"line_number":640,"context_line":"            # either because they\u0027re locally generated, or because they have"},{"line_number":641,"context_line":"            # come from images.fetch_to_raw. However, this is major code smell."},{"line_number":642,"context_line":"            images.convert_image_unsafe(base, self.path, self.driver_format,"},{"line_number":643,"context_line":"                                        run_as_root\u003dTrue)"},{"line_number":644,"context_line":"            if resize:"},{"line_number":645,"context_line":"                disk.resize2fs(self.path, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_1fd52eb8","line":642,"range":{"start_line":642,"start_character":62,"end_line":642,"end_character":75},"updated":"2016-01-13 06:07:38.000000000","message":"why change out_format from \u0027raw\u0027 to driver_format. I think \u0027raw\u0027 is needed here. Are other formats able to resize2fs?","commit_id":"a9c8dee7ec81d6331c3699a2dda3a57b48ecfe5c"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1895f06da97b0a5248bb28f20148556d485dfbb3","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            # audited this, all current sources have been sanity checked,"},{"line_number":640,"context_line":"            # either because they\u0027re locally generated, or because they have"},{"line_number":641,"context_line":"            # come from images.fetch_to_raw. However, this is major code smell."},{"line_number":642,"context_line":"            images.convert_image_unsafe(base, self.path, self.driver_format,"},{"line_number":643,"context_line":"                                        run_as_root\u003dTrue)"},{"line_number":644,"context_line":"            if resize:"},{"line_number":645,"context_line":"                disk.resize2fs(self.path, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_1f820d95","line":642,"range":{"start_line":642,"start_character":62,"end_line":642,"end_character":75},"in_reply_to":"da6ed579_1fd52eb8","updated":"2016-01-13 06:42:02.000000000","message":"Yes other formats can be resized. BUT self.diver_format will be \u0027raw\u0027 anyway.\n\nAlso see previous comments about stable back ports.","commit_id":"a9c8dee7ec81d6331c3699a2dda3a57b48ecfe5c"}]}