)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a3e22778f05ca930bdd4a59e1993af8427976493","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug 1166906"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Added extra states to constant module together with test cases"},{"line_number":12,"context_line":"checking every state map."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also added some debug statements under blockdev and operator"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOn%2F%2F5VQ%3D","line":11,"updated":"2013-04-12 15:48:26.000000000","message":"s/constant/constants/","commit_id":"a6be16b5c9f257368afdc5d5b882c81f6ef6c77a"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"fcbdc2105b8b1c41d618a00309ce4131ef194a77","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug 1166906"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Added extra states to constant module together with test cases"},{"line_number":12,"context_line":"checking every state map."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also added some debug statements under blockdev and operator"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOn%2F%2F49o%3D","line":11,"in_reply_to":"AAAAOn%2F%2F5VQ%3D","updated":"2013-04-12 20:04:00.000000000","message":"thanks, fixing","commit_id":"a6be16b5c9f257368afdc5d5b882c81f6ef6c77a"}],"nova/tests/test_powervm.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e2999034b1b9d593a32fad9a4e35aefe963e8616","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        self._set_get_info_stub(\u0027Open Firmware\u0027)"},{"line_number":299,"context_line":"        info_dict \u003d self.powervm_connection.get_info(self.instance)"},{"line_number":300,"context_line":"        self.assertEqual(info_dict[\u0027state\u0027], power_state.CRASHED)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def test_destroy(self):"},{"line_number":303,"context_line":"        self.powervm_connection.destroy(self.instance, None)"},{"line_number":304,"context_line":"        self.stubs.Set(FakeIVMOperator, \u0027get_lpar\u0027, lambda x, y: None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F914%3D","line":301,"updated":"2013-04-09 21:12:30.000000000","message":"suggest add a test where set the state to some unexpected string. Does an unexpected state string raise an exception, or return NOSTATE, or CRASHED?","commit_id":"9bddedc0e01556ea8ce486e4aedb6ce0eae40c5e"}],"nova/virt/powervm/blockdev.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"636b2530a73e7df62c017cc5bd46b6cb19a5cc7f","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        error_text \u003d stderr.strip()"},{"line_number":538,"context_line":"        if error_text:"},{"line_number":539,"context_line":"            LOG.debug("},{"line_number":540,"context_line":"                _(\"Found error stream for command \\\"%(cmd)s\\\": %(error_text)s\")"},{"line_number":541,"context_line":"                % locals())"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        return stdout.strip().splitlines()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F7%2FU%3D","line":540,"updated":"2013-04-10 21:03:46.000000000","message":"For consistency should this be changed in operator.py too? Doesn\u0027t it have the same run_vios_command and run_vios_command_as_root methods?","commit_id":"c69e038b1bfe55b62b1183ef742a325595e8dfa0"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"915a571e9618536796440a65e409403c9c4a3373","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        if error_text:"},{"line_number":539,"context_line":"            LOG.debug("},{"line_number":540,"context_line":"                _(\"Found error stream for command \\\"%(cmd)s\\\": %(error_text)s\")"},{"line_number":541,"context_line":"                % locals())"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        return stdout.strip().splitlines()"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F56Q%3D","line":541,"updated":"2013-04-12 02:56:05.000000000","message":"Adding that yes, blockdev is of more interest given that it handles image copy from/to disk devices, but yeah it does not heard to add more debug statement on operator as well","commit_id":"c69e038b1bfe55b62b1183ef742a325595e8dfa0"}],"nova/virt/powervm/constants.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"96e91a54b686da0c3a1f893d77b6217e0f0de92f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    POWERVM_RUNNING: power_state.RUNNING,"},{"line_number":30,"context_line":"    POWERVM_STARTING: power_state.RUNNING,"},{"line_number":31,"context_line":"    POWERVM_SHUTDOWN: power_state.SHUTDOWN,"},{"line_number":32,"context_line":"    POWERVM_SHUTTING_DOWN: power_state.SHUTDOWN,"},{"line_number":33,"context_line":"    POWERVM_ERROR: power_state.CRASHED,"},{"line_number":34,"context_line":"    POWERVM_OPEN_FIRMWARE: power_state.CRASHED,"},{"line_number":35,"context_line":"    POWERVM_NOT_AVIALABLE: power_state.CRASHED"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F90g%3D","line":32,"updated":"2013-04-09 21:19:13.000000000","message":"Here isn\u0027t the LPAR in transition to shutting down and not completely shut down yet? In which case should we consider having a mapping that addresses that? \n\nHere we are indicating the LPAR is shutdown before it actually is?","commit_id":"9bddedc0e01556ea8ce486e4aedb6ce0eae40c5e"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"1373310546c1558b2470426537306df3003f6cca","unresolved":false,"context_lines":[{"line_number":22,"context_line":"POWERVM_SHUTDOWN \u003d \u0027Not Activated\u0027"},{"line_number":23,"context_line":"POWERVM_SHUTTING_DOWN \u003d \u0027Shutting Down\u0027"},{"line_number":24,"context_line":"POWERVM_ERROR \u003d \u0027Error\u0027"},{"line_number":25,"context_line":"POWERVM_NOT_AVIALABLE \u003d \u0027Not Available\u0027"},{"line_number":26,"context_line":"POWERVM_OPEN_FIRMWARE \u003d \u0027Open Firmware\u0027"},{"line_number":27,"context_line":"POWERVM_POWER_STATE \u003d {"},{"line_number":28,"context_line":"    POWERVM_NOSTATE: power_state.NOSTATE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F7VU%3D","line":25,"updated":"2013-04-11 07:21:56.000000000","message":"Looks like a typo in POWERVM_NOT_AVIALABLE?","commit_id":"c69e038b1bfe55b62b1183ef742a325595e8dfa0"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"915a571e9618536796440a65e409403c9c4a3373","unresolved":false,"context_lines":[{"line_number":22,"context_line":"POWERVM_SHUTDOWN \u003d \u0027Not Activated\u0027"},{"line_number":23,"context_line":"POWERVM_SHUTTING_DOWN \u003d \u0027Shutting Down\u0027"},{"line_number":24,"context_line":"POWERVM_ERROR \u003d \u0027Error\u0027"},{"line_number":25,"context_line":"POWERVM_NOT_AVIALABLE \u003d \u0027Not Available\u0027"},{"line_number":26,"context_line":"POWERVM_OPEN_FIRMWARE \u003d \u0027Open Firmware\u0027"},{"line_number":27,"context_line":"POWERVM_POWER_STATE \u003d {"},{"line_number":28,"context_line":"    POWERVM_NOSTATE: power_state.NOSTATE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F554%3D","line":25,"in_reply_to":"AAAAOn%2F%2F7VU%3D","updated":"2013-04-12 02:56:05.000000000","message":"Good catch, thanks","commit_id":"c69e038b1bfe55b62b1183ef742a325595e8dfa0"}]}
