)]}'
{"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3e190abfd93e3534c6fbc6cb63b53594a2285d1c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    \u0027e.g http://\u003cserver\u003e/vimService.wsdl. \u0027"},{"line_number":93,"context_line":"                    \u0027Optional over-ride to default location for bug \u0027"},{"line_number":94,"context_line":"                    \u0027work-arounds\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027connection_pool_size\u0027,"},{"line_number":96,"context_line":"               default\u003d10,"},{"line_number":97,"context_line":"               help\u003d\u0027Maximum number of connections in http \u0027"},{"line_number":98,"context_line":"                    \u0027connection pool to VMware\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a33f4324","line":95,"updated":"2016-03-07 16:24:09.000000000","message":"I assume negative numbers don\u0027t make sense here, so you may want to add \"min_value\u003d0\" or \"min_value\u003d1\".","commit_id":"63e579ec5060337f8745d5affa8e6eeb2cd08af1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"987ea10b01aaa55a8d6bbe899794aad813f899f2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    \u0027work-arounds\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027connection_pool_size\u0027,"},{"line_number":96,"context_line":"               default\u003d10,"},{"line_number":97,"context_line":"               help\u003d\u0027Maximum number of connections in http \u0027"},{"line_number":98,"context_line":"                    \u0027connection pool to VMware\u0027)"},{"line_number":99,"context_line":"    ]"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_a2abafd5","line":97,"updated":"2016-03-06 19:01:07.000000000","message":"Can we add more information like the template we have here now for new options?\n\nhttp://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/centralize-config-options.html#quality-view\n\nI think the main thing is to know, why is the default 10 (is that the default in the requests library?).\n\nAs an operator, why would I increase (or decrease) this value?  What are reasonable settings?  Does it depend on the size of my vCenter cluster?","commit_id":"63e579ec5060337f8745d5affa8e6eeb2cd08af1"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"9b052e2cd681cdfcfa559a022745bde7b8c7d70e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    \u0027work-arounds\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027connection_pool_size\u0027,"},{"line_number":96,"context_line":"               default\u003d10,"},{"line_number":97,"context_line":"               help\u003d\u0027Maximum number of connections in http \u0027"},{"line_number":98,"context_line":"                    \u0027connection pool to VMware\u0027)"},{"line_number":99,"context_line":"    ]"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_0e272013","line":97,"in_reply_to":"5aef4532_23185384","updated":"2016-03-08 03:44:33.000000000","message":"Thanks Markus. I will update.","commit_id":"63e579ec5060337f8745d5affa8e6eeb2cd08af1"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3e190abfd93e3534c6fbc6cb63b53594a2285d1c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    \u0027work-arounds\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027connection_pool_size\u0027,"},{"line_number":96,"context_line":"               default\u003d10,"},{"line_number":97,"context_line":"               help\u003d\u0027Maximum number of connections in http \u0027"},{"line_number":98,"context_line":"                    \u0027connection pool to VMware\u0027)"},{"line_number":99,"context_line":"    ]"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_23185384","line":97,"in_reply_to":"7af24918_1303d7b9","updated":"2016-03-07 16:24:09.000000000","message":"Keep in mind that this help text is the base for the ops to decide how to change this option. So Matts questions are reasonable and we should give a direction here.","commit_id":"63e579ec5060337f8745d5affa8e6eeb2cd08af1"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"b917e3ef9b1a0dd6b218913292eff402b88240cf","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    \u0027work-arounds\u0027),"},{"line_number":95,"context_line":"    cfg.IntOpt(\u0027connection_pool_size\u0027,"},{"line_number":96,"context_line":"               default\u003d10,"},{"line_number":97,"context_line":"               help\u003d\u0027Maximum number of connections in http \u0027"},{"line_number":98,"context_line":"                    \u0027connection pool to VMware\u0027)"},{"line_number":99,"context_line":"    ]"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_1303d7b9","line":97,"in_reply_to":"7af24918_a2abafd5","updated":"2016-03-07 02:06:20.000000000","message":"Thanks for review, Matt Riedemann.\nI will update information following the template.\n\nYes, 10 is the default value in requests library. The default value makes request from nova-comoute to vCenter getting slower when nova-compute service restart in larger\nscale.\n\nIt depends on VMs in vCenter cluster, reasonable settings needs suggestion from VMware expert.","commit_id":"63e579ec5060337f8745d5affa8e6eeb2cd08af1"}]}
