)]}'
{"nova/hacking/checks.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c45558cfd8dc5716540c1452437719952332a5a9","unresolved":false,"context_lines":[{"line_number":582,"context_line":"def check_assertTrue_and_assertFalse(logical_line, filename):"},{"line_number":583,"context_line":"    \"\"\"Check for usage for assertTure and assertFalse \"\"\""},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    msg \u003d (\"N343: Use assertTrue(observed) or assertFalse(observed)\""},{"line_number":586,"context_line":"           \"instead of assertEqual(True/False, observed or \""},{"line_number":587,"context_line":"           \"assertEqual(observed True/False)\")"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_a4aafb6e","line":585,"updated":"2016-01-12 15:01:56.000000000","message":"Don\u0027t add this.  assertEqual(False) is not the same thing as assertFalse, and the former version is often needed.\n\nassertFalse(None) will pass while assertEqual(False, None) won\u0027t.","commit_id":"1e72afa5e0480b355483da3a9efba31830015e40"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"aa2d5973d2f396f7c6385cfb49f7af78c3b1f32b","unresolved":false,"context_lines":[{"line_number":582,"context_line":"def check_assertTrue_and_assertFalse(logical_line, filename):"},{"line_number":583,"context_line":"    \"\"\"Check for usage for assertTure and assertFalse \"\"\""},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    msg \u003d (\"N343: Use assertTrue(observed) or assertFalse(observed)\""},{"line_number":586,"context_line":"           \"instead of assertEqual(True/False, observed or \""},{"line_number":587,"context_line":"           \"assertEqual(observed True/False)\")"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_e9c62767","line":585,"in_reply_to":"da6ed579_9f191e7c","updated":"2016-01-22 16:07:05.000000000","message":"I mean that this is not a valid thing to add as a hacking check.  It forces people to use assertFalse() rather than assertEqual() for cases where this will not be as strong of an assertion, and will allow more false positives.  This is not a desirable thing force on people.","commit_id":"1e72afa5e0480b355483da3a9efba31830015e40"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"2aafde3d439159597794ef740225417e4c0fcdee","unresolved":false,"context_lines":[{"line_number":582,"context_line":"def check_assertTrue_and_assertFalse(logical_line, filename):"},{"line_number":583,"context_line":"    \"\"\"Check for usage for assertTure and assertFalse \"\"\""},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    msg \u003d (\"N343: Use assertTrue(observed) or assertFalse(observed)\""},{"line_number":586,"context_line":"           \"instead of assertEqual(True/False, observed or \""},{"line_number":587,"context_line":"           \"assertEqual(observed True/False)\")"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_9f191e7c","line":585,"in_reply_to":"da6ed579_a4aafb6e","updated":"2016-01-13 05:38:50.000000000","message":"Hi Eric, you mean remove the check? is there a sample of assertEqual(False, None) to be used?","commit_id":"1e72afa5e0480b355483da3a9efba31830015e40"}]}