)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/176_add_availability_zone_to_volume_usage_cache.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"7d34f8881292772e3913704e244baeb099a693cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    volume_usage_cache \u003d Table(\u0027volume_usage_cache\u0027, meta, autoload\u003dTrue)"},{"line_number":29,"context_line":"    availability_zone \u003d Column(\u0027availability_zone\u0027, String(255))"},{"line_number":30,"context_line":"    volume_usage_cache.create_column(availability_zone)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fq%2F4%3D","line":30,"updated":"2013-04-29 18:32:14.000000000","message":"Does this column need to be pre-populated?\n\nwhat happens if run migration with data in volume_usage_cache?","commit_id":"63b4d15f03ab336e4cfac5177a61d10eaab9fb73"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"f8a7d9d61a2934c4337f1fd590f7a25937998301","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    volume_usage_cache \u003d Table(\u0027volume_usage_cache\u0027, meta, autoload\u003dTrue)"},{"line_number":29,"context_line":"    availability_zone \u003d Column(\u0027availability_zone\u0027, String(255))"},{"line_number":30,"context_line":"    volume_usage_cache.create_column(availability_zone)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fp9s%3D","line":30,"in_reply_to":"AAAAOn%2F%2Fp%2BE%3D","updated":"2013-04-30 13:01:22.000000000","message":"Done.","commit_id":"63b4d15f03ab336e4cfac5177a61d10eaab9fb73"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"5c52ccee3cea3b64be6ff838be149b1b434e139a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    volume_usage_cache \u003d Table(\u0027volume_usage_cache\u0027, meta, autoload\u003dTrue)"},{"line_number":29,"context_line":"    availability_zone \u003d Column(\u0027availability_zone\u0027, String(255))"},{"line_number":30,"context_line":"    volume_usage_cache.create_column(availability_zone)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2FqKs%3D","line":30,"in_reply_to":"AAAAOn%2F%2Fq%2F4%3D","updated":"2013-04-30 08:11:34.000000000","message":"This column does not need to be pre-populated.\n\nThis table keeps a cache of the volume usage. Every minute (or what ever is configured for volume_usage_poll_interval value) one row in this table gets updated for each attached volume. After this patch is applied, for any currently attached volumes, the value will immediately be null,  but will get updated to the correct value on the next tick of the volume usage poll.\n\nThe volume usage poll function is the only code to access this table. The sequence of operation in that function is to first update the field with the correct value and then to pass the updated data to the consumer.","commit_id":"63b4d15f03ab336e4cfac5177a61d10eaab9fb73"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6a45becbb83f3ac5bdf0b7b2c988fc79a252b2fa","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    volume_usage_cache \u003d Table(\u0027volume_usage_cache\u0027, meta, autoload\u003dTrue)"},{"line_number":29,"context_line":"    availability_zone \u003d Column(\u0027availability_zone\u0027, String(255))"},{"line_number":30,"context_line":"    volume_usage_cache.create_column(availability_zone)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fp%2BE%3D","line":30,"in_reply_to":"AAAAOn%2F%2FqKs%3D","updated":"2013-04-30 12:45:59.000000000","message":"Can you add a comment to this effect.  When looking at migration 175 to decide if it was safe for our environment we came to the same conclusion but had to walk through the code to alleviate our concerns.","commit_id":"63b4d15f03ab336e4cfac5177a61d10eaab9fb73"}],"nova/tests/conductor/test_conductor.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"adc34fc8a49e1ad7aa2bb4a457b32c922538f063","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        self.conductor.vol_usage_update(self.context, \u0027fake-vol\u0027, \u0027rd-req\u0027,"},{"line_number":412,"context_line":"                                        \u0027rd-bytes\u0027, \u0027wr-req\u0027, \u0027wr-bytes\u0027,"},{"line_number":413,"context_line":"                                        inst,"},{"line_number":414,"context_line":"                                        \u0027fake-refr\u0027, \u0027fake-bool\u0027)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def test_ping(self):"},{"line_number":417,"context_line":"        result \u003d self.conductor.ping(self.context, \u0027foo\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FsVY%3D","line":414,"updated":"2013-04-28 01:49:47.000000000","message":"Can you please re-wrap these last two lines?","commit_id":"996fd4abef78bfefbbe8c5e84a4cace48dae803a"}]}