)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"87f287a11640f068b26961024ec621709cf1ab78","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-01-12 16:12:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve \u0027vnc\u0027 conf options documentation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0b524444afc5e0c18a95cbb8ed0836bde404a5dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6ed579_8e9332fa","line":8,"updated":"2016-01-18 15:48:05.000000000","message":"implements bp centralize-config-options","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db3eb8cc33f212739479e5864e7039c3e64915cf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-01-12 16:12:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve \u0027vnc\u0027 conf options documentation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0b524444afc5e0c18a95cbb8ed0836bde404a5dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba63e191_d0afa5e1","line":8,"in_reply_to":"da6ed579_8e9332fa","updated":"2016-01-19 11:52:16.000000000","message":"Done","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"}],"nova/conf/vnc.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"87f287a11640f068b26961024ec621709cf1ab78","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":29,"context_line":"    deprecated_name\u003d\u0027vnc_enabled\u0027,"},{"line_number":30,"context_line":"    help\u003d\"\"\"Enable VNC related features."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Possible values:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* True: Enables the feature"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_09a5fc02","line":31,"updated":"2016-01-18 15:48:05.000000000","message":"Maybe a few more words, like:\n\n    \"Guests will get created with graphical devices to \n    support this. Clients (for example Horizon) can \n    then establish a VNC connection to the guest.\"","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db3eb8cc33f212739479e5864e7039c3e64915cf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":29,"context_line":"    deprecated_name\u003d\u0027vnc_enabled\u0027,"},{"line_number":30,"context_line":"    help\u003d\"\"\"Enable VNC related features."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Possible values:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* True: Enables the feature"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_f5373be1","line":31,"in_reply_to":"da6ed579_09a5fc02","updated":"2016-01-19 11:52:16.000000000","message":"Done","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"87f287a11640f068b26961024ec621709cf1ab78","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* ``nova-compute``"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Interdependencies to other options:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* None"},{"line_number":44,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_ce0cca44","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":34},"updated":"2016-01-18 15:48:05.000000000","message":"We concluded in one of the other (earlier) patches that it would be easier to go with \"Related options\".","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db3eb8cc33f212739479e5864e7039c3e64915cf","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* ``nova-compute``"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Interdependencies to other options:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* None"},{"line_number":44,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_355cf324","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":34},"in_reply_to":"da6ed579_ce0cca44","updated":"2016-01-19 11:52:16.000000000","message":"Done","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"87f287a11640f068b26961024ec621709cf1ab78","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Possible values:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* A country code or keyboard type keymap"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Services which consume this:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_09997c6e","line":58,"updated":"2016-01-18 15:48:05.000000000","message":"I\u0027m no expert here, but I guess we use the \"IETF language tags\" [1] and only those which are supported by the hypervisor on that node? For my local machine they are specified in \"/usr/share/qemu-kvm/keymaps/\". So maybe rephrase as:\n\n    \"A keyboard layout which is supported by the\n    underlying hypervisor on this node. This is\n    usually an \u0027IETF language tag\u0027 (for example \u0027en-us\u0027).\n    If you use QEMU as hypervisor, you should find the\n    list of supported keyboard layouts at\n    /usr/share/qemu/keymaps\"\n\n[1] https://en.wikipedia.org/wiki/IETF_language_tag","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db3eb8cc33f212739479e5864e7039c3e64915cf","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Possible values:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* A country code or keyboard type keymap"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Services which consume this:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_3581534b","line":58,"in_reply_to":"da6ed579_09997c6e","updated":"2016-01-19 11:52:16.000000000","message":"Done","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"87f287a11640f068b26961024ec621709cf1ab78","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    default\u003d\u0027127.0.0.1\u0027,"},{"line_number":73,"context_line":"    deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":74,"context_line":"    help\u003d\"\"\""},{"line_number":75,"context_line":"IP address on which VNC should listen."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_44d3db38","line":75,"updated":"2016-01-18 15:48:05.000000000","message":"Maybe:\n\n    \"The IP address on which an instance should listen\n    to for incoming VNC connection requests on this node.\"","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db3eb8cc33f212739479e5864e7039c3e64915cf","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    default\u003d\u0027127.0.0.1\u0027,"},{"line_number":73,"context_line":"    deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":74,"context_line":"    help\u003d\"\"\""},{"line_number":75,"context_line":"IP address on which VNC should listen."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_35f873e5","line":75,"in_reply_to":"da6ed579_44d3db38","updated":"2016-01-19 11:52:16.000000000","message":"Done","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"87f287a11640f068b26961024ec621709cf1ab78","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Interdependencies to other options:"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"* None"},{"line_number":205,"context_line":"\"\"\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"xvpvncproxy_base_url \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_5fbde6d5","line":204,"updated":"2016-01-18 15:48:05.000000000","message":"* The port must be the same as specified in \"novncproxy_port\" I guess\n* The IP address must be the same as in \"novncproxy_host\" I guess","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"87f287a11640f068b26961024ec621709cf1ab78","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Interdependencies to other options:"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"* None"},{"line_number":235,"context_line":"\"\"\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_045ac383","line":234,"updated":"2016-01-18 15:48:05.000000000","message":"* The port in this URL should be the same as specified in the option \"xvpvncproxy_port\" I assume?\n* The IP must be also the same as in \"xvpvncproxy_host\" I guess? \n\nAt least the serial console stuff had the same pattern.","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c857cf633e511865b5a992378ae42b6491fa0895","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Interdependencies to other options:"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"* None"},{"line_number":235,"context_line":"\"\"\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_1fef89e9","line":234,"in_reply_to":"ba63e191_f56f3b90","updated":"2016-01-19 13:19:05.000000000","message":"I forgot that we can use\n\n    xvpvncproxy_host\u003d0.0.0.0\n\nwhich listens to everything available. While having \n\n    xvpvncproxy_base_url\u003dhttp://0.0.0.0:6081/console\n\nwould probably don\u0027t make sense. This means my first input here is not correct. Regarding the port, I\u0027m not sure anymore. The ops could do some port forwarding magic, right? But if they don\u0027t do it they should be aware that there is a relationship between \"*_base_url\" and \"*_host\" and \"*_port\".\nA deprecation is probably wrong, as it is possible to configure it in a way which doesn\u0027t allow an autogeneration.","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db3eb8cc33f212739479e5864e7039c3e64915cf","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Interdependencies to other options:"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"* None"},{"line_number":235,"context_line":"\"\"\")"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_f56f3b90","line":234,"in_reply_to":"da6ed579_045ac383","updated":"2016-01-19 11:52:16.000000000","message":"I\u0027m not sure. I\u0027ve updated this but seeing as I haven\u0027t used the option it may be incorrect. If you\u0027re correct, shouldn\u0027t this option be deprecated as it could be autogenerated?","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"87f287a11640f068b26961024ec621709cf1ab78","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":257,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":258,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":259,"context_line":"    return {vnc_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_1f7f6e67","line":259,"range":{"start_line":259,"start_character":22,"end_line":259,"end_character":26},"updated":"2016-01-18 15:48:05.000000000","message":"I suggested a different approach here in the previous change of this series.","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db3eb8cc33f212739479e5864e7039c3e64915cf","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":257,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":258,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":259,"context_line":"    return {vnc_group.name: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_30aac1d5","line":259,"range":{"start_line":259,"start_character":22,"end_line":259,"end_character":26},"in_reply_to":"da6ed579_1f7f6e67","updated":"2016-01-19 11:52:16.000000000","message":"Done","commit_id":"ac878a6c227511bb2326fe7db840c610e7579cd6"}]}