)]}'
{"nova/conf/virt.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"05f11be2cf880b1d0f316ec0dba8a021258c1e88","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Services which consume this:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* nova-scheduler"},{"line_number":58,"context_line":"* nova-compute"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Interdependencies to other options:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_d3df4038","line":58,"range":{"start_line":58,"start_character":7,"end_line":58,"end_character":14},"updated":"2016-01-22 22:12:16.000000000","message":"guess scheduler won\u0027t consume this? it\u0027s pure compute layer definition?","commit_id":"bf7aad3adb306a9381c169a8c5dc063b3afe0a87"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"05f11be2cf880b1d0f316ec0dba8a021258c1e88","unresolved":false,"context_lines":[{"line_number":73,"context_line":"* ext3"},{"line_number":74,"context_line":"* ext4"},{"line_number":75,"context_line":"* ufs"},{"line_number":76,"context_line":"* iso9660"},{"line_number":77,"context_line":"* ..."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_53ecb0f2","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":9},"updated":"2016-01-22 22:12:16.000000000","message":"iso9660 should be read only format?\nhttps://en.wikipedia.org/wiki/ISO_9660","commit_id":"bf7aad3adb306a9381c169a8c5dc063b3afe0a87"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"05f11be2cf880b1d0f316ec0dba8a021258c1e88","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Services which consume this:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* nova-compute"},{"line_number":129,"context_line":"\"\"\")"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"vif_plugging_is_fatal \u003d cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_f3efe484","line":128,"range":{"start_line":128,"start_character":1,"end_line":128,"end_character":2},"updated":"2016-01-22 22:12:16.000000000","message":"miss \u0027Interdependencies to other options:\u0027 here","commit_id":"bf7aad3adb306a9381c169a8c5dc063b3afe0a87"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"05f11be2cf880b1d0f316ec0dba8a021258c1e88","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Services which consume this:"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* nova-scheduler"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Interdependencies to other options:"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_f39604ef","line":154,"range":{"start_line":154,"start_character":7,"end_line":154,"end_character":16},"updated":"2016-01-22 22:12:16.000000000","message":"typo? nova-compute?","commit_id":"bf7aad3adb306a9381c169a8c5dc063b3afe0a87"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"05f11be2cf880b1d0f316ec0dba8a021258c1e88","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Services which consume this:"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"* nova-scheduler"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Interdependencies to other options:"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_139cf80d","line":177,"range":{"start_line":177,"start_character":7,"end_line":177,"end_character":16},"updated":"2016-01-22 22:12:16.000000000","message":"ditto","commit_id":"bf7aad3adb306a9381c169a8c5dc063b3afe0a87"},{"author":{"_account_id":9581,"name":"Ren Qiaowei","email":"qiaowei.ren@intel.com","username":"qiaowei"},"change_message_id":"a3e2c4ca023f8943f563900f266f7957babf20f9","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"compute_driver \u003d cfg.StrOpt("},{"line_number":42,"context_line":"    \u0027compute_driver\u0027,"},{"line_number":43,"context_line":"    help\u003d\"\"\"Defines which driver to use for controlling virtualization."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_c4f2866f","line":43,"range":{"start_line":43,"start_character":33,"end_line":43,"end_character":39},"updated":"2016-01-27 01:04:53.000000000","message":"to be used for?","commit_id":"e7642b6cd382658e32a2ab19ac7a70796112e396"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13ae5a827a8d4efc5aadda12f71a60cfc3ee183e","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"compute_driver \u003d cfg.StrOpt("},{"line_number":42,"context_line":"    \u0027compute_driver\u0027,"},{"line_number":43,"context_line":"    help\u003d\"\"\"Defines which driver to use for controlling virtualization."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_3598601b","line":43,"range":{"start_line":43,"start_character":33,"end_line":43,"end_character":39},"in_reply_to":"9a68dd71_c4f2866f","updated":"2016-01-27 09:06:34.000000000","message":"Tomato-tomato: both a grammatically valid","commit_id":"e7642b6cd382658e32a2ab19ac7a70796112e396"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"dc47c859d1af43335981c9b0f32824848159186a","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Services which consume this:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* nova-compute"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Interdependencies to other options:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_38612e3a","line":57,"range":{"start_line":57,"start_character":2,"end_line":57,"end_character":14},"updated":"2016-01-28 14:13:37.000000000","message":"I don\u0027t expect that this is the important stuff, but everywhere else list of services that consume config are wrapped in ``\n\nLike:\n* ``nova-spicehtml5proxy``","commit_id":"e7642b6cd382658e32a2ab19ac7a70796112e396"},{"author":{"_account_id":9581,"name":"Ren Qiaowei","email":"qiaowei.ren@intel.com","username":"qiaowei"},"change_message_id":"a3e2c4ca023f8943f563900f266f7957babf20f9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    \u0027preallocate_images\u0027,"},{"line_number":88,"context_line":"    default\u003d\u0027none\u0027,"},{"line_number":89,"context_line":"    choices\u003d(\u0027none\u0027, \u0027space\u0027),"},{"line_number":90,"context_line":"    help\u003d\"\"\"The image preallocation mode to use. Image preallocation allows"},{"line_number":91,"context_line":"storage for instance images to be allocated up front when the instance is"},{"line_number":92,"context_line":"initially provisioned. This ensures immediate feedback is given if enough"},{"line_number":93,"context_line":"space isn\u0027t available. In addition, it should significantly improve"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_84ba4e6d","line":90,"range":{"start_line":90,"start_character":41,"end_line":90,"end_character":47},"updated":"2016-01-27 01:04:53.000000000","message":"to be used?","commit_id":"e7642b6cd382658e32a2ab19ac7a70796112e396"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13ae5a827a8d4efc5aadda12f71a60cfc3ee183e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    \u0027preallocate_images\u0027,"},{"line_number":88,"context_line":"    default\u003d\u0027none\u0027,"},{"line_number":89,"context_line":"    choices\u003d(\u0027none\u0027, \u0027space\u0027),"},{"line_number":90,"context_line":"    help\u003d\"\"\"The image preallocation mode to use. Image preallocation allows"},{"line_number":91,"context_line":"storage for instance images to be allocated up front when the instance is"},{"line_number":92,"context_line":"initially provisioned. This ensures immediate feedback is given if enough"},{"line_number":93,"context_line":"space isn\u0027t available. In addition, it should significantly improve"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_b5abf01d","line":90,"range":{"start_line":90,"start_character":41,"end_line":90,"end_character":47},"in_reply_to":"9a68dd71_84ba4e6d","updated":"2016-01-27 09:06:34.000000000","message":"Ditto","commit_id":"e7642b6cd382658e32a2ab19ac7a70796112e396"},{"author":{"_account_id":9581,"name":"Ren Qiaowei","email":"qiaowei.ren@intel.com","username":"qiaowei"},"change_message_id":"a3e2c4ca023f8943f563900f266f7957babf20f9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    choices\u003d(\u0027none\u0027, \u0027space\u0027),"},{"line_number":90,"context_line":"    help\u003d\"\"\"The image preallocation mode to use. Image preallocation allows"},{"line_number":91,"context_line":"storage for instance images to be allocated up front when the instance is"},{"line_number":92,"context_line":"initially provisioned. This ensures immediate feedback is given if enough"},{"line_number":93,"context_line":"space isn\u0027t available. In addition, it should significantly improve"},{"line_number":94,"context_line":"performance on writes to new blocks and may even improve I/O performance to"},{"line_number":95,"context_line":"prewritten blocks due to reduced fragmentation."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_e480ea8d","line":93,"range":{"start_line":92,"start_character":67,"end_line":93,"end_character":21},"updated":"2016-01-27 01:04:53.000000000","message":"the space isn\u0027t enough?","commit_id":"e7642b6cd382658e32a2ab19ac7a70796112e396"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1808ea717832d84f20fc4fdb78cb160555f172b0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    choices\u003d(\u0027none\u0027, \u0027space\u0027),"},{"line_number":90,"context_line":"    help\u003d\"\"\"The image preallocation mode to use. Image preallocation allows"},{"line_number":91,"context_line":"storage for instance images to be allocated up front when the instance is"},{"line_number":92,"context_line":"initially provisioned. This ensures immediate feedback is given if enough"},{"line_number":93,"context_line":"space isn\u0027t available. In addition, it should significantly improve"},{"line_number":94,"context_line":"performance on writes to new blocks and may even improve I/O performance to"},{"line_number":95,"context_line":"prewritten blocks due to reduced fragmentation."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_55c073e0","line":93,"range":{"start_line":92,"start_character":67,"end_line":93,"end_character":21},"in_reply_to":"9a68dd71_35bf0062","updated":"2016-01-28 14:01:12.000000000","message":"The existing one sounds better.","commit_id":"e7642b6cd382658e32a2ab19ac7a70796112e396"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13ae5a827a8d4efc5aadda12f71a60cfc3ee183e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    choices\u003d(\u0027none\u0027, \u0027space\u0027),"},{"line_number":90,"context_line":"    help\u003d\"\"\"The image preallocation mode to use. Image preallocation allows"},{"line_number":91,"context_line":"storage for instance images to be allocated up front when the instance is"},{"line_number":92,"context_line":"initially provisioned. This ensures immediate feedback is given if enough"},{"line_number":93,"context_line":"space isn\u0027t available. In addition, it should significantly improve"},{"line_number":94,"context_line":"performance on writes to new blocks and may even improve I/O performance to"},{"line_number":95,"context_line":"prewritten blocks due to reduced fragmentation."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_35bf0062","line":93,"range":{"start_line":92,"start_character":67,"end_line":93,"end_character":21},"in_reply_to":"9a68dd71_e480ea8d","updated":"2016-01-27 09:06:34.000000000","message":"The existing version reads better, IMO?","commit_id":"e7642b6cd382658e32a2ab19ac7a70796112e396"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ce01dcfee96d796464599546d8789346583afe7a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"* ``ironic.IronicDriver``"},{"line_number":51,"context_line":"* ``vmwareapi.VMwareVCDriver``"},{"line_number":52,"context_line":"* ``hyperv.HyperVDriver``"},{"line_number":53,"context_line":"* ..."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Services which consume this:"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_dc4a6827","line":53,"updated":"2016-02-10 12:22:47.000000000","message":"I think we can remove the \"...\" here.\n\nActually, probably should add choices\u003d[...] here.","commit_id":"8f55830e355d19670dd4d6c909e39edfb2a73cb0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ce01dcfee96d796464599546d8789346583afe7a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"* ``ext3``"},{"line_number":73,"context_line":"* ``ext4``"},{"line_number":74,"context_line":"* ``ufs``"},{"line_number":75,"context_line":"* ..."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Services which consume this:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_5781734c","line":75,"updated":"2016-02-10 12:22:47.000000000","message":"hmm, not sure we allow any other ones here either?\n\nI think we restricted this more actually.\n\nI do wonder if its FAT for windows though.","commit_id":"8f55830e355d19670dd4d6c909e39edfb2a73cb0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aff63b7e6ab2a902c23ec84dc84d08823d81bccc","unresolved":false,"context_lines":[{"line_number":72,"context_line":"* ``ext3``"},{"line_number":73,"context_line":"* ``ext4``"},{"line_number":74,"context_line":"* ``ufs``"},{"line_number":75,"context_line":"* ..."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Services which consume this:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_595e88ea","line":75,"in_reply_to":"5a5ae5dd_5781734c","updated":"2016-02-10 13:13:02.000000000","message":"Found the code that checks this in `nova/virt/libvirt/driver.py:3155`. Updated with missing values. `swap` and `vfat` are also supported, but not for ephemeral drives AFAIK","commit_id":"8f55830e355d19670dd4d6c909e39edfb2a73cb0"}]}