)]}'
{"nova/conf/virt.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e409cad4754bff212cba29afaa313693f7b26811","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    \u0027firewall_driver\u0027,"},{"line_number":186,"context_line":"    help\u003d\"\"\"Firewall driver to use with ``nova-network`` service."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Determine which firewall the legacy networking service, ``nova-network``,"},{"line_number":189,"context_line":"should use."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"This option only applies when using the ``nova-network`` service. When using"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_f364c422","line":188,"range":{"start_line":188,"start_character":29,"end_line":188,"end_character":35},"updated":"2016-01-22 22:35:36.000000000","message":"not sure it\u0027s proper to say \u0027legacy\u0027 here","commit_id":"4dab4ef311086a542bb7dcb08de51695d693102c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25518bbaf20e44845e525392973054f40f75f7ef","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    \u0027firewall_driver\u0027,"},{"line_number":186,"context_line":"    help\u003d\"\"\"Firewall driver to use with ``nova-network`` service."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Determine which firewall the legacy networking service, ``nova-network``,"},{"line_number":189,"context_line":"should use."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"This option only applies when using the ``nova-network`` service. When using"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_f338ce3f","line":188,"range":{"start_line":188,"start_character":29,"end_line":188,"end_character":35},"in_reply_to":"9a68dd71_f364c422","updated":"2016-01-26 14:13:16.000000000","message":"This is the terminology used elsewhere in the docs, so I kept it:\n\n    http://docs.openstack.org/liberty/networking-guide/migration_nova_network_to_neutron.html\n\nHowever, the sentence reads fine without so dropped for now.","commit_id":"4dab4ef311086a542bb7dcb08de51695d693102c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e409cad4754bff212cba29afaa313693f7b26811","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"This option only applies when using the ``nova-network`` service. When using"},{"line_number":192,"context_line":"another networking services, such as Neutron, this should be to set to the"},{"line_number":193,"context_line":"``NoopFirewallDriver``."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The option defaults to hypervisor-specific ``iptables`` driver."},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_13515836","line":193,"range":{"start_line":193,"start_character":20,"end_line":193,"end_character":23},"updated":"2016-01-22 22:35:36.000000000","message":"it doesn\u0027t matter, right? no effect?","commit_id":"4dab4ef311086a542bb7dcb08de51695d693102c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25518bbaf20e44845e525392973054f40f75f7ef","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"This option only applies when using the ``nova-network`` service. When using"},{"line_number":192,"context_line":"another networking services, such as Neutron, this should be to set to the"},{"line_number":193,"context_line":"``NoopFirewallDriver``."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The option defaults to hypervisor-specific ``iptables`` driver."},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_d3102a5c","line":193,"range":{"start_line":193,"start_character":20,"end_line":193,"end_character":23},"in_reply_to":"9a68dd71_13515836","updated":"2016-01-26 14:13:16.000000000","message":"I saw it done elsewhere so I used it. Dropped for now\n\nhttps://github.com/openstack/nova/blob/f643cad2aa09da040f92a73e12bec309604ddfa1/nova/conf/scheduler.py","commit_id":"4dab4ef311086a542bb7dcb08de51695d693102c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e409cad4754bff212cba29afaa313693f7b26811","unresolved":false,"context_lines":[{"line_number":192,"context_line":"another networking services, such as Neutron, this should be to set to the"},{"line_number":193,"context_line":"``NoopFirewallDriver``."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The option defaults to hypervisor-specific ``iptables`` driver."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Possible values:"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_730e943c","line":195,"range":{"start_line":195,"start_character":23,"end_line":195,"end_character":33},"updated":"2016-01-22 22:35:36.000000000","message":"the default value is None...\neach driver can specify its default value","commit_id":"4dab4ef311086a542bb7dcb08de51695d693102c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25518bbaf20e44845e525392973054f40f75f7ef","unresolved":false,"context_lines":[{"line_number":192,"context_line":"another networking services, such as Neutron, this should be to set to the"},{"line_number":193,"context_line":"``NoopFirewallDriver``."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The option defaults to hypervisor-specific ``iptables`` driver."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Possible values:"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_13bb2277","line":195,"range":{"start_line":195,"start_character":23,"end_line":195,"end_character":33},"in_reply_to":"9a68dd71_730e943c","updated":"2016-01-26 14:13:16.000000000","message":"True - updated","commit_id":"4dab4ef311086a542bb7dcb08de51695d693102c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e409cad4754bff212cba29afaa313693f7b26811","unresolved":false,"context_lines":[{"line_number":221,"context_line":"Possible values:"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"* True: Network traffic should be allowed pass between instances"},{"line_number":224,"context_line":"* False: Network traffic should not be allowed pass between instances"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Services which consume this:"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_3649ea60","line":224,"range":{"start_line":224,"start_character":60,"end_line":224,"end_character":69},"updated":"2016-01-22 22:35:36.000000000","message":"this should be tenant related? \nthe descriptions here is not so clear all instance can\u0027t talk to each other if it\u0027s False?","commit_id":"4dab4ef311086a542bb7dcb08de51695d693102c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25518bbaf20e44845e525392973054f40f75f7ef","unresolved":false,"context_lines":[{"line_number":221,"context_line":"Possible values:"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"* True: Network traffic should be allowed pass between instances"},{"line_number":224,"context_line":"* False: Network traffic should not be allowed pass between instances"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Services which consume this:"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_938872c8","line":224,"range":{"start_line":224,"start_character":60,"end_line":224,"end_character":69},"in_reply_to":"9a68dd71_3649ea60","updated":"2016-01-26 14:13:16.000000000","message":"I\u0027m not sure. I referred to the docs for this so my presumption was this was hosts and therefore instances. However, I hadn\u0027t considered different tenants and this isn\u0027t clear. Have updated but would appreciate eyes on to ensure what I\u0027m saying is valid.\n\nhttp://docs.openstack.org/openstack-ops/content/security_groups.html","commit_id":"4dab4ef311086a542bb7dcb08de51695d693102c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eded1d348dc4bb2c20f33a00aa251626f18175bf","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* nova.virt.firewall.IptablesFirewallDriver"},{"line_number":200,"context_line":"* nova.virt.firewall.NoopFirewallDriver"},{"line_number":201,"context_line":"* ..."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Services which consume this:"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a57f1b5_2357dd03","line":201,"updated":"2016-02-10 12:29:37.000000000","message":"hmm, I suspect we should be stricter on this... But thats a fix up for later.","commit_id":"4d8bd56a021df813b20e684d1de4924b246913d2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"86ee19ceddae1c0145a62cfc5fbbfd3291027642","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Interdependencies to other options:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* None"},{"line_number":210,"context_line":"\"\"\")"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"allow_same_net_traffic \u003d cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a57f1b5_c369298d","line":209,"updated":"2016-02-10 12:30:21.000000000","message":"the config that switches between neutron and nova-network?","commit_id":"4d8bd56a021df813b20e684d1de4924b246913d2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108511ecdd85207f790b53855ce22497bacc1546","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Interdependencies to other options:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* None"},{"line_number":210,"context_line":"\"\"\")"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"allow_same_net_traffic \u003d cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a57f1b5_9a814f4d","line":209,"in_reply_to":"3a57f1b5_c369298d","updated":"2016-02-10 13:36:01.000000000","message":"Done","commit_id":"4d8bd56a021df813b20e684d1de4924b246913d2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"69e588166b8e68eeb4f9d4f3a56595805f7a25bd","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Interdependencies to other options:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* None"},{"line_number":210,"context_line":"\"\"\")"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"allow_same_net_traffic \u003d cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_aedd5916","line":209,"in_reply_to":"3a57f1b5_c369298d","updated":"2016-02-15 16:55:59.000000000","message":"John, I don\u0027t think that clarifies anything. We are already stating that this option is only used by nova-network, so pointing to another option that says the same thing seems redundant.","commit_id":"4d8bd56a021df813b20e684d1de4924b246913d2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eded1d348dc4bb2c20f33a00aa251626f18175bf","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"* True: Network traffic should be allowed pass between all instances on the"},{"line_number":229,"context_line":"  same network."},{"line_number":230,"context_line":"* False: Network traffic should not be allowed pass between instances"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Services which consume this:"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a57f1b5_c3e4c93c","line":230,"updated":"2016-02-10 12:29:37.000000000","message":"hmm, this seems a bit confusing.\n\nI guess it means only allow traffic to the gateway?","commit_id":"4d8bd56a021df813b20e684d1de4924b246913d2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108511ecdd85207f790b53855ce22497bacc1546","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"* True: Network traffic should be allowed pass between all instances on the"},{"line_number":229,"context_line":"  same network."},{"line_number":230,"context_line":"* False: Network traffic should not be allowed pass between instances"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Services which consume this:"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a57f1b5_7a7c9372","line":230,"in_reply_to":"3a57f1b5_c3e4c93c","updated":"2016-02-10 13:36:01.000000000","message":"Done","commit_id":"4d8bd56a021df813b20e684d1de4924b246913d2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eded1d348dc4bb2c20f33a00aa251626f18175bf","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Interdependencies to other options:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"* None"},{"line_number":239,"context_line":"\"\"\")"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"force_raw_images \u003d cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a57f1b5_237cbd71","line":238,"updated":"2016-02-10 12:29:37.000000000","message":"seems like its only the libvirt firewall?","commit_id":"4d8bd56a021df813b20e684d1de4924b246913d2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"108511ecdd85207f790b53855ce22497bacc1546","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Interdependencies to other options:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"* None"},{"line_number":239,"context_line":"\"\"\")"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"force_raw_images \u003d cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a57f1b5_54316d0a","line":238,"in_reply_to":"3a57f1b5_237cbd71","updated":"2016-02-10 13:36:01.000000000","message":"Done","commit_id":"4d8bd56a021df813b20e684d1de4924b246913d2"}]}