)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"59fc96383282e6d781a172f9dc72e028ffeaf868","unresolved":false,"context_lines":[{"line_number":669,"context_line":"        :param address: GID or MAC."},{"line_number":670,"context_line":"        :returns: truncated MAC."},{"line_number":671,"context_line":"        \"\"\""},{"line_number":672,"context_line":"        if len(address) \u003d\u003d 59:"},{"line_number":673,"context_line":"            return address[36:-14] + address[51:]"},{"line_number":674,"context_line":"        return address"},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_eed1b7fc","line":672,"range":{"start_line":672,"start_character":11,"end_line":672,"end_character":23},"updated":"2016-02-10 09:30:49.000000000","message":"Moshe,\n\nThanks for the nice patch.\nI think it would be nice to make the same change as Ironic code :)\n\nhttps://review.openstack.org/#/c/264263/9..12/ironic/common/utils.py\n\nAnd I couldn\u0027t find the test code of this function in test_driver.py, wouldn\u0027t we need to put the same test code as Ironic to Nova?\n\nBest regards,\nNaohiro","commit_id":"053f7c9c2f51fdb1c3e92a981389bd27114b7503"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"db3d466ed1336cb5f89072ce0a33eafc8ae8c4b9","unresolved":false,"context_lines":[{"line_number":669,"context_line":"        :param address: GID or MAC."},{"line_number":670,"context_line":"        :returns: truncated MAC."},{"line_number":671,"context_line":"        \"\"\""},{"line_number":672,"context_line":"        if len(address) \u003d\u003d 59:"},{"line_number":673,"context_line":"            return address[36:-14] + address[51:]"},{"line_number":674,"context_line":"        return address"},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_e1155ee5","line":672,"range":{"start_line":672,"start_character":11,"end_line":672,"end_character":23},"in_reply_to":"3a57f1b5_eed1b7fc","updated":"2016-03-09 10:32:38.000000000","message":"Done","commit_id":"053f7c9c2f51fdb1c3e92a981389bd27114b7503"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"52308e9482a688abb4510da9130765fdd325b905","unresolved":false,"context_lines":[{"line_number":669,"context_line":"        :param address: GID or MAC."},{"line_number":670,"context_line":"        :returns: truncated MAC."},{"line_number":671,"context_line":"        \"\"\""},{"line_number":672,"context_line":"        if len(address) \u003d\u003d 59:"},{"line_number":673,"context_line":"            return address[36:-14] + address[51:]"},{"line_number":674,"context_line":"        return address"},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_3112ce63","line":672,"range":{"start_line":672,"start_character":11,"end_line":672,"end_character":23},"in_reply_to":"3a57f1b5_eed1b7fc","updated":"2016-02-10 09:50:45.000000000","message":"yes, there are many duplication in this patch, the ironic path\nand the ironic-inspector patch. \nideally I would like to move every common method to ironic-lib.\nbut for now I guess I will need to duplicate the code.","commit_id":"053f7c9c2f51fdb1c3e92a981389bd27114b7503"}]}