)]}'
{"nova/api/openstack/compute/multinic.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b66f9a5f4155ca3e2a00b29d62209238706d413d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":53,"context_line":"        except exception.NoMoreFixedIps as e:"},{"line_number":54,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":55,"context_line":"        except exception.InstanceIsLocked as e:"},{"line_number":56,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":57,"context_line":"        except exception.InstanceInvalidState as state_error:"},{"line_number":58,"context_line":"            common.raise_http_conflict_for_instance_invalid_state(state_error,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_7f05c10e","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":47},"updated":"2016-02-08 08:32:48.000000000","message":"This InstanceIsLocked catching seems unnecessary because this InstanceIsLocked never happen due to this check_instance_state() doesn\u0027t contain LOCKED state.\n\nexception.InstanceInvalidState happens instead of that.","commit_id":"41cd7c5c9e37a9f06eb185f71047cbc9c2bd7ca7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b66f9a5f4155ca3e2a00b29d62209238706d413d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":77,"context_line":"        except exception.FixedIpNotFoundForSpecificInstance as e:"},{"line_number":78,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":79,"context_line":"        except exception.InstanceIsLocked as e:"},{"line_number":80,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":81,"context_line":"        except exception.InstanceInvalidState as state_error:"},{"line_number":82,"context_line":"            common.raise_http_conflict_for_instance_invalid_state(state_error,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_3f22e9a3","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":47},"updated":"2016-02-08 08:32:48.000000000","message":"ditto","commit_id":"41cd7c5c9e37a9f06eb185f71047cbc9c2bd7ca7"}],"nova/compute/api.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"d7e773981a186b0b014719af530c08b83e47d344","unresolved":false,"context_lines":[{"line_number":2672,"context_line":"    @check_instance_lock"},{"line_number":2673,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.PAUSED,"},{"line_number":2674,"context_line":"                                    vm_states.STOPPED],"},{"line_number":2675,"context_line":"                          task_state\u003d[None])"},{"line_number":2676,"context_line":"    def add_fixed_ip(self, context, instance, network_id):"},{"line_number":2677,"context_line":"        \"\"\"Add fixed_ip from specified network to given instance.\"\"\""},{"line_number":2678,"context_line":"        self.compute_rpcapi.add_fixed_ip_to_instance(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_6e69518b","line":2675,"updated":"2016-01-27 15:59:02.000000000","message":"Why is this necessary in this patch please? Probably just me missing something","commit_id":"57f6fb2e6ae5f26361d9ec520d72e941acf4a0b4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b66f9a5f4155ca3e2a00b29d62209238706d413d","unresolved":false,"context_lines":[{"line_number":2678,"context_line":""},{"line_number":2679,"context_line":"    @wrap_check_policy"},{"line_number":2680,"context_line":"    @check_instance_lock"},{"line_number":2681,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.PAUSED,"},{"line_number":2682,"context_line":"                                    vm_states.STOPPED],"},{"line_number":2683,"context_line":"                          task_state\u003d[None])"},{"line_number":2684,"context_line":"    def add_fixed_ip(self, context, instance, network_id):"},{"line_number":2685,"context_line":"        \"\"\"Add fixed_ip from specified network to given instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_3198e269","line":2682,"range":{"start_line":2681,"start_character":35,"end_line":2682,"end_character":54},"updated":"2016-02-08 08:32:48.000000000","message":"It is better to describe why this list of vm_state is enough on the commit message or define vm_states.ALLOW_ADD_FIXED_IP with the reason because current list is different from the other ones.","commit_id":"41cd7c5c9e37a9f06eb185f71047cbc9c2bd7ca7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b66f9a5f4155ca3e2a00b29d62209238706d413d","unresolved":false,"context_lines":[{"line_number":2680,"context_line":"    @check_instance_lock"},{"line_number":2681,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.PAUSED,"},{"line_number":2682,"context_line":"                                    vm_states.STOPPED],"},{"line_number":2683,"context_line":"                          task_state\u003d[None])"},{"line_number":2684,"context_line":"    def add_fixed_ip(self, context, instance, network_id):"},{"line_number":2685,"context_line":"        \"\"\"Add fixed_ip from specified network to given instance.\"\"\""},{"line_number":2686,"context_line":"        self.compute_rpcapi.add_fixed_ip_to_instance(context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_d1662eba","line":2683,"range":{"start_line":2683,"start_character":26,"end_line":2683,"end_character":43},"updated":"2016-02-08 08:32:48.000000000","message":"The behavior of this task_state value is the same as the default value of check_instance_state(). In addition, most other callers don\u0027t specify task_state if the default behavior.\nI prefer avoiding the task_state here for easy understanding the purpose: Check vm_state only.","commit_id":"41cd7c5c9e37a9f06eb185f71047cbc9c2bd7ca7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b66f9a5f4155ca3e2a00b29d62209238706d413d","unresolved":false,"context_lines":[{"line_number":2690,"context_line":"    @check_instance_lock"},{"line_number":2691,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.PAUSED,"},{"line_number":2692,"context_line":"                                    vm_states.STOPPED],"},{"line_number":2693,"context_line":"                          task_state\u003d[None])"},{"line_number":2694,"context_line":"    def remove_fixed_ip(self, context, instance, address):"},{"line_number":2695,"context_line":"        \"\"\"Remove fixed_ip from specified network to given instance.\"\"\""},{"line_number":2696,"context_line":"        self.compute_rpcapi.remove_fixed_ip_from_instance(context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_310ea2e5","line":2693,"range":{"start_line":2693,"start_character":26,"end_line":2693,"end_character":44},"updated":"2016-02-08 08:32:48.000000000","message":"ditto","commit_id":"41cd7c5c9e37a9f06eb185f71047cbc9c2bd7ca7"}]}