)]}'
{"nova/objects/console.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bdf4fa2b74a6b1f9ba47fa40a731389e55d96b08","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \u0027password\u0027: fields.StringField(),"},{"line_number":29,"context_line":"        \u0027port\u0027: fields.IntegerField(),"},{"line_number":30,"context_line":"        \u0027pool_id\u0027: fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027pool\u0027: fields.ObjectField(\u0027ConsolePool\u0027, read_only\u003dTrue),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_1124e45d","line":31,"updated":"2016-01-31 10:11:57.000000000","message":"I wonder if we want to lazy load like instance and have something like: expected_attrs","commit_id":"c13977018659018b20867416f65a874f0d60f87e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4bc6df64f8604c880b6842b7223d046848c5233","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \u0027password\u0027: fields.StringField(),"},{"line_number":29,"context_line":"        \u0027port\u0027: fields.IntegerField(),"},{"line_number":30,"context_line":"        \u0027pool_id\u0027: fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027pool\u0027: fields.ObjectField(\u0027ConsolePool\u0027, read_only\u003dTrue),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_91745436","line":31,"in_reply_to":"7a5de9d1_1124e45d","updated":"2016-01-31 10:30:57.000000000","message":"oh, I see how it works now, we pass it in for get_all","commit_id":"c13977018659018b20867416f65a874f0d60f87e"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"907a7750db98c03e62903834dc6461622442121a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \u0027password\u0027: fields.StringField(),"},{"line_number":29,"context_line":"        \u0027port\u0027: fields.IntegerField(),"},{"line_number":30,"context_line":"        \u0027pool_id\u0027: fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027pool\u0027: fields.ObjectField(\u0027ConsolePool\u0027, read_only\u003dTrue),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_6a942442","line":31,"in_reply_to":"7a5de9d1_22f66cf9","updated":"2016-02-01 13:26:24.000000000","message":"True, we don\u0027t need it if we have the pool loaded. We don\u0027t need lazy-load right now but if we did it would require a new db api method db.console_pool_get_by_console_id(). I think we can do without for now and add if/when that becomes necessary later on. Would that be ok or should I add it now?","commit_id":"c13977018659018b20867416f65a874f0d60f87e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"38d0cbbdedd60841a81a84b11d3930bf47f6b571","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \u0027password\u0027: fields.StringField(),"},{"line_number":29,"context_line":"        \u0027port\u0027: fields.IntegerField(),"},{"line_number":30,"context_line":"        \u0027pool_id\u0027: fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027pool\u0027: fields.ObjectField(\u0027ConsolePool\u0027, read_only\u003dTrue),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_7fc28c54","line":31,"in_reply_to":"7a5de9d1_6a942442","updated":"2016-02-01 21:29:02.000000000","message":"Do we ever need the pool_id by itself in the patches you have stacked above this? If not, then I think we should omit both. If so, I think you should just go ahead and load the full object in each time and we use that for the id.","commit_id":"c13977018659018b20867416f65a874f0d60f87e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"14f6f7cd8b367ae49234f14ae2f6dae9b175d801","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \u0027password\u0027: fields.StringField(),"},{"line_number":29,"context_line":"        \u0027port\u0027: fields.IntegerField(),"},{"line_number":30,"context_line":"        \u0027pool_id\u0027: fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027pool\u0027: fields.ObjectField(\u0027ConsolePool\u0027, read_only\u003dTrue),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_22f66cf9","line":31,"in_reply_to":"7a5de9d1_91745436","updated":"2016-01-31 16:36:13.000000000","message":"It seems kinda weird to keep the pool_id and the actual pool in the object. If we have the pool loaded, we have the id in that object. If not, does the pool_id give us anything? A lazy-load should be able to load it with just our own id.","commit_id":"c13977018659018b20867416f65a874f0d60f87e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4bc6df64f8604c880b6842b7223d046848c5233","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        db.console_delete(self._context, self.id)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @base.remotable_classmethod"},{"line_number":61,"context_line":"    def get(cls, context, console_id, instance_uuid\u003dNone):"},{"line_number":62,"context_line":"        db_console \u003d db.console_get(context, console_id,"},{"line_number":63,"context_line":"                                    instance_uuid\u003dinstance_uuid)"},{"line_number":64,"context_line":"        return cls._from_db_object(context, cls(), db_console,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_b1715046","line":61,"updated":"2016-01-31 10:30:57.000000000","message":"Nit: seems odd to not have expected_attrs, even if we default to [\u0027pool\u0027], but we don\u0027t use that, so maybe thats simpler.","commit_id":"c13977018659018b20867416f65a874f0d60f87e"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"907a7750db98c03e62903834dc6461622442121a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        db.console_delete(self._context, self.id)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @base.remotable_classmethod"},{"line_number":61,"context_line":"    def get(cls, context, console_id, instance_uuid\u003dNone):"},{"line_number":62,"context_line":"        db_console \u003d db.console_get(context, console_id,"},{"line_number":63,"context_line":"                                    instance_uuid\u003dinstance_uuid)"},{"line_number":64,"context_line":"        return cls._from_db_object(context, cls(), db_console,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_ea8ed42c","line":61,"in_reply_to":"7a5de9d1_62f0e4fe","updated":"2016-02-01 13:26:24.000000000","message":"Done","commit_id":"c13977018659018b20867416f65a874f0d60f87e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"14f6f7cd8b367ae49234f14ae2f6dae9b175d801","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        db.console_delete(self._context, self.id)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @base.remotable_classmethod"},{"line_number":61,"context_line":"    def get(cls, context, console_id, instance_uuid\u003dNone):"},{"line_number":62,"context_line":"        db_console \u003d db.console_get(context, console_id,"},{"line_number":63,"context_line":"                                    instance_uuid\u003dinstance_uuid)"},{"line_number":64,"context_line":"        return cls._from_db_object(context, cls(), db_console,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_62f0e4fe","line":61,"in_reply_to":"7a5de9d1_b1715046","updated":"2016-01-31 16:36:13.000000000","message":"Nits in remotable (i.e. rpc api) methods should probably be resolved :)\n\nI agree that we should just go ahead and allow for passing this, even if we default it to be included.","commit_id":"c13977018659018b20867416f65a874f0d60f87e"}]}