)]}'
{"nova/tests/unit/api/openstack/compute/test_flavor_manage.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"62d9554376ecdb6c4a25e7eee51cee7cd0eefc3d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.stubs.Set(flavors,"},{"line_number":103,"context_line":"                       \"get_flavor_by_flavor_id\","},{"line_number":104,"context_line":"                       fake_get_flavor_by_flavor_id)"},{"line_number":105,"context_line":"        self.stubs.Set(flavors, \"destroy\", fake_destroy)"},{"line_number":106,"context_line":"        self.stub_out(\"nova.db.flavor_create\", fake_create)"},{"line_number":107,"context_line":"        self.app \u003d self._setup_app()"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_ffe175ff","line":105,"updated":"2016-01-20 16:29:45.000000000","message":"caught you :)","commit_id":"8a38da2708da9ef9c01333acd267f4dc6b301904"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f51de680abb390aeb5b2aa8403ffae9deac8147","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"                       fake_vol_unreserve)"},{"line_number":1718,"context_line":"        self.stubs.Set(self.compute.volume_api, \u0027terminate_connection\u0027,"},{"line_number":1719,"context_line":"                       fake_vol_api_func)"},{"line_number":1720,"context_line":"        self.stub_out(\u0027nova.db.\u0027"},{"line_number":1721,"context_line":"                      \u0027block_device_mapping_get_by_instance_and_volume_id\u0027,"},{"line_number":1722,"context_line":"                      lambda x, y, z, v: fake_bdm)"},{"line_number":1723,"context_line":"        self.stubs.Set(self.compute.driver, \u0027get_volume_connector\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_37eafe74","line":1720,"range":{"start_line":1720,"start_character":30,"end_line":1720,"end_character":32},"updated":"2016-02-01 20:40:06.000000000","message":"uh, I was seeing a space here but it\u0027s all good\n.\u0027","commit_id":"edd1b9bd2f8a4192696835df7bc51ffa66ff6e8f"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"c5ff2fe01e08b93111d19a1311cf009c58896453","unresolved":false,"context_lines":[{"line_number":1717,"context_line":"                       fake_vol_unreserve)"},{"line_number":1718,"context_line":"        self.stubs.Set(self.compute.volume_api, \u0027terminate_connection\u0027,"},{"line_number":1719,"context_line":"                       fake_vol_api_func)"},{"line_number":1720,"context_line":"        self.stub_out(\u0027nova.db.\u0027"},{"line_number":1721,"context_line":"                      \u0027block_device_mapping_get_by_instance_and_volume_id\u0027,"},{"line_number":1722,"context_line":"                      lambda x, y, z, v: fake_bdm)"},{"line_number":1723,"context_line":"        self.stubs.Set(self.compute.driver, \u0027get_volume_connector\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_027e9b69","line":1720,"range":{"start_line":1720,"start_character":30,"end_line":1720,"end_character":32},"in_reply_to":"7a5de9d1_37eafe74","updated":"2016-02-01 21:51:52.000000000","message":"Yup, there are some looooooong method names to stub ;)","commit_id":"edd1b9bd2f8a4192696835df7bc51ffa66ff6e8f"}],"nova/tests/unit/db/fakes.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f51de680abb390aeb5b2aa8403ffae9deac8147","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return self.values[name]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def stub_out(test, funcs):"},{"line_number":49,"context_line":"    \"\"\"Set the stubs in mapping in the db api.\"\"\""},{"line_number":50,"context_line":"    for func in funcs:"},{"line_number":51,"context_line":"        func_name \u003d \u0027_\u0027.join(func.__name__.split(\u0027_\u0027)[1:])"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_17b5827c","line":48,"range":{"start_line":48,"start_character":13,"end_line":48,"end_character":17},"updated":"2016-02-01 20:40:06.000000000","message":"in theory, all s/stubs/test here in that file were not needed but that\u0027s fine","commit_id":"edd1b9bd2f8a4192696835df7bc51ffa66ff6e8f"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"c5ff2fe01e08b93111d19a1311cf009c58896453","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return self.values[name]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def stub_out(test, funcs):"},{"line_number":49,"context_line":"    \"\"\"Set the stubs in mapping in the db api.\"\"\""},{"line_number":50,"context_line":"    for func in funcs:"},{"line_number":51,"context_line":"        func_name \u003d \u0027_\u0027.join(func.__name__.split(\u0027_\u0027)[1:])"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_6c4d08c3","line":48,"range":{"start_line":48,"start_character":13,"end_line":48,"end_character":17},"in_reply_to":"7a5de9d1_17b5827c","updated":"2016-02-01 21:51:52.000000000","message":"This is a convention started by Matt Riedemann in the following commit that we\u0027ve been using during the mox port (see fake.py) because these functions now take a different argument type (the test class).\n\nhttps://github.com/openstack/nova/commit/e73d2a42e544254672df5e451a0d27ee8d40d3a8","commit_id":"edd1b9bd2f8a4192696835df7bc51ffa66ff6e8f"}],"nova/tests/unit/test_crypto.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f51de680abb390aeb5b2aa8403ffae9deac8147","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                          \"file_name\": file_name}]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        self.stub_out(\u0027nova.db.certificate_get_all_by_user_and_project\u0027,"},{"line_number":110,"context_line":"                       mock_certificate_get_all_by_user_and_project)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        crypto.revoke_certs_by_user_and_project(user_id, project_id)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_77507632","side":"PARENT","line":110,"range":{"start_line":110,"start_character":22,"end_line":110,"end_character":23},"updated":"2016-02-01 20:40:06.000000000","message":"that was not a related change. Since it\u0027s a big change, I\u0027m fine but usually, I\u0027d ask the proposer to remove it in a next respin","commit_id":"5a2d1543f089043e5b6eb681915c61dabb4e6a49"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"c5ff2fe01e08b93111d19a1311cf009c58896453","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                          \"file_name\": file_name}]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        self.stub_out(\u0027nova.db.certificate_get_all_by_user_and_project\u0027,"},{"line_number":110,"context_line":"                       mock_certificate_get_all_by_user_and_project)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        crypto.revoke_certs_by_user_and_project(user_id, project_id)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_bff6c48c","side":"PARENT","line":110,"range":{"start_line":110,"start_character":22,"end_line":110,"end_character":23},"in_reply_to":"7a5de9d1_77507632","updated":"2016-02-01 21:51:52.000000000","message":"This is from a rebase, but was intentionally kept. I ported this line in an earlier patch (in this same review), but another commit that also ported it was merged first (with \"incorrect\" spacing).\n\n\"self.stub_out\" is unfortunately one character less than \"self.stubs.Set\", so search \u0026 replace leaves a bunch of one character spaces that need to be fixed. I have tried hard to find \u0026 fix all the ones I\u0027ve changed, but I\u0027m sure I\u0027ve missed some too.\n\nAnyhoo, I know not to randomly change whitespace, but I do think this is in scope b/c this patch set changes pretty much every line that starts with: \"self.stub_out(\u0027nova.db\".\n\nI hope that additional context helps a bit. I\u0027m learning to be less of a \"boy scout\" for Nova, but old habits die hard.","commit_id":"5a2d1543f089043e5b6eb681915c61dabb4e6a49"}],"nova/tests/unit/test_metadata.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f51de680abb390aeb5b2aa8403ffae9deac8147","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                     \u0027device_name\u0027: \u0027/dev/sdb\u0027})]"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        self.stub_out(\u0027nova.db.block_device_mapping_get_all_by_instance\u0027,"},{"line_number":251,"context_line":"                       fake_bdm_get)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        expected \u003d {\u0027ami\u0027: \u0027sda1\u0027,"},{"line_number":254,"context_line":"                    \u0027root\u0027: \u0027/dev/sda1\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_49059e0e","side":"PARENT","line":251,"range":{"start_line":251,"start_character":22,"end_line":251,"end_character":23},"updated":"2016-02-01 20:40:06.000000000","message":"again, unrelated change","commit_id":"5a2d1543f089043e5b6eb681915c61dabb4e6a49"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"c5ff2fe01e08b93111d19a1311cf009c58896453","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                     \u0027device_name\u0027: \u0027/dev/sdb\u0027})]"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        self.stub_out(\u0027nova.db.block_device_mapping_get_all_by_instance\u0027,"},{"line_number":251,"context_line":"                       fake_bdm_get)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        expected \u003d {\u0027ami\u0027: \u0027sda1\u0027,"},{"line_number":254,"context_line":"                    \u0027root\u0027: \u0027/dev/sda1\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_229e37b9","side":"PARENT","line":251,"range":{"start_line":251,"start_character":22,"end_line":251,"end_character":23},"in_reply_to":"7a5de9d1_49059e0e","updated":"2016-02-01 21:51:52.000000000","message":"This is also from a rebase with \"incorrect\" alignment.\n\nPS: This is why I was playing with getting the other pep8 rules un-ignored in the tox.ini, but there are way too many like this to fix first, so it\u0027s unlikely to happen.","commit_id":"5a2d1543f089043e5b6eb681915c61dabb4e6a49"}]}