)]}'
{"nova/conf/hyperv.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Possible values:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* 1.0: Disables dynamic memory allocation (Default)."},{"line_number":41,"context_line":"* Float values greater than 1.0: Enables allocation of total implied"},{"line_number":42,"context_line":"  RAM divided by this value for startup"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_d2fb2346","line":40,"updated":"2016-01-18 12:24:09.000000000","message":"I added a note in [1] that this option should have a \"min_value \u003d 1.0\" in a later patch when we concentrate on strengthening the validation.\n\n[1] https://etherpad.openstack.org/p/config-options","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Possible values:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* 1.0: Disables dynamic memory allocation (Default)."},{"line_number":41,"context_line":"* Float values greater than 1.0: Enables allocation of total implied"},{"line_number":42,"context_line":"  RAM divided by this value for startup"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e59e9606","line":40,"in_reply_to":"da6ed579_d2fb2346","updated":"2016-01-18 14:10:47.000000000","message":"The usage in the code is like this: \"if dynamic_memory_ratio \u003e 1\"\nSo, it would not be a problem to set this option to 0.\nHowever I don\u0027t know if we should warn the user not to set a higher value that the startup RAM does not reach the minimum memory size to boot the image.","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d6dda6292b5d6b14d3dce88d6aec01a21019f2f4","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Possible values:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* 1.0: Disables dynamic memory allocation (Default)."},{"line_number":41,"context_line":"* Float values greater than 1.0: Enables allocation of total implied"},{"line_number":42,"context_line":"  RAM divided by this value for startup"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_da200cb3","line":40,"in_reply_to":"da6ed579_e59e9606","updated":"2016-01-18 14:31:15.000000000","message":"I\u0027d like to add \"min_value\u003d1.0\" in a later patch because this means that a wrong configuration (\"value\u003d0\" for example) would be shown an service start time and not only when all services are running and I launch an instance. It\u0027s better to signalize wrong configurations as early as possible.\n\nWe don\u0027t know enough about the kind of instances the users will launch on a node with this configuration. I\u0027m fine with the current level of detail. The hyperv folks can then add more details if the want to.","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Possible values:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* \"\": An administrative share will be used (Default)"},{"line_number":91,"context_line":"* Name of a Windows share"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Services which consume this:"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_75e101fe","line":91,"updated":"2016-01-18 12:24:09.000000000","message":"That\u0027s the *path* to the windows share, isn\u0027t it? Method \"get_instances_dir\" [1] makes me believe that.\n\n[1] https://github.com/openstack/nova/blob/master/nova/virt/hyperv/pathutils.py#L49","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Possible values:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* \"\": An administrative share will be used (Default)"},{"line_number":91,"context_line":"* Name of a Windows share"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Services which consume this:"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_808ea8ce","line":91,"in_reply_to":"da6ed579_75e101fe","updated":"2016-01-18 14:10:47.000000000","message":"I think, it should be the share name. So the function returns:\n\\\\remote_server\\share_name\n(Where share_name \u003d instances_path_share)\nAnd if an administrative share is used the function returns for example:\n\\\\remote_server\\C$\nBut actually I did not do a live testing..","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d6dda6292b5d6b14d3dce88d6aec01a21019f2f4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Possible values:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* \"\": An administrative share will be used (Default)"},{"line_number":91,"context_line":"* Name of a Windows share"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Services which consume this:"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_5db976ca","line":91,"in_reply_to":"da6ed579_808ea8ce","updated":"2016-01-18 14:31:15.000000000","message":"OK, the method confused me. I guess you are right.","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Related options:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"* None"},{"line_number":100,"context_line":"\"\"\")"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"limit_cpu_features_opt \u003d cfg.BoolOpt(\u0027limit_cpu_features\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_55571dca","line":99,"updated":"2016-01-18 12:24:09.000000000","message":"* \"instances_path\": The directory which will be used if this option here is left blank.","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Related options:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"* None"},{"line_number":100,"context_line":"\"\"\")"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"limit_cpu_features_opt \u003d cfg.BoolOpt(\u0027limit_cpu_features\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_00471878","line":99,"in_reply_to":"da6ed579_55571dca","updated":"2016-01-18 14:10:47.000000000","message":"you are right..","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* True: Limit processor-specific features"},{"line_number":114,"context_line":"* False: Do not limit processor-specific features (Default)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Related options:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_75390141","line":115,"updated":"2016-01-18 12:24:09.000000000","message":"Services which consume this:\n\n* nova-compute","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* True: Limit processor-specific features"},{"line_number":114,"context_line":"* False: Do not limit processor-specific features (Default)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Related options:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e011a45e","line":115,"in_reply_to":"da6ed579_75390141","updated":"2016-01-18 14:10:47.000000000","message":"oo sorry..","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"During long stress runs the WMI query that is looking for the iSCSI"},{"line_number":129,"context_line":"device number can incorrectly return no data. If the query is"},{"line_number":130,"context_line":"retried the appropriate data can then be obtained. The query runs"},{"line_number":131,"context_line":"until device number is not none or the retry count is reached."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Possible values:"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_50a40b07","line":131,"range":{"start_line":131,"start_character":6,"end_line":131,"end_character":31},"updated":"2016-01-18 12:24:09.000000000","message":"maybe \"until the device can be found\" ? This is a bit more high level description than a \"not none\" explanation.","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":128,"context_line":"During long stress runs the WMI query that is looking for the iSCSI"},{"line_number":129,"context_line":"device number can incorrectly return no data. If the query is"},{"line_number":130,"context_line":"retried the appropriate data can then be obtained. The query runs"},{"line_number":131,"context_line":"until device number is not none or the retry count is reached."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Possible values:"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_cb35a1db","line":131,"range":{"start_line":131,"start_character":6,"end_line":131,"end_character":31},"in_reply_to":"da6ed579_50a40b07","updated":"2016-01-18 14:10:47.000000000","message":"yes.. done","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Possible values:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Positive integer values. Values greater than 1 is recommended."},{"line_number":136,"context_line":"  (Default: 10)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_705cafed","line":135,"range":{"start_line":135,"start_character":34,"end_line":135,"end_character":48},"updated":"2016-01-18 12:24:09.000000000","message":"Note: In fact it *must be* at least 1, because retry #1 is the first try ever. Which means your description here is correct (but could be surprising if one doesn\u0027t want to \"retry\" and sets this to zero.). I noted that down in the etherpad for a later step when we enhance the validation.","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Possible values:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Positive integer values. Values greater than 1 is recommended."},{"line_number":136,"context_line":"  (Default: 10)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_8b5009d6","line":135,"range":{"start_line":135,"start_character":34,"end_line":135,"end_character":48},"in_reply_to":"da6ed579_705cafed","updated":"2016-01-18 14:10:47.000000000","message":"Yes retry_count \u003d 0 means no tries..","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Positive integer values. Values greater than 1 is recommended."},{"line_number":136,"context_line":"  (Default: 10)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Related options:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Time interval between disk mount retries is declared with"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_b51699a5","line":137,"updated":"2016-01-18 12:24:09.000000000","message":"Services which consume this:\n\n* nova-compute","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Positive integer values. Values greater than 1 is recommended."},{"line_number":136,"context_line":"  (Default: 10)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Related options:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Time interval between disk mount retries is declared with"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_6b6cb59c","line":137,"in_reply_to":"da6ed579_b51699a5","updated":"2016-01-18 14:10:47.000000000","message":"sorry again..","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Power state check timeframe"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The timeframe to be checked for instance power state changes."},{"line_number":174,"context_line":"This options is used to fetch the state of the VM from database"},{"line_number":175,"context_line":"within the specified timeframe."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_916844bc","line":174,"range":{"start_line":174,"start_character":55,"end_line":174,"end_character":63},"updated":"2016-01-18 12:24:09.000000000","message":"I\u0027m not sure if this is the database OpenStack uses for its internal state, which could be implied by this sentence. It looks like the timeframe for the WQL query which is executed agains the WMI interface of Windows. The \"os-win\" library makes me think this way (see method \"_get_event_wql_query\" in [1]).\n\n[1] https://github.com/openstack/os-win/blob/9970cff32321cadafec1e8db177ff3f179ecc8c5/os_win/utils/compute/vmutils.py#L845","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Power state check timeframe"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The timeframe to be checked for instance power state changes."},{"line_number":174,"context_line":"This options is used to fetch the state of the VM from database"},{"line_number":175,"context_line":"within the specified timeframe."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_6187ffd7","line":174,"range":{"start_line":174,"start_character":5,"end_line":174,"end_character":12},"updated":"2016-01-18 12:24:09.000000000","message":"nit: \"option\" in singular","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Power state check timeframe"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The timeframe to be checked for instance power state changes."},{"line_number":174,"context_line":"This options is used to fetch the state of the VM from database"},{"line_number":175,"context_line":"within the specified timeframe."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e6f21c06","line":174,"range":{"start_line":174,"start_character":55,"end_line":174,"end_character":63},"in_reply_to":"da6ed579_916844bc","updated":"2016-01-18 14:10:47.000000000","message":"Yes actually I saw this method.. I did not know what WQL is :), so I thought it was a regular database, sorry.. I am changing the sentence like this:\nThis option is used to fetch the state of the VM from the WMI interface, by a WQL query, within the specified timeframe.","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d6dda6292b5d6b14d3dce88d6aec01a21019f2f4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Power state check timeframe"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The timeframe to be checked for instance power state changes."},{"line_number":174,"context_line":"This options is used to fetch the state of the VM from database"},{"line_number":175,"context_line":"within the specified timeframe."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_ddf3269e","line":174,"range":{"start_line":174,"start_character":55,"end_line":174,"end_character":63},"in_reply_to":"da6ed579_e6f21c06","updated":"2016-01-18 14:31:15.000000000","message":"yepp, better (I had to research what WQL is too)","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Possible values:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Time in seconds. (Default: 60)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Services which consume this:"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_71b4b034","line":179,"range":{"start_line":179,"start_character":2,"end_line":179,"end_character":6},"updated":"2016-01-18 12:24:09.000000000","message":"\"Timeframe in seconds\"","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"Power state event polling interval"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Instance power state change event polling frequency. Sets the"},{"line_number":197,"context_line":"listener interval for power state events to the given value."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_913fe424","line":197,"updated":"2016-01-18 12:24:09.000000000","message":"Maybe you can include some of the commit message of [1] which introduced this config option. Maybe something like:\n\n    \"This option enhances the internal lifecycle \n    notifications of VMs that reboot themselves. It is\n    unlikey that an operator has to change this value.\"\n\n[1] https://review.openstack.org/#/c/163080/4","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":194,"context_line":"Power state event polling interval"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Instance power state change event polling frequency. Sets the"},{"line_number":197,"context_line":"listener interval for power state events to the given value."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_46bd28d6","line":197,"in_reply_to":"da6ed579_913fe424","updated":"2016-01-18 14:10:47.000000000","message":"done, thanks..","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4686c2f1d2caebd51af02b3e2394d7f50c04e31f","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Possible values:"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"* If not provided, the first external virtual switch is used"},{"line_number":257,"context_line":"* Virtual switch name"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_340866d9","line":256,"range":{"start_line":256,"start_character":23,"end_line":256,"end_character":45},"updated":"2016-01-18 12:24:09.000000000","message":"Maybe we should specify better from which set the \"first one\" is selected [1].\n\n    \"the first of a list of available vswitches is used. \n    This list is queried by WQL.\"\n\n[1] https://github.com/openstack/os-win/blob/3fd7890771cbb385053e34c2fc8fd31cfda4ca33/os_win/utils/network/networkutils.py#L157","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"15d0a10e58bcce7fd83eaae58d3d07e102ab5fdf","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Possible values:"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"* If not provided, the first external virtual switch is used"},{"line_number":257,"context_line":"* Virtual switch name"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_4692084d","line":256,"range":{"start_line":256,"start_character":23,"end_line":256,"end_character":45},"in_reply_to":"da6ed579_340866d9","updated":"2016-01-18 14:10:47.000000000","message":"OK, done","commit_id":"b18d85fc00a0351c1a2cc1380ce13fdb30c959b4"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e36959acc2e5e00caa5855aaed91aa653c7ee381","unresolved":false,"context_lines":[{"line_number":33,"context_line":"greater than 1. The value expresses the ratio between the total RAM"},{"line_number":34,"context_line":"assigned to an instance and its startup RAM amount. For example a"},{"line_number":35,"context_line":"ratio of 2.0 for an instance with 1024MB of RAM implies 512MB of"},{"line_number":36,"context_line":"RAM allocated at startup"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Possible values:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_c44b4b2a","line":36,"updated":"2016-01-18 15:35:34.000000000","message":"\u0027.\u0027 at the end?","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e36959acc2e5e00caa5855aaed91aa653c7ee381","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* 1.0: Disables dynamic memory allocation (Default)."},{"line_number":41,"context_line":"* Float values greater than 1.0: Enables allocation of total implied"},{"line_number":42,"context_line":"  RAM divided by this value for startup"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Services which consume this:"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_2412670a","line":42,"updated":"2016-01-18 15:35:34.000000000","message":"\u0027.\u0027 at the end?","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e36959acc2e5e00caa5855aaed91aa653c7ee381","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Enables metrics collections for an instance by using Hyper-V\\\u0027s"},{"line_number":60,"context_line":"metric APIs. Collected data can by retrieved by other apps and"},{"line_number":61,"context_line":"services, e.g.: Ceilometer."},{"line_number":62,"context_line":"Requires Hyper-V / Windows Server 2012 and above"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Possible values:"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_44051bc0","line":62,"updated":"2016-01-18 15:35:34.000000000","message":"This line can be removed. We no longer support Windows Server 2008 R2, so the minimum version is Hyper-V / Windows Server 2012 anyways.","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Enables metrics collections for an instance by using Hyper-V\\\u0027s"},{"line_number":60,"context_line":"metric APIs. Collected data can by retrieved by other apps and"},{"line_number":61,"context_line":"services, e.g.: Ceilometer."},{"line_number":62,"context_line":"Requires Hyper-V / Windows Server 2012 and above"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Possible values:"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_729fd603","line":62,"in_reply_to":"da6ed579_44051bc0","updated":"2016-01-28 09:36:20.000000000","message":"done, thanks","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"qemu-img is required for some of the image related operations"},{"line_number":230,"context_line":"like converting between different image types. You can get it"},{"line_number":231,"context_line":"from here: http://qemu.weilnetz.de/. You must make sure that"},{"line_number":232,"context_line":"the qemu-img path is set in the PATH environment variable."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_89aa4c18","line":231,"updated":"2016-01-18 15:30:24.000000000","message":"qemu-img.exe is also provided by the Cloudbase OpenStack Hyper-V Compute Driver installer (https://cloudbase.it/openstack-hyperv-driver/) and it sets the proper path for this in the config file.","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"qemu-img is required for some of the image related operations"},{"line_number":230,"context_line":"like converting between different image types. You can get it"},{"line_number":231,"context_line":"from here: http://qemu.weilnetz.de/. You must make sure that"},{"line_number":232,"context_line":"the qemu-img path is set in the PATH environment variable."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_4d523b69","line":231,"in_reply_to":"da6ed579_89aa4c18","updated":"2016-01-28 09:36:20.000000000","message":"ok, I added","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":229,"context_line":"qemu-img is required for some of the image related operations"},{"line_number":230,"context_line":"like converting between different image types. You can get it"},{"line_number":231,"context_line":"from here: http://qemu.weilnetz.de/. You must make sure that"},{"line_number":232,"context_line":"the qemu-img path is set in the PATH environment variable."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Possible values:"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_4988d422","line":232,"updated":"2016-01-18 15:30:24.000000000","message":"Not necessarely. If you put the whole path, it should be fine.","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":229,"context_line":"qemu-img is required for some of the image related operations"},{"line_number":230,"context_line":"like converting between different image types. You can get it"},{"line_number":231,"context_line":"from here: http://qemu.weilnetz.de/. You must make sure that"},{"line_number":232,"context_line":"the qemu-img path is set in the PATH environment variable."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Possible values:"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_0d4c43c6","line":232,"in_reply_to":"da6ed579_4988d422","updated":"2016-01-28 09:36:20.000000000","message":"done","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":234,"context_line":"Possible values:"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Name of the qemu-img executable, in case it is in the same"},{"line_number":237,"context_line":"  directory as the nova-compute service (Default)"},{"line_number":238,"context_line":"* Path of qemu-img command (DRIVELETTER:\\PATH\\TO\\QEMU-IMG\\COMMAND)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_299c805c","line":237,"updated":"2016-01-18 15:30:24.000000000","message":"or, its directory is already added in PATH.","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":234,"context_line":"Possible values:"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Name of the qemu-img executable, in case it is in the same"},{"line_number":237,"context_line":"  directory as the nova-compute service (Default)"},{"line_number":238,"context_line":"* Path of qemu-img command (DRIVELETTER:\\PATH\\TO\\QEMU-IMG\\COMMAND)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_cdcceb37","line":237,"in_reply_to":"da6ed579_299c805c","updated":"2016-01-28 09:36:20.000000000","message":"done","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":255,"context_line":"External virtual switch name"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"The Hyper-V Virtual Switch is a software-based layer-2 Ethernet"},{"line_number":258,"context_line":"network switch that is available in Hyper-V Manager when you install"},{"line_number":259,"context_line":"the Hyper-V server role. The switch includes programmatically managed"},{"line_number":260,"context_line":"and extensible capabilities to connect virtual machines to both"},{"line_number":261,"context_line":"virtual networks and the physical network. In addition, Hyper-V"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_49d3f438","line":258,"updated":"2016-01-18 15:30:24.000000000","message":"ehh... if you are using Microsoft Hyper-V Server (not Microsoft Windows Server), you won\u0027t have the Hyper-V Manager at your disposal (virtmgmt.msc), but the Virtual Switches still exist and can be created.\n\ninstead, we should something like this:\n\n    The Hyper-V Virtual Switch is a software-based layer-2 \n    Ethernet network switch that is available with the \n    installation of the Hyper-V server role.\n\nAlso, we should also mention that the vSwitch represented by this config option must be an external one (not internal or private), otherwise the VM network traffic will be isolated to only that Server, which is not desirable. :)","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":255,"context_line":"External virtual switch name"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"The Hyper-V Virtual Switch is a software-based layer-2 Ethernet"},{"line_number":258,"context_line":"network switch that is available in Hyper-V Manager when you install"},{"line_number":259,"context_line":"the Hyper-V server role. The switch includes programmatically managed"},{"line_number":260,"context_line":"and extensible capabilities to connect virtual machines to both"},{"line_number":261,"context_line":"virtual networks and the physical network. In addition, Hyper-V"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_8d403358","line":258,"in_reply_to":"da6ed579_49d3f438","updated":"2016-01-28 09:36:20.000000000","message":"thanks, done","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"* If not provided, the first of a list of available vswitches"},{"line_number":268,"context_line":"  is used. This list is queried by WQL."},{"line_number":269,"context_line":"* Virtual switch name"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Services which consume this:"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_8e49f2d2","line":269,"updated":"2016-01-18 15:30:24.000000000","message":"\u0027.\u0027 at the end?","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":277,"context_line":"* None"},{"line_number":278,"context_line":"\"\"\")"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"wait_soft_reboot_seconds_opt \u003d cfg.IntOpt(\u0027wait_soft_reboot_seconds\u0027,"},{"line_number":281,"context_line":"                default\u003d60,"},{"line_number":282,"context_line":"                help\u003d\"\"\""},{"line_number":283,"context_line":"Wait soft reboot seconds"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_8ec49240","line":280,"updated":"2016-01-18 15:30:24.000000000","message":"sooo, this config option looks like a duplicate to me. There is another one, with the same name in libvirt. The only difference is that in libvirt the default is 120 seconds.\n\nWondering if we can do something about it?","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":277,"context_line":"* None"},{"line_number":278,"context_line":"\"\"\")"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"wait_soft_reboot_seconds_opt \u003d cfg.IntOpt(\u0027wait_soft_reboot_seconds\u0027,"},{"line_number":281,"context_line":"                default\u003d60,"},{"line_number":282,"context_line":"                help\u003d\"\"\""},{"line_number":283,"context_line":"Wait soft reboot seconds"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_1f554a4f","line":280,"in_reply_to":"da6ed579_8ec49240","updated":"2016-01-28 09:36:20.000000000","message":"well, I don\u0027t know if hyperv may need a different amount of time for soft reboot from libvirt.. I could change hyperv/vmops.py to use the libvirt.wait_soft_reboot_seconds but this is not the subject of this commit actually..","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":308,"context_line":"configuration drive that attaches to the instance when it boots."},{"line_number":309,"context_line":"By default, you cannot attach the configuration drive image as"},{"line_number":310,"context_line":"a CD drive instead of as a disk drive. To attach a CD drive set"},{"line_number":311,"context_line":"this option to true."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"Possible values:"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_ae5dd616","line":311,"updated":"2016-01-18 15:30:24.000000000","message":"This is a bit hard to understand and a bit misleading, IMO.\n\nHow about this?\n\n    OpenStack can be configured to write instance metadata to\n    a configuration drive, which is then attached to the\n    instance before it boots. The configuration drive can be\n    attached as a disk drive (default) or as a CD drive.","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":308,"context_line":"configuration drive that attaches to the instance when it boots."},{"line_number":309,"context_line":"By default, you cannot attach the configuration drive image as"},{"line_number":310,"context_line":"a CD drive instead of as a disk drive. To attach a CD drive set"},{"line_number":311,"context_line":"this option to true."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"Possible values:"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_7fd6bec6","line":311,"in_reply_to":"da6ed579_ae5dd616","updated":"2016-01-28 09:36:20.000000000","message":"yeah better, thanks:)","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":325,"context_line":"  or when the REST API call to create an instance will have a flag to enable"},{"line_number":326,"context_line":"  the config drive for that instance."},{"line_number":327,"context_line":"* config_drive_format option must be set to \u0027iso9660\u0027 in order to use"},{"line_number":328,"context_line":"  CD drive as the configuration drive image"},{"line_number":329,"context_line":"* To use configuration drive with Hyper-V, you must set the"},{"line_number":330,"context_line":"  mkisofs_cmd value to the full path to an mkisofs.exe installation."},{"line_number":331,"context_line":"  Additionally, you must set the qemu_img_cmd value to the full path"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_f37bbb79","line":328,"updated":"2016-01-18 15:30:24.000000000","message":"\u0027.\u0027 at the end?","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":331,"context_line":"  Additionally, you must set the qemu_img_cmd value to the full path"},{"line_number":332,"context_line":"  to an qemu-img command installation."},{"line_number":333,"context_line":"* You can configure the Compute service to always create a configuration"},{"line_number":334,"context_line":"  drive by setting the force_config_drive option to true"},{"line_number":335,"context_line":"\"\"\")"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"config_drive_inject_password_opt \u003d cfg.BoolOpt(\u0027config_drive_inject_password\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_3382b353","line":334,"updated":"2016-01-18 15:30:24.000000000","message":"\u0027.\u0027 at the end?","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":339,"context_line":"                help\u003d\"\"\""},{"line_number":340,"context_line":"Configuration drive inject password"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"Enables setting the admin password in the configuration drive image"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Possible values:"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_d059cd5c","line":342,"updated":"2016-01-18 15:30:24.000000000","message":"\u0027.\u0027 at the end?","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":353,"context_line":"Related options:"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"* This option is meaningful when used with other options that enable"},{"line_number":356,"context_line":"  configuration drive usage with Hyper-V, such as force_config_drive."},{"line_number":357,"context_line":"\"\"\")"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"volume_attach_retry_count_opt \u003d cfg.IntOpt(\u0027volume_attach_retry_count\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_9346ff4d","line":356,"updated":"2016-01-18 15:30:24.000000000","message":"you could also add config_drive_format here. The only config_drive_format we accept can accept at the moment is \u0027iso9660\u0027.","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":353,"context_line":"Related options:"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"* This option is meaningful when used with other options that enable"},{"line_number":356,"context_line":"  configuration drive usage with Hyper-V, such as force_config_drive."},{"line_number":357,"context_line":"\"\"\")"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"volume_attach_retry_count_opt \u003d cfg.IntOpt(\u0027volume_attach_retry_count\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_ff2ceeac","line":356,"in_reply_to":"da6ed579_9346ff4d","updated":"2016-01-28 09:36:20.000000000","message":"ok, added","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d69396d5935750b96501793530d4097447a639ea","unresolved":false,"context_lines":[{"line_number":400,"context_line":"Related options:"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"* This options is meaningful when volume_attach_retry_count"},{"line_number":403,"context_line":"  is greater than 1"},{"line_number":404,"context_line":"* The retry loop runs with volume_attach_retry_count and"},{"line_number":405,"context_line":"  volume_attach_retry_interval configuration options."},{"line_number":406,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_709341fb","line":403,"updated":"2016-01-18 15:30:24.000000000","message":"missing \u0027.\u0027 at the end?","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"eddd7efb375ff0c1c91c17afdf7118c0a9d68035","unresolved":false,"context_lines":[{"line_number":400,"context_line":"Related options:"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"* This options is meaningful when volume_attach_retry_count"},{"line_number":403,"context_line":"  is greater than 1"},{"line_number":404,"context_line":"* The retry loop runs with volume_attach_retry_count and"},{"line_number":405,"context_line":"  volume_attach_retry_interval configuration options."},{"line_number":406,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_3f0a8627","line":403,"in_reply_to":"da6ed579_709341fb","updated":"2016-01-28 09:36:20.000000000","message":"done, thanks for all.","commit_id":"cbca0e53a62584d312fa3b21bfae817c002a7f34"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"5b1ed2d6370274629bc0b31baf8996393097b156","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                title\u003d\"The Hyper-V feature\","},{"line_number":21,"context_line":"                help\u003d\"\"\""},{"line_number":22,"context_line":"The hyperv feature allows you to configure the Hyper-V hypervisor"},{"line_number":23,"context_line":"driver for use within an OpenStack deployment."},{"line_number":24,"context_line":"\"\"\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_95a4aea6","line":23,"updated":"2016-02-10 18:44:14.000000000","message":"how about \"to be used within an OpenStack deployment.\" ?\n\nit sounds a bit better.","commit_id":"283b98c469e754270e942271bfe7595da24e345d"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"5b1ed2d6370274629bc0b31baf8996393097b156","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* 1.0: Disables dynamic memory allocation (Default)."},{"line_number":41,"context_line":"* Float values greater than 1.0: Enables allocation of total implied"},{"line_number":42,"context_line":"  RAM divided by this value for startup."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Services which consume this:"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_75733216","line":42,"updated":"2016-02-10 18:44:14.000000000","message":"it seems those are the only ones that have an ending \u0027.\u0027, while the rest of the config options\u0027 possible values do not have the \u0027.\u0027. Make sure that either all of them have it, or none of them do. :)","commit_id":"283b98c469e754270e942271bfe7595da24e345d"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"5b1ed2d6370274629bc0b31baf8996393097b156","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                help\u003d\"\"\""},{"line_number":57,"context_line":"Enable instance metrics collection"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Enables metrics collections for an instance by using Hyper-V\\\u0027s"},{"line_number":60,"context_line":"metric APIs. Collected data can by retrieved by other apps and"},{"line_number":61,"context_line":"services, e.g.: Ceilometer."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_b5c68a47","line":59,"range":{"start_line":59,"start_character":60,"end_line":59,"end_character":62},"updated":"2016-02-10 18:44:14.000000000","message":"no need for the \\.","commit_id":"283b98c469e754270e942271bfe7595da24e345d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"517abb071a9350916a4920df7d89023d4f793bc7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                help\u003d\"\"\""},{"line_number":80,"context_line":"Instances path share"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The name of a Windows share name mapped to the \"instances_path\" dir"},{"line_number":83,"context_line":"and used by the resize feature to copy files to the target host."},{"line_number":84,"context_line":"If left blank, an administrative share (hidden network share) will"},{"line_number":85,"context_line":"be used, looking for the same \"instances_path\" used locally."}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_b12709c9","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":32},"updated":"2016-02-12 15:40:09.000000000","message":"I think we don\u0027t need \u0027name\u0027 twice","commit_id":"bfea684c8ce2893611c6aa5f49e21fe5b7fbfd09"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"40acd97f6f1b98c3113a97a83917a7e23ebc4215","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                help\u003d\"\"\""},{"line_number":80,"context_line":"Instances path share"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The name of a Windows share name mapped to the \"instances_path\" dir"},{"line_number":83,"context_line":"and used by the resize feature to copy files to the target host."},{"line_number":84,"context_line":"If left blank, an administrative share (hidden network share) will"},{"line_number":85,"context_line":"be used, looking for the same \"instances_path\" used locally."}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_db9b12c8","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":32},"in_reply_to":"3a57f1b5_b12709c9","updated":"2016-02-22 07:02:06.000000000","message":"Done","commit_id":"bfea684c8ce2893611c6aa5f49e21fe5b7fbfd09"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"517abb071a9350916a4920df7d89023d4f793bc7","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"This flag is needed to support live migration to hosts with"},{"line_number":108,"context_line":"different CPU features and checked during instance creation"},{"line_number":109,"context_line":"in order to limit the CPU features used by the VM."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_942f5b87","line":109,"range":{"start_line":109,"start_character":47,"end_line":109,"end_character":49},"updated":"2016-02-12 15:40:09.000000000","message":"is the VM an official terminology we use? shall we use instance or server instead?","commit_id":"bfea684c8ce2893611c6aa5f49e21fe5b7fbfd09"},{"author":{"_account_id":18934,"name":"ecelik","email":"celik.esra@tubitak.gov.tr","username":"esracelik"},"change_message_id":"40acd97f6f1b98c3113a97a83917a7e23ebc4215","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"This flag is needed to support live migration to hosts with"},{"line_number":108,"context_line":"different CPU features and checked during instance creation"},{"line_number":109,"context_line":"in order to limit the CPU features used by the VM."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Possible values:"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_9bbfcafa","line":109,"range":{"start_line":109,"start_character":47,"end_line":109,"end_character":49},"in_reply_to":"3a57f1b5_942f5b87","updated":"2016-02-22 07:02:06.000000000","message":"Done","commit_id":"bfea684c8ce2893611c6aa5f49e21fe5b7fbfd09"}]}