)]}'
{"nova/conf/cert.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d3e67daeb7f76f63f265d13ceb48f478a7c84870","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"rpcapi_cap_opt \u003d cfg.StrOpt(\"cert\","},{"line_number":39,"context_line":"        help\u003d\"\"\""},{"line_number":40,"context_line":"Specifies the maximum version for messages sent to cert services. This should"},{"line_number":41,"context_line":"be the minimum value that is supported by all of the deployed cert services."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_8dce1382","line":40,"range":{"start_line":40,"start_character":47,"end_line":40,"end_character":51},"updated":"2016-01-20 17:04:15.000000000","message":"If I get [1] and [2] right, this capping means the max version of RPC messages which is *sent by* cert services. Especially the phrase \n\n    \"but it can only send out X+1 version RPC messages\"\n\nin [1] makes me believe that.\n\n[1] http://docs.openstack.org/openstack-ops/content/ops_upgrades_upgrade_levels.html\n[2] https://git.openstack.org/cgit/openstack/nova/commit/?id\u003d5e8ec9d38","commit_id":"5c3f2cac167d1eb6ffa4d322a5cfc8636bc4e6ba"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"09d0084031f97644ef1f56fbe9714d16fb495e76","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"rpcapi_cap_opt \u003d cfg.StrOpt(\"cert\","},{"line_number":39,"context_line":"        help\u003d\"\"\""},{"line_number":40,"context_line":"Specifies the maximum version for messages sent to cert services. This should"},{"line_number":41,"context_line":"be the minimum value that is supported by all of the deployed cert services."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_fde72b10","line":40,"range":{"start_line":40,"start_character":47,"end_line":40,"end_character":51},"in_reply_to":"9a68dd71_1b033475","updated":"2016-01-20 22:38:43.000000000","message":"Looking at the code some more, it\u0027s used by nova/cert/rpcapi.py, which uses it to create the client, so it seems like it\u0027s limiting what is being sent. I changed it in the next patchset.","commit_id":"5c3f2cac167d1eb6ffa4d322a5cfc8636bc4e6ba"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"25ea02c69c8a41c6a1e16e9857375d463067a06b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"rpcapi_cap_opt \u003d cfg.StrOpt(\"cert\","},{"line_number":39,"context_line":"        help\u003d\"\"\""},{"line_number":40,"context_line":"Specifies the maximum version for messages sent to cert services. This should"},{"line_number":41,"context_line":"be the minimum value that is supported by all of the deployed cert services."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_1b033475","line":40,"range":{"start_line":40,"start_character":47,"end_line":40,"end_character":51},"in_reply_to":"9a68dd71_8dce1382","updated":"2016-01-20 21:43:34.000000000","message":"Well, without dansmith around, it\u0027s hard to say for sure. I\u0027m basing this on the existing help string: \"Set a version cap for messages sent to cert services\". So if it turns out that this is wrong, we can fix it in a subsequent patch.","commit_id":"5c3f2cac167d1eb6ffa4d322a5cfc8636bc4e6ba"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d3e67daeb7f76f63f265d13ceb48f478a7c84870","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Possible values:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Any string representing a version number in the format \u0027N.N\u0027; for example,"},{"line_number":46,"context_line":"possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Services which consume this:"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_ad48b72e","line":46,"updated":"2016-01-20 17:04:15.000000000","message":"If I get [1] right, we can also provide aliases like \"liberty\" here.\n\n[1] http://git.openstack.org/cgit/openstack/nova/tree/nova/cert/rpcapi.py#n71","commit_id":"5c3f2cac167d1eb6ffa4d322a5cfc8636bc4e6ba"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"25ea02c69c8a41c6a1e16e9857375d463067a06b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Possible values:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Any string representing a version number in the format \u0027N.N\u0027; for example,"},{"line_number":46,"context_line":"possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Services which consume this:"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_9b4644be","line":46,"in_reply_to":"9a68dd71_ad48b72e","updated":"2016-01-20 21:43:34.000000000","message":"Done","commit_id":"5c3f2cac167d1eb6ffa4d322a5cfc8636bc4e6ba"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f4a9abd77bb89dc8a5dc270dd92905569dfcf84","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Possible values:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Any string representing a version number in the format \u0027N.N\u0027; for example,"},{"line_number":46,"context_line":"possible values might be \u00271.12\u0027 or \u00272.0\u0027."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Services which consume this:"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_2c57db03","line":46,"in_reply_to":"9a68dd71_ad48b72e","updated":"2016-01-20 21:31:15.000000000","message":"Yeah that\u0027s right because of how the option is used for the version aliases here:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/cert/rpcapi.py#n71","commit_id":"5c3f2cac167d1eb6ffa4d322a5cfc8636bc4e6ba"}]}