)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"8c2ffc8c7acf93aae7118501d4e21ac544ca8fa4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the vif_plugged event to spawn instances correctly."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4f7a2001410dc6682bcf80f87f0dfba987ae572b"},{"line_number":15,"context_line":"Closes-bug: #1512955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_69306108","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"updated":"2016-02-09 11:27:42.000000000","message":"The referenced bug is for XenAPI, not libvirt+xen.\nPlease raise a new bug for libvirt+Xen","commit_id":"d3bfea7dba7e89ba65b3a16d348dbc0a4c5144fd"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"e164cbb836bcc9aff4a78129f8fc0eb1cfb9b049","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the vif_plugged event to spawn instances correctly."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4f7a2001410dc6682bcf80f87f0dfba987ae572b"},{"line_number":15,"context_line":"Closes-bug: #1512955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_688cd235","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":20},"in_reply_to":"5a5ae5dd_69306108","updated":"2016-02-09 14:25:39.000000000","message":"Thanks Bob, fixed it!","commit_id":"d3bfea7dba7e89ba65b3a16d348dbc0a4c5144fd"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3256d9cb292fa0cbc0918209a1feebeea0dc3810","unresolved":false,"context_lines":[{"line_number":4844,"context_line":"        else:"},{"line_number":4845,"context_line":"            events \u003d []"},{"line_number":4846,"context_line":""},{"line_number":4847,"context_line":"        pause \u003d bool(events) and self._conn_supports_start_paused"},{"line_number":4848,"context_line":"        guest \u003d None"},{"line_number":4849,"context_line":"        try:"},{"line_number":4850,"context_line":"            with self.virtapi.wait_for_instance_event("}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_c8173ea1","line":4847,"updated":"2016-03-10 18:08:41.000000000","message":"This doesn\u0027t really make any sense. Waiting for the neutron event if we\u0027re not starting paused doesn\u0027t actually matter. The point of the even is to make sure that our backend is hooked up and that things like a DHCP server are already waiting for us by the time the guest gets started up. If we are not going to start, plug, then unpause there\u0027s really no reason to wait.","commit_id":"6c45a082ef3dd755dc88c29304e5e41c7d8a6e61"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"711fefe5124d6670318a993c14daf4a5afc10918","unresolved":false,"context_lines":[{"line_number":4844,"context_line":"        else:"},{"line_number":4845,"context_line":"            events \u003d []"},{"line_number":4846,"context_line":""},{"line_number":4847,"context_line":"        pause \u003d bool(events) and self._conn_supports_start_paused"},{"line_number":4848,"context_line":"        guest \u003d None"},{"line_number":4849,"context_line":"        try:"},{"line_number":4850,"context_line":"            with self.virtapi.wait_for_instance_event("}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_ebbcb4dd","line":4847,"in_reply_to":"5aef4532_c8173ea1","updated":"2016-03-10 18:20:29.000000000","message":"There\u0027s no value in ensuring that Neutron has finished its work before starting the instance? Nvm, I see that I have misunderstood the context manager below.\n\nSo now that I look at what wait_for_instance_event actually does it is not at all what I expected. The code within the context manager runs before waiting for the event which seems counter to the name. But given that I agree that this change does not make sense.","commit_id":"6c45a082ef3dd755dc88c29304e5e41c7d8a6e61"}]}