)]}'
{"id":"openstack%2Fnova~2687","triplet_id":"openstack%2Fnova~master~I0ebe7c2b045caa648395928dc1a80255d9572cd0","project":"openstack/nova","branch":"master","topic":"SAN_driver-branch","hashtags":[],"change_id":"I0ebe7c2b045caa648395928dc1a80255d9572cd0","subject":"Added snapshot features in SolarisISCSIDriver","status":"ABANDONED","created":"2011-12-30 05:36:12.000000000","updated":"2012-02-17 06:03:05.000000000","total_comment_count":37,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c082ffb548fc3d940f2941dc750a9f51da2cde2d","_number":2687,"virtual_id_number":2687,"owner":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"date":"2012-02-01 21:41:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"date":"2012-01-20 21:42:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"value":0,"date":"2012-01-05 13:59:28.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2012-01-16 21:21:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-01-09 14:46:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"date":"2012-01-09 08:13:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2012-02-01 21:41:53.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"date":"2012-01-16 21:21:16.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-01-03 05:24:40.000000000","updated_by":{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},"reviewer":{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},"state":"REVIEWER"},{"updated":"2012-01-05 13:59:28.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-01-09 14:46:55.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2012-01-16 21:21:16.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-01-20 21:42:41.000000000","updated_by":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"reviewer":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"state":"REVIEWER"},{"updated":"2012-02-01 21:41:53.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"}],"messages":[{"id":"8143b03c6fe50be2712023160887ded8170cd7f2","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2011-12-30 05:38:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"30a9873fafd3574d449d3b71d2bc94cb422c3846","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2011-12-30 06:10:25.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f11a26b1b59f80aa8a126838f3f5b0568e52fee4","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2011-12-30 07:10:52.000000000","message":"Patch Set 1:\n\nReview Patch Set 3 .That is the correct one.","accounts_in_message":[],"_revision_number":1},{"id":"37e4317d635c981836740d4cc489a84324067693","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2011-12-30 07:11:11.000000000","message":"Patch Set 2:\n\nReview Patch Set 3 .That is the correct one","accounts_in_message":[],"_revision_number":2},{"id":"56912fdadeed6908a6c13c948d9fa43f6133d903","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-12-30 15:12:27.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t submit this\n\n(10 inline comments)\n\nDo you think you could break apart the new functions you added to make them more testable, then add some tests? And please see my inline comments.","accounts_in_message":[],"_revision_number":3},{"id":"4a8739afdc967f9b17f525f697c125b86a57c29c","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2011-12-31 11:07:40.000000000","message":"Patch Set 3:\n\nHi Brian,\n\nI need some more information regarding this. \n\nHow do I break apart the new functions and add some tests? Also where to add the tests?\n\nI am describing what the functions are meant to do. Please let me know whether you want me to do like this?\n\nTest setup:\n\n1.Controller node(running all nova services including nova-volume)\n2.Compute node(running nova-compute)\n3.VLAN networking manager is used.\n4. Storage: An X86 server running opensolaris 2010.03 development build. It can run Solaris 11 express/Nexenta core platform or any OS that supports ZFS and comstar.\n\nFollowing nova-volume flags that are added in /etc/nova/nova.conf file of the controller node:\n\n--volume_manager\u003dnova.volume.manager.VolumeManager\n--volume_driver\u003dnova.volume.san.SolarisISCSIDriver\n--san_ip\u003d\u003cIP address of the solaris storage\u003e\n--san_login\u003d\u003cuser having primary administrator role in the storage\u003e\n--san_password\u003d\u003cpassword\u003e \n--use_local_volumes\u003dFalse\n--nouse_local_volumes\n--poolname\u003dnova\n#poolname flag will make nova understand on which zfs pool the volumes will be created\nTurn on listsnapshot property on this pool. \n zpool set listsnapshot\u003don \u003cpoolname\u003e\nFunctions/Methods:\n\n1. create_snapshot: This function is responsible for creating snapshot of the zfs volume on user request.\n If you run \"euca-create-snapshot  \u003cvolume_name\u003e\" command from the client, a snapshot \u003cpool\u003e/\u003cvolume\u003e@\u003csnapshot name\u003e will be created in the storage.\nLogin to the storage node and run \nzfs list –r \u003cpoolname\u003e/\u003cvolume_name\u003e to check for that snapshot.\n2. _get_snapshot_child_dataset_count: This function checks for presence of snapshot of a volume\nIf a zfs volume contains a snapshot we can’t delete the volume simply without removing the snapshot. Again if we delete the volume recursively the snapshot is deleted. But the snapshot record still exists in nova database with an “available” state. So I think one should delete the snapshot first and then only he will be able to delete the snapshot and the database will be consistent. When nova gets a user request (euca-delete-volume \u003cvolume_name\u003e) for volume deletion, the volume manager first removes the export and then physically deletes the volume. So I made some changes in remove_export method, so that it checks first for the presence of snapshot in that volume and if not found then only it deletes the export. The method _get_snapshot_child_dataset_count checks for presence of child dataset in the volume \u003cvolume_name\u003e. \n3. delete_snapshot: This method is straightforward and deletes the snapshot as requested by user.\nRun euca-delete-snapshot \u003csnapshot_name\u003e from the client and wait for the deletion to complete. Once the snapshot is deleted login to the storage and run\nzfs list –r \u003cpoolname\u003e/\u003cvolume_name\u003e \nIn the o/p you will not see any snapshot.\n4. create_volume_from_snapshot:\nIf you run euca-create-volume –snapshot \u003csnapshot_name\u003e -z \u003czone\u003e -s \u003csize\u003e\nA new volume will be created using the snapshot \u003csnapshot_name\u003e. Login to the storage node and list the new volume using\nzfs list \u003cpoolname\u003e/\u003cvolume_name\u003e \nSee the size of the volume using \nzfs get volsize \u003cpoolname\u003e/\u003cvolume_name\u003e\nNote: In zfs we use to replicate a snapshot to create a new dataset. Here I have used below command (cmd_1 in san.py)\nzfs send \u003cpoolname\u003e/\u003csource_volume_name\u003e@\u003csnapshot_name\u003e | zfs recv \u003cpoolname\u003e/\u003cnew_volume_name\u003e\nThis command creates the new volume and a snapshot “\u003cpoolname\u003e/\u003c new_volume_name \u003e@\u003csnapshot_name\u003e” along with it. We need to delete this snapshot. Below command is used to delete the snapshot (cmd_2 in san.py)\nzfs destroy \u003cpoolname\u003e/\u003c new_volume_name \u003e@\u003csnapshot_name\u003e","accounts_in_message":[],"_revision_number":3},{"id":"654f6cf3686cba07340ae02d785a00142de0fb60","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2012-01-01 15:02:45.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t submit this\n\n(5 inline comments)\n\nHi!\n\nI have some additional inline comments, please check those.\n\nAlso, would be great to add some documentation for this to the RST docs in /doc/source. The information you posted in the code review comments would be a good start of documentation about the new functionality you added.\n\nHang in there, Nilanjan, you\u0027re doing a good job... just a few stylistic things to fix up.\n\nCheers!\n-jay","accounts_in_message":[],"_revision_number":3},{"id":"a3154e88e52bd6531561cd9497fcaea48ce35392","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-02 10:34:20.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"6f2a17bd3626f5b70adbecae82662c08de1e24e7","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-01-02 13:01:34.000000000","message":"Patch Set 4:\n\nSmokeStack Results (patch set 4):\n\tUnit Failed:Nova tests failed.  http://smokestack.openstack.org/?go\u003d/jobs/7640\n\tLibvirt Success: http://smokestack.openstack.org/?go\u003d/jobs/7638\n\tXenServer Success: http://smokestack.openstack.org/?go\u003d/jobs/7639","accounts_in_message":[],"_revision_number":4},{"id":"6b5f6e073bbdc68a124e4be9f07d2c79e64b5bd6","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-02 13:34:38.000000000","message":"Patch Set 4:\n\nI am not sure why Smoke Test is failing. There is no pep8 failures in the code.","accounts_in_message":[],"_revision_number":4},{"id":"3b36239e649927be29370517f6dea2808e329d22","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2012-01-02 14:23:06.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nAfter looking at doc/source/devref/volume.rst, I realized that it was not appropriate to ask Nilanjan to write docs for this new volume support if the existing docs were completely outdated and less than useful... so, thanks for the fixups, Nilanjan, and this lgtm.","accounts_in_message":[],"_revision_number":4},{"id":"72e08fa3e5844ef2a5575475303fc0db9fd03991","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-03 05:22:51.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nAfter closing the inline comments I think it can move in.","accounts_in_message":[],"_revision_number":4},{"id":"f77dd3c9010eb2eda8a667a6ef7ce28b163d2bdd","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-01-03 14:47:44.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\nThis is pretty much all bash commands, so don\u0027t worry about the unittesting I mentioned. Ideally we will get this to a point where it can be functionally tested. Thanks, Nilanjan!","accounts_in_message":[],"_revision_number":4},{"id":"a6c19e374f0467b4651d94c0c695ca1c83884788","author":{"_account_id":144,"name":"justinsb","email":"justin@fathomdb.com","username":"justin-fathomdb"},"date":"2012-01-03 17:07:44.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t submit this\n\n(7 inline comments)\n\nGreat contribution, but I have some questions and suggestions (mostly about style \u0026 requesting a few explanatory comments), so I\u0027m marking as -1 for now.","accounts_in_message":[],"_revision_number":4},{"id":"acf01f9816ce1ce484742d61edf444cd8a9923ad","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-05 07:15:05.000000000","message":"Patch Set 4: No score\n\n(7 inline comments)\n\nHi Justin,\n\nPlease see my responses inline.\n\nI have made changes to _build_zfs_poolname and would be amending the commit.","accounts_in_message":[],"_revision_number":4},{"id":"83f1664054ad61a8e4fed425c2a04684afb7e544","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-05 07:17:33.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"40a6080e6103402e0e3f749aad521f6207c84663","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-05 07:22:15.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"7c4527c0d898febee04f0522d5826d7d3fa40c3c","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-05 07:24:29.000000000","message":"Patch Set 5:\n\nPlease ignore this patch set. It has some problem while commiting. Please review patch set 6.","accounts_in_message":[],"_revision_number":5},{"id":"703417bd2c2e1c74adbb21cd285d1e93f782d09c","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-01-05 13:59:28.000000000","message":"Patch Set 6:\n\nSmokeStack Results (patch set 6):\n\tUnit Failed:Nova tests failed.  http://smokestack.openstack.org/?go\u003d/jobs/8055\n\tLibvirt Success: http://smokestack.openstack.org/?go\u003d/jobs/8053\n\tXenServer Success: http://smokestack.openstack.org/?go\u003d/jobs/8072","accounts_in_message":[],"_revision_number":6},{"id":"dffc4243ee5a51cce2039101f040c5f20ff9e560","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-09 08:13:22.000000000","message":"Patch Set 6:\n\nIt seems smokestack is not able to find my email address nilanjan.r@tcs.com in author\u0027s list. How to add that?\n\nJustin,\n\nHop you are doing well. Please check the latest changes in the code and give your valuable inputs.\n\nRegards\nNilanjan","accounts_in_message":[],"_revision_number":6},{"id":"c9abacb2c2f1eaf255a20cf0f5f8c9ba16334084","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2012-01-09 14:46:55.000000000","message":"Patch Set 6:\n\nNilanjan, just add your name in the Authors file :)","accounts_in_message":[],"_revision_number":6},{"id":"71b58c5dbe1eb107fdc8adadb9b567e15364c198","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-12 05:32:39.000000000","message":"Patch Set 6:\n\nHi Jay,\n\nIs it so that the code will not be reviewed and tested before I sign the contributor agreement?\n\nI am asking this because I need to consult with our company\u0027s legal team before signing the agreement which might take some time.\n\nThanks \u0026 Regards\nNilanjan","accounts_in_message":[],"_revision_number":6},{"id":"56b8751f44be76b7d5974f1ad369edb8fd2a2ab4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-01-16 21:21:16.000000000","message":"Patch Set 6: (6 inline comments)\n\nLots of nits regarding spacing in comments, but the code looks OK.  (By the way, the requested Authors change isn\u0027t for the CLA, but you will need to sign the CLA before we can accept your code; sorry…)","accounts_in_message":[],"_revision_number":6},{"id":"c26fd9ab37c0c87031e066c9e555a787972e44b7","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-01-17 06:37:21.000000000","message":"Patch Set 6: (1 inline comment)\n\nHi Kevin,\n\nI am working with our legal team for the CLA. It will take some time. Also I will change the commenting as suggested by you. \n\nThanks \u0026 Regards\nNilanjan","accounts_in_message":[],"_revision_number":6},{"id":"371c1a6ee7f514754274573d2daa24ade295cf24","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-01-17 16:40:50.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"2020c6de4ec510dc21e29f5f2bf48022187c2fb3","author":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"date":"2012-01-20 21:42:41.000000000","message":"Patch Set 6:\n\nIdeally, a new feature will also include documentation so that both devs and sys admins will know how to use this feature. You can either provide RST documentation in the nova/doc/source directory with this patch, or submit a second patch (after this patch lands) to the openstack-manuals project.","accounts_in_message":[],"_revision_number":6},{"id":"5995186299a0fb9be94bdde2474f95ab13317675","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-02-01 21:41:53.000000000","message":"Patch Set 6:\n\nAny updates here, Nilanjan?","accounts_in_message":[],"_revision_number":6},{"id":"eccee44be5102f151c0c9cb694e0ce774ec9a065","author":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"date":"2012-02-02 13:02:21.000000000","message":"Patch Set 6:\n\nHi Justin,\n\nI think your patch has landed where you have changed changes the command execution functions to take arrays of string arguments. Now I think I need to do changes in my code as well. Please guide.\n\nHi Brian,\n\nI have intimated our legal team at TCS who are reviewing the CLA. I am waiting for their go ahead. Once done I shall be able to upload the code.","accounts_in_message":[],"_revision_number":6},{"id":"8b30397af44693ba28c714f751c0465a423f767c","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-02-17 06:03:03.000000000","message":"Patch Set 6:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":6},{"id":"c4d847ae5d93de06e8e7b15666d50711832a2b01","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-02-17 06:03:05.000000000","message":"Patch Set 6: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"70cdec66f4faaeb166c319ecd65c777104269fb6","revisions":{"3af98155b85f01af80fe9497bd86f625fc806422":{"kind":"REWORK","_number":1,"created":"2011-12-30 05:36:12.000000000","uploader":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"ref":"refs/changes/87/2687/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/2687/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/2687/1"}}},"commit":{"parents":[{"commit":"d73a0046440b1c22cfb296fb0370905575739ab2","subject":"Clean up pylint errors in top-level files","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d73a0046440b1c22cfb296fb0370905575739ab2"}]}],"author":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 05:29:48.000000000","tz":330},"committer":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 05:36:02.000000000","tz":330},"subject":"Added snapshot functionalities in SolarisISCSIDriver","message":"Added snapshot functionalities in SolarisISCSIDriver\n\nChange-Id: I0ebe7c2b045caa648395928dc1a80255d9572cd0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3af98155b85f01af80fe9497bd86f625fc806422"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3af98155b85f01af80fe9497bd86f625fc806422"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d73a0046440b1c22cfb296fb0370905575739ab2","is_merged_in_target_branch":true,"change_id":"Ida7cf1ff0cbf94ad82c7a75708c79ad7bb27f7fd","change_number":2672,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"c3b7926de101e20802ed3ff621ce0d185e880213":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2011-12-30 05:38:31.000000000","uploader":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"ref":"refs/changes/87/2687/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/2687/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/2687/2"}}},"commit":{"parents":[{"commit":"d73a0046440b1c22cfb296fb0370905575739ab2","subject":"Clean up pylint errors in top-level files","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d73a0046440b1c22cfb296fb0370905575739ab2"}]}],"author":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 05:29:48.000000000","tz":330},"committer":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 05:37:37.000000000","tz":330},"subject":"Added snapshot features in SolarisISCSIDriver","message":"Added snapshot features in SolarisISCSIDriver\n\nChange-Id: I0ebe7c2b045caa648395928dc1a80255d9572cd0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c3b7926de101e20802ed3ff621ce0d185e880213"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c3b7926de101e20802ed3ff621ce0d185e880213"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d73a0046440b1c22cfb296fb0370905575739ab2","is_merged_in_target_branch":true,"change_id":"Ida7cf1ff0cbf94ad82c7a75708c79ad7bb27f7fd","change_number":2672,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"ab560e91130e347bb1cae4860d6370c15ef6aff4":{"kind":"REWORK","_number":3,"created":"2011-12-30 06:10:25.000000000","uploader":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"ref":"refs/changes/87/2687/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/2687/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/2687/3"}}},"commit":{"parents":[{"commit":"d73a0046440b1c22cfb296fb0370905575739ab2","subject":"Clean up pylint errors in top-level files","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d73a0046440b1c22cfb296fb0370905575739ab2"}]}],"author":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 05:29:48.000000000","tz":330},"committer":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 06:09:47.000000000","tz":330},"subject":"Added snapshot features in SolarisISCSIDriver","message":"Added snapshot features in SolarisISCSIDriver\n\nChange-Id: I0ebe7c2b045caa648395928dc1a80255d9572cd0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ab560e91130e347bb1cae4860d6370c15ef6aff4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ab560e91130e347bb1cae4860d6370c15ef6aff4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d73a0046440b1c22cfb296fb0370905575739ab2","is_merged_in_target_branch":true,"change_id":"Ida7cf1ff0cbf94ad82c7a75708c79ad7bb27f7fd","change_number":2672,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"3add4cdb0d783e6ce1326eb3e048eaf29a63e8d7":{"kind":"REWORK","_number":4,"created":"2012-01-02 10:34:20.000000000","uploader":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"ref":"refs/changes/87/2687/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/2687/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/2687/4"}}},"commit":{"parents":[{"commit":"ea21fe69655ae441eb9660e0579046355f6db4c1","subject":"Merge \"Adds EC2 ImportKeyPair API support.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ea21fe69655ae441eb9660e0579046355f6db4c1"}]}],"author":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 05:29:48.000000000","tz":330},"committer":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2012-01-02 10:32:03.000000000","tz":330},"subject":"Added snapshot features in SolarisISCSIDriver","message":"Added snapshot features in SolarisISCSIDriver\n\nChange-Id: I0ebe7c2b045caa648395928dc1a80255d9572cd0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3add4cdb0d783e6ce1326eb3e048eaf29a63e8d7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3add4cdb0d783e6ce1326eb3e048eaf29a63e8d7"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"ea21fe69655ae441eb9660e0579046355f6db4c1","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"14a4dbb3046b9fb0f6f055cce6f1ad2a9442e128":{"kind":"REWORK","_number":5,"created":"2012-01-05 07:17:33.000000000","uploader":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"ref":"refs/changes/87/2687/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/2687/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/2687/5"}}},"commit":{"parents":[{"commit":"8b79dae67ca2686780d3e3b5863d0578264e92a5","subject":"Fix LP912092","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8b79dae67ca2686780d3e3b5863d0578264e92a5"}]}],"author":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 05:29:48.000000000","tz":330},"committer":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2012-01-05 07:16:35.000000000","tz":330},"subject":"Added snapshot features in SolarisISCSIDriver","message":"Added snapshot features in SolarisISCSIDriver\n\nChange-Id: I0ebe7c2b045caa648395928dc1a80255d9572cd0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14a4dbb3046b9fb0f6f055cce6f1ad2a9442e128"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14a4dbb3046b9fb0f6f055cce6f1ad2a9442e128"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8b79dae67ca2686780d3e3b5863d0578264e92a5","is_merged_in_target_branch":true,"change_id":"I02f79781baebac339ec9f15c7ce7e318b5aaa50f","change_number":2825,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"70cdec66f4faaeb166c319ecd65c777104269fb6":{"kind":"REWORK","_number":6,"created":"2012-01-05 07:22:15.000000000","uploader":{"_account_id":2256,"name":"Nilanjan Roy","email":"nilanjan1.roy@gmail.com","username":"nilanjan-r"},"ref":"refs/changes/87/2687/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/2687/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/2687/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/2687/6"}}},"commit":{"parents":[{"commit":"8b79dae67ca2686780d3e3b5863d0578264e92a5","subject":"Fix LP912092","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8b79dae67ca2686780d3e3b5863d0578264e92a5"}]}],"author":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2011-12-30 05:29:48.000000000","tz":330},"committer":{"name":"Nilanjan Roy","email":"nilanjan.r@tcs.com","date":"2012-01-05 07:21:45.000000000","tz":330},"subject":"Added snapshot features in SolarisISCSIDriver","message":"Added snapshot features in SolarisISCSIDriver\n\nChange-Id: I0ebe7c2b045caa648395928dc1a80255d9572cd0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/70cdec66f4faaeb166c319ecd65c777104269fb6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/70cdec66f4faaeb166c319ecd65c777104269fb6"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8b79dae67ca2686780d3e3b5863d0578264e92a5","is_merged_in_target_branch":true,"change_id":"I02f79781baebac339ec9f15c7ce7e318b5aaa50f","change_number":2825,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}