)]}'
{"nova/conf/serial_console.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af8875823f79ae5a328ea7f9ab9b977650b7043e","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"serialproxy_port_opt \u003d cfg.IntOpt(\u0027serialproxy_port\u0027,"},{"line_number":156,"context_line":"        default\u003d6083,"},{"line_number":157,"context_line":"        min\u003d1,"},{"line_number":158,"context_line":"        max\u003d65535,"},{"line_number":159,"context_line":"        help\u003d\"\"\""},{"line_number":160,"context_line":"The port number which is used by the ``nova-serialproxy`` service to listen"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_686fb6c5","side":"PARENT","line":157,"updated":"2016-01-22 02:07:15.000000000","message":"This is actually different from the min port in the PortOpt:\n\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1220","commit_id":"f1da349a4fea7d0dc178dcb4b11d922aefd5b8de"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"434bb1da7f46b558cbd9e960087897253caa9fed","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"serialproxy_port_opt \u003d cfg.IntOpt(\u0027serialproxy_port\u0027,"},{"line_number":156,"context_line":"        default\u003d6083,"},{"line_number":157,"context_line":"        min\u003d1,"},{"line_number":158,"context_line":"        max\u003d65535,"},{"line_number":159,"context_line":"        help\u003d\"\"\""},{"line_number":160,"context_line":"The port number which is used by the ``nova-serialproxy`` service to listen"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_5bd0c053","side":"PARENT","line":157,"in_reply_to":"9a68dd71_686fb6c5","updated":"2016-01-28 02:19:02.000000000","message":"Yes, you\u0027re right, the PORT_MIN is modified to 0 in this patch: https://review.openstack.org/#/c/266712/. I\u0027not sure if we allow the user to set serialproxy_port to 0? Thank you.","commit_id":"f1da349a4fea7d0dc178dcb4b11d922aefd5b8de"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"657837fd3845d294534934c532eec5c7482c6053","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\"\"\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# This config option was never used"},{"line_number":102,"context_line":"listen_opt \u003d cfg.IPOpt(\u0027listen\u0027,"},{"line_number":103,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":104,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":105,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_5a1a1719","line":102,"updated":"2016-01-27 15:01:10.000000000","message":"let\u0027s not bother changing this one, it\u0027s deprecated and we\u0027ll remove it.","commit_id":"f755fd01ff23c5073d0d8a7b9d55ac21e67ee47f"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"434bb1da7f46b558cbd9e960087897253caa9fed","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\"\"\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# This config option was never used"},{"line_number":102,"context_line":"listen_opt \u003d cfg.IPOpt(\u0027listen\u0027,"},{"line_number":103,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":104,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":105,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_c0e27b9f","line":102,"in_reply_to":"7a5de9d1_5a1a1719","updated":"2016-01-28 02:19:02.000000000","message":"OK, I will keep it as it is. thank you.","commit_id":"f755fd01ff23c5073d0d8a7b9d55ac21e67ee47f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7039f093647ab34267f1ab639a4c0aa5669e74be","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"serialproxy_port_opt \u003d cfg.IntOpt(\u0027serialproxy_port\u0027,"},{"line_number":156,"context_line":"        default\u003d6083,"},{"line_number":157,"context_line":"        min\u003d1,"},{"line_number":158,"context_line":"        max\u003d65535,"},{"line_number":159,"context_line":"        help\u003d\"\"\""},{"line_number":160,"context_line":"The port number which is used by the ``nova-serialproxy`` service to listen"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_c2f7db8a","side":"PARENT","line":157,"updated":"2016-03-06 19:46:30.000000000","message":"This changes the min from 1 to 0, do we care?\n\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1230","commit_id":"f1da349a4fea7d0dc178dcb4b11d922aefd5b8de"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"26bc6d175c3d5a38b428df204834edc5d177cdc0","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"serialproxy_port_opt \u003d cfg.IntOpt(\u0027serialproxy_port\u0027,"},{"line_number":156,"context_line":"        default\u003d6083,"},{"line_number":157,"context_line":"        min\u003d1,"},{"line_number":158,"context_line":"        max\u003d65535,"},{"line_number":159,"context_line":"        help\u003d\"\"\""},{"line_number":160,"context_line":"The port number which is used by the ``nova-serialproxy`` service to listen"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_6309bb2c","side":"PARENT","line":157,"in_reply_to":"7af24918_c2f7db8a","updated":"2016-03-07 16:11:41.000000000","message":"If the \"nova-serialproxy\" service starts with a port\u003d0 it will get a random port number assigned from the host OS, did I get this right? It\u0027s important that this port number is equal to the port number defined in the config option \"base_url\" above. Otherwise there won\u0027t be a connection established. AFAIK we don\u0027t have functional tests for this feature. Could you successfully test the setting \"serialproxy_port\u003d0\" in a local environment?","commit_id":"f1da349a4fea7d0dc178dcb4b11d922aefd5b8de"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"26bc6d175c3d5a38b428df204834edc5d177cdc0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"\"proxyclient_address\" instead. This option is deprecated and will be removed"},{"line_number":108,"context_line":"in future releases.\"\"\")"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"proxyclient_address_opt \u003d cfg.IPOpt(\u0027proxyclient_address\u0027,"},{"line_number":111,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":112,"context_line":"        help\u003d\"\"\""},{"line_number":113,"context_line":"The IP address to which proxy clients (like ``nova-serialproxy``) should"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_8337a7e2","line":110,"updated":"2016-03-07 16:11:41.000000000","message":"This is a stronger validation than the StrOpt which makes me think that a reno file could be appropriate. I\u0027m thinking here of a case where someone configured this with real hostnames and relies on hostname to IP resolution. Same below for the other IPOpts.","commit_id":"5e502210256a0d089d9a58480be19e3bed620436"}]}