)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"473241cbec227c598bcb1e75b751a240b5ae18a4","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"        if max_net_count \u003d\u003d 0:"},{"line_number":1087,"context_line":"            raise exception.PortLimitExceeded()"},{"line_number":1088,"context_line":"        elif max_net_count \u003c max_count:"},{"line_number":1089,"context_line":"            LOG.warning(_LW(\"max count reduced from %(max_count)d to \""},{"line_number":1090,"context_line":"                            \"%(max_net_count)d due to network port quota\"),"},{"line_number":1091,"context_line":"                        {\u0027max_count\u0027: max_count,"},{"line_number":1092,"context_line":"                         \u0027max_net_count\u0027: max_net_count})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_c9a3649d","line":1089,"range":{"start_line":1089,"start_character":16,"end_line":1089,"end_character":23},"updated":"2016-01-18 15:21:16.000000000","message":"It\u0027s a user request so does the admin really need to see this as a warning? I\u0027d say this is better as info level than warning.","commit_id":"2f21268368152266ab8a310476dd458499d6a0a3"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"c0e95b52d8dba6e13dc39eb6610ca266e721eacc","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"        if max_net_count \u003d\u003d 0:"},{"line_number":1087,"context_line":"            raise exception.PortLimitExceeded()"},{"line_number":1088,"context_line":"        elif max_net_count \u003c max_count:"},{"line_number":1089,"context_line":"            LOG.warning(_LW(\"max count reduced from %(max_count)d to \""},{"line_number":1090,"context_line":"                            \"%(max_net_count)d due to network port quota\"),"},{"line_number":1091,"context_line":"                        {\u0027max_count\u0027: max_count,"},{"line_number":1092,"context_line":"                         \u0027max_net_count\u0027: max_net_count})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_32f63b90","line":1089,"range":{"start_line":1089,"start_character":16,"end_line":1089,"end_character":23},"in_reply_to":"9a68dd71_4f88fc22","updated":"2016-01-21 10:13:55.000000000","message":"Ok. np.","commit_id":"2f21268368152266ab8a310476dd458499d6a0a3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"969bbe406695595093afecedee0eaf31114e86a3","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"        if max_net_count \u003d\u003d 0:"},{"line_number":1087,"context_line":"            raise exception.PortLimitExceeded()"},{"line_number":1088,"context_line":"        elif max_net_count \u003c max_count:"},{"line_number":1089,"context_line":"            LOG.warning(_LW(\"max count reduced from %(max_count)d to \""},{"line_number":1090,"context_line":"                            \"%(max_net_count)d due to network port quota\"),"},{"line_number":1091,"context_line":"                        {\u0027max_count\u0027: max_count,"},{"line_number":1092,"context_line":"                         \u0027max_net_count\u0027: max_net_count})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_4f88fc22","line":1089,"range":{"start_line":1089,"start_character":16,"end_line":1089,"end_character":23},"in_reply_to":"da6ed579_245a672b","updated":"2016-01-21 00:03:37.000000000","message":"warning is not appropriate IMO, and verbose\u003dTrue is the default in oslo.log now, so INFO is probably fine.","commit_id":"2f21268368152266ab8a310476dd458499d6a0a3"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"320d2c5e6ce21afeccc615726a76a5ba96cad11e","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"        if max_net_count \u003d\u003d 0:"},{"line_number":1087,"context_line":"            raise exception.PortLimitExceeded()"},{"line_number":1088,"context_line":"        elif max_net_count \u003c max_count:"},{"line_number":1089,"context_line":"            LOG.warning(_LW(\"max count reduced from %(max_count)d to \""},{"line_number":1090,"context_line":"                            \"%(max_net_count)d due to network port quota\"),"},{"line_number":1091,"context_line":"                        {\u0027max_count\u0027: max_count,"},{"line_number":1092,"context_line":"                         \u0027max_net_count\u0027: max_net_count})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_245a672b","line":1089,"range":{"start_line":1089,"start_character":16,"end_line":1089,"end_character":23},"in_reply_to":"da6ed579_c9a3649d","updated":"2016-01-18 15:41:03.000000000","message":"I\u0027m hesitating between warning and info.\n\nI agree that this is a user request and we\u0027d better somehow indicate changing of max_count via API, rather than in logs, which are admin-oriented.\n\nAt the same time,  logged at info level this could easily be missed (e.g. without verbose\u003dTrue) or simply not receive enough attention. And for me this situation seems to be somewhere on the edge of normal operation: if we are short on some resource and we change the max_count number of instances passed by user, I\u0027d rather we treat this a bit more severe.\n\nI don\u0027t insist on warning, though, maybe info is just fine.","commit_id":"2f21268368152266ab8a310476dd458499d6a0a3"}]}