)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d752600d50d3d6d6e4fb8152cf29836969d6af39","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make sure that we always have a parent_addr set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since enabling PF tracking in the following commit:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"we expect all of the PciDevice objects to have a parent_addr field set"},{"line_number":12,"context_line":"since we use it for matching in case the (miss-)feature of allowing to"},{"line_number":13,"context_line":"specify a PF address to enable all VFs was used in the whitelist."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba63e191_4b89f9c9","line":10,"updated":"2016-01-18 17:15:57.000000000","message":"...seems we list of the commit details","commit_id":"39b6e3703e18b747236390ef56bdf44ba845260e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ce4e94bd89eed0dea8299c3194a488b0d48962b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make sure that we always have a parent_addr set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since enabling PF tracking in the following commit:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"we expect all of the PciDevice objects to have a parent_addr field set"},{"line_number":12,"context_line":"since we use it for matching in case the (miss-)feature of allowing to"},{"line_number":13,"context_line":"specify a PF address to enable all VFs was used in the whitelist."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba63e191_ee16bba6","line":10,"in_reply_to":"ba63e191_4b89f9c9","updated":"2016-01-18 17:29:53.000000000","message":"Yeah, it was 50355c4595e08f293f610da32247e405b20c1c5b.","commit_id":"39b6e3703e18b747236390ef56bdf44ba845260e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8a449852e3711e0457dcb86b79a83e918d55c529","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This caused a lazy-load on the object which always fails, so this patch"},{"line_number":18,"context_line":"makes sure that all data coming back from the drivers that support PCI"},{"line_number":19,"context_line":"passthrough provide a pf_address field."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-bug: #1535367"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba63e191_1ea012f4","line":19,"updated":"2016-01-18 21:13:29.000000000","message":"s/pf_address/parent_addr/","commit_id":"5691c21bab6c3a7b88d1922f6e0b4edeb7142b30"}],"nova/objects/pci_device.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f757a15e0494cca141227aa2b90563822ca57bf5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        \u0027request_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":106,"context_line":"        \u0027extra_info\u0027: fields.DictOfStringsField(),"},{"line_number":107,"context_line":"        \u0027numa_node\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":108,"context_line":"        \u0027parent_addr\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_3323a1bf","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":56},"updated":"2016-01-19 15:02:21.000000000","message":"I wonder if it wouldn\u0027t be better to default this field to None in the actual field definition, but maybe we can\u0027t do that until v2.0 of the object.\n\nHonestly I think it\u0027s kind of odd that we can have nullable fields but they don\u0027t automatically default to None in that case - we seem to have to fix a lot of whack a mole lazy load issues like this bug because nullable\u003dTrue doesn\u0027t also mean default\u003dNone in the field definition.","commit_id":"a8eab61d35f6c8e07eecf4fb74feeecb8d844d38"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f757a15e0494cca141227aa2b90563822ca57bf5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        map(lambda x: dev_dict.pop(x, None),"},{"line_number":146,"context_line":"            [key for key in no_changes])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # NOTE(ndipanov): This needs to be set as it\u0027s accessed when matching"},{"line_number":149,"context_line":"        dev_dict.setdefault(\u0027parent_addr\u0027)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        for k, v in dev_dict.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_f3a7494d","line":148,"range":{"start_line":148,"start_character":69,"end_line":148,"end_character":77},"updated":"2016-01-19 15:02:21.000000000","message":"This seems like an incomplete thought, but maybe I just don\u0027t have full context, I know it means when matching the PciDeviceSpec here:\n\nhttps://github.com/openstack/nova/blob/master/nova/pci/devspec.py#L172\n\nJust sounds a bit incomplete.\n\nAnyway, this looks like it should be OK since it\u0027s called from create() so we\u0027re at least defaulting the field.","commit_id":"a8eab61d35f6c8e07eecf4fb74feeecb8d844d38"}]}