)]}'
{"nova/pci/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"3bba7099da735b314dae44e43bd54126237f03c5","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                    dev[\u0027address\u0027] in new_addrs - exist_addrs]:"},{"line_number":166,"context_line":"            dev[\u0027compute_node_id\u0027] \u003d self.node_id"},{"line_number":167,"context_line":"            # NOTE(danms): These devices are created with no context"},{"line_number":168,"context_line":"            dev_obj \u003d objects.PciDevice.create(dev)"},{"line_number":169,"context_line":"            self.pci_devs.objects.append(dev_obj)"},{"line_number":170,"context_line":"            self.stats.add_device(dev_obj)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_8468fe88","line":168,"range":{"start_line":168,"start_character":30,"end_line":168,"end_character":46},"updated":"2016-01-19 17:13:42.000000000","message":"I don\u0027t like what this patch is doing - it takes us back to the old days of passing the context everywhere.\n\nI think we should just pass it in here (the context does not need to have a valid token for DB operations, and anyway objects we load from the DB will have the context stored for as long as the service runs).\n\nSo I say:\n - Store context on the object\n - Pass it in to every create (this is the only place)\n - Don\u0027t worry about it at call sites.","commit_id":"fb247d83a0d55b244dd1abc03ff18c9b10ad2b07"}],"nova/tests/unit/objects/test_pci_device.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2657e429408ba6f40dcaa6789405d3e75129eef2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.pci_device \u003d pci_device.PciDevice.get_by_dev_addr(ctxt, 1, \u0027a\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_create_pci_device(self):"},{"line_number":120,"context_line":"        self.pci_device \u003d pci_device.PciDevice.create(None, dev_dict)"},{"line_number":121,"context_line":"        self.assertEqual(self.pci_device.product_id, \u0027p\u0027)"},{"line_number":122,"context_line":"        self.assertEqual(self.pci_device.obj_what_changed(),"},{"line_number":123,"context_line":"                         set([\u0027compute_node_id\u0027, \u0027product_id\u0027, \u0027vendor_id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_8748d988","line":120,"range":{"start_line":120,"start_character":54,"end_line":120,"end_character":58},"updated":"2016-01-20 10:35:00.000000000","message":"OK - we should probably pass something resembling an actual context here but it\u0027s not a big deal and can be fixed up later if we need to...","commit_id":"b011421f44183d91b35a3f9012eefa3328c13865"}],"nova/tests/unit/pci/test_stats.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2657e429408ba6f40dcaa6789405d3e75129eef2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class PciDeviceStatsTestCase(test.NoDBTestCase):"},{"line_number":65,"context_line":"    def _create_fake_devs(self):"},{"line_number":66,"context_line":"        self.fake_dev_1 \u003d objects.PciDevice.create(None, fake_pci_1)"},{"line_number":67,"context_line":"        self.fake_dev_2 \u003d objects.PciDevice.create(None, fake_pci_2)"},{"line_number":68,"context_line":"        self.fake_dev_3 \u003d objects.PciDevice.create(None, fake_pci_3)"},{"line_number":69,"context_line":"        self.fake_dev_4 \u003d objects.PciDevice.create(None, fake_pci_4)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_7d13f40d","line":66,"range":{"start_line":66,"start_character":51,"end_line":66,"end_character":55},"updated":"2016-01-20 10:35:00.000000000","message":"So this is a nodb test case so I guess it\u0027s fine to pass None here - it still looks a bit off.","commit_id":"b011421f44183d91b35a3f9012eefa3328c13865"}]}