)]}'
{"nova/image/glance.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"542d3def974d533acc46f4dc092576648251e56b","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        try:"},{"line_number":294,"context_line":"            recv_service_image_meta \u003d self._client.call("},{"line_number":295,"context_line":"                context, 1, \u0027create\u0027, **sent_service_image_meta)"},{"line_number":296,"context_line":"        except Exception:"},{"line_number":297,"context_line":"            _reraise_translated_exception()"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return self._translate_from_glance(recv_service_image_meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FrY0%3D","line":296,"updated":"2013-04-29 14:41:15.000000000","message":"Exception seems a bit too broad in this case.  _reraise_translated_exception only raises three exceptions, all inherited from glanceclient.exc.HTTPException, so that would probably be best in this case.  Otherwise there\u0027s a chance of exceptions just silently disappearing.","commit_id":"f5a05b0ef9d7a365cb24cd002a708fa977ccd74c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"fc71e39c0008a0fbdb736b3437cc5666679bc6e7","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        try:"},{"line_number":294,"context_line":"            recv_service_image_meta \u003d self._client.call("},{"line_number":295,"context_line":"                context, 1, \u0027create\u0027, **sent_service_image_meta)"},{"line_number":296,"context_line":"        except Exception:"},{"line_number":297,"context_line":"            _reraise_translated_exception()"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return self._translate_from_glance(recv_service_image_meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FpUQ%3D","line":296,"in_reply_to":"AAAAOn%2F%2Fp7Y%3D","updated":"2013-04-30 18:59:48.000000000","message":"You are correct, I misread that yesterday.  I would still prefer that it catches the minimum types of exceptions it needs.  It helps prevent future code changes from inadvertently trapping things it shouldn\u0027t, which has cropped up a few times before.","commit_id":"f5a05b0ef9d7a365cb24cd002a708fa977ccd74c"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"76ff2cbcac0b9ca76b1eaeb4cb4e26586bcf44a6","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        try:"},{"line_number":294,"context_line":"            recv_service_image_meta \u003d self._client.call("},{"line_number":295,"context_line":"                context, 1, \u0027create\u0027, **sent_service_image_meta)"},{"line_number":296,"context_line":"        except Exception:"},{"line_number":297,"context_line":"            _reraise_translated_exception()"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return self._translate_from_glance(recv_service_image_meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Foso%3D","line":296,"in_reply_to":"AAAAOn%2F%2FpUQ%3D","updated":"2013-05-01 01:18:17.000000000","message":"ok, I\u0027m really not entirely convinced its better, but its a pretty minor issue so I\u0027ll update the patch to narrow the exception catching","commit_id":"f5a05b0ef9d7a365cb24cd002a708fa977ccd74c"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"fb52e76bcf0a7ced451e341b5626b12a3ff44d1e","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        try:"},{"line_number":294,"context_line":"            recv_service_image_meta \u003d self._client.call("},{"line_number":295,"context_line":"                context, 1, \u0027create\u0027, **sent_service_image_meta)"},{"line_number":296,"context_line":"        except Exception:"},{"line_number":297,"context_line":"            _reraise_translated_exception()"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return self._translate_from_glance(recv_service_image_meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fp7Q%3D","line":296,"in_reply_to":"AAAAOn%2F%2Fqww%3D","updated":"2013-04-30 13:39:08.000000000","message":"Perhaps I\u0027m misunderstanding how _reraise_translated_exception works, but even if the exception does not match one of the three exceptions to be translated, doesn\u0027t the original exception still get reraised and propogated up with the original stack trace - eg it won\u0027t get lost?","commit_id":"f5a05b0ef9d7a365cb24cd002a708fa977ccd74c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"41bf49f1de0865539e95273fe8e3c5cdbe42fa5c","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        try:"},{"line_number":294,"context_line":"            recv_service_image_meta \u003d self._client.call("},{"line_number":295,"context_line":"                context, 1, \u0027create\u0027, **sent_service_image_meta)"},{"line_number":296,"context_line":"        except Exception:"},{"line_number":297,"context_line":"            _reraise_translated_exception()"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return self._translate_from_glance(recv_service_image_meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fqww%3D","line":296,"in_reply_to":"AAAAOn%2F%2FrY0%3D","updated":"2013-04-29 20:58:58.000000000","message":"Agreed, Exception seems a bit too broad…","commit_id":"f5a05b0ef9d7a365cb24cd002a708fa977ccd74c"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"fb52e76bcf0a7ced451e341b5626b12a3ff44d1e","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        try:"},{"line_number":294,"context_line":"            recv_service_image_meta \u003d self._client.call("},{"line_number":295,"context_line":"                context, 1, \u0027create\u0027, **sent_service_image_meta)"},{"line_number":296,"context_line":"        except Exception:"},{"line_number":297,"context_line":"            _reraise_translated_exception()"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return self._translate_from_glance(recv_service_image_meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fp7Y%3D","line":296,"in_reply_to":"AAAAOn%2F%2FrY0%3D","updated":"2013-04-30 13:39:08.000000000","message":"Perhaps I\u0027m misunderstanding how _reraise_translated_exception works, but even if the exception does not match one of the three exceptions to be translated, doesn\u0027t the original exception still get reraised and propogated up with the original stack trace - eg it won\u0027t get lost?","commit_id":"f5a05b0ef9d7a365cb24cd002a708fa977ccd74c"}]}