)]}'
{"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"353a7b3bb1fa4aa994430f4ede05758829c22ca7","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                mock.ANY,"},{"line_number":1118,"context_line":"                \u0027fake_res_pool\u0027,"},{"line_number":1119,"context_line":"                mock.ANY)"},{"line_number":1120,"context_line":"        fake_attach_vol.asert_called_once_with("},{"line_number":1121,"context_line":"                connection_info,"},{"line_number":1122,"context_line":"                self.instance,"},{"line_number":1123,"context_line":"                constants.DEFAULT_ADAPTER_TYPE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_65d5e141","line":1120,"updated":"2016-01-21 01:07:04.000000000","message":"typo: asert? i wonder how the results shows passed","commit_id":"33962b4404fcdfd9829bb549956d71524afb6d49"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"1e878b24058778d3a67bbc5b9b10497292821351","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                mock.ANY,"},{"line_number":1118,"context_line":"                \u0027fake_res_pool\u0027,"},{"line_number":1119,"context_line":"                mock.ANY)"},{"line_number":1120,"context_line":"        fake_attach_vol.asert_called_once_with("},{"line_number":1121,"context_line":"                connection_info,"},{"line_number":1122,"context_line":"                self.instance,"},{"line_number":1123,"context_line":"                constants.DEFAULT_ADAPTER_TYPE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_a01d0768","line":1120,"in_reply_to":"9a68dd71_055ae583","updated":"2016-01-21 01:32:55.000000000","message":"thanks for the link! it is definitely a beast.","commit_id":"33962b4404fcdfd9829bb549956d71524afb6d49"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"bc1df5f6ff3a1b79a8b826e6af3b32f96276d079","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                mock.ANY,"},{"line_number":1118,"context_line":"                \u0027fake_res_pool\u0027,"},{"line_number":1119,"context_line":"                mock.ANY)"},{"line_number":1120,"context_line":"        fake_attach_vol.asert_called_once_with("},{"line_number":1121,"context_line":"                connection_info,"},{"line_number":1122,"context_line":"                self.instance,"},{"line_number":1123,"context_line":"                constants.DEFAULT_ADAPTER_TYPE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_055ae583","line":1120,"in_reply_to":"9a68dd71_65d5e141","updated":"2016-01-21 01:18:44.000000000","message":"Yup :)\n\nhttp://engineeringblog.yelp.com/2015/02/assert_called_once-threat-or-menace.html","commit_id":"33962b4404fcdfd9829bb549956d71524afb6d49"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"353a7b3bb1fa4aa994430f4ede05758829c22ca7","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":1143,"context_line":"        fake_vol_map.assert_not_called()"},{"line_number":1144,"context_line":"        fake_block_dev.assert_called_once_with(mock.ANY)"},{"line_number":1145,"context_line":"        fake_attach_vol.asert_called_once_with("},{"line_number":1146,"context_line":"                connection_info,"},{"line_number":1147,"context_line":"                self.instance,"},{"line_number":1148,"context_line":"                constants.DEFAULT_ADAPTER_TYPE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_c5c4cd93","line":1145,"updated":"2016-01-21 01:07:04.000000000","message":"ditto","commit_id":"33962b4404fcdfd9829bb549956d71524afb6d49"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"5b7615e79e008f9aadfe2b7c4f2bf42df83be1c6","unresolved":false,"context_lines":[{"line_number":1110,"context_line":"                        injected_files\u003d[], admin_password\u003dNone,"},{"line_number":1111,"context_line":"                        network_info\u003dself.network_info,"},{"line_number":1112,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":1113,"context_line":"        fake_vol_map.assert_not_called()"},{"line_number":1114,"context_line":"        fake_block_dev.assert_called_once_with(mock.ANY)"},{"line_number":1115,"context_line":"        fake_get_res_pool.assert_called_once_with(mock.ANY)"},{"line_number":1116,"context_line":"        fake_relocate_vmdk.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_28fe42ae","line":1113,"updated":"2016-01-25 06:06:29.000000000","message":"Could we have done with not mocking volume_in_mapping method, as it\u0027s not being called even once? Just asking for understanding. I can see you just added it as it was present in the original tests.","commit_id":"2312c6a68ae29934e5e211899e7fdeb55fd4fa15"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"df6c20b682e71d8aaea3cc9db40d63d043cddfe4","unresolved":false,"context_lines":[{"line_number":1110,"context_line":"                        injected_files\u003d[], admin_password\u003dNone,"},{"line_number":1111,"context_line":"                        network_info\u003dself.network_info,"},{"line_number":1112,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":1113,"context_line":"        fake_vol_map.assert_not_called()"},{"line_number":1114,"context_line":"        fake_block_dev.assert_called_once_with(mock.ANY)"},{"line_number":1115,"context_line":"        fake_get_res_pool.assert_called_once_with(mock.ANY)"},{"line_number":1116,"context_line":"        fake_relocate_vmdk.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_25301a01","line":1113,"in_reply_to":"9a68dd71_28fe42ae","updated":"2016-01-28 16:32:55.000000000","message":"Yes i only added it as it was in the original and I am trying for parity","commit_id":"2312c6a68ae29934e5e211899e7fdeb55fd4fa15"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"5b7615e79e008f9aadfe2b7c4f2bf42df83be1c6","unresolved":false,"context_lines":[{"line_number":1848,"context_line":"        device \u003d \u0027fake_device\u0027"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"        with test.nested("},{"line_number":1851,"context_line":"            # simulate target not found in 1st call"},{"line_number":1852,"context_line":"            # simulate target found in 2nd call"},{"line_number":1853,"context_line":"            mock.patch.object(volumeops.VMwareVolumeOps,"},{"line_number":1854,"context_line":"                              \u0027_iscsi_get_target\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_a8ad529c","line":1851,"updated":"2016-01-25 06:06:29.000000000","message":"Leftover comment. Please remove","commit_id":"2312c6a68ae29934e5e211899e7fdeb55fd4fa15"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"df6c20b682e71d8aaea3cc9db40d63d043cddfe4","unresolved":false,"context_lines":[{"line_number":1848,"context_line":"        device \u003d \u0027fake_device\u0027"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"        with test.nested("},{"line_number":1851,"context_line":"            # simulate target not found in 1st call"},{"line_number":1852,"context_line":"            # simulate target found in 2nd call"},{"line_number":1853,"context_line":"            mock.patch.object(volumeops.VMwareVolumeOps,"},{"line_number":1854,"context_line":"                              \u0027_iscsi_get_target\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_90a58e05","line":1851,"in_reply_to":"9a68dd71_a8ad529c","updated":"2016-01-28 16:32:55.000000000","message":"Done","commit_id":"2312c6a68ae29934e5e211899e7fdeb55fd4fa15"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"0961e14f12568745a0258f0653db076c28ec90b7","unresolved":false,"context_lines":[{"line_number":813,"context_line":"                                                 iid, \u0027%s.80.vmdk\u0027 % iid)"},{"line_number":814,"context_line":"            mock_extend.assert_called_once_with("},{"line_number":815,"context_line":"                    self.instance, self.instance.root_gb * units.Mi,"},{"line_number":816,"context_line":"                    str(cached_image), \"fake_dc_ref\")"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def test_spawn_disk_extend_failed_copy(self):"},{"line_number":819,"context_line":"        # Spawn instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_65953d85","side":"PARENT","line":816,"updated":"2016-02-02 11:20:20.000000000","message":"ideally stuff like this would convert to using a mock.sentinel","commit_id":"806113e4f413dba0f3dff980a00946e016dd4c7d"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"96b4c054031d3c56c0c9b5c6dbb7a59a5e523e6e","unresolved":false,"context_lines":[{"line_number":813,"context_line":"                                                 iid, \u0027%s.80.vmdk\u0027 % iid)"},{"line_number":814,"context_line":"            mock_extend.assert_called_once_with("},{"line_number":815,"context_line":"                    self.instance, self.instance.root_gb * units.Mi,"},{"line_number":816,"context_line":"                    str(cached_image), \"fake_dc_ref\")"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def test_spawn_disk_extend_failed_copy(self):"},{"line_number":819,"context_line":"        # Spawn instance"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_5481754c","side":"PARENT","line":816,"in_reply_to":"7a5de9d1_65953d85","updated":"2016-02-02 22:02:56.000000000","message":"I will follow that in subsquent patches if that is ok","commit_id":"806113e4f413dba0f3dff980a00946e016dd4c7d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"0961e14f12568745a0258f0653db076c28ec90b7","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                                  fake_get_res_pool,"},{"line_number":1098,"context_line":"                                  fake_block_dev,"},{"line_number":1099,"context_line":"                                  fake_vol_map,"},{"line_number":1100,"context_line":"                                  set_image_ref\u003dTrue):"},{"line_number":1101,"context_line":"        self._create_instance(set_image_ref\u003dset_image_ref)"},{"line_number":1102,"context_line":"        connection_info \u003d self._test_vmdk_connection_info(\u0027vmdk\u0027)"},{"line_number":1103,"context_line":"        root_disk \u003d [{\u0027connection_info\u0027: connection_info,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_a5281534","line":1100,"updated":"2016-02-02 11:20:20.000000000","message":"I know this is the way it was done before, but a huge set of mocks on a private function seems really error prone for people not knowing what it is going to really do and not really do.","commit_id":"7c41924a9ed2a8180bb7c8454955b0c4c5dd082c"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"96b4c054031d3c56c0c9b5c6dbb7a59a5e523e6e","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                                  fake_get_res_pool,"},{"line_number":1098,"context_line":"                                  fake_block_dev,"},{"line_number":1099,"context_line":"                                  fake_vol_map,"},{"line_number":1100,"context_line":"                                  set_image_ref\u003dTrue):"},{"line_number":1101,"context_line":"        self._create_instance(set_image_ref\u003dset_image_ref)"},{"line_number":1102,"context_line":"        connection_info \u003d self._test_vmdk_connection_info(\u0027vmdk\u0027)"},{"line_number":1103,"context_line":"        root_disk \u003d [{\u0027connection_info\u0027: connection_info,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_67864167","line":1100,"in_reply_to":"7a5de9d1_a5281534","updated":"2016-02-02 22:02:56.000000000","message":"For this patch i thought it was important to go for parity and only change what needs to be changed to move from mox to mock.  Im happy to improve the tests in a subsequent patch.  Particularly if you can give me a hint on how to do so.  I am pretty new at mock and did not realize this was not good.","commit_id":"7c41924a9ed2a8180bb7c8454955b0c4c5dd082c"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"f33bdb1edf0591b08d26ef7f4c6f4b28c2208808","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"        self._create_vm()"},{"line_number":1333,"context_line":"        instances \u003d [self.instance]"},{"line_number":1334,"context_line":"        self.conn.poll_rebooting_instances(60, instances)"},{"line_number":1335,"context_line":"        fake_reboot.assert_called_once_with(mock.ANY, mock.ANY, mock.ANY)"},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"    def test_reboot_not_poweredon(self):"},{"line_number":1338,"context_line":"        self._create_vm()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_08dc8744","line":1335,"updated":"2016-02-01 18:12:37.000000000","message":"nit: if input parameters are not validated, may be validating call count is sufficient.","commit_id":"7c41924a9ed2a8180bb7c8454955b0c4c5dd082c"}]}