)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"47a4fee38bb0792cc539901869d2f06842ff0b21","unresolved":false,"context_lines":[{"line_number":10,"context_line":"file into nova/conf/network.py. Improved help text will follow in a"},{"line_number":11,"context_line":"dependent patch."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Blueprint centralize-config-options"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I32eee9d2c587ad17381257bc0028e903a31c17fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa0719c6_2ff71d8c","line":13,"updated":"2016-03-23 15:47:13.000000000","message":"Please be aware that the effort in Newton is tracked with a\nnew (follow up) blueprint \n\n    centralize-config-options-newton\n\nIf questions arise, ping me. Thanks for your help here!","commit_id":"63a38f3cf234f36697cb0fd983e8d46e4ab11c92"}],"nova/conf/network.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"440f55dc39b28854bdeaa093cc399af1bf1a7a2c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                     \u0027Statement of Authority\u0027),"},{"line_number":273,"context_line":"]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"ALL_DEFAULT_OPTS \u003d itertools.chain(linux_net_opts,"},{"line_number":276,"context_line":"                                   network_opts,"},{"line_number":277,"context_line":"                                   ldap_dns_opts)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_b33bfdea","line":277,"range":{"start_line":275,"start_character":19,"end_line":277,"end_character":49},"updated":"2016-04-05 09:19:22.000000000","message":"Please be aware that this can prevent the generation of these options.\nSee bug 1565824 for that. Change https://review.openstack.org/#/c/301166/\nfixes this and should be merged before this one. As you call ALL_DEFAULT_OPTS only once in \"list_opts\", this code works but has the potential to break in the future if someone decides to call ALL_DEFAULT_OPTS in \"register_opts\" as well.","commit_id":"571602ac24770e2ed773cdc76c1a867371625754"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8f56baae88aa4686c3ae9d63a275893e557ccdcd","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                     \u0027Statement of Authority\u0027),"},{"line_number":273,"context_line":"]"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"ALL_DEFAULT_OPTS \u003d itertools.chain(linux_net_opts,"},{"line_number":276,"context_line":"                                   network_opts,"},{"line_number":277,"context_line":"                                   ldap_dns_opts)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_c204dcc1","line":277,"range":{"start_line":275,"start_character":19,"end_line":277,"end_character":49},"in_reply_to":"9a061dce_b33bfdea","updated":"2016-04-05 09:47:21.000000000","message":"On a second thought: As this gets called seldom and doesn\u0027t suffer from the slight performance impact, we should use the more explicit \"list1 + list2 + list3\" concatenation.","commit_id":"571602ac24770e2ed773cdc76c1a867371625754"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"f55f75a9a505591e39b04b050468ca794b08bb6d","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"def register_opts(conf):"},{"line_number":277,"context_line":"    conf.register_opts(linux_net_opts)"},{"line_number":278,"context_line":"    conf.register_opts(network_opts)"},{"line_number":279,"context_line":"    conf.register_opts(ldap_dns_opts)"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_781b99ca","line":277,"updated":"2016-04-06 21:16:32.000000000","message":"I think it looks good and consistent if we register ALL_DEFAULT_OPTS instead of one list at a time.","commit_id":"5f879cf1af37dc54b8ff904451df4ce3c36f004a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d23d41470dfaf5bde736fb5302fcea35c2079e9f","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"def register_opts(conf):"},{"line_number":277,"context_line":"    conf.register_opts(linux_net_opts)"},{"line_number":278,"context_line":"    conf.register_opts(network_opts)"},{"line_number":279,"context_line":"    conf.register_opts(ldap_dns_opts)"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_efa6a9ac","line":277,"in_reply_to":"9a061dce_781b99ca","updated":"2016-04-07 09:05:08.000000000","message":"Nit: +1, I much prefer the original code here.","commit_id":"5f879cf1af37dc54b8ff904451df4ce3c36f004a"}]}