)]}'
{"nova/compute/api.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"84a33a5e98825ce2ae35f7d3d68f684d5d5fec5c","unresolved":false,"context_lines":[{"line_number":2431,"context_line":"        self._check_auto_disk_config(image\u003dimage, **kwargs)"},{"line_number":2432,"context_line":""},{"line_number":2433,"context_line":"        flavor \u003d instance.get_flavor()"},{"line_number":2434,"context_line":"        root_bdm \u003d compute_utils._get_root_bdm(context, instance)"},{"line_number":2435,"context_line":"        self._checks_for_create_and_rebuild(context, image_id, image,"},{"line_number":2436,"context_line":"                flavor, metadata, files_to_inject, root_bdm)"},{"line_number":2437,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a1b2928_f12bdf31","line":2434,"range":{"start_line":2434,"start_character":33,"end_line":2434,"end_character":46},"updated":"2016-04-11 08:01:27.000000000","message":"This looks strange as function belongs to compute_utils. Could you please make it public instead?","commit_id":"ab8b9e856cfe711ef5785f819545b00af80df6fc"}],"nova/compute/utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"58a5dc71f6f58af238c5687bcbbb75b7dd8f0645","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    if root_bdm is not None:"},{"line_number":200,"context_line":"        return root_bdm.is_volume"},{"line_number":201,"context_line":"    # in case we hit a very old instance without root bdm, we _assume_"},{"line_number":202,"context_line":"    # that"},{"line_number":203,"context_line":"    # instance is backed by a volume, if and only if image_ref is not set"},{"line_number":204,"context_line":"    return not instance.image_ref"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_4ce24f05","line":202,"updated":"2016-01-20 21:37:20.000000000","message":"I think \"that\" would fit on the previous line, then you can get rid of this extra comment line. Only if another update is needed though.","commit_id":"2dfa610d587b255091cfb645c233b20a8c46a235"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f740a79115f30e172566289a725b5c0fef332a35","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def get_root_bdm(context, instance, bdms\u003dNone):"},{"line_number":191,"context_line":"    if bdms is None:"},{"line_number":192,"context_line":"        if isinstance(instance, objects.Instance):"},{"line_number":193,"context_line":"            uuid \u003d instance.uuid"},{"line_number":194,"context_line":"        else:"},{"line_number":195,"context_line":"            uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":196,"context_line":"        bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":197,"context_line":"                context, uuid)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_5a5048d4","line":195,"range":{"start_line":192,"start_character":8,"end_line":195,"end_character":35},"updated":"2016-04-20 05:59:28.000000000","message":"Should probably remove the selected code and only call get_by_instance_uuid with instance.uuid as the original code was. This change was done by me only to exclusively give me the ability to solve bug 1469179 however this bug will not get resolved this way instead we are waiting for the resource-providers blueprint.","commit_id":"8b85f7c74c022e38d8fd4839bc5c50aaa09a83fc"}]}