)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7e32f39720e844cd8bced52fa57f0c6998731ff0","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    def _add_instance_volumes(self, context, instance):"},{"line_number":497,"context_line":"        bdms \u003d self.compute_api.get_instance_bdms(context, instance)"},{"line_number":498,"context_line":"        instance[\u0027volumes_attached\u0027] \u003d [bdm[\u0027volume_id\u0027] for bdm in bdms"},{"line_number":499,"context_line":"                                        if bdm[\u0027volume_id\u0027]]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_servers(self, req, is_detail):"},{"line_number":502,"context_line":"        \"\"\"Returns a list of servers, based on any search options specified.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fpn4%3D","line":499,"updated":"2013-04-30 16:23:51.000000000","message":"So, here you add the \u0027volumes_attached\u0027 list to the instance dictionary.  For all the test examples, this list happens to be empty, but it seems to me that, in actual execution, there are cases where this list would not be empty.  Since this is new, and since I do not see a corresponding XML template change, that means that this information will never be included in the response if the requested format is XML, correct?  I want to make sure that you update the ServerTemplate to ensure that, if this data is present, it will be rendered into the XML.","commit_id":"c67bffc8fe4816c240b65cf2459da91ff16fc183"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"636e0f884b03e3f5115076aa578b41afeb1cdcaa","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    def _add_instance_volumes(self, context, instance):"},{"line_number":497,"context_line":"        bdms \u003d self.compute_api.get_instance_bdms(context, instance)"},{"line_number":498,"context_line":"        instance[\u0027volumes_attached\u0027] \u003d [bdm[\u0027volume_id\u0027] for bdm in bdms"},{"line_number":499,"context_line":"                                        if bdm[\u0027volume_id\u0027]]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_servers(self, req, is_detail):"},{"line_number":502,"context_line":"        \"\"\"Returns a list of servers, based on any search options specified.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FiuM%3D","line":499,"in_reply_to":"AAAAOn%2F%2Fpn4%3D","updated":"2013-05-06 07:33:17.000000000","message":"Agree","commit_id":"c67bffc8fe4816c240b65cf2459da91ff16fc183"}],"nova/tests/api/openstack/compute/test_servers.py":[{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"e12dae59dd1955145e8d8b38b3cfc1a9e1733cf2","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        image_bookmark \u003d \"http://localhost/fake/images/10\""},{"line_number":464,"context_line":"        flavor_bookmark \u003d \"http://localhost/fake/flavors/1\""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        self.stubs.Set(db, \u0027block_device_mapping_get_all_by_instance\u0027,"},{"line_number":467,"context_line":"                       fake_bdm_get_all_by_instance)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        uuid \u003d FAKE_UUID"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F1%2Bo%3D","line":466,"updated":"2013-04-18 13:06:04.000000000","message":"Perhaps mox would be better:\n\nself.mox.StubOutWithMock(db, \u0027block_device_mapping_get_all_by_instance\u0027)\n\ndb.block_device_mapping_get_all_by_instance(req.context, uuid).AndReturn([{\u0027volume_id\u0027: \u0027volume_id1\u0027}, {\u0027volume_id\u0027: \u0027volume_id2\u0027}])\n\nself.mox.ReplayAll()","commit_id":"c67bffc8fe4816c240b65cf2459da91ff16fc183"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"6cb9cdf2bdcd57ccb3acfad0972be13b9fdc564e","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        image_bookmark \u003d \"http://localhost/fake/images/10\""},{"line_number":464,"context_line":"        flavor_bookmark \u003d \"http://localhost/fake/flavors/1\""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        self.stubs.Set(db, \u0027block_device_mapping_get_all_by_instance\u0027,"},{"line_number":467,"context_line":"                       fake_bdm_get_all_by_instance)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        uuid \u003d FAKE_UUID"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F1I0%3D","line":466,"in_reply_to":"AAAAOn%2F%2F1%2BU%3D","updated":"2013-04-19 21:23:46.000000000","message":"Sounds good to me :)","commit_id":"c67bffc8fe4816c240b65cf2459da91ff16fc183"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"33070dced98b809ae258db19a8adf6de6ebacd5c","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        image_bookmark \u003d \"http://localhost/fake/images/10\""},{"line_number":464,"context_line":"        flavor_bookmark \u003d \"http://localhost/fake/flavors/1\""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        self.stubs.Set(db, \u0027block_device_mapping_get_all_by_instance\u0027,"},{"line_number":467,"context_line":"                       fake_bdm_get_all_by_instance)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        uuid \u003d FAKE_UUID"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F1%2BU%3D","line":466,"in_reply_to":"AAAAOn%2F%2F1%2Bo%3D","updated":"2013-04-18 13:19:16.000000000","message":"Agree, just prefer to use the approach as all over the module","commit_id":"c67bffc8fe4816c240b65cf2459da91ff16fc183"}]}