)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"680845b56c623fd29ccab82d592a821803daffbc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename Image.check_image_exists to Image.exists()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Apart from being shorter, this is also another step away from the"},{"line_number":10,"context_line":"overloading of \u0027image\u0027 in the image backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint libvirt-instance-storage"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a122d0e_53437713","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":44},"updated":"2016-05-03 20:04:56.000000000","message":"Perhaps update your commit message to include your comment from below. I didn\u0027t understand the overloading part of the commit message until I read your comment below. It\u0027s also a good nugget of knowledge to pass on.\n\n\"\"\"\nApart from being shorter, this is also another step away from the overloading of the term \u0027image\u0027 in the image backend. An \u0027image\u0027 in this code refers either to the thing which glance stores, or an instance\u0027s disk. Image in the latter context has come about because that\u0027s what libvirt calls it. However, as it\u0027s overloaded in nova we should never have used it. At some point I\u0027d like to rename these all to \u0027disk\u0027.\n\"\"\"","commit_id":"9b0e0f606f267a4f78a2d39b1355c2b26f33431e"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"a8d50544a4346595a9267636888efafbd5440a78","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename Image.check_image_exists to Image.exists()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Apart from being shorter, this is also another step away from the"},{"line_number":10,"context_line":"overloading of \u0027image\u0027 in the image backend."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint libvirt-instance-storage"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a122d0e_1b43c46d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":44},"in_reply_to":"1a122d0e_53437713","updated":"2016-05-04 09:22:38.000000000","message":"Agree that reads better. Done locally. It\u0027ll update next time I push the series.","commit_id":"9b0e0f606f267a4f78a2d39b1355c2b26f33431e"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"1692b825c6c98adc3bf4fdc0fc4a9fa64ae14c68","unresolved":false,"context_lines":[{"line_number":13,"context_line":"that\u0027s what libvirt calls it. However, as it\u0027s overloaded in nova we"},{"line_number":14,"context_line":"should never have used it. At some point I\u0027d like to rename these all"},{"line_number":15,"context_line":"to \u0027disk\u0027."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic15e8412971b2a3f8e87ec68605c4753e23f94b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"dab17558_495b3754","line":16,"updated":"2016-05-17 19:13:25.000000000","message":"Should the blueprint be mentioned here?","commit_id":"14c3149a860cd798e04bfc2959b72a749247617a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"139accc56a54a66e05e232b323a8d8b6c461f77d","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"        # reasonably assumed that no such instances exist in the wild"},{"line_number":1061,"context_line":"        # anymore, it should be set back to False (the default) so it will"},{"line_number":1062,"context_line":"        # throw errors, like it should."},{"line_number":1063,"context_line":"        if backend.exists():"},{"line_number":1064,"context_line":"            backend.remove_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME,"},{"line_number":1065,"context_line":"                                ignore_errors\u003dTrue)"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_d39cbf6b","line":1063,"range":{"start_line":1063,"start_character":11,"end_line":1063,"end_character":18},"updated":"2016-05-18 15:00:38.000000000","message":"Per IRC conversation, I think we should rename this backend variable to disk, so that it makes more sense. We\u0027re not checking that the backend exists, but rather the image/disk (on the backend) exists.","commit_id":"14c3149a860cd798e04bfc2959b72a749247617a"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"3dfa60c820ea9eb429be90253fbd68ee0a94bc28","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"        # reasonably assumed that no such instances exist in the wild"},{"line_number":1061,"context_line":"        # anymore, it should be set back to False (the default) so it will"},{"line_number":1062,"context_line":"        # throw errors, like it should."},{"line_number":1063,"context_line":"        if backend.exists():"},{"line_number":1064,"context_line":"            backend.remove_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME,"},{"line_number":1065,"context_line":"                                ignore_errors\u003dTrue)"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_ed1ba91a","line":1063,"updated":"2016-05-25 11:41:10.000000000","message":"if we\u0027ve began to rename local variables...","commit_id":"50e3f90c2099403415293ba13f7a921beb25978a"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"fd10119b3c2213e69a0d0be4ffa755a03edf5def","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"        # reasonably assumed that no such instances exist in the wild"},{"line_number":1061,"context_line":"        # anymore, it should be set back to False (the default) so it will"},{"line_number":1062,"context_line":"        # throw errors, like it should."},{"line_number":1063,"context_line":"        if backend.exists():"},{"line_number":1064,"context_line":"            backend.remove_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME,"},{"line_number":1065,"context_line":"                                ignore_errors\u003dTrue)"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_a8a2f6ab","line":1063,"in_reply_to":"bab6814e_b0aba988","updated":"2016-05-26 10:32:57.000000000","message":"Because I suck. Will fix.","commit_id":"50e3f90c2099403415293ba13f7a921beb25978a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5a0601425a00a19bba466c97768bfc8a6a67e7b0","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"        # reasonably assumed that no such instances exist in the wild"},{"line_number":1061,"context_line":"        # anymore, it should be set back to False (the default) so it will"},{"line_number":1062,"context_line":"        # throw errors, like it should."},{"line_number":1063,"context_line":"        if backend.exists():"},{"line_number":1064,"context_line":"            backend.remove_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME,"},{"line_number":1065,"context_line":"                                ignore_errors\u003dTrue)"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_b0aba988","line":1063,"in_reply_to":"bab6814e_ed1ba91a","updated":"2016-05-25 14:28:20.000000000","message":"Right, why didn\u0027t this change as well?","commit_id":"50e3f90c2099403415293ba13f7a921beb25978a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5a0601425a00a19bba466c97768bfc8a6a67e7b0","unresolved":false,"context_lines":[{"line_number":7176,"context_line":"        # anymore, the try/except/finally should be removed,"},{"line_number":7177,"context_line":"        # and ignore_errors should be set back to False (the default) so"},{"line_number":7178,"context_line":"        # that problems throw errors, like they should."},{"line_number":7179,"context_line":"        if root_disk.exists():"},{"line_number":7180,"context_line":"            try:"},{"line_number":7181,"context_line":"                root_disk.rollback_to_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME)"},{"line_number":7182,"context_line":"            except exception.SnapshotNotFound:"}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_d090ed50","line":7179,"updated":"2016-05-25 14:28:20.000000000","message":"...so much better...","commit_id":"50e3f90c2099403415293ba13f7a921beb25978a"}]}