)]}'
{"nova/tests/unit/virt/vmwareapi/test_vif.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"95fa8ac9ef76086afd084bce8ae862dd801e44e8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                       return_value\u003dTrue)"},{"line_number":67,"context_line":"    @mock.patch.object(network_util, \u0027create_port_group\u0027)"},{"line_number":68,"context_line":"    def test_ensure_vlan_bridge(self,"},{"line_number":69,"context_line":"                                fake_create_port_group,"},{"line_number":70,"context_line":"                                fake_check_if_vlan_interface_exists,"},{"line_number":71,"context_line":"                                fake_get_vswitch_for_vlan_interface,"},{"line_number":72,"context_line":"                                fake_get_network_with_the_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_b4984e1d","line":69,"updated":"2016-01-25 05:52:33.000000000","message":"mock_create_port_group would be a better choice for param name, as it\u0027s really a mock not a fake.","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"efabdded1ae05efc4db88cc05a74cdcdcd08742d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                       return_value\u003dTrue)"},{"line_number":67,"context_line":"    @mock.patch.object(network_util, \u0027create_port_group\u0027)"},{"line_number":68,"context_line":"    def test_ensure_vlan_bridge(self,"},{"line_number":69,"context_line":"                                fake_create_port_group,"},{"line_number":70,"context_line":"                                fake_check_if_vlan_interface_exists,"},{"line_number":71,"context_line":"                                fake_get_vswitch_for_vlan_interface,"},{"line_number":72,"context_line":"                                fake_get_network_with_the_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_87293d9d","line":69,"in_reply_to":"9a68dd71_b4984e1d","updated":"2016-01-25 18:11:06.000000000","message":"Done","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"95fa8ac9ef76086afd084bce8ae862dd801e44e8","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dTrue)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        fake_get_network_with_the_name.assert_called_with("},{"line_number":77,"context_line":"                self.session,"},{"line_number":78,"context_line":"                \u0027fa0\u0027,"},{"line_number":79,"context_line":"                self.cluster)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_94850ad0","line":76,"updated":"2016-01-25 05:52:33.000000000","message":"Indentation can be corrected. \u0027self.session\u0027 can be moved one tab left, and also all the arguments can be written in one line, like so:\n\n self.session, \u0027fa0\u0027, self.cluster)\n\nWould be great if you can make it consistent with instances of same thing elsewhere in Nova, if I am not wrong about python coding practices :)","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"95fa8ac9ef76086afd084bce8ae862dd801e44e8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                       return_value\u003dTrue)"},{"line_number":100,"context_line":"    @mock.patch.object(network_util, \u0027create_port_group\u0027)"},{"line_number":101,"context_line":"    def test_ensure_vlan_bridge_without_vlan("},{"line_number":102,"context_line":"            self,"},{"line_number":103,"context_line":"            fake_create_port_group,"},{"line_number":104,"context_line":"            fake_check_if_vlan_interface_exists,"},{"line_number":105,"context_line":"            fake_get_vswitch_for_vlan_interface,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_74d096c9","line":102,"updated":"2016-01-25 05:52:33.000000000","message":"What I have seen so far in Nova is you write all arguments one below the other only when the first argument is on the same line as function/method name.","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"cfbdddcac0906d16fd3ee3fc5b4e3bd6da6c79f3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                       return_value\u003dTrue)"},{"line_number":100,"context_line":"    @mock.patch.object(network_util, \u0027create_port_group\u0027)"},{"line_number":101,"context_line":"    def test_ensure_vlan_bridge_without_vlan("},{"line_number":102,"context_line":"            self,"},{"line_number":103,"context_line":"            fake_create_port_group,"},{"line_number":104,"context_line":"            fake_check_if_vlan_interface_exists,"},{"line_number":105,"context_line":"            fake_get_vswitch_for_vlan_interface,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_c16f65fa","line":102,"in_reply_to":"9a68dd71_74d096c9","updated":"2016-01-30 10:58:33.000000000","message":"Doesn\u0027t look like this is done :)","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"efabdded1ae05efc4db88cc05a74cdcdcd08742d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                       return_value\u003dTrue)"},{"line_number":100,"context_line":"    @mock.patch.object(network_util, \u0027create_port_group\u0027)"},{"line_number":101,"context_line":"    def test_ensure_vlan_bridge_without_vlan("},{"line_number":102,"context_line":"            self,"},{"line_number":103,"context_line":"            fake_create_port_group,"},{"line_number":104,"context_line":"            fake_check_if_vlan_interface_exists,"},{"line_number":105,"context_line":"            fake_get_vswitch_for_vlan_interface,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_9aeaf0d9","line":102,"in_reply_to":"9a68dd71_74d096c9","updated":"2016-01-25 18:11:06.000000000","message":"Done","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"bea5d34fb5ee207676d2ef5d1bdf0f7b98a70217","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                       return_value\u003dTrue)"},{"line_number":100,"context_line":"    @mock.patch.object(network_util, \u0027create_port_group\u0027)"},{"line_number":101,"context_line":"    def test_ensure_vlan_bridge_without_vlan("},{"line_number":102,"context_line":"            self,"},{"line_number":103,"context_line":"            fake_create_port_group,"},{"line_number":104,"context_line":"            fake_check_if_vlan_interface_exists,"},{"line_number":105,"context_line":"            fake_get_vswitch_for_vlan_interface,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_0ab5147d","line":102,"in_reply_to":"9a68dd71_74d096c9","updated":"2016-02-02 22:37:58.000000000","message":"the names are so long that i had to wrap the 1st arg and then they have to be below it.","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"95fa8ac9ef76086afd084bce8ae862dd801e44e8","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dFalse)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        fake_get_network_with_the_name.assert_called_with("},{"line_number":111,"context_line":"                self.session,"},{"line_number":112,"context_line":"                \u0027fa0\u0027,"},{"line_number":113,"context_line":"                self.cluster)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_545d5245","line":110,"updated":"2016-01-25 05:52:33.000000000","message":"is this method called more than once? If no, then this can also be changed to assert_called_once_with","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"efabdded1ae05efc4db88cc05a74cdcdcd08742d","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dFalse)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        fake_get_network_with_the_name.assert_called_with("},{"line_number":111,"context_line":"                self.session,"},{"line_number":112,"context_line":"                \u0027fa0\u0027,"},{"line_number":113,"context_line":"                self.cluster)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_5af0f8c8","line":110,"in_reply_to":"9a68dd71_545d5245","updated":"2016-01-25 18:11:06.000000000","message":"no it is called twice.  see the next line","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"cfbdddcac0906d16fd3ee3fc5b4e3bd6da6c79f3","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dFalse)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        fake_get_network_with_the_name.assert_called_with("},{"line_number":111,"context_line":"                self.session,"},{"line_number":112,"context_line":"                \u0027fa0\u0027,"},{"line_number":113,"context_line":"                self.cluster)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_6179d1c7","line":110,"in_reply_to":"9a68dd71_5af0f8c8","updated":"2016-01-30 10:58:33.000000000","message":"OK, sorry :)","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"dc1f06d5557bfeeb5537dcfb6abc27d3ae6d360a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                self.session,"},{"line_number":121,"context_line":"                \u0027vmnet0\u0027,"},{"line_number":122,"context_line":"                self.cluster)"},{"line_number":123,"context_line":"        fake_create_port_group(self.session, \u0027fa0\u0027, \u0027vmnet0\u0027, 3,"},{"line_number":124,"context_line":"            self.cluster)"},{"line_number":125,"context_line":"        fake_get_network_with_the_name(self.session, \u0027fa0\u0027, None)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_b7d74f22","line":123,"updated":"2016-01-22 00:31:09.000000000","message":"meant to call assert_called_once_with here?","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"95fa8ac9ef76086afd084bce8ae862dd801e44e8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                self.session,"},{"line_number":121,"context_line":"                \u0027vmnet0\u0027,"},{"line_number":122,"context_line":"                self.cluster)"},{"line_number":123,"context_line":"        fake_create_port_group(self.session, \u0027fa0\u0027, \u0027vmnet0\u0027, 3,"},{"line_number":124,"context_line":"            self.cluster)"},{"line_number":125,"context_line":"        fake_get_network_with_the_name(self.session, \u0027fa0\u0027, None)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_08b9fe2d","line":123,"in_reply_to":"9a68dd71_b7d74f22","updated":"2016-01-25 05:52:33.000000000","message":"Agree with giridhar.","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"dc1f06d5557bfeeb5537dcfb6abc27d3ae6d360a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                self.cluster)"},{"line_number":123,"context_line":"        fake_create_port_group(self.session, \u0027fa0\u0027, \u0027vmnet0\u0027, 3,"},{"line_number":124,"context_line":"            self.cluster)"},{"line_number":125,"context_line":"        fake_get_network_with_the_name(self.session, \u0027fa0\u0027, None)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # FlatDHCP network mode without vlan - network exists with the host"},{"line_number":128,"context_line":"    # Get vswitch and check vlan interface should not be called"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_57de1340","line":125,"updated":"2016-01-22 00:31:09.000000000","message":"same as above","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"95fa8ac9ef76086afd084bce8ae862dd801e44e8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    # FlatDHCP network mode without vlan - network exists with the host"},{"line_number":128,"context_line":"    # Get vswitch and check vlan interface should not be called"},{"line_number":129,"context_line":"    @mock.patch.object(network_util, \u0027get_network_with_the_name\u0027,"},{"line_number":130,"context_line":"                       return_value\u003dNone)"},{"line_number":131,"context_line":"    @mock.patch.object(network_util, \u0027get_vswitch_for_vlan_interface\u0027,"},{"line_number":132,"context_line":"                       return_value\u003d\u0027vmnet0\u0027)"},{"line_number":133,"context_line":"    @mock.patch.object(network_util, \u0027check_if_vlan_interface_exists\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_14a59a45","line":130,"updated":"2016-01-25 05:52:33.000000000","message":"return_value\u003dNone is superfluous. If the StubOutWithMock instance has AndReturn(None) called on it, I would probably be ok with having a \u0027return_value\u003dNone\u0027 specified, but here it\u0027s not required","commit_id":"2b6168c79da1686bcf1309626a197b0df35892a4"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cbd2af2c449ff00a2f60cbfac9b7d991b5c9bb34","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.session, \u0027vmnet0\u0027, self.cluster)"},{"line_number":81,"context_line":"        mock_check_if_vlan_interface_exists.assert_called_once_with("},{"line_number":82,"context_line":"            self.session, \u0027vmnet0\u0027, self.cluster)"},{"line_number":83,"context_line":"        mock_create_port_group(self.session, \u0027fa0\u0027, \u0027vmnet0\u0027, 3,"},{"line_number":84,"context_line":"            self.cluster)"},{"line_number":85,"context_line":"        mock_get_network_with_the_name(self.session, \u0027fa0\u0027, None)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_ed50010d","line":83,"updated":"2016-01-26 07:19:45.000000000","message":"Add \u0027assert_called_once_with\u0027.","commit_id":"5b18d9ee38cf9af4daf99bb0423394d268c2b763"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"e837e71b99a2022626f54138c6d2ea2c3db60253","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.session, \u0027vmnet0\u0027, self.cluster)"},{"line_number":81,"context_line":"        mock_check_if_vlan_interface_exists.assert_called_once_with("},{"line_number":82,"context_line":"            self.session, \u0027vmnet0\u0027, self.cluster)"},{"line_number":83,"context_line":"        mock_create_port_group(self.session, \u0027fa0\u0027, \u0027vmnet0\u0027, 3,"},{"line_number":84,"context_line":"            self.cluster)"},{"line_number":85,"context_line":"        mock_get_network_with_the_name(self.session, \u0027fa0\u0027, None)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_dd4a67ac","line":83,"in_reply_to":"9a68dd71_ed50010d","updated":"2016-01-26 18:01:18.000000000","message":"Done","commit_id":"5b18d9ee38cf9af4daf99bb0423394d268c2b763"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cbd2af2c449ff00a2f60cbfac9b7d991b5c9bb34","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self.session, \u0027vmnet0\u0027, self.cluster)"},{"line_number":83,"context_line":"        mock_create_port_group(self.session, \u0027fa0\u0027, \u0027vmnet0\u0027, 3,"},{"line_number":84,"context_line":"            self.cluster)"},{"line_number":85,"context_line":"        mock_get_network_with_the_name(self.session, \u0027fa0\u0027, None)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # FlatDHCP network mode without vlan - network doesn\u0027t exist with the host"},{"line_number":88,"context_line":"    @mock.patch.object(network_util, \u0027get_network_with_the_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_8d55c5fb","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":65},"updated":"2016-01-26 07:19:45.000000000","message":"Is this line necessary?\nAssertion about mock_get_network_with_the_name is in line 76.","commit_id":"5b18d9ee38cf9af4daf99bb0423394d268c2b763"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"e837e71b99a2022626f54138c6d2ea2c3db60253","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self.session, \u0027vmnet0\u0027, self.cluster)"},{"line_number":83,"context_line":"        mock_create_port_group(self.session, \u0027fa0\u0027, \u0027vmnet0\u0027, 3,"},{"line_number":84,"context_line":"            self.cluster)"},{"line_number":85,"context_line":"        mock_get_network_with_the_name(self.session, \u0027fa0\u0027, None)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # FlatDHCP network mode without vlan - network doesn\u0027t exist with the host"},{"line_number":88,"context_line":"    @mock.patch.object(network_util, \u0027get_network_with_the_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_3dd063c9","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":65},"in_reply_to":"9a68dd71_8d55c5fb","updated":"2016-01-26 18:01:18.000000000","message":"Done","commit_id":"5b18d9ee38cf9af4daf99bb0423394d268c2b763"}]}