)]}'
{"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":11428,"name":"Ajaya Agrawal","email":"ajku.agr@gmail.com","username":"ajayaa"},"change_message_id":"f019eda11527d44c16217b1ecbc0fc69d3b4fd78","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        fake_rules \u003d [\u0027a\u0027, \u0027b\u0027, \u0027c\u0027]"},{"line_number":88,"context_line":"        mock_get.return_value \u003d fake_rules"},{"line_number":89,"context_line":"        result \u003d self.conductor.provider_fw_rule_get_all(self.context)"},{"line_number":90,"context_line":"        self.assertEqual(result, fake_rules)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class ConductorTestCase(_BaseTestCase, test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_b94db93f","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":8},"updated":"2016-01-23 18:50:34.000000000","message":"Shall we use assert_called_once_with here?","commit_id":"07323e12d735e9c38aacaddb1c85dd637a5fdd14"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"30e8396318a02092f92d3bf4c8d0315c97dba8e7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        fake_rules \u003d [\u0027a\u0027, \u0027b\u0027, \u0027c\u0027]"},{"line_number":88,"context_line":"        mock_get.return_value \u003d fake_rules"},{"line_number":89,"context_line":"        result \u003d self.conductor.provider_fw_rule_get_all(self.context)"},{"line_number":90,"context_line":"        self.assertEqual(result, fake_rules)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class ConductorTestCase(_BaseTestCase, test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_80ba43bf","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":8},"in_reply_to":"9a68dd71_b94db93f","updated":"2016-01-26 20:20:18.000000000","message":"yes, we can ,though seems not very necessary to me..","commit_id":"07323e12d735e9c38aacaddb1c85dd637a5fdd14"},{"author":{"_account_id":11428,"name":"Ajaya Agrawal","email":"ajku.agr@gmail.com","username":"ajayaa"},"change_message_id":"f019eda11527d44c16217b1ecbc0fc69d3b4fd78","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        timeouts \u003d []"},{"line_number":219,"context_line":"        calls \u003d dict(count\u003d0)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        def fake_ping(obj, context, message, timeout):"},{"line_number":222,"context_line":"            timeouts.append(timeout)"},{"line_number":223,"context_line":"            calls[\u0027count\u0027] +\u003d 1"},{"line_number":224,"context_line":"            if calls[\u0027count\u0027] \u003c 15:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_195ba5f7","line":221,"range":{"start_line":221,"start_character":22,"end_line":221,"end_character":25},"updated":"2016-01-23 18:50:34.000000000","message":"obj is not being used in this function anywhere.","commit_id":"07323e12d735e9c38aacaddb1c85dd637a5fdd14"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"30e8396318a02092f92d3bf4c8d0315c97dba8e7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        timeouts \u003d []"},{"line_number":219,"context_line":"        calls \u003d dict(count\u003d0)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        def fake_ping(obj, context, message, timeout):"},{"line_number":222,"context_line":"            timeouts.append(timeout)"},{"line_number":223,"context_line":"            calls[\u0027count\u0027] +\u003d 1"},{"line_number":224,"context_line":"            if calls[\u0027count\u0027] \u003c 15:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_8016c3a5","line":221,"range":{"start_line":221,"start_character":22,"end_line":221,"end_character":25},"in_reply_to":"9a68dd71_195ba5f7","updated":"2016-01-26 20:20:18.000000000","message":"yes, but you need this to be consistent to the mocked function","commit_id":"07323e12d735e9c38aacaddb1c85dd637a5fdd14"},{"author":{"_account_id":11428,"name":"Ajaya Agrawal","email":"ajku.agr@gmail.com","username":"ajayaa"},"change_message_id":"f019eda11527d44c16217b1ecbc0fc69d3b4fd78","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            self.context, objects.Instance(), inst, [])"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        migration \u003d mock.MagicMock()"},{"line_number":333,"context_line":"        mock_mig.return_value \u003d migration"},{"line_number":334,"context_line":"        if isinstance(self.conductor, (conductor_api.ComputeTaskAPI,"},{"line_number":335,"context_line":"                                       conductor_api.LocalComputeTaskAPI)):"},{"line_number":336,"context_line":"            # The API method is actually \u0027live_migrate_instance\u0027.  It gets"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_d9e66d14","line":333,"range":{"start_line":333,"start_character":8,"end_line":333,"end_character":16},"updated":"2016-01-23 18:50:34.000000000","message":"Since line number 335 in the original code does not return anything, is this needed?","commit_id":"07323e12d735e9c38aacaddb1c85dd637a5fdd14"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"30e8396318a02092f92d3bf4c8d0315c97dba8e7","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            self.context, objects.Instance(), inst, [])"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        migration \u003d mock.MagicMock()"},{"line_number":333,"context_line":"        mock_mig.return_value \u003d migration"},{"line_number":334,"context_line":"        if isinstance(self.conductor, (conductor_api.ComputeTaskAPI,"},{"line_number":335,"context_line":"                                       conductor_api.LocalComputeTaskAPI)):"},{"line_number":336,"context_line":"            # The API method is actually \u0027live_migrate_instance\u0027.  It gets"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_80648349","line":333,"range":{"start_line":333,"start_character":8,"end_line":333,"end_character":16},"in_reply_to":"9a68dd71_d9e66d14","updated":"2016-01-26 20:20:18.000000000","message":"yes, otherwise you can\u0027t check line #345-#347 in new code","commit_id":"07323e12d735e9c38aacaddb1c85dd637a5fdd14"}]}