)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2730e389f425190348dc44e52555660a67572a16","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"stop setting mtu when pluging vhostuser port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- this change removes a call to set mtu on"},{"line_number":10,"context_line":"  vhost-user interface."},{"line_number":11,"context_line":"- this change make creating vhost-user interface"},{"line_number":12,"context_line":"  an atomic action."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3afc51ec_f2c73743","line":10,"range":{"start_line":9,"start_character":2,"end_line":10,"end_character":23},"updated":"2016-03-13 17:16:16.000000000","message":"Can you expand on why this is a problem in the commit message?","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"339993e96644fab2f670a9f096430626dec7f795","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"stop setting mtu when pluging vhostuser port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- this change removes a call to set mtu on"},{"line_number":10,"context_line":"  vhost-user interface."},{"line_number":11,"context_line":"- this change make creating vhost-user interface"},{"line_number":12,"context_line":"  an atomic action."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1af94dfe_a0ce1981","line":10,"range":{"start_line":9,"start_character":2,"end_line":10,"end_character":23},"in_reply_to":"3afc51ec_f2c73743","updated":"2016-03-16 00:43:58.000000000","message":"sure ill expand in the next version.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5f5846ce079bc59fc3430cf4ee222cd9ec6839d1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- this change removes a call to set mtu on"},{"line_number":10,"context_line":"  vhost-user interface."},{"line_number":11,"context_line":"- this change make creating vhost-user interface"},{"line_number":12,"context_line":"  an atomic action."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2e17723d5052d57cd1557bd8a173c06ea0dcb2d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1af94dfe_afca8a4d","line":11,"updated":"2016-03-15 18:09:35.000000000","message":"I think it would be useful to make this a separate change since it\u0027s straight-forward and doesn\u0027t change behavior, and I\u0027d be OK with backporting that. I\u0027m not really OK with the mtu change being backported.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"339993e96644fab2f670a9f096430626dec7f795","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- this change removes a call to set mtu on"},{"line_number":10,"context_line":"  vhost-user interface."},{"line_number":11,"context_line":"- this change make creating vhost-user interface"},{"line_number":12,"context_line":"  an atomic action."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2e17723d5052d57cd1557bd8a173c06ea0dcb2d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1af94dfe_20ba09e2","line":11,"in_reply_to":"1af94dfe_afca8a4d","updated":"2016-03-16 00:43:58.000000000","message":"well the mtu behavior was always broken if the mtu was ever set to anything but 0 in the nova config which was the old default. i can seperate these though if desired.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":13,"context_line":"vhost-user interfaces exist only in userspace from the host perspective"},{"line_number":14,"context_line":"and are not represented in the linux networking stack as kernel netdevs."},{"line_number":15,"context_line":"As a result attempting to set the mtu on a vhost-user interface"},{"line_number":16,"context_line":"using ifconfig or ip like will fail with a device not found error."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- this change removes a call to _set_device_mtu when plugging"},{"line_number":19,"context_line":"  vhost-user interfaces."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1af94dfe_979cc0c1","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":25},"updated":"2016-03-16 19:01:01.000000000","message":"link","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b40458b47ab8d12e0bb5c734f278251e2078462","unresolved":false,"context_lines":[{"line_number":13,"context_line":"vhost-user interfaces exist only in userspace from the host perspective"},{"line_number":14,"context_line":"and are not represented in the linux networking stack as kernel netdevs."},{"line_number":15,"context_line":"As a result attempting to set the mtu on a vhost-user interface"},{"line_number":16,"context_line":"using ifconfig or ip like will fail with a device not found error."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- this change removes a call to _set_device_mtu when plugging"},{"line_number":19,"context_line":"  vhost-user interfaces."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1af94dfe_69de6b12","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":25},"in_reply_to":"1af94dfe_979cc0c1","updated":"2016-03-17 04:50:17.000000000","message":"Done","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f2eb88ccbd4a5c297e50c496e72824079a018236","unresolved":false,"context_lines":[{"line_number":7,"context_line":"stop setting mtu when plugging vhost-user ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vhost-user is a userspace protocol to establish connectivity"},{"line_number":10,"context_line":"between a virto-net frontend typically qemu and a"},{"line_number":11,"context_line":"userspace virtio backend such as ovs with dpdk."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"vhost-user interfaces exist only in userspace from the host perspective"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1af94dfe_775a59f3","line":10,"updated":"2016-03-18 19:33:19.000000000","message":"s/virto/virtio/ :)","commit_id":"adf7ba61dd73fe4bfffa20295be9a4b1006a1fe6"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f2eb88ccbd4a5c297e50c496e72824079a018236","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  which stopped vms booting with vhost-user interfaces"},{"line_number":22,"context_line":"  due to an uncaught exception resulting in a failure to set the"},{"line_number":23,"context_line":"  interface type in ovs."},{"line_number":24,"context_line":"- this change make creating vhost-user interface"},{"line_number":25,"context_line":"  an atomic action."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This latent bug is only triggered when the mtu value is set to a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1af94dfe_d7752d64","line":24,"updated":"2016-03-18 19:33:19.000000000","message":"s/make creating/makes creating/","commit_id":"adf7ba61dd73fe4bfffa20295be9a4b1006a1fe6"}],"nova/network/linux_net.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2730e389f425190348dc44e52555660a67572a16","unresolved":false,"context_lines":[{"line_number":1382,"context_line":"        delete_net_dev(dev)"},{"line_number":1383,"context_line":""},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"def ovs_set_vhostuser_port_type(dev):"},{"line_number":1386,"context_line":"    _ovs_vsctl([\u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev, \u0027type\u003ddpdkvhostuser\u0027])"},{"line_number":1387,"context_line":""},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":"def create_ivs_vif_port(dev, iface_id, mac, instance_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_f2ce1759","side":"PARENT","line":1386,"range":{"start_line":1385,"start_character":0,"end_line":1386,"end_character":69},"updated":"2016-03-13 17:16:16.000000000","message":"So the atomic part is removing this since it\u0027s now used as part of the add-port command via the type arg.","commit_id":"5bef6fbc088f809ce9f942b139143a19ee599f52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"408d4da8b899f921c329c418e87d17430e75dae0","unresolved":false,"context_lines":[{"line_number":1382,"context_line":"        delete_net_dev(dev)"},{"line_number":1383,"context_line":""},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"def ovs_set_vhostuser_port_type(dev):"},{"line_number":1386,"context_line":"    _ovs_vsctl([\u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev, \u0027type\u003ddpdkvhostuser\u0027])"},{"line_number":1387,"context_line":""},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":"def create_ivs_vif_port(dev, iface_id, mac, instance_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_205e89e9","side":"PARENT","line":1386,"range":{"start_line":1385,"start_character":0,"end_line":1386,"end_character":69},"in_reply_to":"3afc51ec_f2ce1759","updated":"2016-03-15 18:58:24.000000000","message":"yes.","commit_id":"5bef6fbc088f809ce9f942b139143a19ee599f52"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a15d10cc5ac698bf216d57020981cb6ce3ee710","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"        raise exception.AgentError(method\u003dfull_args)"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"def _create_ovs_vif_cmd(bridge, dev, iface_id, mac, instance_id, type):"},{"line_number":1370,"context_line":"    cmd \u003d [\u0027--\u0027, \u0027--if-exists\u0027, \u0027del-port\u0027, dev, \u0027--\u0027,"},{"line_number":1371,"context_line":"            \u0027add-port\u0027, bridge, dev,"},{"line_number":1372,"context_line":"            \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_e0bf4ff9","line":1369,"range":{"start_line":1369,"start_character":65,"end_line":1369,"end_character":69},"updated":"2016-03-14 11:06:35.000000000","message":"Please don\u0027t hide the built in function type. See: http://docs.openstack.org/developer/hacking/#general\n\nMaybe go for \"port_type\" or \"interface_type\"?","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"339993e96644fab2f670a9f096430626dec7f795","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"        raise exception.AgentError(method\u003dfull_args)"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"def _create_ovs_vif_cmd(bridge, dev, iface_id, mac, instance_id, type):"},{"line_number":1370,"context_line":"    cmd \u003d [\u0027--\u0027, \u0027--if-exists\u0027, \u0027del-port\u0027, dev, \u0027--\u0027,"},{"line_number":1371,"context_line":"            \u0027add-port\u0027, bridge, dev,"},{"line_number":1372,"context_line":"            \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_0030ad55","line":1369,"range":{"start_line":1369,"start_character":65,"end_line":1369,"end_character":69},"in_reply_to":"3afc51ec_e0bf4ff9","updated":"2016-03-16 00:43:58.000000000","message":"oh good catch yes ill change to interface_type since this is used to set the type field in the interface table.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a15d10cc5ac698bf216d57020981cb6ce3ee710","unresolved":false,"context_lines":[{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"def create_ovs_vif_port(bridge, dev, iface_id, mac, instance_id,"},{"line_number":1383,"context_line":"                        mtu\u003dNone, type\u003dNone):"},{"line_number":1384,"context_line":"    _ovs_vsctl(_create_ovs_vif_cmd(bridge, dev, iface_id,"},{"line_number":1385,"context_line":"                                   mac, instance_id, type))"},{"line_number":1386,"context_line":"    if type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_60421f12","line":1383,"range":{"start_line":1383,"start_character":34,"end_line":1383,"end_character":38},"updated":"2016-03-14 11:06:35.000000000","message":"as above.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a15d10cc5ac698bf216d57020981cb6ce3ee710","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"                        mtu\u003dNone, type\u003dNone):"},{"line_number":1384,"context_line":"    _ovs_vsctl(_create_ovs_vif_cmd(bridge, dev, iface_id,"},{"line_number":1385,"context_line":"                                   mac, instance_id, type))"},{"line_number":1386,"context_line":"    if type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":1387,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_c0c0532d","line":1386,"updated":"2016-03-14 11:06:35.000000000","message":"Why not just pass in some sentinel that means \"No MTU\", rather than this nasty hard code here?\n\n  NO_MTU_SENTINAL \u003d object()\n  ...\n  if mtu !\u003d NO_MTU_SENTINAL:\n    _set_device_mtu(dev, mtu)\n\nor something a bit like that?","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"408d4da8b899f921c329c418e87d17430e75dae0","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"                        mtu\u003dNone, type\u003dNone):"},{"line_number":1384,"context_line":"    _ovs_vsctl(_create_ovs_vif_cmd(bridge, dev, iface_id,"},{"line_number":1385,"context_line":"                                   mac, instance_id, type))"},{"line_number":1386,"context_line":"    if type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":1387,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_aeb9fa30","line":1386,"in_reply_to":"3afc51ec_c0c0532d","updated":"2016-03-15 18:58:24.000000000","message":"sure i can make that change it however will never make sense to call _set_device_mtu on a vhost-user port as they are not present in the kenel so ip commands will always fail.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b369fa7e8c4b2f85194a4609cff0e83c1b93565a","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"    _ovs_vsctl(_create_ovs_vif_cmd(bridge, dev, iface_id,"},{"line_number":1385,"context_line":"                                   mac, instance_id, type))"},{"line_number":1386,"context_line":"    if type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":1387,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"def delete_ovs_vif_port(bridge, dev, delete_dev\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_cfba3fe1","line":1387,"updated":"2016-03-14 12:20:19.000000000","message":"so does this mean that for vhost ports setting the MTU will never make sense? In the bug report you mentioned \u0027with certain version of iproute2 spawning of vm with vhost-user ports will fail\u0027.\n\nDoes this mean that you intend to remove this conditional execution in the future?","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"408d4da8b899f921c329c418e87d17430e75dae0","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"    _ovs_vsctl(_create_ovs_vif_cmd(bridge, dev, iface_id,"},{"line_number":1385,"context_line":"                                   mac, instance_id, type))"},{"line_number":1386,"context_line":"    if type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":1387,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"def delete_ovs_vif_port(bridge, dev, delete_dev\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_e9fe5c04","line":1387,"in_reply_to":"3afc51ec_cfba3fe1","updated":"2016-03-15 18:58:24.000000000","message":"actully i should update the bug report.\ni originally taught this was version specific but it is not.\n\n\nthe code for _set_device_mtu was \n\nif not mtu:\n        mtu \u003d CONF.network_device_mtu\n    if mtu:\n        utils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, dev, \u0027mtu\u0027,\n                      mtu, run_as_root\u003dTrue,\n                      check_exit_code\u003d[0, 2, 254])\n\ni discovered the issue on a fuel deployment which set the mtu\ni my devstack deployment the mtu was not set in the conf or network so the ip link command wasn never called.\n\ncurrently it never makes sense to set the mtu for a vhost-user port from the host as there is no mechanism implemented to do so.\n\nthere is a patch in flight to add support to set mtu on vhost-user ports in ovs as part of introducing jumbo frame support. once that is merged it will be possible to set the \nmtu as part of the add port command but not after the port is created or via ip. as such it will never make sense to call  _set_device_mtu unless a addtional change is made to dpdk to refect userspace interfaces in the kernel so ip can interact with them.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec49a278994e8e90b7da1d83b5a90e87d8ce799d","unresolved":false,"context_lines":[{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"def _create_ovs_vif_cmd(bridge, dev, iface_id, mac,"},{"line_number":1370,"context_line":"                        instance_id, interface_type):"},{"line_number":1371,"context_line":"    cmd \u003d [\u0027--\u0027, \u0027--if-exists\u0027, \u0027del-port\u0027, dev, \u0027--\u0027,"},{"line_number":1372,"context_line":"            \u0027add-port\u0027, bridge, dev,"},{"line_number":1373,"context_line":"            \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_9b2ca29a","line":1370,"range":{"start_line":1370,"start_character":37,"end_line":1370,"end_character":51},"updated":"2016-03-17 23:55:21.000000000","message":"We should maybe default this to None?","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"                                   interface_type))"},{"line_number":1388,"context_line":"    # Note at present there is no support for setting the"},{"line_number":1389,"context_line":"    # mtu for vhost-user type ports."},{"line_number":1390,"context_line":"    if interface_type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":1391,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_33f4e185","line":1390,"range":{"start_line":1390,"start_character":4,"end_line":1390,"end_character":68},"updated":"2016-03-16 19:01:01.000000000","message":"As John noted earlier, we could use a NO_MTU_SENTINEL or something, but I\u0027m OK with this also.\n\nHowever, it might be good to have an else block that logs a debug message that we\u0027re not setting mtu for this interface_type.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"701498f689ea88ba7191a5672d62526b27cb5fe8","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"                                   interface_type))"},{"line_number":1388,"context_line":"    # Note at present there is no support for setting the"},{"line_number":1389,"context_line":"    # mtu for vhost-user type ports."},{"line_number":1390,"context_line":"    if interface_type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":1391,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_6c316305","line":1390,"range":{"start_line":1390,"start_character":4,"end_line":1390,"end_character":68},"in_reply_to":"1af94dfe_33f4e185","updated":"2016-03-16 22:05:51.000000000","message":"ok yes i can certainly add an else block to emit the debug level log message.\n\nthe reason i have not used a sentinel is i dont know what would be a good vaule or how to pass it. i also wanted to be explcit that this is needed for vhost-user incase it accidentally got removed at some point.\n\nfor example setting the mtu to NO_MTU_SENTINEL would not work in the future if setting the mtu via the ovs-vsctl add-port command is implemented as is currently planned in ovs.\nat that point i would need to restore the mtu to the correct value but i still should not call the _set_device_mtu function\nso a specific set mtu boolean function argument would make more sense.That extends the api more then is strictly needed.\n\nperhaps it is cleaner to move the _set_device_mtu call outside the create_ovs_vif_port function and just call them both where needed?\n\nif there is no strong objection i would prefer to keep this as is but if there is a strong preference i would be happy to change it though i would prefer to limit the scope of the changes i am making.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec49a278994e8e90b7da1d83b5a90e87d8ce799d","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"                                   interface_type))"},{"line_number":1388,"context_line":"    # Note at present there is no support for setting the"},{"line_number":1389,"context_line":"    # mtu for vhost-user type ports."},{"line_number":1390,"context_line":"    if interface_type !\u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":1391,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_380e343b","line":1390,"range":{"start_line":1390,"start_character":4,"end_line":1390,"end_character":68},"in_reply_to":"1af94dfe_6c316305","updated":"2016-03-17 23:55:21.000000000","message":"I\u0027m fine with leaving this as-is.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31e056d951d255f0da1b1426eb76fdcfc8f843cc","unresolved":false,"context_lines":[{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"def _create_ovs_vif_cmd(bridge, dev, iface_id, mac,"},{"line_number":1370,"context_line":"                        instance_id, interface_type):"},{"line_number":1371,"context_line":"    cmd \u003d [\u0027--\u0027, \u0027--if-exists\u0027, \u0027del-port\u0027, dev, \u0027--\u0027,"},{"line_number":1372,"context_line":"            \u0027add-port\u0027, bridge, dev,"},{"line_number":1373,"context_line":"            \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_fb54c6fe","line":1370,"range":{"start_line":1370,"start_character":37,"end_line":1370,"end_character":51},"updated":"2016-03-18 00:09:11.000000000","message":"We should just default this to None. -1 for this.","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3ff33828174fbc77cc46e0a62195d07b85f5aac3","unresolved":false,"context_lines":[{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"def _create_ovs_vif_cmd(bridge, dev, iface_id, mac,"},{"line_number":1370,"context_line":"                        instance_id, interface_type):"},{"line_number":1371,"context_line":"    cmd \u003d [\u0027--\u0027, \u0027--if-exists\u0027, \u0027del-port\u0027, dev, \u0027--\u0027,"},{"line_number":1372,"context_line":"            \u0027add-port\u0027, bridge, dev,"},{"line_number":1373,"context_line":"            \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_e2235bbb","line":1370,"range":{"start_line":1370,"start_character":37,"end_line":1370,"end_character":51},"in_reply_to":"1af94dfe_aadf8167","updated":"2016-03-18 14:56:17.000000000","message":"Yeah, I don\u0027t like relying on the behavior of other things calling this, we should be explicit.","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82835f8d38dc809a3be0564c1e6e7078345211bc","unresolved":false,"context_lines":[{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"def _create_ovs_vif_cmd(bridge, dev, iface_id, mac,"},{"line_number":1370,"context_line":"                        instance_id, interface_type):"},{"line_number":1371,"context_line":"    cmd \u003d [\u0027--\u0027, \u0027--if-exists\u0027, \u0027del-port\u0027, dev, \u0027--\u0027,"},{"line_number":1372,"context_line":"            \u0027add-port\u0027, bridge, dev,"},{"line_number":1373,"context_line":"            \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_aadf8167","line":1370,"range":{"start_line":1370,"start_character":37,"end_line":1370,"end_character":51},"in_reply_to":"1af94dfe_fb54c6fe","updated":"2016-03-18 07:27:14.000000000","message":"i didnt default to none because of the default in create_ovs_vif_port which is the only place it is used outside of tests but ok thats a simple change will do","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31e056d951d255f0da1b1426eb76fdcfc8f843cc","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1392,"context_line":"    else:"},{"line_number":1393,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""},{"line_number":1394,"context_line":"                    \"of type %(interface_type)s.\","},{"line_number":1395,"context_line":"                  {\u0027interface_name\u0027: dev,"},{"line_number":1396,"context_line":"                   \u0027interface_type\u0027: interface_type})"},{"line_number":1397,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_bb751e99","line":1394,"range":{"start_line":1394,"start_character":20,"end_line":1394,"end_character":50},"updated":"2016-03-18 00:09:11.000000000","message":"nit: please align this with \"MTU above. -1 for this.","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82835f8d38dc809a3be0564c1e6e7078345211bc","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":1392,"context_line":"    else:"},{"line_number":1393,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""},{"line_number":1394,"context_line":"                    \"of type %(interface_type)s.\","},{"line_number":1395,"context_line":"                  {\u0027interface_name\u0027: dev,"},{"line_number":1396,"context_line":"                   \u0027interface_type\u0027: interface_type})"},{"line_number":1397,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_cae2cd2e","line":1394,"range":{"start_line":1394,"start_character":20,"end_line":1394,"end_character":50},"in_reply_to":"1af94dfe_bb751e99","updated":"2016-03-18 07:27:14.000000000","message":"sorry taught i had guess i missed this line","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"}],"nova/tests/unit/network/test_linux_net.py":[{"author":{"_account_id":9581,"name":"Ren Qiaowei","email":"qiaowei.ren@intel.com","username":"qiaowei"},"change_message_id":"1e1b21665eb0e7f0054b35beda0374d6de7a9f72","unresolved":false,"context_lines":[{"line_number":1234,"context_line":""},{"line_number":1235,"context_line":"        expected +\u003d [\u0027type\u003dfake-type\u0027]"},{"line_number":1236,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1237,"context_line":"                                           \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1238,"context_line":"                                           \u0027fake-instance-uuid\u0027,"},{"line_number":1239,"context_line":"                                           \u0027fake-type\u0027)"},{"line_number":1240,"context_line":"        self.assertEqual(expected, cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b6ea56ab","line":1237,"range":{"start_line":1237,"start_character":43,"end_line":1237,"end_character":71},"updated":"2016-01-26 09:06:20.000000000","message":"to add a blank space indent like other cases will be nice.","commit_id":"9eea036a826d14e847ffe20f2328ccb15616ae74"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"284d773e30bd2f14550bd2931a85dde9aeb714c0","unresolved":false,"context_lines":[{"line_number":1234,"context_line":""},{"line_number":1235,"context_line":"        expected +\u003d [\u0027type\u003dfake-type\u0027]"},{"line_number":1236,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1237,"context_line":"                                           \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1238,"context_line":"                                           \u0027fake-instance-uuid\u0027,"},{"line_number":1239,"context_line":"                                           \u0027fake-type\u0027)"},{"line_number":1240,"context_line":"        self.assertEqual(expected, cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_13ba4fc1","line":1237,"range":{"start_line":1237,"start_character":43,"end_line":1237,"end_character":71},"in_reply_to":"9a68dd71_b6ea56ab","updated":"2016-01-26 10:22:00.000000000","message":"done.","commit_id":"9eea036a826d14e847ffe20f2328ccb15616ae74"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1230,"context_line":"                                            \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1231,"context_line":"                                            \u0027fake-instance-uuid\u0027,"},{"line_number":1232,"context_line":"                                            None)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1235,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_f386f9d9","line":1232,"range":{"start_line":1232,"start_character":44,"end_line":1232,"end_character":48},"updated":"2016-03-16 19:01:01.000000000","message":"Could just omit this for the default case...","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec49a278994e8e90b7da1d83b5a90e87d8ce799d","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1230,"context_line":"                                            \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1231,"context_line":"                                            \u0027fake-instance-uuid\u0027,"},{"line_number":1232,"context_line":"                                            None)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1235,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_78043c17","line":1232,"range":{"start_line":1232,"start_character":44,"end_line":1232,"end_character":48},"in_reply_to":"1af94dfe_6f9cabc0","updated":"2016-03-17 23:55:21.000000000","message":"Oh right, maybe it should?","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f03ad16b2e60aac961c0d7e596fe4d9d5b118791","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1230,"context_line":"                                            \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1231,"context_line":"                                            \u0027fake-instance-uuid\u0027,"},{"line_number":1232,"context_line":"                                            None)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1235,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_6f9cabc0","line":1232,"range":{"start_line":1232,"start_character":44,"end_line":1232,"end_character":48},"in_reply_to":"1af94dfe_f386f9d9","updated":"2016-03-17 05:09:53.000000000","message":"actully this is need as _create_ovs_vif_cmd dose not default the interface type to none.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"701498f689ea88ba7191a5672d62526b27cb5fe8","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1230,"context_line":"                                            \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1231,"context_line":"                                            \u0027fake-instance-uuid\u0027,"},{"line_number":1232,"context_line":"                                            None)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1235,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_0015033f","line":1232,"range":{"start_line":1232,"start_character":44,"end_line":1232,"end_character":48},"in_reply_to":"1af94dfe_f386f9d9","updated":"2016-03-16 22:05:51.000000000","message":"ok i will remove","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"        expected +\u003d [\u0027type\u003dfake-type\u0027]"},{"line_number":1237,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1238,"context_line":"                                            \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1239,"context_line":"                                            \u0027fake-instance-uuid\u0027,"},{"line_number":1240,"context_line":"                                            \u0027fake-type\u0027)"},{"line_number":1241,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"    def test_ovs_vif_port(self):"},{"line_number":1244,"context_line":"        calls \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_b3cab118","line":1241,"range":{"start_line":1236,"start_character":8,"end_line":1241,"end_character":39},"updated":"2016-03-16 19:01:01.000000000","message":"How is this any different from what you\u0027re testing in test_ovs_vif_port_with_type below?","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"701498f689ea88ba7191a5672d62526b27cb5fe8","unresolved":false,"context_lines":[{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"        expected +\u003d [\u0027type\u003dfake-type\u0027]"},{"line_number":1237,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1238,"context_line":"                                            \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1239,"context_line":"                                            \u0027fake-instance-uuid\u0027,"},{"line_number":1240,"context_line":"                                            \u0027fake-type\u0027)"},{"line_number":1241,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"    def test_ovs_vif_port(self):"},{"line_number":1244,"context_line":"        calls \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_40e9cb13","line":1241,"range":{"start_line":1236,"start_character":8,"end_line":1241,"end_character":39},"in_reply_to":"1af94dfe_b3cab118","updated":"2016-03-16 22:05:51.000000000","message":"in the test below i am calling the _create_ovs_vif_cmd function indirectly passing the type as a keyword argument \ncreate_ovs_vif_port where as here i am calling directly passing it as a positional argument. they are similar but i wanted to test each seperatly.\n\ni guess in test_ovs_vif_port_with_type i should not check the ovs-vsctl calls but instead check that _create_ovs_vif_cmd is called with the correct arguments.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"                ]"},{"line_number":1269,"context_line":"        self._ovs_vif_port(calls, interface_type\u003d\u0027fake-type\u0027)"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"    def test_ovs_vif_port_with_mtu(self):"},{"line_number":1272,"context_line":"        self.flags(network_device_mtu\u003d10000)"},{"line_number":1273,"context_line":"        calls \u003d ["},{"line_number":1274,"context_line":"                mock.call(\u0027ovs-vsctl\u0027, \u0027--timeout\u003d120\u0027, \u0027--\u0027, \u0027--if-exists\u0027,"},{"line_number":1275,"context_line":"                          \u0027del-port\u0027, \u0027fake-dev\u0027, \u0027--\u0027, \u0027add-port\u0027,"},{"line_number":1276,"context_line":"                          \u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1277,"context_line":"                          \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, \u0027fake-dev\u0027,"},{"line_number":1278,"context_line":"                          \u0027external-ids:iface-id\u003dfake-iface-id\u0027,"},{"line_number":1279,"context_line":"                          \u0027external-ids:iface-status\u003dactive\u0027,"},{"line_number":1280,"context_line":"                          \u0027external-ids:attached-mac\u003dfake-mac\u0027,"},{"line_number":1281,"context_line":"                          \u0027external-ids:vm-uuid\u003dfake-instance-uuid\u0027,"},{"line_number":1282,"context_line":"                          run_as_root\u003dTrue),"},{"line_number":1283,"context_line":"                mock.call(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, \u0027fake-dev\u0027, \u0027mtu\u0027,"},{"line_number":1284,"context_line":"                          10000, run_as_root\u003dTrue,"},{"line_number":1285,"context_line":"                          check_exit_code\u003d[0, 2, 254])"},{"line_number":1286,"context_line":"                ]"},{"line_number":1287,"context_line":"        self._ovs_vif_port(calls)"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"    def _create_veth_pair(self, calls):"},{"line_number":1290,"context_line":"        with mock.patch.object(utils, \u0027execute\u0027, return_value\u003d(\u0027\u0027, \u0027\u0027)) as ex:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_5764f8e2","line":1287,"range":{"start_line":1271,"start_character":4,"end_line":1287,"end_character":33},"updated":"2016-03-16 19:01:01.000000000","message":"We should have a test like this but with the vhostuser type so we can assert that ip link isn\u0027t called.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b40458b47ab8d12e0bb5c734f278251e2078462","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"                ]"},{"line_number":1269,"context_line":"        self._ovs_vif_port(calls, interface_type\u003d\u0027fake-type\u0027)"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"    def test_ovs_vif_port_with_mtu(self):"},{"line_number":1272,"context_line":"        self.flags(network_device_mtu\u003d10000)"},{"line_number":1273,"context_line":"        calls \u003d ["},{"line_number":1274,"context_line":"                mock.call(\u0027ovs-vsctl\u0027, \u0027--timeout\u003d120\u0027, \u0027--\u0027, \u0027--if-exists\u0027,"},{"line_number":1275,"context_line":"                          \u0027del-port\u0027, \u0027fake-dev\u0027, \u0027--\u0027, \u0027add-port\u0027,"},{"line_number":1276,"context_line":"                          \u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1277,"context_line":"                          \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, \u0027fake-dev\u0027,"},{"line_number":1278,"context_line":"                          \u0027external-ids:iface-id\u003dfake-iface-id\u0027,"},{"line_number":1279,"context_line":"                          \u0027external-ids:iface-status\u003dactive\u0027,"},{"line_number":1280,"context_line":"                          \u0027external-ids:attached-mac\u003dfake-mac\u0027,"},{"line_number":1281,"context_line":"                          \u0027external-ids:vm-uuid\u003dfake-instance-uuid\u0027,"},{"line_number":1282,"context_line":"                          run_as_root\u003dTrue),"},{"line_number":1283,"context_line":"                mock.call(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, \u0027fake-dev\u0027, \u0027mtu\u0027,"},{"line_number":1284,"context_line":"                          10000, run_as_root\u003dTrue,"},{"line_number":1285,"context_line":"                          check_exit_code\u003d[0, 2, 254])"},{"line_number":1286,"context_line":"                ]"},{"line_number":1287,"context_line":"        self._ovs_vif_port(calls)"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"    def _create_veth_pair(self, calls):"},{"line_number":1290,"context_line":"        with mock.patch.object(utils, \u0027execute\u0027, return_value\u003d(\u0027\u0027, \u0027\u0027)) as ex:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_4c2f3df6","line":1287,"range":{"start_line":1271,"start_character":4,"end_line":1287,"end_character":33},"in_reply_to":"1af94dfe_20bbdf0f","updated":"2016-03-17 04:50:17.000000000","message":"i have rewritten test_ovs_vif_port_with_type to\ncover the regression test and make it more useful.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"701498f689ea88ba7191a5672d62526b27cb5fe8","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"                ]"},{"line_number":1269,"context_line":"        self._ovs_vif_port(calls, interface_type\u003d\u0027fake-type\u0027)"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"    def test_ovs_vif_port_with_mtu(self):"},{"line_number":1272,"context_line":"        self.flags(network_device_mtu\u003d10000)"},{"line_number":1273,"context_line":"        calls \u003d ["},{"line_number":1274,"context_line":"                mock.call(\u0027ovs-vsctl\u0027, \u0027--timeout\u003d120\u0027, \u0027--\u0027, \u0027--if-exists\u0027,"},{"line_number":1275,"context_line":"                          \u0027del-port\u0027, \u0027fake-dev\u0027, \u0027--\u0027, \u0027add-port\u0027,"},{"line_number":1276,"context_line":"                          \u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1277,"context_line":"                          \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, \u0027fake-dev\u0027,"},{"line_number":1278,"context_line":"                          \u0027external-ids:iface-id\u003dfake-iface-id\u0027,"},{"line_number":1279,"context_line":"                          \u0027external-ids:iface-status\u003dactive\u0027,"},{"line_number":1280,"context_line":"                          \u0027external-ids:attached-mac\u003dfake-mac\u0027,"},{"line_number":1281,"context_line":"                          \u0027external-ids:vm-uuid\u003dfake-instance-uuid\u0027,"},{"line_number":1282,"context_line":"                          run_as_root\u003dTrue),"},{"line_number":1283,"context_line":"                mock.call(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, \u0027fake-dev\u0027, \u0027mtu\u0027,"},{"line_number":1284,"context_line":"                          10000, run_as_root\u003dTrue,"},{"line_number":1285,"context_line":"                          check_exit_code\u003d[0, 2, 254])"},{"line_number":1286,"context_line":"                ]"},{"line_number":1287,"context_line":"        self._ovs_vif_port(calls)"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"    def _create_veth_pair(self, calls):"},{"line_number":1290,"context_line":"        with mock.patch.object(utils, \u0027execute\u0027, return_value\u003d(\u0027\u0027, \u0027\u0027)) as ex:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_20bbdf0f","line":1287,"range":{"start_line":1271,"start_character":4,"end_line":1287,"end_character":33},"in_reply_to":"1af94dfe_5764f8e2","updated":"2016-03-16 22:05:51.000000000","message":"ah yes you are right i will add one.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31e056d951d255f0da1b1426eb76fdcfc8f843cc","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                ]"},{"line_number":1229,"context_line":"        cmd \u003d linux_net._create_ovs_vif_cmd(\u0027fake-bridge\u0027, \u0027fake-dev\u0027,"},{"line_number":1230,"context_line":"                                            \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1231,"context_line":"                                            \u0027fake-instance-uuid\u0027, None)"},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":"        self.assertEqual(expected, cmd)"},{"line_number":1234,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_fb6b26b7","line":1231,"range":{"start_line":1231,"start_character":66,"end_line":1231,"end_character":70},"updated":"2016-03-18 00:09:11.000000000","message":"I think we should just default this to None in the actual _create_ovs_vif_cmd method, it looks weird to have to pass None explicitly.","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31e056d951d255f0da1b1426eb76fdcfc8f843cc","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"            \u0027fake-bridge\u0027,"},{"line_number":1263,"context_line":"            \u0027fake-dev\u0027, \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1264,"context_line":"            \"fake-instance-uuid\", mtu\u003d1500,"},{"line_number":1265,"context_line":"            interface_type\u003d\u0027dpdkvhostuser\u0027)"},{"line_number":1266,"context_line":"        mock_create_cmd.assert_called_once_with(\u0027fake-bridge\u0027,"},{"line_number":1267,"context_line":"            \u0027fake-dev\u0027, \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1268,"context_line":"            \"fake-instance-uuid\", \u0027dpdkvhostuser\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_1b67f2e9","line":1265,"range":{"start_line":1265,"start_character":27,"end_line":1265,"end_character":42},"updated":"2016-03-18 00:09:11.000000000","message":"nit: could use your newly defined constant.","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82835f8d38dc809a3be0564c1e6e7078345211bc","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"            \u0027fake-bridge\u0027,"},{"line_number":1263,"context_line":"            \u0027fake-dev\u0027, \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1264,"context_line":"            \"fake-instance-uuid\", mtu\u003d1500,"},{"line_number":1265,"context_line":"            interface_type\u003d\u0027dpdkvhostuser\u0027)"},{"line_number":1266,"context_line":"        mock_create_cmd.assert_called_once_with(\u0027fake-bridge\u0027,"},{"line_number":1267,"context_line":"            \u0027fake-dev\u0027, \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":1268,"context_line":"            \"fake-instance-uuid\", \u0027dpdkvhostuser\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_2a07f1ca","line":1265,"range":{"start_line":1265,"start_character":27,"end_line":1265,"end_character":42},"in_reply_to":"1af94dfe_1b67f2e9","updated":"2016-03-18 07:27:14.000000000","message":"i was debating that. i originally did import the constant but normally constants are not imported for most of these tests because \"fake-X\" is just used instead but i need to exercise the if in create_ovs_vif_port hence \"dpdkvhostuser\".\n\nbut yes ill revert to the constant","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"                                      \u0027br0\u0027, \u0027usv-xxx-yyy-zzz\u0027,"},{"line_number":1318,"context_line":"                                      \u0027aaa-bbb-ccc\u0027, \u0027ca:fe:de:ad:be:ef\u0027,"},{"line_number":1319,"context_line":"                                      \u0027f0000000-0000-0000-0000-000000000001\u0027,"},{"line_number":1320,"context_line":"                                      9000, interface_type \u003d \u0027dpdkvhostuser\u0027)]"},{"line_number":1321,"context_line":"        }"},{"line_number":1322,"context_line":"        with mock.patch.object(linux_net,"},{"line_number":1323,"context_line":"                               \u0027create_ovs_vif_port\u0027) as create_ovs_vif_port:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_37b68c3d","line":1320,"range":{"start_line":1320,"start_character":58,"end_line":1320,"end_character":61},"updated":"2016-03-16 19:01:01.000000000","message":"nit: drop the spaces","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"701498f689ea88ba7191a5672d62526b27cb5fe8","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"                                      \u0027br0\u0027, \u0027usv-xxx-yyy-zzz\u0027,"},{"line_number":1318,"context_line":"                                      \u0027aaa-bbb-ccc\u0027, \u0027ca:fe:de:ad:be:ef\u0027,"},{"line_number":1319,"context_line":"                                      \u0027f0000000-0000-0000-0000-000000000001\u0027,"},{"line_number":1320,"context_line":"                                      9000, interface_type \u003d \u0027dpdkvhostuser\u0027)]"},{"line_number":1321,"context_line":"        }"},{"line_number":1322,"context_line":"        with mock.patch.object(linux_net,"},{"line_number":1323,"context_line":"                               \u0027create_ovs_vif_port\u0027) as create_ovs_vif_port:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_805f53e4","line":1320,"range":{"start_line":1320,"start_character":58,"end_line":1320,"end_character":61},"in_reply_to":"1af94dfe_37b68c3d","updated":"2016-03-16 22:05:51.000000000","message":"yep sorry that was mentioned in the last patch revision also i missed that.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b40458b47ab8d12e0bb5c734f278251e2078462","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"                                      \u0027br0\u0027, \u0027usv-xxx-yyy-zzz\u0027,"},{"line_number":1318,"context_line":"                                      \u0027aaa-bbb-ccc\u0027, \u0027ca:fe:de:ad:be:ef\u0027,"},{"line_number":1319,"context_line":"                                      \u0027f0000000-0000-0000-0000-000000000001\u0027,"},{"line_number":1320,"context_line":"                                      9000, interface_type \u003d \u0027dpdkvhostuser\u0027)]"},{"line_number":1321,"context_line":"        }"},{"line_number":1322,"context_line":"        with mock.patch.object(linux_net,"},{"line_number":1323,"context_line":"                               \u0027create_ovs_vif_port\u0027) as create_ovs_vif_port:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_0ceff5b0","line":1320,"range":{"start_line":1320,"start_character":58,"end_line":1320,"end_character":61},"in_reply_to":"1af94dfe_805f53e4","updated":"2016-03-17 04:50:17.000000000","message":"Done","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31e056d951d255f0da1b1426eb76fdcfc8f843cc","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"                                      \u0027br0\u0027, \u0027usv-xxx-yyy-zzz\u0027,"},{"line_number":1318,"context_line":"                                      \u0027aaa-bbb-ccc\u0027, \u0027ca:fe:de:ad:be:ef\u0027,"},{"line_number":1319,"context_line":"                                      \u0027f0000000-0000-0000-0000-000000000001\u0027,"},{"line_number":1320,"context_line":"                                      9000, interface_type\u003d\u0027dpdkvhostuser\u0027)]"},{"line_number":1321,"context_line":"        }"},{"line_number":1322,"context_line":"        with mock.patch.object(linux_net,"},{"line_number":1323,"context_line":"                               \u0027create_ovs_vif_port\u0027) as create_ovs_vif_port:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_3bb10e48","line":1320,"range":{"start_line":1320,"start_character":59,"end_line":1320,"end_character":74},"updated":"2016-03-18 00:09:11.000000000","message":"nit: could use the constant.","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a15d10cc5ac698bf216d57020981cb6ce3ee710","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        iface_id \u003d self.get_ovs_interfaceid(vif)"},{"line_number":677,"context_line":"        port_name \u003d os.path.basename("},{"line_number":678,"context_line":"            vif[\u0027details\u0027][network_model.VIF_DETAILS_VHOSTUSER_SOCKET])"},{"line_number":679,"context_line":"        mtu \u003d vif[\u0027network\u0027].get_meta(\u0027mtu\u0027)"},{"line_number":680,"context_line":"        linux_net.create_ovs_vif_port("},{"line_number":681,"context_line":"            self.get_bridge_name(vif),"},{"line_number":682,"context_line":"            port_name, iface_id, vif[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_40af2394","line":679,"updated":"2016-03-14 11:06:35.000000000","message":"Longer term, should this not correctly tell us if MTU should be set or not? i.e. Neutron should tell us if we should set the MTU or not?\n\nI think here we should explicitly pass in some NO_MTU sentinel, as this code looks like its trying to set the MTU (because None means use the default).","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"339993e96644fab2f670a9f096430626dec7f795","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        iface_id \u003d self.get_ovs_interfaceid(vif)"},{"line_number":677,"context_line":"        port_name \u003d os.path.basename("},{"line_number":678,"context_line":"            vif[\u0027details\u0027][network_model.VIF_DETAILS_VHOSTUSER_SOCKET])"},{"line_number":679,"context_line":"        mtu \u003d vif[\u0027network\u0027].get_meta(\u0027mtu\u0027)"},{"line_number":680,"context_line":"        linux_net.create_ovs_vif_port("},{"line_number":681,"context_line":"            self.get_bridge_name(vif),"},{"line_number":682,"context_line":"            port_name, iface_id, vif[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_c09085ef","line":679,"in_reply_to":"1af94dfe_ef9f725d","updated":"2016-03-16 00:43:58.000000000","message":"well the reason that we dont set it at all is that it cat be set currently in the ovs/dpdk implementation of vhost-user.\n\nmtu support will be added for vhost-user in ovs as part of adding jumbo frame support. that will not be availble until ovs 2.6 so i plan on support setting the mtu in os-vif in Newton but not set it in nova for mitaka and previous releases.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a4ac8ba2890aba26dece0535fbf2ad62e86dd38","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        iface_id \u003d self.get_ovs_interfaceid(vif)"},{"line_number":677,"context_line":"        port_name \u003d os.path.basename("},{"line_number":678,"context_line":"            vif[\u0027details\u0027][network_model.VIF_DETAILS_VHOSTUSER_SOCKET])"},{"line_number":679,"context_line":"        mtu \u003d vif[\u0027network\u0027].get_meta(\u0027mtu\u0027)"},{"line_number":680,"context_line":"        linux_net.create_ovs_vif_port("},{"line_number":681,"context_line":"            self.get_bridge_name(vif),"},{"line_number":682,"context_line":"            port_name, iface_id, vif[\u0027address\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_ef9f725d","line":679,"in_reply_to":"3afc51ec_40af2394","updated":"2016-03-15 18:07:43.000000000","message":"The default in Nova would be None, fwiw:\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/network.py#L35\n\nhttps://github.com/openstack/nova/blob/master/nova/network/linux_net.py#L1334-L1339\n\nThe thing that made this urgent was neutron used to default the mtu to 0 but changed that to 1500 in mitaka:\n\nhttp://docs.openstack.org/releasenotes/neutron/unreleased.html#b3\n\nSo a workaround if you don\u0027t want MTU is setting that back to 0, which maybe needs to be documented as a limitation for networks that have vhostuser ports. But agree with other questions in here that it\u0027s very odd to just not set it at all, seems we\u0027d at least log that we\u0027re not using it or something.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a15d10cc5ac698bf216d57020981cb6ce3ee710","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        linux_net.create_ovs_vif_port("},{"line_number":681,"context_line":"            self.get_bridge_name(vif),"},{"line_number":682,"context_line":"            port_name, iface_id, vif[\u0027address\u0027],"},{"line_number":683,"context_line":"            instance.uuid, mtu,"},{"line_number":684,"context_line":"            type \u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def plug_vhostuser(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_00999b1f","line":683,"range":{"start_line":683,"start_character":27,"end_line":683,"end_character":30},"updated":"2016-03-14 11:06:35.000000000","message":"see above.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2730e389f425190348dc44e52555660a67572a16","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            self.get_bridge_name(vif),"},{"line_number":682,"context_line":"            port_name, iface_id, vif[\u0027address\u0027],"},{"line_number":683,"context_line":"            instance.uuid, mtu,"},{"line_number":684,"context_line":"            type \u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def plug_vhostuser(self, instance, vif):"},{"line_number":687,"context_line":"        fp_plug \u003d vif[\u0027details\u0027].get("}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_b2b5afce","line":684,"range":{"start_line":684,"start_character":16,"end_line":684,"end_character":19},"updated":"2016-03-13 17:16:16.000000000","message":"nit: remove the spaces around \u003d in kwargs, there is probably some pep8 violation here that we\u0027re not gating on.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"339993e96644fab2f670a9f096430626dec7f795","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            self.get_bridge_name(vif),"},{"line_number":682,"context_line":"            port_name, iface_id, vif[\u0027address\u0027],"},{"line_number":683,"context_line":"            instance.uuid, mtu,"},{"line_number":684,"context_line":"            type \u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def plug_vhostuser(self, instance, vif):"},{"line_number":687,"context_line":"        fp_plug \u003d vif[\u0027details\u0027].get("}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_e0582159","line":684,"range":{"start_line":684,"start_character":16,"end_line":684,"end_character":19},"in_reply_to":"3afc51ec_b2b5afce","updated":"2016-03-16 00:43:58.000000000","message":"ah yes you are right though that one always annoyed me.\nin all other cases the sapces are required except keyword args. ill fix this in next version.","commit_id":"072d383671afde234aa8fbd21b8039a17b655276"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            self.get_bridge_name(vif),"},{"line_number":682,"context_line":"            port_name, iface_id, vif[\u0027address\u0027],"},{"line_number":683,"context_line":"            instance.uuid, mtu,"},{"line_number":684,"context_line":"            interface_type \u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def plug_vhostuser(self, instance, vif):"},{"line_number":687,"context_line":"        fp_plug \u003d vif[\u0027details\u0027].get("}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_b780dc47","line":684,"range":{"start_line":684,"start_character":26,"end_line":684,"end_character":29},"updated":"2016-03-16 19:01:01.000000000","message":"Drop the spaces in kwargs.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b40458b47ab8d12e0bb5c734f278251e2078462","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            self.get_bridge_name(vif),"},{"line_number":682,"context_line":"            port_name, iface_id, vif[\u0027address\u0027],"},{"line_number":683,"context_line":"            instance.uuid, mtu,"},{"line_number":684,"context_line":"            interface_type \u003d network_model.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def plug_vhostuser(self, instance, vif):"},{"line_number":687,"context_line":"        fp_plug \u003d vif[\u0027details\u0027].get("}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_2cf47184","line":684,"range":{"start_line":684,"start_character":26,"end_line":684,"end_character":29},"in_reply_to":"1af94dfe_b780dc47","updated":"2016-03-17 04:50:17.000000000","message":"Done","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"}],"releasenotes/notes/neutron-mtu-6a7edd9e396107d7.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``segment_mtu`` configuration option in Neutron before Mitaka, then the"},{"line_number":11,"context_line":"    (deprecated) ``network_device_mtu`` configuration option in Nova is used,"},{"line_number":12,"context_line":"    which defaults to not setting an MTU value."},{"line_number":13,"context_line":"  - When plugging virtual interfaces of type vhost-user the MTU value will"},{"line_number":14,"context_line":"    not be applied to the interface by nova. vhost-user port exist only in"},{"line_number":15,"context_line":"    userspace and are not backed by kernel netdevs, for this reason it is"},{"line_number":16,"context_line":"    not possible to set the mtu on a vhost-user interface using standard"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1af94dfe_97ea000e","line":13,"updated":"2016-03-16 19:01:01.000000000","message":"You should have a new separate reno slug for this change rather than add to the existing MTU change, because if we backport your change but not that change, then the backport is going to be really odd.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec49a278994e8e90b7da1d83b5a90e87d8ce799d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``segment_mtu`` configuration option in Neutron before Mitaka, then the"},{"line_number":11,"context_line":"    (deprecated) ``network_device_mtu`` configuration option in Nova is used,"},{"line_number":12,"context_line":"    which defaults to not setting an MTU value."},{"line_number":13,"context_line":"  - When plugging virtual interfaces of type vhost-user the MTU value will"},{"line_number":14,"context_line":"    not be applied to the interface by nova. vhost-user port exist only in"},{"line_number":15,"context_line":"    userspace and are not backed by kernel netdevs, for this reason it is"},{"line_number":16,"context_line":"    not possible to set the mtu on a vhost-user interface using standard"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1af94dfe_1b125257","line":13,"in_reply_to":"1af94dfe_80d47320","updated":"2016-03-17 23:55:21.000000000","message":"reno generates the hash.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b40458b47ab8d12e0bb5c734f278251e2078462","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``segment_mtu`` configuration option in Neutron before Mitaka, then the"},{"line_number":11,"context_line":"    (deprecated) ``network_device_mtu`` configuration option in Nova is used,"},{"line_number":12,"context_line":"    which defaults to not setting an MTU value."},{"line_number":13,"context_line":"  - When plugging virtual interfaces of type vhost-user the MTU value will"},{"line_number":14,"context_line":"    not be applied to the interface by nova. vhost-user port exist only in"},{"line_number":15,"context_line":"    userspace and are not backed by kernel netdevs, for this reason it is"},{"line_number":16,"context_line":"    not possible to set the mtu on a vhost-user interface using standard"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1af94dfe_0ca7f54f","line":13,"in_reply_to":"1af94dfe_97ea000e","updated":"2016-03-17 04:50:17.000000000","message":"Done","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"701498f689ea88ba7191a5672d62526b27cb5fe8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``segment_mtu`` configuration option in Neutron before Mitaka, then the"},{"line_number":11,"context_line":"    (deprecated) ``network_device_mtu`` configuration option in Nova is used,"},{"line_number":12,"context_line":"    which defaults to not setting an MTU value."},{"line_number":13,"context_line":"  - When plugging virtual interfaces of type vhost-user the MTU value will"},{"line_number":14,"context_line":"    not be applied to the interface by nova. vhost-user port exist only in"},{"line_number":15,"context_line":"    userspace and are not backed by kernel netdevs, for this reason it is"},{"line_number":16,"context_line":"    not possible to set the mtu on a vhost-user interface using standard"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1af94dfe_80d47320","line":13,"in_reply_to":"1af94dfe_97ea000e","updated":"2016-03-16 22:05:51.000000000","message":"ok i added this to this change as i did not know how the numbers in the file name were generated. they did not appear to be a change id or commit so i decided to group the mtu changes together. i will split this out in the next version.","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4d84bbf3dd48dd5478c728398d5ea1ed6ff3c65","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    (deprecated) ``network_device_mtu`` configuration option in Nova is used,"},{"line_number":12,"context_line":"    which defaults to not setting an MTU value."},{"line_number":13,"context_line":"  - When plugging virtual interfaces of type vhost-user the MTU value will"},{"line_number":14,"context_line":"    not be applied to the interface by nova. vhost-user port exist only in"},{"line_number":15,"context_line":"    userspace and are not backed by kernel netdevs, for this reason it is"},{"line_number":16,"context_line":"    not possible to set the mtu on a vhost-user interface using standard"},{"line_number":17,"context_line":"    tools such as ifconfig or ip link. In a future release of ovs it is"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1af94dfe_f7d9c484","line":14,"range":{"start_line":14,"start_character":56,"end_line":14,"end_character":60},"updated":"2016-03-16 19:01:01.000000000","message":"ports","commit_id":"c1bb6255b262cfcc491df0311d67170abcfd8480"}],"releasenotes/notes/vhost-user-mtu-23d0af36a8adfa56.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31e056d951d255f0da1b1426eb76fdcfc8f843cc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    not possible to set the mtu on a vhost-user interface using standard"},{"line_number":7,"context_line":"    tools such as ifconfig or ip link."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - In a future release of ovs it is expected that setting the mtu of"},{"line_number":10,"context_line":"    a vhost-user interfaces will be supported as part of interface"},{"line_number":11,"context_line":"    creation via the add-port command."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1af94dfe_db7e2a69","line":11,"range":{"start_line":9,"start_character":4,"end_line":11,"end_character":38},"updated":"2016-03-18 00:09:11.000000000","message":"It might be weird for this to show up on it\u0027s own in the \u0027other\u0027 section of the release notes. I\u0027d probably just include this in the \u0027fixes\u0027 section.\n\nWe might want to ask bauzas if we even want a release note for this though.","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d9b940a1f4c79821c5e330de127304556b36b9d0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    not possible to set the mtu on a vhost-user interface using standard"},{"line_number":7,"context_line":"    tools such as ifconfig or ip link."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - In a future release of ovs it is expected that setting the mtu of"},{"line_number":10,"context_line":"    a vhost-user interfaces will be supported as part of interface"},{"line_number":11,"context_line":"    creation via the add-port command."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1af94dfe_fd8c9fdb","line":11,"range":{"start_line":9,"start_character":4,"end_line":11,"end_character":38},"in_reply_to":"1af94dfe_8ae60513","updated":"2016-03-18 13:53:54.000000000","message":"ill just remove this","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82835f8d38dc809a3be0564c1e6e7078345211bc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    not possible to set the mtu on a vhost-user interface using standard"},{"line_number":7,"context_line":"    tools such as ifconfig or ip link."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - In a future release of ovs it is expected that setting the mtu of"},{"line_number":10,"context_line":"    a vhost-user interfaces will be supported as part of interface"},{"line_number":11,"context_line":"    creation via the add-port command."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1af94dfe_8ae60513","line":11,"range":{"start_line":9,"start_character":4,"end_line":11,"end_character":38},"in_reply_to":"1af94dfe_db7e2a69","updated":"2016-03-18 07:27:14.000000000","message":"i could just remove it. i just wanted to capture that that ovs community is aware of gap and are addressing it in the future. incidentilly it is currently still possible to set the mtu via dhcp for vhost-user interfaces when the OS in the guest supports it. should i mention that? i can collapse this all into the fixes section as you suggest.","commit_id":"2a09439e1ece64d5f66ae8b64a72bbfb177f856b"}]}