)]}'
{"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"06f5b7b9ab1a6d350c05f1112654a81b6c9a0db2","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class IndirectionFixture(fixtures.Fixture):"},{"line_number":237,"context_line":"    def setUp(self):"},{"line_number":238,"context_line":"        super(IndirectionFixture, self).setUp()"},{"line_number":239,"context_line":"        ser \u003d base.NovaObjectSerializer()"},{"line_number":240,"context_line":"        self.indirection_api \u003d FakeIndirectionHack(serializer\u003dser)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_f3c7c061","line":237,"updated":"2016-01-25 02:33:23.000000000","message":"You\u0027re probably better off with _setUp. See https://github.com/testing-cabal/fixtures/blob/master/fixtures/fixture.py#L174 and https://github.com/testing-cabal/fixtures/blob/master/fixtures/fixture.py#L215","commit_id":"085105b3b34c2d392b6075882c47d0feb82bebd2"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"06f5b7b9ab1a6d350c05f1112654a81b6c9a0db2","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"class _BaseTestCase(testscenarios.WithScenarios, test.TestCase):"},{"line_number":247,"context_line":"    use_fixtures \u003d []"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    # testscenarios allows use to define a set of scenarios in the format of:"},{"line_number":250,"context_line":"    #    (name, dict(attr_to_add_to_tests))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d38e3c2d","line":247,"updated":"2016-01-25 02:33:23.000000000","message":"I think this is here for documentation purposes? Because use_fixtures is set in the scenarios, and you\u0027re mixing WithScenarios in, its not possible to run the tests without scenarios having been applied, which means that use_fixtures will always be defined to the value from the scenario.\n\nPerhaps set to None to make it clear its value is not mutated, but replaced.","commit_id":"085105b3b34c2d392b6075882c47d0feb82bebd2"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"06f5b7b9ab1a6d350c05f1112654a81b6c9a0db2","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    # add the scenario name to the test name in parens."},{"line_number":254,"context_line":"    scenarios \u003d ["},{"line_number":255,"context_line":"        (\u0027local\u0027, {"},{"line_number":256,"context_line":"            \u0027use_fixtures\u0027: [nova_fixtures.IndirectionAPIFixture(None)]}),"},{"line_number":257,"context_line":"        (\u0027remote\u0027, {"},{"line_number":258,"context_line":"            \u0027use_fixtures\u0027: [IndirectionFixture()]})"},{"line_number":259,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_738190fa","line":256,"updated":"2016-01-25 02:33:23.000000000","message":"Perhaps this would be better with a tuple or some other immutable value here - because the scenario object is shared with all your tests, if someone modifies use_fixtures, it will modify it for all tests, and that can lead to hard to reason about situations.","commit_id":"085105b3b34c2d392b6075882c47d0feb82bebd2"}]}