)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f4eb4d317bd92b6077de70ba153c412a6ea0b791","unresolved":false,"context_lines":[{"line_number":15,"context_line":"to the nova.conf file, so we can config it by ourself.It will"},{"line_number":16,"context_line":"be set to 10 seconds if the value is bigger than"},{"line_number":17,"context_line":"CONF.shutdown_timeout."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib8c4c9d93256ed1707e065e39760ba5034b26545"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a68dd71_052c5397","line":18,"updated":"2016-01-26 02:58:28.000000000","message":"Add DocImpact here to notify there is a doc impact, see \nhttps://review.openstack.org/#/c/222113/ \u0027s commit message for reference.","commit_id":"df60a5946c637233b404fa5c6904e97a3b52b387"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1eb1fea78e7de37d453bcfe1e7224d9ecae18197","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The overall time to wait is set by CONF.shutdown_timeout."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But the instance shutdown_retry_interval param is defined as a"},{"line_number":14,"context_line":"constant in the ComputeManager class.I think we should move it"},{"line_number":15,"context_line":"to the nova.conf file, so we can config it by ourself.It will"},{"line_number":16,"context_line":"be set to 10 seconds if the value is bigger than"},{"line_number":17,"context_line":"CONF.shutdown_timeout."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a68dd71_a8918554","line":14,"updated":"2016-01-26 20:16:01.000000000","message":"Add spaces after .\u0027s.","commit_id":"6ce33486590e470eb3e17a67346b00a0d9a3b09e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ea6ad8b9339ed0883ea2041237cdff985a6a8b4d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But the instance shutdown_retry_interval param is defined as a"},{"line_number":14,"context_line":"constant in the ComputeManager class.I think we should move it"},{"line_number":15,"context_line":"to the nova.conf file, so we can config it by ourself.It will"},{"line_number":16,"context_line":"be set to 10 seconds if the value is bigger than"},{"line_number":17,"context_line":"CONF.shutdown_timeout."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a68dd71_5012025a","line":15,"updated":"2016-01-26 07:47:43.000000000","message":"s/ourself/ourselves/","commit_id":"6ce33486590e470eb3e17a67346b00a0d9a3b09e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ea6ad8b9339ed0883ea2041237cdff985a6a8b4d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"to the nova.conf file, so we can config it by ourself.It will"},{"line_number":16,"context_line":"be set to 10 seconds if the value is bigger than"},{"line_number":17,"context_line":"CONF.shutdown_timeout."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib8c4c9d93256ed1707e065e39760ba5034b26545"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a68dd71_cd165d58","line":18,"updated":"2016-01-26 07:47:43.000000000","message":"I agree with Zhenyu. Add \u0027DocImpact\u0027 flag.","commit_id":"6ce33486590e470eb3e17a67346b00a0d9a3b09e"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1eb1fea78e7de37d453bcfe1e7224d9ecae18197","unresolved":false,"context_lines":[{"line_number":15,"context_line":"to the nova.conf file, so we can config it by ourself.It will"},{"line_number":16,"context_line":"be set to 10 seconds if the value is bigger than"},{"line_number":17,"context_line":"CONF.shutdown_timeout."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib8c4c9d93256ed1707e065e39760ba5034b26545"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a68dd71_48756930","line":18,"in_reply_to":"9a68dd71_cd165d58","updated":"2016-01-26 20:16:01.000000000","message":"Agreed. Needs DocImpact.","commit_id":"6ce33486590e470eb3e17a67346b00a0d9a3b09e"}],"nova/compute/manager.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"194c15a72d37c10adbc34ac27bb5f053e5392680","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                    \u0027image_volume_cache_enabled configuration option.\u0027),"},{"line_number":152,"context_line":"    cfg.IntOpt(\u0027shutdown_retry_interval\u0027,"},{"line_number":153,"context_line":"               default\u003d10,"},{"line_number":154,"context_line":"               help\u003d\u0027Number of times to retry shutdown instance. \u0027"},{"line_number":155,"context_line":"               \u0027Re-issuing a shutdown singal to an instance if the \u0027"},{"line_number":156,"context_line":"               \u0027shutdown operation failed during shutdown_timeout.\u0027)"},{"line_number":157,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_b07a7022","line":154,"updated":"2016-01-25 20:57:32.000000000","message":"Why not just use the comment from the existing code as the help text? Seems easier. Also this isn\u0027t \"number of times to retry\" it\u0027s \"How long to wait before re-issuing a shutdown signal\".","commit_id":"d73a8f7272a30055e3ce0336e5b668047c431276"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"194c15a72d37c10adbc34ac27bb5f053e5392680","unresolved":false,"context_lines":[{"line_number":153,"context_line":"               default\u003d10,"},{"line_number":154,"context_line":"               help\u003d\u0027Number of times to retry shutdown instance. \u0027"},{"line_number":155,"context_line":"               \u0027Re-issuing a shutdown singal to an instance if the \u0027"},{"line_number":156,"context_line":"               \u0027shutdown operation failed during shutdown_timeout.\u0027)"},{"line_number":157,"context_line":"    ]"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"interval_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_d0db644d","line":156,"updated":"2016-01-25 20:57:32.000000000","message":"singal -\u003e signal","commit_id":"d73a8f7272a30055e3ce0336e5b668047c431276"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f4eb4d317bd92b6077de70ba153c412a6ea0b791","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                    \"Set to 0 to disable.\"),"},{"line_number":240,"context_line":"    cfg.IntOpt(\"shutdown_timeout\","},{"line_number":241,"context_line":"               default\u003d60,"},{"line_number":242,"context_line":"               help\u003d\"Total amount of time to wait in seconds for an instance \""},{"line_number":243,"context_line":"               \"to perform a clean shutdown. Power off the instance immediately \""},{"line_number":244,"context_line":"               \"if setting to 0\"),"},{"line_number":245,"context_line":"]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"running_deleted_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_0a1ea06f","line":244,"range":{"start_line":242,"start_character":15,"end_line":244,"end_character":32},"updated":"2016-01-26 02:58:28.000000000","message":"nit : check the spaces.","commit_id":"df60a5946c637233b404fa5c6904e97a3b52b387"},{"author":{"_account_id":18777,"name":"Jinxing Fang","email":"fang.jinxing@99cloud.net","username":"jinxingfang"},"change_message_id":"725430ad9f1df66b91c951bfe0bfd7cdb2d630b3","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                    \"Set to 0 to disable.\"),"},{"line_number":240,"context_line":"    cfg.IntOpt(\"shutdown_timeout\","},{"line_number":241,"context_line":"               default\u003d60,"},{"line_number":242,"context_line":"               help\u003d\"Total amount of time to wait in seconds for an instance \""},{"line_number":243,"context_line":"               \"to perform a clean shutdown. Power off the instance immediately \""},{"line_number":244,"context_line":"               \"if setting to 0\"),"},{"line_number":245,"context_line":"]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"running_deleted_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_65574f58","line":244,"range":{"start_line":242,"start_character":15,"end_line":244,"end_character":32},"in_reply_to":"9a68dd71_0a1ea06f","updated":"2016-01-26 03:26:14.000000000","message":"thanks!","commit_id":"df60a5946c637233b404fa5c6904e97a3b52b387"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1eb1fea78e7de37d453bcfe1e7224d9ecae18197","unresolved":false,"context_lines":[{"line_number":154,"context_line":"               help\u003d\u0027Time interval to retry shutdown instance. \u0027"},{"line_number":155,"context_line":"                    \u0027How long to wait in seconds before re-issuing a shutdown \u0027"},{"line_number":156,"context_line":"                    \u0027signal to an instance during power off.  The overall \u0027"},{"line_number":157,"context_line":"                    \u0027time to wait is set by CONF.shutdown_timeout.It will be \u0027"},{"line_number":158,"context_line":"                    \u0027set to default if the value is bigger than \u0027"},{"line_number":159,"context_line":"                    \u0027CONF.shutdown_timeout.\u0027)"},{"line_number":160,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_282fd5f7","line":157,"updated":"2016-01-26 20:16:01.000000000","message":"Again, space after \u0027.\u0027 here.","commit_id":"6ce33486590e470eb3e17a67346b00a0d9a3b09e"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1eb1fea78e7de37d453bcfe1e7224d9ecae18197","unresolved":false,"context_lines":[{"line_number":2252,"context_line":"                          default\u003dCONF.shutdown_timeout)"},{"line_number":2253,"context_line":"            retry_interval \u003d CONF.shutdown_retry_interval"},{"line_number":2254,"context_line":"            if retry_interval \u003e\u003d timeout:"},{"line_number":2255,"context_line":"                LOG.warning(_LW(\u0027The instance shutdown retry interval is \u0027"},{"line_number":2256,"context_line":"                                \u0027bigger than instance shutdown timeout. \u0027"},{"line_number":2257,"context_line":"                                \u0027Setting it to default value 10 seconds.\u0027))"},{"line_number":2258,"context_line":"                retry_interval \u003d 10"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_e870ddde","line":2255,"updated":"2016-01-26 20:16:01.000000000","message":"Change these to be the actual config option names, i.e. shutdown_retry_interval and shutdown_timeout.","commit_id":"6ce33486590e470eb3e17a67346b00a0d9a3b09e"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1eb1fea78e7de37d453bcfe1e7224d9ecae18197","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"            retry_interval \u003d CONF.shutdown_retry_interval"},{"line_number":2254,"context_line":"            if retry_interval \u003e\u003d timeout:"},{"line_number":2255,"context_line":"                LOG.warning(_LW(\u0027The instance shutdown retry interval is \u0027"},{"line_number":2256,"context_line":"                                \u0027bigger than instance shutdown timeout. \u0027"},{"line_number":2257,"context_line":"                                \u0027Setting it to default value 10 seconds.\u0027))"},{"line_number":2258,"context_line":"                retry_interval \u003d 10"},{"line_number":2259,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_0849b18e","line":2256,"updated":"2016-01-26 20:16:01.000000000","message":"bigger than -\u003e greater than","commit_id":"6ce33486590e470eb3e17a67346b00a0d9a3b09e"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1eb1fea78e7de37d453bcfe1e7224d9ecae18197","unresolved":false,"context_lines":[{"line_number":2254,"context_line":"            if retry_interval \u003e\u003d timeout:"},{"line_number":2255,"context_line":"                LOG.warning(_LW(\u0027The instance shutdown retry interval is \u0027"},{"line_number":2256,"context_line":"                                \u0027bigger than instance shutdown timeout. \u0027"},{"line_number":2257,"context_line":"                                \u0027Setting it to default value 10 seconds.\u0027))"},{"line_number":2258,"context_line":"                retry_interval \u003d 10"},{"line_number":2259,"context_line":"        else:"},{"line_number":2260,"context_line":"            timeout \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_b30fb62d","line":2257,"updated":"2016-01-26 20:16:01.000000000","message":"it -\u003e shutdown_retry_interval","commit_id":"6ce33486590e470eb3e17a67346b00a0d9a3b09e"},{"author":{"_account_id":19912,"name":"Xuanzhou Perry Dong","email":"oss_xzdong@163.com","username":"oss_xzdong"},"change_message_id":"69fc3f04f883dd24ae2946d027a3ae97fcfa1e03","unresolved":false,"context_lines":[{"line_number":2256,"context_line":"                                \u0027greater than instance shutdown_timeout. \u0027"},{"line_number":2257,"context_line":"                                \u0027Setting shutdown_retry_interval to default \u0027"},{"line_number":2258,"context_line":"                                \u0027value 10 seconds.\u0027))"},{"line_number":2259,"context_line":"                retry_interval \u003d 10"},{"line_number":2260,"context_line":"        else:"},{"line_number":2261,"context_line":"            timeout \u003d 0"},{"line_number":2262,"context_line":"            retry_interval \u003d 0"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_e75f433f","line":2259,"updated":"2016-01-29 08:26:27.000000000","message":"Hardcoded default value here. Should have a common definition for the default value and refer to it.","commit_id":"b14ca44c2efca3b6f2025b15e83164eeeb8cd4ee"}]}