)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"143a7c04ea5991ec405af3759c627ff9e1fefff5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"with message \"VMwareDriverException: Invalid configuration for"},{"line_number":12,"context_line":"device \u00270\u0027\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So, this change will automatically create a new controller when the"},{"line_number":15,"context_line":"former controller\u0027s quota is used up."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes bug: #1522232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_323ab699","line":14,"updated":"2016-01-27 08:20:08.000000000","message":"Please help me understand: the logic to create a new controller (when all the possible unit numbers of existing SCSI controllers are taken) already exists. This patch is trying to update the code which is meant to create a new controller.","commit_id":"b20bc1e856e6e47858d2ef454dc3383cda123dc2"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"24761165eabe835a1f5b3486fa5ce075533fcd78","unresolved":false,"context_lines":[{"line_number":11,"context_line":"with message \"VMwareDriverException: Invalid configuration for"},{"line_number":12,"context_line":"device \u00270\u0027\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So, this change will automatically create a new controller when the"},{"line_number":15,"context_line":"former controller\u0027s quota is used up."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes bug: #1522232"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_58ad0987","line":14,"in_reply_to":"9a68dd71_323ab699","updated":"2016-01-27 09:22:49.000000000","message":"yes, you are right.\nWill update the commit message in next patch.","commit_id":"b20bc1e856e6e47858d2ef454dc3383cda123dc2"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"143a7c04ea5991ec405af3759c627ff9e1fefff5","unresolved":false,"context_lines":[{"line_number":774,"context_line":"                        constants.ADAPTER_TYPE_LSILOGICSAS,"},{"line_number":775,"context_line":"                        constants.ADAPTER_TYPE_BUSLOGIC,"},{"line_number":776,"context_line":"                        constants.ADAPTER_TYPE_PARAVIRTUAL]:"},{"line_number":777,"context_line":"        bus_number \u003d len(scsi_keys)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    controller_spec \u003d create_controller_spec(client_factory, controller_key,"},{"line_number":780,"context_line":"                                             adapter_type, bus_number)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_326156a9","line":777,"updated":"2016-01-27 08:20:08.000000000","message":"We should also check the limit on the number of SCSI controllers before creating a new one.","commit_id":"b20bc1e856e6e47858d2ef454dc3383cda123dc2"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"24761165eabe835a1f5b3486fa5ce075533fcd78","unresolved":false,"context_lines":[{"line_number":774,"context_line":"                        constants.ADAPTER_TYPE_LSILOGICSAS,"},{"line_number":775,"context_line":"                        constants.ADAPTER_TYPE_BUSLOGIC,"},{"line_number":776,"context_line":"                        constants.ADAPTER_TYPE_PARAVIRTUAL]:"},{"line_number":777,"context_line":"        bus_number \u003d len(scsi_keys)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    controller_spec \u003d create_controller_spec(client_factory, controller_key,"},{"line_number":780,"context_line":"                                             adapter_type, bus_number)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_58c4293f","line":777,"in_reply_to":"9a68dd71_326156a9","updated":"2016-01-27 09:22:49.000000000","message":"Please review patch set 3.","commit_id":"b20bc1e856e6e47858d2ef454dc3383cda123dc2"},{"author":{"_account_id":9581,"name":"Ren Qiaowei","email":"qiaowei.ren@intel.com","username":"qiaowei"},"change_message_id":"7ef9eb3fafa41a8025582b2f70623eff7ba2dd3e","unresolved":false,"context_lines":[{"line_number":781,"context_line":"    # create new controller with the specified type and return its spec"},{"line_number":782,"context_line":"    controller_key \u003d -101"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    # Check how many existing adaptors exists"},{"line_number":785,"context_line":"    # Set the bus_number based on the existing adaptors"},{"line_number":786,"context_line":"    bus_number \u003d 0"},{"line_number":787,"context_line":"    if adapter_type in [constants.DEFAULT_ADAPTER_TYPE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_2acda530","line":784,"range":{"start_line":784,"start_character":39,"end_line":784,"end_character":45},"updated":"2016-02-02 03:53:10.000000000","message":"exist","commit_id":"d73b05ff204d17feb1e38e059ecd08aed93024ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9f089181f21714f4cdb9f079f32802aa6cf44d14","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            return i"},{"line_number":752,"context_line":"    msg \u003d _(\u0027Only 4 SCSI controllers are allowed to be \u0027"},{"line_number":753,"context_line":"            \u0027created on this instance.\u0027)"},{"line_number":754,"context_line":"    raise vexc.VMwareDriverException(msg)"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"def allocate_controller_key_and_unit_number(client_factory, devices,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3afc51ec_5218b61d","line":754,"updated":"2016-03-12 16:10:00.000000000","message":"I don\u0027t see a unit test for this case.","commit_id":"6e9034dfeabb2d9b8c866f5de9bce73e1d18bb0a"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"15c503b23b491be15c95b989621b92165b413e11","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            return i"},{"line_number":752,"context_line":"    msg \u003d _(\u0027Only 4 SCSI controllers are allowed to be \u0027"},{"line_number":753,"context_line":"            \u0027created on this instance.\u0027)"},{"line_number":754,"context_line":"    raise vexc.VMwareDriverException(msg)"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"def allocate_controller_key_and_unit_number(client_factory, devices,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3afc51ec_f75e02e8","line":754,"in_reply_to":"3afc51ec_5218b61d","updated":"2016-03-14 02:53:16.000000000","message":"OK, will add.","commit_id":"6e9034dfeabb2d9b8c866f5de9bce73e1d18bb0a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9f089181f21714f4cdb9f079f32802aa6cf44d14","unresolved":false,"context_lines":[{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    # Get free bus number for new SCSI controller."},{"line_number":785,"context_line":"    bus_number \u003d 0"},{"line_number":786,"context_line":"    if adapter_type in [constants.DEFAULT_ADAPTER_TYPE,"},{"line_number":787,"context_line":"                        constants.ADAPTER_TYPE_LSILOGICSAS,"},{"line_number":788,"context_line":"                        constants.ADAPTER_TYPE_BUSLOGIC,"},{"line_number":789,"context_line":"                        constants.ADAPTER_TYPE_PARAVIRTUAL]:"},{"line_number":790,"context_line":"        bus_number \u003d _get_bus_number_for_scsi_controller(devices)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    controller_spec \u003d create_controller_spec(client_factory, controller_key,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3afc51ec_7204d2bf","line":789,"range":{"start_line":786,"start_character":23,"end_line":789,"end_character":59},"updated":"2016-03-12 16:10:00.000000000","message":"This list is duplicated above, can we define a constant in the constants module for this list and re-use it in both places please?","commit_id":"6e9034dfeabb2d9b8c866f5de9bce73e1d18bb0a"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"15c503b23b491be15c95b989621b92165b413e11","unresolved":false,"context_lines":[{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    # Get free bus number for new SCSI controller."},{"line_number":785,"context_line":"    bus_number \u003d 0"},{"line_number":786,"context_line":"    if adapter_type in [constants.DEFAULT_ADAPTER_TYPE,"},{"line_number":787,"context_line":"                        constants.ADAPTER_TYPE_LSILOGICSAS,"},{"line_number":788,"context_line":"                        constants.ADAPTER_TYPE_BUSLOGIC,"},{"line_number":789,"context_line":"                        constants.ADAPTER_TYPE_PARAVIRTUAL]:"},{"line_number":790,"context_line":"        bus_number \u003d _get_bus_number_for_scsi_controller(devices)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    controller_spec \u003d create_controller_spec(client_factory, controller_key,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3afc51ec_576ed696","line":789,"range":{"start_line":786,"start_character":23,"end_line":789,"end_character":59},"in_reply_to":"3afc51ec_7204d2bf","updated":"2016-03-14 02:53:16.000000000","message":"Good catch, will do.","commit_id":"6e9034dfeabb2d9b8c866f5de9bce73e1d18bb0a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"926e0a0571fa08f1214145f851000b19026227fa","unresolved":false,"context_lines":[{"line_number":745,"context_line":"    # Every SCSI controller will take a unique bus number"},{"line_number":746,"context_line":"    taken \u003d [dev.busNumber for dev in devices if _is_scsi_controller(dev)]"},{"line_number":747,"context_line":"    # The max bus number for SCSI controllers is 3"},{"line_number":748,"context_line":"    max_bus_number \u003d 3"},{"line_number":749,"context_line":"    for i in range(max_bus_number + 1):"},{"line_number":750,"context_line":"        if i not in taken:"},{"line_number":751,"context_line":"            return i"}],"source_content_type":"text/x-python","patch_set":16,"id":"1af94dfe_c56532e2","line":748,"range":{"start_line":748,"start_character":4,"end_line":748,"end_character":22},"updated":"2016-03-15 20:15:15.000000000","message":"nit: I might make this a constant like SCSI_MAX_CONNECT_NUMBER.","commit_id":"bd1373940942869d360f571795447c772ef6b105"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"bc1756c6540d08bdacd6ef578a02aea9bb1b05ae","unresolved":false,"context_lines":[{"line_number":745,"context_line":"    # Every SCSI controller will take a unique bus number"},{"line_number":746,"context_line":"    taken \u003d [dev.busNumber for dev in devices if _is_scsi_controller(dev)]"},{"line_number":747,"context_line":"    # The max bus number for SCSI controllers is 3"},{"line_number":748,"context_line":"    max_bus_number \u003d 3"},{"line_number":749,"context_line":"    for i in range(max_bus_number + 1):"},{"line_number":750,"context_line":"        if i not in taken:"},{"line_number":751,"context_line":"            return i"}],"source_content_type":"text/x-python","patch_set":16,"id":"1af94dfe_1cabe81e","line":748,"range":{"start_line":748,"start_character":4,"end_line":748,"end_character":22},"in_reply_to":"1af94dfe_c56532e2","updated":"2016-03-16 02:00:54.000000000","message":"Good idea. Will do.","commit_id":"bd1373940942869d360f571795447c772ef6b105"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"926e0a0571fa08f1214145f851000b19026227fa","unresolved":false,"context_lines":[{"line_number":749,"context_line":"    for i in range(max_bus_number + 1):"},{"line_number":750,"context_line":"        if i not in taken:"},{"line_number":751,"context_line":"            return i"},{"line_number":752,"context_line":"    msg \u003d _(\u0027Only 4 SCSI controllers are allowed to be \u0027"},{"line_number":753,"context_line":"            \u0027created on this instance.\u0027)"},{"line_number":754,"context_line":"    raise vexc.VMwareDriverException(msg)"},{"line_number":755,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1af94dfe_85cfaaaf","line":752,"range":{"start_line":752,"start_character":18,"end_line":752,"end_character":19},"updated":"2016-03-15 20:15:15.000000000","message":"4? or 3?","commit_id":"bd1373940942869d360f571795447c772ef6b105"},{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"bc1756c6540d08bdacd6ef578a02aea9bb1b05ae","unresolved":false,"context_lines":[{"line_number":749,"context_line":"    for i in range(max_bus_number + 1):"},{"line_number":750,"context_line":"        if i not in taken:"},{"line_number":751,"context_line":"            return i"},{"line_number":752,"context_line":"    msg \u003d _(\u0027Only 4 SCSI controllers are allowed to be \u0027"},{"line_number":753,"context_line":"            \u0027created on this instance.\u0027)"},{"line_number":754,"context_line":"    raise vexc.VMwareDriverException(msg)"},{"line_number":755,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1af94dfe_1cf2c8d2","line":752,"range":{"start_line":752,"start_character":18,"end_line":752,"end_character":19},"in_reply_to":"1af94dfe_85cfaaaf","updated":"2016-03-16 02:00:54.000000000","message":"it\u0027s 4: 0,1,2,3\n\nThe max bus number is 3.","commit_id":"bd1373940942869d360f571795447c772ef6b105"}]}