)]}'
{"nova/network/manager.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"cec97019eba85fd123d4b7fd51dda28448354e4e","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"            return"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        network_uuids \u003d [uuid for (uuid, fixed_ip) in networks]"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        self._get_networks_by_uuids(context, network_uuids)"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"        for network_uuid, address in networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fv8c%3D","line":1310,"updated":"2013-04-24 22:03:43.000000000","message":"This is not strictly related to your change, but I was trying to understand the test case changes and ran across it.  Can anyone explain why this call happens?  We\u0027re just throwing away the return value, so it seems unnecessary to me.\n\nI think that makes line 1309 superfluous too since it\u0027s only used for this call.","commit_id":"ecf51e3d8afd42e15197f76aa57c57e9c6ee4262"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"a62db97fe776a5015cba89cd8734cd7b35427b3c","unresolved":false,"context_lines":[{"line_number":1307,"context_line":"            return"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"        network_uuids \u003d [uuid for (uuid, fixed_ip) in networks]"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        self._get_networks_by_uuids(context, network_uuids)"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"        for network_uuid, address in networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FsRI%3D","line":1310,"in_reply_to":"AAAAOn%2F%2Fv8c%3D","updated":"2013-04-28 05:04:21.000000000","message":"This call will check the networks those caller required (such as end user who post provisioning request) are existed. db.network_get_all_by_uuids can raise NoNetworksFound exception. IMO.","commit_id":"ecf51e3d8afd42e15197f76aa57c57e9c6ee4262"}],"nova/tests/network/test_manager.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"cbfd13930dc4d17d50ba92aef49ed2130617a01d","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"        res \u003d self.network._get_networks_by_uuids(self.context,"},{"line_number":1251,"context_line":"                                                  requested_networks)"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"        self.assertTrue(res[0][\u0027id\u0027], 1)"},{"line_number":1254,"context_line":"        self.assertTrue(res[0][\u0027id\u0027], 0)"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Fl7M%3D","line":1253,"updated":"2013-05-02 15:47:30.000000000","message":"These asserts are not correct.  assertTrue is not what you want to be using here - the second parameter is a message, not a value to compare to.  Probably want assertEqual instead.","commit_id":"6ebefc02d1bfc0635476e16a9fd7a8e0c5a78dc5"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"f2a0614dcf521f362c75a0b01a602e470839d9d4","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"        res \u003d self.network._get_networks_by_uuids(self.context,"},{"line_number":1251,"context_line":"                                                  requested_networks)"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"        self.assertTrue(res[0][\u0027id\u0027], 1)"},{"line_number":1254,"context_line":"        self.assertTrue(res[0][\u0027id\u0027], 0)"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FlHY%3D","line":1253,"in_reply_to":"AAAAOn%2F%2Fl7M%3D","updated":"2013-05-03 02:36:54.000000000","message":"Oops, my mistake :). Thanks,","commit_id":"6ebefc02d1bfc0635476e16a9fd7a8e0c5a78dc5"}]}