)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e2c360a6c7c21b1a7dfa269a5f56dfda1d146cad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"API: Rearrange HTTPBadRequest raising in _resize"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aimed to fix AutoDiskConfigDisabledByImage exception is"},{"line_number":10,"context_line":"excpeced for 2 times, besides, rearrange HTTPBadRequest to group them"},{"line_number":11,"context_line":"around each other for easy reading."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"P.S. Don\u0027t touch any logic so no UT need to be added/changed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_8311dbb1","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":9},"updated":"2016-01-27 07:30:41.000000000","message":"excepted","commit_id":"3b77ea6cd12644fd980a6293f5bc708619d8deb4"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"5c8dc39f189f6db97ea429064324f4f33b9bc142","unresolved":false,"context_lines":[{"line_number":7,"context_line":"API: Rearrange HTTPBadRequest raising in _resize"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aimed to fix AutoDiskConfigDisabledByImage exception is"},{"line_number":10,"context_line":"excpeced for 2 times, besides, rearrange HTTPBadRequest to group them"},{"line_number":11,"context_line":"around each other for easy reading."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"P.S. Don\u0027t touch any logic so no UT need to be added/changed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_cf561506","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":9},"in_reply_to":"9a68dd71_8311dbb1","updated":"2016-01-27 07:39:36.000000000","message":"Thanks gman, will update if requires respin.","commit_id":"3b77ea6cd12644fd980a6293f5bc708619d8deb4"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a12be30634245d98db4ead481cb9af5a4c1616be","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                    \"the instance was started with.\")"},{"line_number":913,"context_line":"            raise exc.HTTPUnauthorized(explanation\u003dmsg)"},{"line_number":914,"context_line":"        except exception.FlavorNotFound:"},{"line_number":915,"context_line":"            msg \u003d _(\"Unable to locate requested flavor.\")"},{"line_number":916,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":917,"context_line":"        except exception.CannotResizeToSameFlavor:"},{"line_number":918,"context_line":"            msg \u003d _(\"Resize requires a flavor change.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_3e960f4d","line":915,"range":{"start_line":915,"start_character":12,"end_line":915,"end_character":57},"updated":"2016-01-28 06:16:17.000000000","message":"I\u0027m curious why we not just use the message in the exception. like just use e.format_message(). Then we can just group them together","commit_id":"3b77ea6cd12644fd980a6293f5bc708619d8deb4"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"4f0ee68dc0c9d70e595de692e1871e2fd14f5595","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                    \"the instance was started with.\")"},{"line_number":913,"context_line":"            raise exc.HTTPUnauthorized(explanation\u003dmsg)"},{"line_number":914,"context_line":"        except exception.FlavorNotFound:"},{"line_number":915,"context_line":"            msg \u003d _(\"Unable to locate requested flavor.\")"},{"line_number":916,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":917,"context_line":"        except exception.CannotResizeToSameFlavor:"},{"line_number":918,"context_line":"            msg \u003d _(\"Resize requires a flavor change.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_3e55af4f","line":915,"range":{"start_line":915,"start_character":12,"end_line":915,"end_character":57},"in_reply_to":"7a5de9d1_3e960f4d","updated":"2016-01-28 06:38:17.000000000","message":"Hi Alex, actually , I\u0027v notice this. But to be honest, if some one others do this, there should be some special reason. But I don\u0027t know, they are ported from old v2 api.\n\nclass FlavorNotFound(NotFound):\n    msg_fmt \u003d _(\"Flavor %(flavor_id)s could not be found.\")\nthe msg will be expose to user with an flavor_id. it\u0027s much friendly.","commit_id":"3b77ea6cd12644fd980a6293f5bc708619d8deb4"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a12be30634245d98db4ead481cb9af5a4c1616be","unresolved":false,"context_lines":[{"line_number":915,"context_line":"            msg \u003d _(\"Unable to locate requested flavor.\")"},{"line_number":916,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":917,"context_line":"        except exception.CannotResizeToSameFlavor:"},{"line_number":918,"context_line":"            msg \u003d _(\"Resize requires a flavor change.\")"},{"line_number":919,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":920,"context_line":"        except exception.ImageNotFound:"},{"line_number":921,"context_line":"            msg \u003d _(\"Image that the instance was started \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_be88bf23","line":918,"range":{"start_line":918,"start_character":12,"end_line":918,"end_character":55},"updated":"2016-01-28 06:16:17.000000000","message":"ditto","commit_id":"3b77ea6cd12644fd980a6293f5bc708619d8deb4"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"4f0ee68dc0c9d70e595de692e1871e2fd14f5595","unresolved":false,"context_lines":[{"line_number":915,"context_line":"            msg \u003d _(\"Unable to locate requested flavor.\")"},{"line_number":916,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":917,"context_line":"        except exception.CannotResizeToSameFlavor:"},{"line_number":918,"context_line":"            msg \u003d _(\"Resize requires a flavor change.\")"},{"line_number":919,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":920,"context_line":"        except exception.ImageNotFound:"},{"line_number":921,"context_line":"            msg \u003d _(\"Image that the instance was started \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_9e72a3e4","line":918,"range":{"start_line":918,"start_character":12,"end_line":918,"end_character":55},"in_reply_to":"7a5de9d1_be88bf23","updated":"2016-01-28 06:38:17.000000000","message":"class CannotResizeToSameFlavor(NovaException):\n    msg_fmt \u003d _(\"When resizing, instances must change flavor!\")\n\nyeah, this is okay, we expose \"When resizing, instances must change flavor!\" to users.","commit_id":"3b77ea6cd12644fd980a6293f5bc708619d8deb4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95a9c803c11c0b9e4bc9a5180421d5507ad70cbe","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                exception.CannotResizeDisk,"},{"line_number":916,"context_line":"                exception.CannotResizeToSameFlavor,"},{"line_number":917,"context_line":"                exception.FlavorNotFound,"},{"line_number":918,"context_line":"                exception.ImageNotFound,"},{"line_number":919,"context_line":"                exception.NoValidHost) as e:"},{"line_number":920,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":921,"context_line":"        except exception.Invalid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_c70a8ad2","line":918,"range":{"start_line":918,"start_character":39,"end_line":918,"end_character":40},"updated":"2016-01-28 08:09:09.000000000","message":"Nice cleanup for others exception but for ImageNotFound, I am wondering old msg was more appropriate than \n\"Image %(image_id)s could not be found.\"","commit_id":"c619d6aecfd57b95e93ec1921bc057340e355a63"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"6d7649f6a5d301764a50019d30a2f0c05bb1d221","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                exception.CannotResizeDisk,"},{"line_number":916,"context_line":"                exception.CannotResizeToSameFlavor,"},{"line_number":917,"context_line":"                exception.FlavorNotFound,"},{"line_number":918,"context_line":"                exception.ImageNotFound,"},{"line_number":919,"context_line":"                exception.NoValidHost) as e:"},{"line_number":920,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"},{"line_number":921,"context_line":"        except exception.Invalid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_270d9e3e","line":918,"range":{"start_line":918,"start_character":39,"end_line":918,"end_character":40},"in_reply_to":"7a5de9d1_c70a8ad2","updated":"2016-01-28 08:29:44.000000000","message":"Done","commit_id":"c619d6aecfd57b95e93ec1921bc057340e355a63"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"23df590b6ad09cffd189092ebc2b0d905eea1c80","unresolved":false,"context_lines":[{"line_number":917,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":918,"context_line":"        except (exception.AutoDiskConfigDisabledByImage,"},{"line_number":919,"context_line":"                exception.CannotResizeDisk,"},{"line_number":920,"context_line":"                exception.CannotResizeToSameFlavor,"},{"line_number":921,"context_line":"                exception.FlavorNotFound,"},{"line_number":922,"context_line":"                exception.NoValidHost) as e:"},{"line_number":923,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_3750fbd3","line":920,"updated":"2016-01-30 14:05:49.000000000","message":"The exception message of this exception expects a param to be passed (flavor), and hence passing a generic msg e.format_message() won\u0027t print out great.","commit_id":"b08e6e7a83565a13b0d8747d21d4e0c60eaebcb3"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"b1091695803b56e30cdb8f43e647de02f1f4eac2","unresolved":false,"context_lines":[{"line_number":917,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":918,"context_line":"        except (exception.AutoDiskConfigDisabledByImage,"},{"line_number":919,"context_line":"                exception.CannotResizeDisk,"},{"line_number":920,"context_line":"                exception.CannotResizeToSameFlavor,"},{"line_number":921,"context_line":"                exception.FlavorNotFound,"},{"line_number":922,"context_line":"                exception.NoValidHost) as e:"},{"line_number":923,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_a4aeac2b","line":920,"in_reply_to":"7a5de9d1_3750fbd3","updated":"2016-02-02 02:49:01.000000000","message":"hi Rushi,\nAre you talking about this ? https://github.com/openstack/nova/blob/master/nova/exception.py#L1321\n\nI am sorry, I don\u0027t get you too match.\n\nThink about how user will do if they do a resize\nusually, he will do\n\u0027nova resize $myserver $new_flavor\u0027\nhence user will get to know what the $new_flavor would like, in our case, we raise an exception and print out that \"When resizing, instances must change flavor!\", and user will get to know that $new_flavor he just input was the same one with the instances used, I think this make sense.","commit_id":"b08e6e7a83565a13b0d8747d21d4e0c60eaebcb3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4c4a581205f933063e064be369861660c4ea5fe8","unresolved":false,"context_lines":[{"line_number":917,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":918,"context_line":"        except (exception.AutoDiskConfigDisabledByImage,"},{"line_number":919,"context_line":"                exception.CannotResizeDisk,"},{"line_number":920,"context_line":"                exception.CannotResizeToSameFlavor,"},{"line_number":921,"context_line":"                exception.FlavorNotFound,"},{"line_number":922,"context_line":"                exception.NoValidHost) as e:"},{"line_number":923,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_da362050","line":920,"in_reply_to":"7a5de9d1_a4aeac2b","updated":"2016-02-02 06:07:44.000000000","message":"The changed exceptions(FlavorNoyFound, CannotResizeToSameFlavor) contain enough message as them, so this patch seems good for me.","commit_id":"b08e6e7a83565a13b0d8747d21d4e0c60eaebcb3"}]}