)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"a44a0063ab23c47665a14c980f17128853c203cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Elliott \u003cbdelliott@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-04-24 09:57:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send a \u0027create.error\u0027 notif if run_instance fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will make it easier for external notification consuming systems to"},{"line_number":10,"context_line":"learn when instance build attempts fail within the nova-compute layer."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAOn%2F%2Fuiw%3D","line":7,"updated":"2013-04-25 22:02:47.000000000","message":"notif?","commit_id":"e1dbaf15fcb53409a4c9b0cdc6bfd66d435fa963"}],"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b7189e5f6392a773ffa4bb43a4dbeb0618c6918e","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        extra_usage_info \u003d {}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        def notify(status):"},{"line_number":841,"context_line":"            \"\"\"Send a create.{start,error, end} notification.\"\"\""},{"line_number":842,"context_line":"            type_ \u003d \"create.%(status)s\" % dict(status\u003dstatus)"},{"line_number":843,"context_line":"            self._notify_about_instance_usage(context, instance, type_,"},{"line_number":844,"context_line":"                    extra_usage_info\u003dextra_usage_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FxnI%3D","line":841,"updated":"2013-04-23 19:35:57.000000000","message":"femtonit: Decide on a spacing inside the docstring braces; i.e., \"{start, error, end}\" or \"{start,error,end}\"","commit_id":"cc22bc465ff8adb28075807925e5d0a533665e65"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"80ff6ec1313d932a0dce42c55615bc4636936618","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        extra_usage_info \u003d {}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        def notify(status):"},{"line_number":841,"context_line":"            \"\"\"Send a create.{start,error, end} notification.\"\"\""},{"line_number":842,"context_line":"            type_ \u003d \"create.%(status)s\" % dict(status\u003dstatus)"},{"line_number":843,"context_line":"            self._notify_about_instance_usage(context, instance, type_,"},{"line_number":844,"context_line":"                    extra_usage_info\u003dextra_usage_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fxmk%3D","line":841,"in_reply_to":"AAAAOn%2F%2FxnI%3D","updated":"2013-04-23 19:37:20.000000000","message":"Done","commit_id":"cc22bc465ff8adb28075807925e5d0a533665e65"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"92f1ed1245a4ebd90e76ea3f07590443bbceb5c2","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        except exception.BuildAbortException as e:"},{"line_number":859,"context_line":"            # Instance build encountered an error, but the instance"},{"line_number":860,"context_line":"            # should not go to error."},{"line_number":861,"context_line":"            LOG.info(e)"},{"line_number":862,"context_line":"            notify(\"error\")  # notify that something went wrong"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FxOo%3D","line":861,"updated":"2013-04-23 23:28:56.000000000","message":"Do we need the LOG.info here since there is a log statement in line 877?","commit_id":"6a4dc43d50325ee7b57a31a52c7ece202788dc99"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"0378e0e00b34d418809d9347d93521e40e0497da","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        except exception.BuildAbortException as e:"},{"line_number":859,"context_line":"            # Instance build encountered an error, but the instance"},{"line_number":860,"context_line":"            # should not go to error."},{"line_number":861,"context_line":"            LOG.info(e)"},{"line_number":862,"context_line":"            notify(\"error\")  # notify that something went wrong"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FxH8%3D","line":861,"in_reply_to":"AAAAOn%2F%2FxOo%3D","updated":"2013-04-24 02:17:12.000000000","message":"I will kill the one on 877","commit_id":"6a4dc43d50325ee7b57a31a52c7ece202788dc99"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"ce39140c226fe0e988a8c5abde4f3b1dc5566650","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        def notify(status, msg\u003dNone):"},{"line_number":841,"context_line":"            \"\"\"Send a create.{start,error,end} notification.\"\"\""},{"line_number":842,"context_line":"            type_ \u003d \"create.%(status)s\" % dict(status\u003dstatus)"},{"line_number":843,"context_line":"            info \u003d extra_usage_info.copy()"},{"line_number":844,"context_line":"            if not msg:"},{"line_number":845,"context_line":"                msg \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FwZo%3D","line":842,"updated":"2013-04-24 17:35:25.000000000","message":"Hmm, should the .error go on the \u003cnotification_queue\u003e.error queue or on the .info queue? I\u0027m thinking the .error queue.","commit_id":"4105f2a3beeeb57a526b603135079f0a7192dcea"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"cf87d9434bc2deb015485c63d2b4e5fc8ef54c77","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        def notify(status, msg\u003dNone):"},{"line_number":841,"context_line":"            \"\"\"Send a create.{start,error,end} notification.\"\"\""},{"line_number":842,"context_line":"            type_ \u003d \"create.%(status)s\" % dict(status\u003dstatus)"},{"line_number":843,"context_line":"            info \u003d extra_usage_info.copy()"},{"line_number":844,"context_line":"            if not msg:"},{"line_number":845,"context_line":"                msg \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FwVs%3D","line":842,"in_reply_to":"AAAAOn%2F%2FwZo%3D","updated":"2013-04-24 18:18:17.000000000","message":"good idea.","commit_id":"4105f2a3beeeb57a526b603135079f0a7192dcea"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"ce39140c226fe0e988a8c5abde4f3b1dc5566650","unresolved":false,"context_lines":[{"line_number":965,"context_line":"            if rescheduled:"},{"line_number":966,"context_line":"                # log the original build error"},{"line_number":967,"context_line":"                self._log_original_error(exc_info, instance[\u0027uuid\u0027])"},{"line_number":968,"context_line":"                raise exception.RescheduledException("},{"line_number":969,"context_line":"                        instance_uuid\u003dinstance[\u0027uuid\u0027],"},{"line_number":970,"context_line":"                        reason\u003dunicode(exc_info[1]))"},{"line_number":971,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FwZQ%3D","line":968,"updated":"2013-04-24 17:35:25.000000000","message":"the old way of doing a reschedule wasn\u0027t to raise an exception, will this still work if we raise?\n\nI *think* it will since the call back to the scheduler is essentially like a fresh call from the api, yes?","commit_id":"4105f2a3beeeb57a526b603135079f0a7192dcea"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"cf87d9434bc2deb015485c63d2b4e5fc8ef54c77","unresolved":false,"context_lines":[{"line_number":965,"context_line":"            if rescheduled:"},{"line_number":966,"context_line":"                # log the original build error"},{"line_number":967,"context_line":"                self._log_original_error(exc_info, instance[\u0027uuid\u0027])"},{"line_number":968,"context_line":"                raise exception.RescheduledException("},{"line_number":969,"context_line":"                        instance_uuid\u003dinstance[\u0027uuid\u0027],"},{"line_number":970,"context_line":"                        reason\u003dunicode(exc_info[1]))"},{"line_number":971,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FwVg%3D","line":968,"in_reply_to":"AAAAOn%2F%2FwZQ%3D","updated":"2013-04-24 18:18:17.000000000","message":"Yes, the cast back to scheduler is already made before the exception is raised here.  You are correct that it is like a fresh call from the API.  The only difference is that the request_spec gets annotated with the information about hosts previously attempted.","commit_id":"4105f2a3beeeb57a526b603135079f0a7192dcea"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b7189e5f6392a773ffa4bb43a4dbeb0618c6918e","unresolved":false,"context_lines":[{"line_number":8452,"context_line":"            (\u0027/d/e/f\u0027, base64.b64encode(\u0027seespotrun\u0027)),"},{"line_number":8453,"context_line":"        ]"},{"line_number":8454,"context_line":""},{"line_number":8455,"context_line":"        def _roe(context, instance, exc_info, requested_networks,"},{"line_number":8456,"context_line":"                 admin_password, injected_files, is_first_time, request_spec,"},{"line_number":8457,"context_line":"                 filter_properties, bdms\u003dNone):"},{"line_number":8458,"context_line":"            self.assertEqual(expected, injected_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fxm0%3D","line":8455,"updated":"2013-04-23 19:35:57.000000000","message":"roe, roe, roe your boat…","commit_id":"cc22bc465ff8adb28075807925e5d0a533665e65"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"80ff6ec1313d932a0dce42c55615bc4636936618","unresolved":false,"context_lines":[{"line_number":8452,"context_line":"            (\u0027/d/e/f\u0027, base64.b64encode(\u0027seespotrun\u0027)),"},{"line_number":8453,"context_line":"        ]"},{"line_number":8454,"context_line":""},{"line_number":8455,"context_line":"        def _roe(context, instance, exc_info, requested_networks,"},{"line_number":8456,"context_line":"                 admin_password, injected_files, is_first_time, request_spec,"},{"line_number":8457,"context_line":"                 filter_properties, bdms\u003dNone):"},{"line_number":8458,"context_line":"            self.assertEqual(expected, injected_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fxmo%3D","line":8455,"in_reply_to":"AAAAOn%2F%2Fxm0%3D","updated":"2013-04-23 19:37:20.000000000","message":"or better yet, just make sushi","commit_id":"cc22bc465ff8adb28075807925e5d0a533665e65"}]}