)]}'
{"nova/conf/__init__.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"61e6ba81e1dc291919fdfd4e0dcfac0f06e0e73b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# from nova.conf import api_database"},{"line_number":24,"context_line":"# from nova.conf import availability_zone"},{"line_number":25,"context_line":"# from nova.conf import aws"},{"line_number":26,"context_line":"# from nova.conf import barbican"},{"line_number":27,"context_line":"# from nova.conf import base"},{"line_number":28,"context_line":"# from nova.conf import cells"},{"line_number":29,"context_line":"from nova.conf import cert"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_17627bd8","line":26,"updated":"2016-02-16 16:59:56.000000000","message":"I think we need to import barbican as well","commit_id":"23f8e92922578a0b760981db1743304b8e8e554d"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"61e6ba81e1dc291919fdfd4e0dcfac0f06e0e73b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"# api_database.register_opts(CONF)"},{"line_number":84,"context_line":"# availability_zone.register_opts(CONF)"},{"line_number":85,"context_line":"# aws.register_opts(CONF)"},{"line_number":86,"context_line":"# barbican.register_opts(CONF)"},{"line_number":87,"context_line":"# base.register_opts(CONF)"},{"line_number":88,"context_line":"# cells.register_opts(CONF)"},{"line_number":89,"context_line":"cert.register_opts(CONF)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_b7a7e709","line":86,"updated":"2016-02-16 16:59:56.000000000","message":"we should register barbican options","commit_id":"23f8e92922578a0b760981db1743304b8e8e554d"}],"nova/conf/barbican.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3033f459e7785488b03be4e03a63c89d3ce1f282","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def list_opts():"},{"line_number":45,"context_line":"    return {"},{"line_number":46,"context_line":"        barbican_group.name: barbican_opts"},{"line_number":47,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_dadf0fd4","line":46,"range":{"start_line":46,"start_character":23,"end_line":46,"end_character":27},"updated":"2016-03-24 12:13:55.000000000","message":"Nit: we can drop the name here now, but lets do a global tidy up on those.","commit_id":"3fd75531cbe583c4885b7c2b0b145063087d6195"}],"nova/conf/keymgr.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"61e6ba81e1dc291919fdfd4e0dcfac0f06e0e73b","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def list_opts():"},{"line_number":60,"context_line":"    return {"},{"line_number":61,"context_line":"        keymgr_group.name: keymgr_opts,"},{"line_number":62,"context_line":"        barbican_group.name: barbican_opts"},{"line_number":63,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_37b9b715","line":61,"updated":"2016-02-16 16:59:56.000000000","message":"I think using just the group like barbican_group and kymgr_group instead of keymgr_group.name and barbican_group.name should be good.","commit_id":"23f8e92922578a0b760981db1743304b8e8e554d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3033f459e7785488b03be4e03a63c89d3ce1f282","unresolved":false,"context_lines":[{"line_number":22,"context_line":"keymgr_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027api_class\u0027,"},{"line_number":24,"context_line":"               default\u003d\u0027nova.keymgr.conf_key_mgr.ConfKeyManager\u0027,"},{"line_number":25,"context_line":"               help\u003d\u0027The full class name of the key manager API class\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt("},{"line_number":27,"context_line":"        \u0027fixed_key\u0027,"},{"line_number":28,"context_line":"        help\u003d\u0027Fixed key returned by key manager, specified in hex\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_daf6ef5b","line":25,"updated":"2016-03-24 12:13:55.000000000","message":"Nit: I don\u0027t like the indent, but we need to fix the descriptions anyways, so thats OK.\n\nAs an aside, we need to fix up this config to use stevdore","commit_id":"3fd75531cbe583c4885b7c2b0b145063087d6195"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"159aeb804f9f2c666f3091e5fc2b2ba1045d76ef","unresolved":false,"context_lines":[{"line_number":22,"context_line":"keymgr_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027api_class\u0027,"},{"line_number":24,"context_line":"               default\u003d\u0027nova.keymgr.conf_key_mgr.ConfKeyManager\u0027,"},{"line_number":25,"context_line":"               help\u003d\u0027The full class name of the key manager API class\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt("},{"line_number":27,"context_line":"        \u0027fixed_key\u0027,"},{"line_number":28,"context_line":"        help\u003d\u0027Fixed key returned by key manager, specified in hex\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_55a7500a","line":25,"in_reply_to":"fa0719c6_daf6ef5b","updated":"2016-03-24 12:16:27.000000000","message":"Thanks, I will do it more carefully for later patches.","commit_id":"3fd75531cbe583c4885b7c2b0b145063087d6195"}],"nova/keymgr/__init__.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"61e6ba81e1dc291919fdfd4e0dcfac0f06e0e73b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import nova.conf"},{"line_number":18,"context_line":"from oslo_utils import importutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"CONF \u003d nova.conf.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_371bf7cb","line":17,"updated":"2016-02-16 16:59:56.000000000","message":"nit: nova import should be in a different group.","commit_id":"23f8e92922578a0b760981db1743304b8e8e554d"}],"nova/keymgr/barbican.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"61e6ba81e1dc291919fdfd4e0dcfac0f06e0e73b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from barbicanclient import client as barbican_client"},{"line_number":25,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":26,"context_line":"from keystoneauth1 import session"},{"line_number":27,"context_line":"import nova.conf"},{"line_number":28,"context_line":"from oslo_log import log as logging"},{"line_number":29,"context_line":"from oslo_utils import excutils"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_77f88fc3","line":27,"updated":"2016-02-16 16:59:56.000000000","message":"nit: This should be in the below grouping (OpenStack libraries group)","commit_id":"23f8e92922578a0b760981db1743304b8e8e554d"}]}