)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d811b945b002315deb8d2782c56047106f49712","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix bug in db.instance_type_destroy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix db.instance_type_destroy()"},{"line_number":10,"context_line":"Coresponding instance_type_projects weren\u0027t deleted"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fix db.instance_type_acces_get_by_flavor_id method"},{"line_number":13,"context_line":"Return [] list if there is no such instance_type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAOn%2F%2Fwbg%3D","line":10,"updated":"2013-04-24 16:42:14.000000000","message":"NIT: Should \u0027Coresponding\u0027 be \u0027Corresponding\u0027","commit_id":"463a21e3e9e8d9699c4e652d09f12c032cd408ce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8c6ab0d07ebcedee3494386cc770d0b0dbc68d4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix bug in db.instance_type_destroy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix db.instance_type_destroy()"},{"line_number":10,"context_line":"Coresponding instance_type_projects weren\u0027t deleted"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fix db.instance_type_acces_get_by_flavor_id method"},{"line_number":13,"context_line":"Return [] list if there is no such instance_type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAOn%2F%2FwJg%3D","line":10,"in_reply_to":"AAAAOn%2F%2Fwbg%3D","updated":"2013-04-24 19:48:49.000000000","message":"thanks fixing","commit_id":"463a21e3e9e8d9699c4e652d09f12c032cd408ce"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"aabb5f50af07fab7dbe241b19ae2a00f7e5f7fc8","unresolved":false,"context_lines":[{"line_number":3761,"context_line":"        session.query(models.InstanceTypeExtraSpecs).\\"},{"line_number":3762,"context_line":"                filter_by(instance_type_id\u003dinstance_type_id).\\"},{"line_number":3763,"context_line":"                soft_delete()"},{"line_number":3764,"context_line":"        model_query(context, models.InstanceTypeProjects,"},{"line_number":3765,"context_line":"                    session\u003dsession, read_deleted\u003d\"no\").\\"},{"line_number":3766,"context_line":"                filter_by(instance_type_id\u003dinstance_type_id).\\"},{"line_number":3767,"context_line":"                soft_delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FwQQ%3D","line":3764,"updated":"2013-04-24 18:49:30.000000000","message":"Why use model_query() here when the two lines above it just use session.query()?  Should all 3 use the model_query() wrapper?","commit_id":"463a21e3e9e8d9699c4e652d09f12c032cd408ce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8c6ab0d07ebcedee3494386cc770d0b0dbc68d4f","unresolved":false,"context_lines":[{"line_number":3761,"context_line":"        session.query(models.InstanceTypeExtraSpecs).\\"},{"line_number":3762,"context_line":"                filter_by(instance_type_id\u003dinstance_type_id).\\"},{"line_number":3763,"context_line":"                soft_delete()"},{"line_number":3764,"context_line":"        model_query(context, models.InstanceTypeProjects,"},{"line_number":3765,"context_line":"                    session\u003dsession, read_deleted\u003d\"no\").\\"},{"line_number":3766,"context_line":"                filter_by(instance_type_id\u003dinstance_type_id).\\"},{"line_number":3767,"context_line":"                soft_delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FwKI%3D","line":3764,"in_reply_to":"AAAAOn%2F%2FwQQ%3D","updated":"2013-04-24 19:48:49.000000000","message":"Yes I agree that it should be done through model_query, but such change is refactoring (and patch just fix bug).\n\nI refactored this method in next patch","commit_id":"463a21e3e9e8d9699c4e652d09f12c032cd408ce"}],"nova/tests/test_db_api.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b3fd021e5ed255f28dba5e2da47e7ec521f4baba","unresolved":false,"context_lines":[{"line_number":2357,"context_line":"            (inst_type1[\u0027flavorid\u0027], \u0027p2\u0027),"},{"line_number":2358,"context_line":"            (inst_type2[\u0027flavorid\u0027], \u0027p3\u0027)"},{"line_number":2359,"context_line":"        ]"},{"line_number":2360,"context_line":"        accesses \u003d [self._create_inst_type_access(*v) for v in values]"},{"line_number":2361,"context_line":"        db.instance_type_destroy(self.ctxt, inst_type1[\u0027name\u0027])"},{"line_number":2362,"context_line":""},{"line_number":2363,"context_line":"        p \u003d (self.ctxt, inst_type1[\u0027flavorid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FwcU%3D","line":2360,"updated":"2013-04-24 16:36:43.000000000","message":"I don\u0027t see accesses used anywhere.  Was that intentional?","commit_id":"463a21e3e9e8d9699c4e652d09f12c032cd408ce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8c6ab0d07ebcedee3494386cc770d0b0dbc68d4f","unresolved":false,"context_lines":[{"line_number":2357,"context_line":"            (inst_type1[\u0027flavorid\u0027], \u0027p2\u0027),"},{"line_number":2358,"context_line":"            (inst_type2[\u0027flavorid\u0027], \u0027p3\u0027)"},{"line_number":2359,"context_line":"        ]"},{"line_number":2360,"context_line":"        accesses \u003d [self._create_inst_type_access(*v) for v in values]"},{"line_number":2361,"context_line":"        db.instance_type_destroy(self.ctxt, inst_type1[\u0027name\u0027])"},{"line_number":2362,"context_line":""},{"line_number":2363,"context_line":"        p \u003d (self.ctxt, inst_type1[\u0027flavorid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FwJk%3D","line":2360,"in_reply_to":"AAAAOn%2F%2FwcU%3D","updated":"2013-04-24 19:48:49.000000000","message":"yes probably I should remove it.","commit_id":"463a21e3e9e8d9699c4e652d09f12c032cd408ce"}]}