)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"1490989fbc6f2fad0389a91d4be0d7f3692fde1e","unresolved":false,"context_lines":[{"line_number":4793,"context_line":"            # this connector is for the wrong host. Use the connector that"},{"line_number":4794,"context_line":"            # was stored in connection_info instead (if we have one, and it"},{"line_number":4795,"context_line":"            # is for the expected host)."},{"line_number":4796,"context_line":"            stashed_connector \u003d connection_info.get(\u0027connector\u0027)"},{"line_number":4797,"context_line":"            if not stashed_connector:"},{"line_number":4798,"context_line":"                # Volume was attached before we began stashing connectors"},{"line_number":4799,"context_line":"                LOG.warning(_LW(\"Host mismatch detected, but stashed \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_078fb1cc","line":4796,"range":{"start_line":4796,"start_character":32,"end_line":4796,"end_character":47},"updated":"2016-02-29 09:48:13.000000000","message":"I missed why we have removed the check to control if connection_info is None, it if is here we have an exception","commit_id":"6cf62881fb6706ec57ac4844b970bf82cc68ed0a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"6936d8d53f70fee022407dd08ca3b07e0ad863ed","unresolved":false,"context_lines":[{"line_number":4793,"context_line":"            # this connector is for the wrong host. Use the connector that"},{"line_number":4794,"context_line":"            # was stored in connection_info instead (if we have one, and it"},{"line_number":4795,"context_line":"            # is for the expected host)."},{"line_number":4796,"context_line":"            stashed_connector \u003d connection_info.get(\u0027connector\u0027)"},{"line_number":4797,"context_line":"            if not stashed_connector:"},{"line_number":4798,"context_line":"                # Volume was attached before we began stashing connectors"},{"line_number":4799,"context_line":"                LOG.warning(_LW(\"Host mismatch detected, but stashed \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aed3d3a_7e9d4465","line":4796,"range":{"start_line":4796,"start_character":32,"end_line":4796,"end_character":47},"in_reply_to":"9aed3d3a_078fb1cc","updated":"2016-02-29 18:12:21.000000000","message":"If it is None, it will fail before here (in encryptors.get_encryption_metadata). This was removed because of comments in the patch before it was split https://review.openstack.org/#/c/266095. In general, the feedback was not to protect against future bugs in other code that should be treated as bugs instead of adding extra checks that should not be needed. Looks like the feedback was not specific to this check, though.","commit_id":"6cf62881fb6706ec57ac4844b970bf82cc68ed0a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5ce3f4ac313ec2ccd7ee09b14e2573f837c90705","unresolved":false,"context_lines":[{"line_number":4802,"context_line":"        connection_info \u003d self._driver_detach_volume(context, instance, bdm)"},{"line_number":4803,"context_line":"        connector \u003d self.driver.get_volume_connector(instance)"},{"line_number":4804,"context_line":""},{"line_number":4805,"context_line":"        if not destroy_bdm and (connector.get(\u0027host\u0027) !\u003d instance.host):"},{"line_number":4806,"context_line":"            # If the volume is attached to another host (evacuate) then"},{"line_number":4807,"context_line":"            # this connector is for the wrong host. Use the connector that"},{"line_number":4808,"context_line":"            # was stored in connection_info instead (if we have one, and it"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_a606471e","line":4805,"updated":"2016-03-07 10:21:09.000000000","message":"I was trying to convince myself we always get {} and not a None from the above detach method. I think we are good.","commit_id":"255d7db2b4cc78c9af2c761f97f52d00af2fbec3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5ce3f4ac313ec2ccd7ee09b14e2573f837c90705","unresolved":false,"context_lines":[{"line_number":4820,"context_line":"                # Unexpected error. The stashed connector is also not matching"},{"line_number":4821,"context_line":"                # the needed instance host."},{"line_number":4822,"context_line":"                LOG.error(_LE(\"Host mismatch detected in stashed volume \""},{"line_number":4823,"context_line":"                              \"connector. Will use local volume connector. \""},{"line_number":4824,"context_line":"                              \"Instance host is %(ihost)s. Local volume \""},{"line_number":4825,"context_line":"                              \"connector host is %(chost)s. Stashed volume \""},{"line_number":4826,"context_line":"                              \"connector host is %(schost)s.\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_a6580758","line":4823,"range":{"start_line":4823,"start_character":42,"end_line":4823,"end_character":73},"updated":"2016-03-07 10:21:09.000000000","message":"Does this change not change this?\n\nWe will use a modified local volume connector now?","commit_id":"255d7db2b4cc78c9af2c761f97f52d00af2fbec3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"876b4a0974f9f3ee789d731cca3e92213f43afe1","unresolved":false,"context_lines":[{"line_number":4820,"context_line":"                # Unexpected error. The stashed connector is also not matching"},{"line_number":4821,"context_line":"                # the needed instance host."},{"line_number":4822,"context_line":"                LOG.error(_LE(\"Host mismatch detected in stashed volume \""},{"line_number":4823,"context_line":"                              \"connector. Will use local volume connector. \""},{"line_number":4824,"context_line":"                              \"Instance host is %(ihost)s. Local volume \""},{"line_number":4825,"context_line":"                              \"connector host is %(chost)s. Stashed volume \""},{"line_number":4826,"context_line":"                              \"connector host is %(schost)s.\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_5bbbbfc4","line":4823,"range":{"start_line":4823,"start_character":42,"end_line":4823,"end_character":73},"in_reply_to":"5aef4532_a6580758","updated":"2016-03-07 18:49:04.000000000","message":"Done","commit_id":"255d7db2b4cc78c9af2c761f97f52d00af2fbec3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5ce3f4ac313ec2ccd7ee09b14e2573f837c90705","unresolved":false,"context_lines":[{"line_number":4842,"context_line":"                # For attachments that existed before connector was"},{"line_number":4843,"context_line":"                # stashed in bdm.connection_info, we can only add"},{"line_number":4844,"context_line":"                # the instance_host to the local connector."},{"line_number":4845,"context_line":"                # Cinder drivers can implement workarounds using this info."},{"line_number":4846,"context_line":"                connector \u003d connector.copy()"},{"line_number":4847,"context_line":"                connector[\u0027instance_host\u0027] \u003d instance.host"},{"line_number":4848,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_c6f2736f","line":4845,"updated":"2016-03-07 10:21:09.000000000","message":"I think we should probably log that we are inventing a connector from the limited info we have.","commit_id":"255d7db2b4cc78c9af2c761f97f52d00af2fbec3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"876b4a0974f9f3ee789d731cca3e92213f43afe1","unresolved":false,"context_lines":[{"line_number":4842,"context_line":"                # For attachments that existed before connector was"},{"line_number":4843,"context_line":"                # stashed in bdm.connection_info, we can only add"},{"line_number":4844,"context_line":"                # the instance_host to the local connector."},{"line_number":4845,"context_line":"                # Cinder drivers can implement workarounds using this info."},{"line_number":4846,"context_line":"                connector \u003d connector.copy()"},{"line_number":4847,"context_line":"                connector[\u0027instance_host\u0027] \u003d instance.host"},{"line_number":4848,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_fbca8b4e","line":4845,"in_reply_to":"5aef4532_c6f2736f","updated":"2016-03-07 18:49:04.000000000","message":"Done","commit_id":"255d7db2b4cc78c9af2c761f97f52d00af2fbec3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96e7714fa742650e1d79363f3d0ebf226e146777","unresolved":false,"context_lines":[{"line_number":4802,"context_line":"        connection_info \u003d self._driver_detach_volume(context, instance, bdm)"},{"line_number":4803,"context_line":"        connector \u003d self.driver.get_volume_connector(instance)"},{"line_number":4804,"context_line":""},{"line_number":4805,"context_line":"        if connection_info and not destroy_bdm and ("},{"line_number":4806,"context_line":"           connector.get(\u0027host\u0027) !\u003d instance.host):"},{"line_number":4807,"context_line":"            # If the volume is attached to another host (evacuate) then"},{"line_number":4808,"context_line":"            # this connector is for the wrong host. Use the connector that"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab17558_e51b6c71","side":"PARENT","line":4805,"range":{"start_line":4805,"start_character":11,"end_line":4805,"end_character":26},"updated":"2016-05-10 21:08:22.000000000","message":"Why remove this check?","commit_id":"9517315ef20e30efa28348c83e5fa2e146bdbb82"}]}