)]}'
{"nova/api/ec2/ec2utils.py":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"e075dd55cb32aa0e595f33be6d317f55f71b5b81","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        value \u003d _CACHE.get(key)"},{"line_number":49,"context_line":"        if value is None:"},{"line_number":50,"context_line":"            value \u003d func(context, reqid)"},{"line_number":51,"context_line":"            _CACHE.set(key, value)"},{"line_number":52,"context_line":"        return value"},{"line_number":53,"context_line":"    return memoizer"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_ef502634","line":51,"updated":"2016-02-01 13:13:59.000000000","message":"get_or_create?","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        value \u003d _CACHE.get(key)"},{"line_number":49,"context_line":"        if value is None:"},{"line_number":50,"context_line":"            value \u003d func(context, reqid)"},{"line_number":51,"context_line":"            _CACHE.set(key, value)"},{"line_number":52,"context_line":"        return value"},{"line_number":53,"context_line":"    return memoizer"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_16fd886d","line":51,"in_reply_to":"7a5de9d1_ef502634","updated":"2016-02-02 00:09:13.000000000","message":"Pavel,\n\nIf we calculate the value everytime using \"func(context, reqid)\" i am not sure if that is ok under all conditions. So left the logic as is.\n\n-- Dims","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"}],"nova/api/metadata/handler.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"102b6a4e3306ec5fda2252c04f4a2a92aa872e60","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from nova import utils"},{"line_number":35,"context_line":"from nova import wsgi"},{"line_number":36,"context_line":"from oslo_config import cfg"},{"line_number":37,"context_line":"from oslo_log import log as logging"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"CONF \u003d cfg.CONF"},{"line_number":40,"context_line":"CONF.import_opt(\u0027use_forwarded_for\u0027, \u0027nova.api.auth\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_d2fdceb1","line":37,"updated":"2016-02-01 13:57:23.000000000","message":"why are these moved? This should be in block 2","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from nova import utils"},{"line_number":35,"context_line":"from nova import wsgi"},{"line_number":36,"context_line":"from oslo_config import cfg"},{"line_number":37,"context_line":"from oslo_log import log as logging"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"CONF \u003d cfg.CONF"},{"line_number":40,"context_line":"CONF.import_opt(\u0027use_forwarded_for\u0027, \u0027nova.api.auth\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_1634a847","line":37,"in_reply_to":"7a5de9d1_d2fdceb1","updated":"2016-02-02 00:09:13.000000000","message":"Fixed.","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"}],"nova/availability_zones.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ae93501319696adef5f33d8d745b3df3517b5860","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import collections"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from nova import objects"},{"line_number":23,"context_line":"from nova.openstack.common import memorycache"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_5702f30c","side":"PARENT","line":20,"updated":"2016-02-02 13:17:45.000000000","message":"this import shouldn\u0027t get moved into block 3","commit_id":"3be21335e40df935738143ad0ad92002a945f28c"}],"nova/cache_utils.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"b70fd991f6ae8b635d1b6e5d820e7e65e88d83d3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                _get_custom_cache_region(expiration_time\u003dexpiration_time,"},{"line_number":73,"context_line":"                                         backend\u003d\u0027dogpile.cache.memcached\u0027,"},{"line_number":74,"context_line":"                                         url\u003dCONF.memcached_servers))"},{"line_number":75,"context_line":"    # If the operator still uses the new style [cache]/memcache_servers"},{"line_number":76,"context_line":"    # and has [cache]/enabled flag on then we let oslo_cache configure"},{"line_number":77,"context_line":"    # the region from the configuration settings"},{"line_number":78,"context_line":"    elif CONF.cache.enabled and CONF.cache.memcache_servers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_c1a74cbb","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":27},"updated":"2016-02-01 08:28:25.000000000","message":"Do we need \u0027still\u0027 here?","commit_id":"cff8917861394fad3f740a59eb8cd9508bd20380"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"e075dd55cb32aa0e595f33be6d317f55f71b5b81","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                       help\u003d\u0027DEPRECATED: Memcached servers or None for in \u0027"},{"line_number":45,"context_line":"                            \u0027process cache. \"memcached_servers\" opt is \u0027"},{"line_number":46,"context_line":"                            \u0027deprecated in Mitaka. In Newton release \u0027"},{"line_number":47,"context_line":"                            \u0027oslo.cache config options should  be used as \u0027"},{"line_number":48,"context_line":"                            \u0027this option will be removed. Please add a \u0027"},{"line_number":49,"context_line":"                            \u0027[cache] group in your nova.conf file and \u0027"},{"line_number":50,"context_line":"                            \u0027add \"enable\" and \"memcache_servers\" option in \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_afb22ee3","line":47,"range":{"start_line":47,"start_character":61,"end_line":47,"end_character":63},"updated":"2016-02-01 13:13:59.000000000","message":"two spaces","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                       help\u003d\u0027DEPRECATED: Memcached servers or None for in \u0027"},{"line_number":45,"context_line":"                            \u0027process cache. \"memcached_servers\" opt is \u0027"},{"line_number":46,"context_line":"                            \u0027deprecated in Mitaka. In Newton release \u0027"},{"line_number":47,"context_line":"                            \u0027oslo.cache config options should  be used as \u0027"},{"line_number":48,"context_line":"                            \u0027this option will be removed. Please add a \u0027"},{"line_number":49,"context_line":"                            \u0027[cache] group in your nova.conf file and \u0027"},{"line_number":50,"context_line":"                            \u0027add \"enable\" and \"memcache_servers\" option in \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_56154099","line":47,"range":{"start_line":47,"start_character":61,"end_line":47,"end_character":63},"in_reply_to":"7a5de9d1_7215fa99","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                       help\u003d\u0027DEPRECATED: Memcached servers or None for in \u0027"},{"line_number":45,"context_line":"                            \u0027process cache. \"memcached_servers\" opt is \u0027"},{"line_number":46,"context_line":"                            \u0027deprecated in Mitaka. In Newton release \u0027"},{"line_number":47,"context_line":"                            \u0027oslo.cache config options should  be used as \u0027"},{"line_number":48,"context_line":"                            \u0027this option will be removed. Please add a \u0027"},{"line_number":49,"context_line":"                            \u0027[cache] group in your nova.conf file and \u0027"},{"line_number":50,"context_line":"                            \u0027add \"enable\" and \"memcache_servers\" option in \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_964898cd","line":47,"range":{"start_line":47,"start_character":61,"end_line":47,"end_character":63},"in_reply_to":"7a5de9d1_afb22ee3","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bbe47fed4f1cab538ebaea09afd73a87fadfa5d2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                       help\u003d\u0027DEPRECATED: Memcached servers or None for in \u0027"},{"line_number":45,"context_line":"                            \u0027process cache. \"memcached_servers\" opt is \u0027"},{"line_number":46,"context_line":"                            \u0027deprecated in Mitaka. In Newton release \u0027"},{"line_number":47,"context_line":"                            \u0027oslo.cache config options should  be used as \u0027"},{"line_number":48,"context_line":"                            \u0027this option will be removed. Please add a \u0027"},{"line_number":49,"context_line":"                            \u0027[cache] group in your nova.conf file and \u0027"},{"line_number":50,"context_line":"                            \u0027add \"enable\" and \"memcache_servers\" option in \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_7215fa99","line":47,"range":{"start_line":47,"start_character":61,"end_line":47,"end_character":63},"in_reply_to":"7a5de9d1_afb22ee3","updated":"2016-02-01 13:59:19.000000000","message":"the nit can be addressed after as well. overall I think the config option is fine.","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"e075dd55cb32aa0e595f33be6d317f55f71b5b81","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    return CacheClient("},{"line_number":101,"context_line":"            _get_custom_cache_region(expiration_time\u003dexpiration_time,"},{"line_number":102,"context_line":"                                     backend\u003d\u0027oslo_cache.dict\u0027))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def _get_default_cache_region(expiration_time):"},{"line_number":106,"context_line":"    region \u003d cache.create_region()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_4a760871","line":103,"updated":"2016-02-01 13:13:59.000000000","message":"rewrite get_client functions beautiful without duplicate code","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    return CacheClient("},{"line_number":101,"context_line":"            _get_custom_cache_region(expiration_time\u003dexpiration_time,"},{"line_number":102,"context_line":"                                     backend\u003d\u0027oslo_cache.dict\u0027))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def _get_default_cache_region(expiration_time):"},{"line_number":106,"context_line":"    region \u003d cache.create_region()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_76663c52","line":103,"in_reply_to":"7a5de9d1_4a760871","updated":"2016-02-02 00:09:13.000000000","message":"Not sure i understand :)","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"e075dd55cb32aa0e595f33be6d317f55f71b5b81","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def _get_default_cache_region(expiration_time):"},{"line_number":106,"context_line":"    region \u003d cache.create_region()"},{"line_number":107,"context_line":"    if expiration_time !\u003d 0:"},{"line_number":108,"context_line":"        CONF.cache.expiration_time \u003d expiration_time"},{"line_number":109,"context_line":"    cache.configure_cache_region(CONF, region)"},{"line_number":110,"context_line":"    return region"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_efc266e8","line":107,"updated":"2016-02-01 13:13:59.000000000","message":"think about default oslo.cache expiration_time value 600","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def _get_default_cache_region(expiration_time):"},{"line_number":106,"context_line":"    region \u003d cache.create_region()"},{"line_number":107,"context_line":"    if expiration_time !\u003d 0:"},{"line_number":108,"context_line":"        CONF.cache.expiration_time \u003d expiration_time"},{"line_number":109,"context_line":"    cache.configure_cache_region(CONF, region)"},{"line_number":110,"context_line":"    return region"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_16b5887c","line":107,"in_reply_to":"7a5de9d1_efc266e8","updated":"2016-02-02 00:09:13.000000000","message":"the point here was that various callers of get_client have custom expiration and we need to override the oslo.cache expiration time here. since we default expiration_time to 0 in the method param. So we need to override the CONF.cache.expiration_time only if the callers request it.","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"}],"nova/servicegroup/drivers/mc.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"102b6a4e3306ec5fda2252c04f4a2a92aa872e60","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from nova.i18n import _, _LI, _LW"},{"line_number":25,"context_line":"from nova.openstack.common import memorycache"},{"line_number":26,"context_line":"from nova.servicegroup import api"},{"line_number":27,"context_line":"from nova.servicegroup.drivers import base"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_d2c2ae52","side":"PARENT","line":27,"updated":"2016-02-01 13:57:23.000000000","message":"I don\u0027t understand why this gets moved","commit_id":"908de5e029f851627e645c2b64fb17baf05f251b"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from nova.i18n import _, _LI, _LW"},{"line_number":25,"context_line":"from nova.openstack.common import memorycache"},{"line_number":26,"context_line":"from nova.servicegroup import api"},{"line_number":27,"context_line":"from nova.servicegroup.drivers import base"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_5666a02a","side":"PARENT","line":27,"in_reply_to":"7a5de9d1_d2c2ae52","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"908de5e029f851627e645c2b64fb17baf05f251b"}],"nova/tests/unit/consoleauth/test_consoleauth.py":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"10fb8c81980df281806ea72017ce7634f40acdd1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.manager_api.authorize_console(self.context, token, \u0027novnc\u0027,"},{"line_number":59,"context_line":"                                         \u0027127.0.0.1\u0027, \u00278080\u0027, \u0027host\u0027,"},{"line_number":60,"context_line":"                                         self.instance_uuid)"},{"line_number":61,"context_line":"        self.assertTrue(self.manager_api.check_token(self.context, token))"},{"line_number":62,"context_line":"        timeutils.advance_time_seconds(1)"},{"line_number":63,"context_line":"        self.assertFalse(self.manager_api.check_token(self.context, token))"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_2c8169fb","line":61,"range":{"start_line":61,"start_character":29,"end_line":61,"end_character":52},"updated":"2016-02-01 13:20:02.000000000","message":"check again this method result (remember smth with none vs not-none instead of true vs false)","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.manager_api.authorize_console(self.context, token, \u0027novnc\u0027,"},{"line_number":59,"context_line":"                                         \u0027127.0.0.1\u0027, \u00278080\u0027, \u0027host\u0027,"},{"line_number":60,"context_line":"                                         self.instance_uuid)"},{"line_number":61,"context_line":"        self.assertTrue(self.manager_api.check_token(self.context, token))"},{"line_number":62,"context_line":"        timeutils.advance_time_seconds(1)"},{"line_number":63,"context_line":"        self.assertFalse(self.manager_api.check_token(self.context, token))"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_51d30a60","line":61,"range":{"start_line":61,"start_character":29,"end_line":61,"end_character":52},"in_reply_to":"7a5de9d1_2c8169fb","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"102b6a4e3306ec5fda2252c04f4a2a92aa872e60","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.manager.authorize_console(self.context, self.u_token, \u0027novnc\u0027,"},{"line_number":165,"context_line":"                                       \u0027127.0.0.1\u0027, \u00278080\u0027, \u0027host\u0027,"},{"line_number":166,"context_line":"                                       self.u_instance)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_check_token_encoding(self):"},{"line_number":169,"context_line":"        self.mox.StubOutWithMock(self.manager.mc, \"get\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_728bba1f","line":166,"updated":"2016-02-01 13:57:23.000000000","message":"we should really redo this as a mock based test.","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.manager.authorize_console(self.context, self.u_token, \u0027novnc\u0027,"},{"line_number":165,"context_line":"                                       \u0027127.0.0.1\u0027, \u00278080\u0027, \u0027host\u0027,"},{"line_number":166,"context_line":"                                       self.u_instance)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_check_token_encoding(self):"},{"line_number":169,"context_line":"        self.mox.StubOutWithMock(self.manager.mc, \"get\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_f0b546ec","line":166,"in_reply_to":"7a5de9d1_728bba1f","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"}],"nova/tests/unit/servicegroup/test_mc_servicegroup.py":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"e075dd55cb32aa0e595f33be6d317f55f71b5b81","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        fn \u003d self.servicegroup_api._driver._report_state"},{"line_number":64,"context_line":"        fn(service)"},{"line_number":65,"context_line":"        self.mc_client.set.assert_called_once_with(\u0027compute:fake-host\u0027,"},{"line_number":66,"context_line":"                                                   mock.ANY, time\u003d60)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_aa0e9c89","line":66,"range":{"start_line":66,"start_character":61,"end_line":66,"end_character":68},"updated":"2016-02-01 13:13:59.000000000","message":"look at it again (set method has only key and value args)","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        fn \u003d self.servicegroup_api._driver._report_state"},{"line_number":64,"context_line":"        fn(service)"},{"line_number":65,"context_line":"        self.mc_client.set.assert_called_once_with(\u0027compute:fake-host\u0027,"},{"line_number":66,"context_line":"                                                   mock.ANY, time\u003d60)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_b1459e43","line":66,"range":{"start_line":66,"start_character":61,"end_line":66,"end_character":68},"in_reply_to":"7a5de9d1_aa0e9c89","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"}],"nova/tests/unit/test_cache.py":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"e075dd55cb32aa0e595f33be6d317f55f71b5b81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7a5de9d1_0a77b002","line":29,"updated":"2016-02-01 13:13:59.000000000","message":"maybe more tests? (get_custom_cache_region, get_memcached_client)","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7a5de9d1_f1aeb62c","line":29,"in_reply_to":"7a5de9d1_0a77b002","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"}],"releasenotes/notes/switch-to-oslo-cache-7114a0ab2dea52df.yaml":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"e075dd55cb32aa0e595f33be6d317f55f71b5b81","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  - Option ``memcached_servers`` is deprecated in Mitaka. Operators should"},{"line_number":7,"context_line":"    oslo.cache configuration instead. Specifically ``enabled`` option under"},{"line_number":8,"context_line":"    [cache] section should be set to True and the url(s) for the memcached"},{"line_number":9,"context_line":"    servers should be in [cache]/memcache_servers option."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a5de9d1_8ad080ca","line":7,"range":{"start_line":6,"start_character":68,"end_line":7,"end_character":14},"updated":"2016-02-01 13:13:59.000000000","message":"should use","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  - Option ``memcached_servers`` is deprecated in Mitaka. Operators should"},{"line_number":7,"context_line":"    oslo.cache configuration instead. Specifically ``enabled`` option under"},{"line_number":8,"context_line":"    [cache] section should be set to True and the url(s) for the memcached"},{"line_number":9,"context_line":"    servers should be in [cache]/memcache_servers option."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a5de9d1_3159ae35","line":7,"range":{"start_line":6,"start_character":68,"end_line":7,"end_character":14},"in_reply_to":"7a5de9d1_8ad080ca","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"}],"test-requirements.txt":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"e075dd55cb32aa0e595f33be6d317f55f71b5b81","unresolved":false,"context_lines":[{"line_number":12,"context_line":"python-barbicanclient\u003e\u003d3.3.0 # Apache-2.0"},{"line_number":13,"context_line":"python-ironicclient\u003e\u003d0.9.0 # Apache-2.0"},{"line_number":14,"context_line":"python-subunit\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":15,"context_line":"python-memcached\u003e\u003d1.56  # PSF"},{"line_number":16,"context_line":"requests-mock\u003e\u003d0.7.0 # Apache-2.0"},{"line_number":17,"context_line":"sphinx!\u003d1.2.0,!\u003d1.3b1,\u003c1.3,\u003e\u003d1.1.2 # BSD"},{"line_number":18,"context_line":"oslosphinx!\u003d3.4.0,\u003e\u003d2.5.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"7a5de9d1_0a81f08e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":16},"updated":"2016-02-01 13:13:59.000000000","message":"could explain why you add this, what about \u0027oslo.cache\u0027 itself?","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"14b5d7152d4849e789363e66945df7a8a7a169c9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"python-barbicanclient\u003e\u003d3.3.0 # Apache-2.0"},{"line_number":13,"context_line":"python-ironicclient\u003e\u003d0.9.0 # Apache-2.0"},{"line_number":14,"context_line":"python-subunit\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":15,"context_line":"python-memcached\u003e\u003d1.56  # PSF"},{"line_number":16,"context_line":"requests-mock\u003e\u003d0.7.0 # Apache-2.0"},{"line_number":17,"context_line":"sphinx!\u003d1.2.0,!\u003d1.3b1,\u003c1.3,\u003e\u003d1.1.2 # BSD"},{"line_number":18,"context_line":"oslosphinx!\u003d3.4.0,\u003e\u003d2.5.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"7a5de9d1_11c912ac","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":16},"in_reply_to":"7a5de9d1_0a81f08e","updated":"2016-02-02 00:09:13.000000000","message":"Done","commit_id":"d360ba543693d6f0d8f463629b6a11557b504c53"}]}