)]}'
{"nova/pci/devspec.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"762d8cec037f661adf18ff73cb9b21364ddeeb0e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    v \u003d get_value(a)"},{"line_number":40,"context_line":"    if v \u003e max:"},{"line_number":41,"context_line":"        raise exception.PciConfigInvalidWhitelist("},{"line_number":42,"context_line":"            reason \u003d _(\"invalid %(property)s %(attr)s\") %"},{"line_number":43,"context_line":"                       {\u0027property\u0027: property, \u0027attr\u0027: a})"},{"line_number":44,"context_line":"    setattr(pci_obj, property, hex_value % v)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_af0c393c","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":21},"updated":"2016-02-02 09:50:52.000000000","message":"Can you change here like\n\n reason\u003d_(\"invalid ...\n\nfor removing 2 spaces around \"\u003d\"?\n\nThis my point should be out of scope for this patch purpose, but https://review.openstack.org/#/c/271904/ is doing that in parallel and the conflict happens if this patch is merged faster.\n\nSo I prefer to make here valid as possible in future review.","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"},{"author":{"_account_id":6508,"name":"Dmitry Stepanenko","email":"dstepanenko@mirantis.com","username":"dstepanenko"},"change_message_id":"89c7aeb49e47107c75307e71afb86ec65860aff3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    v \u003d get_value(a)"},{"line_number":40,"context_line":"    if v \u003e max:"},{"line_number":41,"context_line":"        raise exception.PciConfigInvalidWhitelist("},{"line_number":42,"context_line":"            reason \u003d _(\"invalid %(property)s %(attr)s\") %"},{"line_number":43,"context_line":"                       {\u0027property\u0027: property, \u0027attr\u0027: a})"},{"line_number":44,"context_line":"    setattr(pci_obj, property, hex_value % v)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_cf1095ae","line":42,"updated":"2016-02-02 09:59:59.000000000","message":"nit: Is there any reason to change the way of text formatting here from old style to new one? There are just 2 parameters here - not too much for being confused with parameters order","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0a2cfe7c397e76c5651a15dbeb3c9ea0c31be0c3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    v \u003d get_value(a)"},{"line_number":40,"context_line":"    if v \u003e max:"},{"line_number":41,"context_line":"        raise exception.PciConfigInvalidWhitelist("},{"line_number":42,"context_line":"            reason \u003d _(\"invalid %(property)s %(attr)s\") %"},{"line_number":43,"context_line":"                       {\u0027property\u0027: property, \u0027attr\u0027: a})"},{"line_number":44,"context_line":"    setattr(pci_obj, property, hex_value % v)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_48cedf84","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":21},"in_reply_to":"7a5de9d1_af0c393c","updated":"2016-02-02 23:49:51.000000000","message":"Done","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0a2cfe7c397e76c5651a15dbeb3c9ea0c31be0c3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    v \u003d get_value(a)"},{"line_number":40,"context_line":"    if v \u003e max:"},{"line_number":41,"context_line":"        raise exception.PciConfigInvalidWhitelist("},{"line_number":42,"context_line":"            reason \u003d _(\"invalid %(property)s %(attr)s\") %"},{"line_number":43,"context_line":"                       {\u0027property\u0027: property, \u0027attr\u0027: a})"},{"line_number":44,"context_line":"    setattr(pci_obj, property, hex_value % v)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_6892bb59","line":42,"in_reply_to":"7a5de9d1_cf1095ae","updated":"2016-02-02 23:49:51.000000000","message":"To avoid \u0027H703  Multiple positional placeholders\u0027.","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8abc343afb7ceab0e6bb8dd9afcfdddb324851b1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    v \u003d get_value(a)"},{"line_number":40,"context_line":"    if v \u003e max:"},{"line_number":41,"context_line":"        raise exception.PciConfigInvalidWhitelist("},{"line_number":42,"context_line":"            reason \u003d _(\"invalid %(property)s %(attr)s\") %"},{"line_number":43,"context_line":"                       {\u0027property\u0027: property, \u0027attr\u0027: a})"},{"line_number":44,"context_line":"    setattr(pci_obj, property, hex_value % v)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_f2b44dd5","line":42,"in_reply_to":"7a5de9d1_cf1095ae","updated":"2016-02-02 13:27:14.000000000","message":"agree we should clean up the pep8 issue now with spaces around \u003d in param list.","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0a2cfe7c397e76c5651a15dbeb3c9ea0c31be0c3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    v \u003d get_value(a)"},{"line_number":40,"context_line":"    if v \u003e max:"},{"line_number":41,"context_line":"        raise exception.PciConfigInvalidWhitelist("},{"line_number":42,"context_line":"            reason \u003d _(\"invalid %(property)s %(attr)s\") %"},{"line_number":43,"context_line":"                       {\u0027property\u0027: property, \u0027attr\u0027: a})"},{"line_number":44,"context_line":"    setattr(pci_obj, property, hex_value % v)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_08c8e773","line":42,"in_reply_to":"7a5de9d1_f2b44dd5","updated":"2016-02-02 23:49:51.000000000","message":"Done","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"}],"nova/pci/request.py":[{"author":{"_account_id":11428,"name":"Ajaya Agrawal","email":"ajku.agr@gmail.com","username":"ajayaa"},"change_message_id":"081b8fbc5f0e44a6956a1c460c2fdf45905246fe","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                if aliases[name][0][\"dev_type\"] \u003d\u003d spec[\"dev_type\"]:"},{"line_number":107,"context_line":"                    aliases[name].append(spec)"},{"line_number":108,"context_line":"                else:"},{"line_number":109,"context_line":"                    reason \u003d _(\"Device type mismatch for alias \u0027%s\u0027\") % name"},{"line_number":110,"context_line":"                    raise exception.PciInvalidAlias(reason\u003dreason)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    except exception.PciInvalidAlias:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_9ebf7560","line":109,"range":{"start_line":109,"start_character":33,"end_line":109,"end_character":34},"updated":"2016-02-01 07:50:41.000000000","message":"Why not do string formatting using dictionary, similar to the last file?","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cf6d2179e906122bbc6b808d3fa51159dc0d3eb2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                if aliases[name][0][\"dev_type\"] \u003d\u003d spec[\"dev_type\"]:"},{"line_number":107,"context_line":"                    aliases[name].append(spec)"},{"line_number":108,"context_line":"                else:"},{"line_number":109,"context_line":"                    reason \u003d _(\"Device type mismatch for alias \u0027%s\u0027\") % name"},{"line_number":110,"context_line":"                    raise exception.PciInvalidAlias(reason\u003dreason)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    except exception.PciInvalidAlias:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_a1b9f0cd","line":109,"range":{"start_line":109,"start_character":33,"end_line":109,"end_character":34},"in_reply_to":"7a5de9d1_9ebf7560","updated":"2016-02-01 08:12:25.000000000","message":"Ajaya, Thank you for your review.\nBecause there is only one replacement.","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"},{"author":{"_account_id":6508,"name":"Dmitry Stepanenko","email":"dstepanenko@mirantis.com","username":"dstepanenko"},"change_message_id":"0c5b3497f04565a5d69a2a766cd95381286e3095","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                if aliases[name][0][\"dev_type\"] \u003d\u003d spec[\"dev_type\"]:"},{"line_number":107,"context_line":"                    aliases[name].append(spec)"},{"line_number":108,"context_line":"                else:"},{"line_number":109,"context_line":"                    reason \u003d _(\"Device type mismatch for alias \u0027%s\u0027\") % name"},{"line_number":110,"context_line":"                    raise exception.PciInvalidAlias(reason\u003dreason)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    except exception.PciInvalidAlias:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_692ce14a","line":109,"range":{"start_line":109,"start_character":33,"end_line":109,"end_character":34},"in_reply_to":"7a5de9d1_a1b9f0cd","updated":"2016-02-03 13:32:57.000000000","message":"Correct me if I\u0027m wrong. Here you\u0027re first moving \"translate\" string into given locale using \"_\" function and then do formating. Shouldn\u0027t you do it in the opposite order?\n\nI mean, there is conceptual difference between\n_(\"%s\") % name and _(%(name) % {\u0027name\u0027 : name}) - in the second version name also being translated using \"_\" function.","commit_id":"1683cf4cc2502051fd3c45afc05838b1d97591db"}]}