)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"05af77344480c596477edf010997df444734b037","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The vm_state should not be modified until the task is complete."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Several methods in nova.compute.api alter the vm_state value before proceeding with the actual work. The initial vm_state may be changed to something other than the initial vm_state (which is a problem: since we do not know what the initial state actually was, we cannot reasonably recover and set the corresponding ERROR if a problem with the operation occurs)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Actually done:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAO3%2F%2F%2BoY%3D","line":9,"updated":"2013-05-15 18:22:58.000000000","message":"The commit message must be word-wrapped at 72 columns…","commit_id":"3adf00f31748f71b03a6d9a39e1d207624ad9b5e"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bc37d849c85862162b40cedc71ef5b22a849ba72","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The vm_state should not be modified until the task is complete."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Several methods in nova.compute.api alter the vm_state value before proceeding with the actual work."},{"line_number":10,"context_line":"The initial vm_state may be changed to something other than the initial vm_state"},{"line_number":11,"context_line":"(which is a problem: since we do not know what the initial state actually was,"},{"line_number":12,"context_line":"we cannot reasonably recover and set the corresponding ERROR if a problem with the operation occurs)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAO3%2F%2F8UQ%3D","line":9,"updated":"2013-05-16 15:55:51.000000000","message":"The commit message needs to be word-wrapped at _72_ columns, not 100 columns.","commit_id":"cfc374640012daa9867351dffeb0f1dc00bee11f"},{"author":{"_account_id":7348,"name":"Marharyta Kislinska","email":"mkislins@yahoo-inc.com","username":"azilli"},"change_message_id":"01de315a6f0b977e67bea822ef23875193a63afe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The vm_state should not be modified until the task is complete."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Several methods in nova.compute.api alter the vm_state value before proceeding with the actual work."},{"line_number":10,"context_line":"The initial vm_state may be changed to something other than the initial vm_state"},{"line_number":11,"context_line":"(which is a problem: since we do not know what the initial state actually was,"},{"line_number":12,"context_line":"we cannot reasonably recover and set the corresponding ERROR if a problem with the operation occurs)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAPH%2F%2F%2Bqg%3D","line":9,"in_reply_to":"AAAAO3%2F%2F8UQ%3D","updated":"2013-05-17 10:19:27.000000000","message":"Didn\u0027t know about that. Thanks.","commit_id":"cfc374640012daa9867351dffeb0f1dc00bee11f"}],"nova/compute/api.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"05af77344480c596477edf010997df444734b037","unresolved":false,"context_lines":[{"line_number":1730,"context_line":"                method\u003d\u0027reboot\u0027)"},{"line_number":1731,"context_line":"        state \u003d {\u0027SOFT\u0027: task_states.REBOOTING,"},{"line_number":1732,"context_line":"                 \u0027HARD\u0027: task_states.REBOOTING_HARD}[reboot_type]"},{"line_number":1733,"context_line":"        instance \u003d self.update(context, instance,"},{"line_number":1734,"context_line":"                               task_state\u003dstate,"},{"line_number":1735,"context_line":"                               expected_task_state\u003d[None,"},{"line_number":1736,"context_line":"                                                    task_states.REBOOTING])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAO3%2F%2F%2BoQ%3D","line":1733,"updated":"2013-05-15 18:22:58.000000000","message":"I see you removing the state updates, but I don\u0027t see where those state updates have been moved to.  Did the update-after-task code already exist?  Where do these state changes finally get applied?","commit_id":"3adf00f31748f71b03a6d9a39e1d207624ad9b5e"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bc37d849c85862162b40cedc71ef5b22a849ba72","unresolved":false,"context_lines":[{"line_number":1730,"context_line":"                method\u003d\u0027reboot\u0027)"},{"line_number":1731,"context_line":"        state \u003d {\u0027SOFT\u0027: task_states.REBOOTING,"},{"line_number":1732,"context_line":"                 \u0027HARD\u0027: task_states.REBOOTING_HARD}[reboot_type]"},{"line_number":1733,"context_line":"        instance \u003d self.update(context, instance,"},{"line_number":1734,"context_line":"                               task_state\u003dstate,"},{"line_number":1735,"context_line":"                               expected_task_state\u003d[None,"},{"line_number":1736,"context_line":"                                                    task_states.REBOOTING])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAO3%2F%2F8UM%3D","line":1733,"updated":"2013-05-16 15:55:51.000000000","message":"Repeating my question: I see you removing the state updates, but I don\u0027t see where those state updates have been moved to. Did the update-after-task code already exist? Where do these state changes finally get applied?","commit_id":"cfc374640012daa9867351dffeb0f1dc00bee11f"},{"author":{"_account_id":7348,"name":"Marharyta Kislinska","email":"mkislins@yahoo-inc.com","username":"azilli"},"change_message_id":"01de315a6f0b977e67bea822ef23875193a63afe","unresolved":false,"context_lines":[{"line_number":1730,"context_line":"                method\u003d\u0027reboot\u0027)"},{"line_number":1731,"context_line":"        state \u003d {\u0027SOFT\u0027: task_states.REBOOTING,"},{"line_number":1732,"context_line":"                 \u0027HARD\u0027: task_states.REBOOTING_HARD}[reboot_type]"},{"line_number":1733,"context_line":"        instance \u003d self.update(context, instance,"},{"line_number":1734,"context_line":"                               task_state\u003dstate,"},{"line_number":1735,"context_line":"                               expected_task_state\u003d[None,"},{"line_number":1736,"context_line":"                                                    task_states.REBOOTING])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F%2Bp8%3D","line":1733,"in_reply_to":"AAAAO3%2F%2F8UM%3D","updated":"2013-05-17 10:19:27.000000000","message":"As I saw from the code the vm_state update is done in the actual task processing functions (and errrors also are handled there).","commit_id":"cfc374640012daa9867351dffeb0f1dc00bee11f"}]}