)]}'
{"plugins/xenserver/xenapi/etc/xapi.d/plugins/pluginlib_nova.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"644b388274da0341752ed846729d05954a5f4249","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        _vbd_unplug_with_retry(session, vbd)"},{"line_number":117,"context_line":"        try:"},{"line_number":118,"context_line":"            session.xenapi.VBD.destroy(vbd)"},{"line_number":119,"context_line":"        except XenAPI.Failure as e:"},{"line_number":120,"context_line":"            logging.error(_(\u0027Ignoring XenAPI.Failure %s\u0027), e)"},{"line_number":121,"context_line":"        logging.debug(_(\u0027Destroying VBD for VDI %s done.\u0027), vdi)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_2aa33051","line":119,"updated":"2016-02-02 22:36:50.000000000","message":"This syntax is invalid in Python 2.4.  I think you\u0027re going to have to bite the bullet here and do a \"# noqa\" for these…","commit_id":"0e1ef805943908ce42e9178b35bf36712b6eab05"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"dd96ad411023fb3a32d40143144f898268f80f9e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        _vbd_unplug_with_retry(session, vbd)"},{"line_number":117,"context_line":"        try:"},{"line_number":118,"context_line":"            session.xenapi.VBD.destroy(vbd)"},{"line_number":119,"context_line":"        except XenAPI.Failure as e:"},{"line_number":120,"context_line":"            logging.error(_(\u0027Ignoring XenAPI.Failure %s\u0027), e)"},{"line_number":121,"context_line":"        logging.debug(_(\u0027Destroying VBD for VDI %s done.\u0027), vdi)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_66f39a0b","line":119,"in_reply_to":"5a5ae5dd_72adb387","updated":"2016-02-03 19:59:58.000000000","message":"I have used sys.exc_info() so as to get the exception, I think this will make the trick.","commit_id":"0e1ef805943908ce42e9178b35bf36712b6eab05"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"c28de38dba95fe1969f2e9e67d5feac2ed9ea488","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        _vbd_unplug_with_retry(session, vbd)"},{"line_number":117,"context_line":"        try:"},{"line_number":118,"context_line":"            session.xenapi.VBD.destroy(vbd)"},{"line_number":119,"context_line":"        except XenAPI.Failure as e:"},{"line_number":120,"context_line":"            logging.error(_(\u0027Ignoring XenAPI.Failure %s\u0027), e)"},{"line_number":121,"context_line":"        logging.debug(_(\u0027Destroying VBD for VDI %s done.\u0027), vdi)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_72adb387","line":119,"in_reply_to":"5a5ae5dd_d98135fd","updated":"2016-02-03 11:34:52.000000000","message":"Are there other options here?\nThis patch cannot land as it will break the XenAPI driver.\n\nAt worst we could prevent pep8 running on these plugin files, but I\u0027d really like to avoid that.","commit_id":"0e1ef805943908ce42e9178b35bf36712b6eab05"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"e521f2dcc726c6b2df9ab1a19de1b19f0d2fb2e7","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        _vbd_unplug_with_retry(session, vbd)"},{"line_number":117,"context_line":"        try:"},{"line_number":118,"context_line":"            session.xenapi.VBD.destroy(vbd)"},{"line_number":119,"context_line":"        except XenAPI.Failure as e:"},{"line_number":120,"context_line":"            logging.error(_(\u0027Ignoring XenAPI.Failure %s\u0027), e)"},{"line_number":121,"context_line":"        logging.debug(_(\u0027Destroying VBD for VDI %s done.\u0027), vdi)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_d98135fd","line":119,"in_reply_to":"7a5de9d1_2aa33051","updated":"2016-02-03 09:11:32.000000000","message":"No, unfortunately I can\u0027t.\n\nThe purpose of this patch series was to make the pep8 tests run with python3 in new OSes where py3 is chosen by default. Unfortunately, the old syntax is only Py2, therefore it throws an invalid syntax error in Py3.","commit_id":"0e1ef805943908ce42e9178b35bf36712b6eab05"}],"plugins/xenserver/xenapi/etc/xapi.d/plugins/utils.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2005da75aef21163866cf26b657274a32b4930aa","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    kwargs[\u0027env\u0027] \u003d env"},{"line_number":84,"context_line":"    try:"},{"line_number":85,"context_line":"        proc \u003d subprocess.Popen(cmdline, **kwargs)"},{"line_number":86,"context_line":"    except OSError as e:"},{"line_number":87,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"},{"line_number":88,"context_line":"            raise CommandNotFound"},{"line_number":89,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_91e29202","line":86,"updated":"2016-02-03 20:27:20.000000000","message":"Still need to update this one…","commit_id":"9bb45720e14c87c619b0a55933d88a1a04226f9a"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"201e8ea9402d366b3b42b6030b07687369dda847","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    kwargs[\u0027env\u0027] \u003d env"},{"line_number":84,"context_line":"    try:"},{"line_number":85,"context_line":"        proc \u003d subprocess.Popen(cmdline, **kwargs)"},{"line_number":86,"context_line":"    except OSError as e:"},{"line_number":87,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"},{"line_number":88,"context_line":"            raise CommandNotFound"},{"line_number":89,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_c76d8705","line":86,"in_reply_to":"5a5ae5dd_91e29202","updated":"2016-02-04 11:39:04.000000000","message":"Thanks Kevin.","commit_id":"9bb45720e14c87c619b0a55933d88a1a04226f9a"}]}