)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"60083c36fe4ac03381058c27086783e0822ec9bf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"improved help text will be split into several patches; this is patch 4"},{"line_number":13,"context_line":"of 4."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Blueprint centralize-config-options"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I18f05d7883399ab9f282ed52b23ab9bea7ac2399"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa0719c6_aff4cd5a","line":15,"updated":"2016-03-23 15:48:40.000000000","message":"Please be aware that the effort in Newton is tracked with a\nnew (follow up) blueprint \n\n    centralize-config-options-newton\n\nIf questions arise, ping me. Thanks for your help here!","commit_id":"84bf75dce001add20d8bf3730fbff3c808a12f10"}],"nova/conf/network.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"45fded3f56f80b9dd79c884853206d7769ba82be","unresolved":false,"context_lines":[{"line_number":590,"context_line":"    cfg.IntOpt(\"ebtables_exec_attempts\","},{"line_number":591,"context_line":"            default\u003d3,"},{"line_number":592,"context_line":"            help\u003d\"\"\""},{"line_number":593,"context_line":"This option determines the number of time to retry ebtables commands before"},{"line_number":594,"context_line":"giving up. The minimum number of retries is 1, even if this option is set to a"},{"line_number":595,"context_line":"negative value or zero."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_5896eb4c","line":593,"updated":"2016-03-27 16:49:42.000000000","message":"s/time/times/","commit_id":"e0ad608fa43188400499e8c56f4b556708ce1fd0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"45fded3f56f80b9dd79c884853206d7769ba82be","unresolved":false,"context_lines":[{"line_number":620,"context_line":""},{"line_number":621,"context_line":"   Any positive float or integer. Setting this to zero will result in no"},{"line_number":622,"context_line":"   waiting between attempts, and setting this to a negative value will result"},{"line_number":623,"context_line":"   an exception being thrown if an ebtables retry is every needed."},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"* Services that use this:"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_38917753","line":623,"updated":"2016-03-27 16:49:42.000000000","message":"s/every/ever/","commit_id":"e0ad608fa43188400499e8c56f4b556708ce1fd0"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"d30b90c8f410ae76e6e80967d92e8d4b5faf40fd","unresolved":false,"context_lines":[{"line_number":533,"context_line":"    cfg.StrOpt(\"iptables_drop_action\","},{"line_number":534,"context_line":"            default\u003d\"DROP\","},{"line_number":535,"context_line":"            help\u003d\"\"\""},{"line_number":536,"context_line":"By default, packets that do not pass the firewall are DROPped. In many cases,"},{"line_number":537,"context_line":"though, an operator may find it more useful to change this from DROP to REJECT,"},{"line_number":538,"context_line":"so that the user issuing those packets may have a better idea as to what\u0027s"},{"line_number":539,"context_line":"going on, or LOGDROP in order to record the blocked traffic before DROPping."}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_5a722012","line":536,"range":{"start_line":536,"start_character":54,"end_line":536,"end_character":61},"updated":"2016-05-31 20:26:04.000000000","message":"Just curious why are we using upper case DROP? This will look different in docs.","commit_id":"1c1954d1048c5cf98a3ae894d5654df62886391c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"8ae03d6d9430634f86d2074c26319eddf04f3f25","unresolved":false,"context_lines":[{"line_number":533,"context_line":"    cfg.StrOpt(\"iptables_drop_action\","},{"line_number":534,"context_line":"            default\u003d\"DROP\","},{"line_number":535,"context_line":"            help\u003d\"\"\""},{"line_number":536,"context_line":"By default, packets that do not pass the firewall are DROPped. In many cases,"},{"line_number":537,"context_line":"though, an operator may find it more useful to change this from DROP to REJECT,"},{"line_number":538,"context_line":"so that the user issuing those packets may have a better idea as to what\u0027s"},{"line_number":539,"context_line":"going on, or LOGDROP in order to record the blocked traffic before DROPping."}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_3d3c76c7","line":536,"range":{"start_line":536,"start_character":54,"end_line":536,"end_character":61},"in_reply_to":"9abb7d3a_5a722012","updated":"2016-05-31 20:33:50.000000000","message":"I think it\u0027s to match how it looks by default: http://ipset.netfilter.org/iptables.man.html\n\nI would suggest changing to \"DROP\u0027d\", but that\u0027s just me.","commit_id":"1c1954d1048c5cf98a3ae894d5654df62886391c"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"06713999760ae46603fae3c11945ad7b08c4a725","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    None"},{"line_number":485,"context_line":"\"\"\"),"},{"line_number":486,"context_line":"    cfg.StrOpt(\"metadata_host\","},{"line_number":487,"context_line":"            default\u003d\"$my_ip\","},{"line_number":488,"context_line":"            help\u003d\"\"\""},{"line_number":489,"context_line":"This option determines the IP address for the network metadata API server."}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_ef47aba0","line":486,"range":{"start_line":486,"start_character":8,"end_line":486,"end_character":14},"updated":"2016-06-30 18:27:32.000000000","message":"Can we replace this StrOpt with IPOpt? I am just curious if there is IpOpt for IP addresses type why are we using Stropt?","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"75ebe1e91c18ed5d7b030501bc8b0e4519ee108c","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    None"},{"line_number":485,"context_line":"\"\"\"),"},{"line_number":486,"context_line":"    cfg.StrOpt(\"metadata_host\","},{"line_number":487,"context_line":"            default\u003d\"$my_ip\","},{"line_number":488,"context_line":"            help\u003d\"\"\""},{"line_number":489,"context_line":"This option determines the IP address for the network metadata API server."}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_da8e0bcf","line":486,"range":{"start_line":486,"start_character":8,"end_line":486,"end_character":14},"in_reply_to":"1aa78d24_10ef21b1","updated":"2016-07-06 17:52:46.000000000","message":"Ok., thanks","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"2374a315964248cd775b1f79a33b088bd47cfa98","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    None"},{"line_number":485,"context_line":"\"\"\"),"},{"line_number":486,"context_line":"    cfg.StrOpt(\"metadata_host\","},{"line_number":487,"context_line":"            default\u003d\"$my_ip\","},{"line_number":488,"context_line":"            help\u003d\"\"\""},{"line_number":489,"context_line":"This option determines the IP address for the network metadata API server."}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_10ef21b1","line":486,"range":{"start_line":486,"start_character":8,"end_line":486,"end_character":14},"in_reply_to":"3aaa91ec_ef47aba0","updated":"2016-07-05 14:58:26.000000000","message":"Because this was part of the config option reorganization effort. Options were moved to a central location in step 1, and then the help text was improved in step 2, as explained in the commit message. There was no intention of changing any logic or functionality; I would suggest that should be done in a follow-up patch.","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"06713999760ae46603fae3c11945ad7b08c4a725","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"   Any valid IP address. The default is the IP address of the Nova API server."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"* Related options:"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    metadata_port"},{"line_number":498,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_af22c3b6","line":495,"range":{"start_line":495,"start_character":0,"end_line":495,"end_character":18},"updated":"2016-06-30 18:27:32.000000000","message":"* should be to iterate items after a headline according to wiki.","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"2374a315964248cd775b1f79a33b088bd47cfa98","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"   Any valid IP address. The default is the IP address of the Nova API server."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"* Related options:"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    metadata_port"},{"line_number":498,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_b37d7770","line":495,"range":{"start_line":495,"start_character":0,"end_line":495,"end_character":18},"in_reply_to":"3aaa91ec_af22c3b6","updated":"2016-07-05 14:58:26.000000000","message":"All instances of a line beginning with \u0027* \u0027 have been removed.","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"06713999760ae46603fae3c11945ad7b08c4a725","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    metadata_port"},{"line_number":498,"context_line":"\"\"\"),"},{"line_number":499,"context_line":"    cfg.IntOpt(\"metadata_port\","},{"line_number":500,"context_line":"            default\u003d8775,"},{"line_number":501,"context_line":"            min\u003d1,"},{"line_number":502,"context_line":"            max\u003d65535,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_efd4cbe9","line":499,"range":{"start_line":499,"start_character":8,"end_line":499,"end_character":14},"updated":"2016-06-30 18:27:32.000000000","message":"Can we replace this IntOpt with PortOpt so that we don\u0027t need to add min and max values?","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"2374a315964248cd775b1f79a33b088bd47cfa98","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    metadata_port"},{"line_number":498,"context_line":"\"\"\"),"},{"line_number":499,"context_line":"    cfg.IntOpt(\"metadata_port\","},{"line_number":500,"context_line":"            default\u003d8775,"},{"line_number":501,"context_line":"            min\u003d1,"},{"line_number":502,"context_line":"            max\u003d65535,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_53ed3324","line":499,"range":{"start_line":499,"start_character":8,"end_line":499,"end_character":14},"in_reply_to":"3aaa91ec_efd4cbe9","updated":"2016-07-05 14:58:26.000000000","message":"Same comment as above. You should file a bug, and then make that change after this patch is merged.","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"06713999760ae46603fae3c11945ad7b08c4a725","unresolved":false,"context_lines":[{"line_number":578,"context_line":"This option is used mainly in testing to avoid calls to the underlying network"},{"line_number":579,"context_line":"utilities."},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"Possible values:"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"   True, False (default)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"* Related options:"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    None"},{"line_number":588,"context_line":"\"\"\"),"},{"line_number":589,"context_line":"    cfg.IntOpt(\"ebtables_exec_attempts\","},{"line_number":590,"context_line":"            default\u003d3,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_6fe9fb7e","line":587,"range":{"start_line":581,"start_character":0,"end_line":587,"end_character":8},"updated":"2016-06-30 18:27:32.000000000","message":"we can drop this section according to wiki https://wiki.openstack.org/w/index.php?title\u003dConfigOptionsConsistency","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"2374a315964248cd775b1f79a33b088bd47cfa98","unresolved":false,"context_lines":[{"line_number":578,"context_line":"This option is used mainly in testing to avoid calls to the underlying network"},{"line_number":579,"context_line":"utilities."},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"Possible values:"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"   True, False (default)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"* Related options:"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    None"},{"line_number":588,"context_line":"\"\"\"),"},{"line_number":589,"context_line":"    cfg.IntOpt(\"ebtables_exec_attempts\","},{"line_number":590,"context_line":"            default\u003d3,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_53d41346","line":587,"range":{"start_line":581,"start_character":0,"end_line":587,"end_character":8},"in_reply_to":"3aaa91ec_6fe9fb7e","updated":"2016-07-05 14:58:26.000000000","message":"Done","commit_id":"1c05342ebac69a941fc37c7f0b6823f486bc88bc"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"811d4812561825a3f7021a846c551c7b4ca784d9","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Possible values:"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"   Any valid IP address. The default is the IP address of the Nova API server."},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"Related options:"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_4d0ee03b","line":432,"range":{"start_line":432,"start_character":2,"end_line":432,"end_character":78},"updated":"2016-07-20 19:26:39.000000000","message":"Additional nit: take a look at https://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_description_indentation. \n\n-\u003e Note: * should be to iterate items after a headline.\n\nPlease apply to all ``Possible values`` and ``Related options``","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1e7b1594feec51f5b26afd4db16b4566c2e902ab","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Possible values:"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"   Any valid IP address. The default is the IP address of the Nova API server."},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"Related options:"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_f8d66b4d","line":432,"range":{"start_line":432,"start_character":2,"end_line":432,"end_character":78},"in_reply_to":"dada55a8_4d0ee03b","updated":"2016-07-20 23:58:35.000000000","message":"Please note that this was pushed back in February, before that document existed. The idea behind that was that once these help improvements were merged, we would then clean up the formatting for the entire file, instead of section by section.","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"811d4812561825a3f7021a846c551c7b4ca784d9","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    metadata_port"},{"line_number":437,"context_line":"\"\"\"),"},{"line_number":438,"context_line":"    cfg.IntOpt(\"metadata_port\","},{"line_number":439,"context_line":"            default\u003d8775,"},{"line_number":440,"context_line":"            min\u003d1,"},{"line_number":441,"context_line":"            max\u003d65535,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_cdef7085","line":438,"range":{"start_line":438,"start_character":8,"end_line":438,"end_character":14},"updated":"2016-07-20 19:26:39.000000000","message":"Actually this Opt can be changed to PortOpt. Just remember that PortOpt does not support min and max params. ``Possible values`` section can be dropped afterwards.","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1e7b1594feec51f5b26afd4db16b4566c2e902ab","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    metadata_port"},{"line_number":437,"context_line":"\"\"\"),"},{"line_number":438,"context_line":"    cfg.IntOpt(\"metadata_port\","},{"line_number":439,"context_line":"            default\u003d8775,"},{"line_number":440,"context_line":"            min\u003d1,"},{"line_number":441,"context_line":"            max\u003d65535,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_58c857a8","line":438,"range":{"start_line":438,"start_character":8,"end_line":438,"end_character":14},"in_reply_to":"dada55a8_cdef7085","updated":"2016-07-20 23:58:35.000000000","message":"Done","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"811d4812561825a3f7021a846c551c7b4ca784d9","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"Possible values:"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"   Any positive integer if a limited timeout is desired, or zero if the calls"},{"line_number":504,"context_line":"   should wait forever for a response."},{"line_number":505,"context_line":"\"\"\"),"},{"line_number":506,"context_line":"    cfg.BoolOpt(\"fake_network\","}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_edd354d3","line":503,"range":{"start_line":503,"start_character":3,"end_line":503,"end_character":64},"updated":"2016-07-20 19:26:39.000000000","message":"Please add min\u003d0 to IntOpt.","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"811d4812561825a3f7021a846c551c7b4ca784d9","unresolved":false,"context_lines":[{"line_number":516,"context_line":"giving up. The minimum number of retries is 1, even if this option is set to a"},{"line_number":517,"context_line":"negative value or zero."},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Possible values:"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"   Any positive integer"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"Related options:"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_0d586889","line":521,"range":{"start_line":519,"start_character":0,"end_line":521,"end_character":23},"updated":"2016-07-20 19:26:39.000000000","message":"Please add min\u003d0 to IntOpt. Afterwards this section can be dropped.","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1e7b1594feec51f5b26afd4db16b4566c2e902ab","unresolved":false,"context_lines":[{"line_number":516,"context_line":"giving up. The minimum number of retries is 1, even if this option is set to a"},{"line_number":517,"context_line":"negative value or zero."},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Possible values:"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"   Any positive integer"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"Related options:"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_ec2cec9a","line":521,"range":{"start_line":519,"start_character":0,"end_line":521,"end_character":23},"in_reply_to":"dada55a8_0d586889","updated":"2016-07-20 23:58:35.000000000","message":"Actually, the min should be 1, since a zero will be treated as a 1. And \u0027possible values\u0027 still applies, because we should be explicit that there is no upper bound.","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"811d4812561825a3f7021a846c551c7b4ca784d9","unresolved":false,"context_lines":[{"line_number":536,"context_line":""},{"line_number":537,"context_line":"Possible values:"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"   Any positive float or integer. Setting this to zero will result in no"},{"line_number":540,"context_line":"   waiting between attempts, and setting this to a negative value will result"},{"line_number":541,"context_line":"   an exception being thrown if an ebtables retry is every needed."},{"line_number":542,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_2d6c4c34","line":539,"range":{"start_line":539,"start_character":3,"end_line":539,"end_character":33},"updated":"2016-07-20 19:26:39.000000000","message":"Please add min\u003d0.0 to FloatOpt.","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1e7b1594feec51f5b26afd4db16b4566c2e902ab","unresolved":false,"context_lines":[{"line_number":536,"context_line":""},{"line_number":537,"context_line":"Possible values:"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"   Any positive float or integer. Setting this to zero will result in no"},{"line_number":540,"context_line":"   waiting between attempts, and setting this to a negative value will result"},{"line_number":541,"context_line":"   an exception being thrown if an ebtables retry is every needed."},{"line_number":542,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_6c959c85","line":539,"range":{"start_line":539,"start_character":3,"end_line":539,"end_character":33},"in_reply_to":"dada55a8_2d6c4c34","updated":"2016-07-20 23:58:35.000000000","message":"Done","commit_id":"47060d9830f91cf90c7868b295ea923da8228912"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"c706bd05ba54af2af6afcc93df73050205de41be","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            help\u003d\"\"\""},{"line_number":706,"context_line":"This option determines the number of time to retry ebtables commands before"},{"line_number":707,"context_line":"giving up. The minimum number of retries is 1, even if this option is set to a"},{"line_number":708,"context_line":"negative value or zero."},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"Possible values:"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_bf578624","line":708,"updated":"2016-07-21 19:06:42.000000000","message":"Isn\u0027t this text now untrue? You can\u0027t set the flag to a negative number, as the flag enforces a positive number. In other news, does this reduce the code we need in the implementation where this was previously enforced?","commit_id":"d616ceccfe38ade9b2806696a28606350a691560"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"daa877470fe1a0f826b3cebd33a064878f52dfef","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            help\u003d\"\"\""},{"line_number":706,"context_line":"This option determines the number of time to retry ebtables commands before"},{"line_number":707,"context_line":"giving up. The minimum number of retries is 1, even if this option is set to a"},{"line_number":708,"context_line":"negative value or zero."},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"Possible values:"},{"line_number":711,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_2b0b5425","line":708,"in_reply_to":"dada55a8_bf578624","updated":"2016-07-21 20:17:55.000000000","message":"Good point. The code is removed in a follow-up patch.","commit_id":"d616ceccfe38ade9b2806696a28606350a691560"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"c706bd05ba54af2af6afcc93df73050205de41be","unresolved":false,"context_lines":[{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    * Any non-negative float or integer. Setting this to zero will result in no"},{"line_number":732,"context_line":"    waiting between attempts, and setting this to a negative value will result"},{"line_number":733,"context_line":"    an exception being thrown if an ebtables retry is every needed."},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"Related options:"},{"line_number":736,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_bf05c614","line":733,"updated":"2016-07-21 19:06:42.000000000","message":"/is every/is ever/\n\nAnd is this true any more? Surely we\u0027ll never throw this exception now because the process would refuse to start instead?","commit_id":"d616ceccfe38ade9b2806696a28606350a691560"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"daa877470fe1a0f826b3cebd33a064878f52dfef","unresolved":false,"context_lines":[{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    * Any non-negative float or integer. Setting this to zero will result in no"},{"line_number":732,"context_line":"    waiting between attempts, and setting this to a negative value will result"},{"line_number":733,"context_line":"    an exception being thrown if an ebtables retry is every needed."},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"Related options:"},{"line_number":736,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_cb1c386c","line":733,"in_reply_to":"dada55a8_bf05c614","updated":"2016-07-21 20:17:55.000000000","message":"Done","commit_id":"d616ceccfe38ade9b2806696a28606350a691560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"37628d19eb334002045d68cda4e2ff3658e06929","unresolved":false,"context_lines":[{"line_number":666,"context_line":""},{"line_number":667,"context_line":"Related options:"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    * iptables_top_rege+x"},{"line_number":670,"context_line":"\"\"\"),"},{"line_number":671,"context_line":"    cfg.StrOpt(\"iptables_drop_action\","},{"line_number":672,"context_line":"            default\u003d\"DROP\","}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_b1da1615","line":669,"range":{"start_line":669,"start_character":6,"end_line":669,"end_character":25},"updated":"2016-07-21 21:43:04.000000000","message":"iptables_top_regex","commit_id":"1208610759b966fec224758aaf1cdd9f23c9b86f"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f6196107cf4127fb540d982e4eb88715e0340216","unresolved":false,"context_lines":[{"line_number":666,"context_line":""},{"line_number":667,"context_line":"Related options:"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    * iptables_top_rege+x"},{"line_number":670,"context_line":"\"\"\"),"},{"line_number":671,"context_line":"    cfg.StrOpt(\"iptables_drop_action\","},{"line_number":672,"context_line":"            default\u003d\"DROP\","}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_65fbb479","line":669,"range":{"start_line":669,"start_character":6,"end_line":669,"end_character":25},"in_reply_to":"dada55a8_b1da1615","updated":"2016-07-22 00:00:18.000000000","message":"Done","commit_id":"1208610759b966fec224758aaf1cdd9f23c9b86f"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"37628d19eb334002045d68cda4e2ff3658e06929","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    cfg.StrOpt(\"iptables_drop_action\","},{"line_number":672,"context_line":"            default\u003d\"DROP\","},{"line_number":673,"context_line":"            help\u003d\"\"\""},{"line_number":674,"context_line":"By default, packets that do not pass the firewall are DROPped. In many cases,"},{"line_number":675,"context_line":"though, an operator may find it more useful to change this from DROP to REJECT,"},{"line_number":676,"context_line":"so that the user issuing those packets may have a better idea as to what\u0027s"},{"line_number":677,"context_line":"going on, or LOGDROP in order to record the blocked traffic before DROPping."}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_51d91af2","line":674,"range":{"start_line":674,"start_character":54,"end_line":674,"end_character":61},"updated":"2016-07-21 21:43:04.000000000","message":"dropped?","commit_id":"1208610759b966fec224758aaf1cdd9f23c9b86f"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a134a9d832b4980355fd5fdf6eae4b3069b29589","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    cfg.StrOpt(\"iptables_drop_action\","},{"line_number":672,"context_line":"            default\u003d\"DROP\","},{"line_number":673,"context_line":"            help\u003d\"\"\""},{"line_number":674,"context_line":"By default, packets that do not pass the firewall are DROPped. In many cases,"},{"line_number":675,"context_line":"though, an operator may find it more useful to change this from DROP to REJECT,"},{"line_number":676,"context_line":"so that the user issuing those packets may have a better idea as to what\u0027s"},{"line_number":677,"context_line":"going on, or LOGDROP in order to record the blocked traffic before DROPping."}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_6598d478","line":674,"range":{"start_line":674,"start_character":54,"end_line":674,"end_character":61},"in_reply_to":"dada55a8_51d91af2","updated":"2016-07-21 23:52:55.000000000","message":"No, the name of the target is DROP, so I think this is correct.","commit_id":"1208610759b966fec224758aaf1cdd9f23c9b86f"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"37628d19eb334002045d68cda4e2ff3658e06929","unresolved":false,"context_lines":[{"line_number":703,"context_line":"            default\u003d3,"},{"line_number":704,"context_line":"            min\u003d1,"},{"line_number":705,"context_line":"            help\u003d\"\"\""},{"line_number":706,"context_line":"This option determines the number of time to retry ebtables commands before"},{"line_number":707,"context_line":"giving up. The minimum number of retries is 1."},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_b1f17697","line":706,"range":{"start_line":706,"start_character":37,"end_line":706,"end_character":41},"updated":"2016-07-21 21:43:04.000000000","message":"times","commit_id":"1208610759b966fec224758aaf1cdd9f23c9b86f"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f6196107cf4127fb540d982e4eb88715e0340216","unresolved":false,"context_lines":[{"line_number":703,"context_line":"            default\u003d3,"},{"line_number":704,"context_line":"            min\u003d1,"},{"line_number":705,"context_line":"            help\u003d\"\"\""},{"line_number":706,"context_line":"This option determines the number of time to retry ebtables commands before"},{"line_number":707,"context_line":"giving up. The minimum number of retries is 1."},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_85ece8bb","line":706,"range":{"start_line":706,"start_character":37,"end_line":706,"end_character":41},"in_reply_to":"dada55a8_b1f17697","updated":"2016-07-22 00:00:18.000000000","message":"Done","commit_id":"1208610759b966fec224758aaf1cdd9f23c9b86f"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"37628d19eb334002045d68cda4e2ff3658e06929","unresolved":false,"context_lines":[{"line_number":704,"context_line":"            min\u003d1,"},{"line_number":705,"context_line":"            help\u003d\"\"\""},{"line_number":706,"context_line":"This option determines the number of time to retry ebtables commands before"},{"line_number":707,"context_line":"giving up. The minimum number of retries is 1."},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"Possible values:"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_513d9a29","line":707,"range":{"start_line":707,"start_character":11,"end_line":707,"end_character":46},"updated":"2016-07-21 21:43:04.000000000","message":"This is actually redundant when setting min\u003d1","commit_id":"1208610759b966fec224758aaf1cdd9f23c9b86f"}]}