)]}'
{"nova/objects/migrate_data.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7e906b8e40d05c1951bed143c0bda4aeaf887ea4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # FIXME: image_type should be enum?"},{"line_number":115,"context_line":"        \u0027image_type\u0027: fields.StringField(),"},{"line_number":116,"context_line":"        \u0027block_migration\u0027: fields.BooleanField(),"},{"line_number":117,"context_line":"        \u0027disk_over_commit\u0027: fields.BooleanField(),"},{"line_number":118,"context_line":"        \u0027disk_available_mb\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":119,"context_line":"        \u0027is_shared_instance_path\u0027: fields.BooleanField(),"},{"line_number":120,"context_line":"        \u0027is_shared_block_storage\u0027: fields.BooleanField(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_2bb5067d","line":117,"updated":"2016-02-24 12:18:24.000000000","message":"seems like these should both be nullable\u003dtrue now?","commit_id":"3ce0c2ac8b4fbd13e1f211c3181b11161a574b23"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"b3e5305e9dd0f06456de958840f03c1edcf036ee","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # FIXME: image_type should be enum?"},{"line_number":115,"context_line":"        \u0027image_type\u0027: fields.StringField(),"},{"line_number":116,"context_line":"        \u0027block_migration\u0027: fields.BooleanField(),"},{"line_number":117,"context_line":"        \u0027disk_over_commit\u0027: fields.BooleanField(),"},{"line_number":118,"context_line":"        \u0027disk_available_mb\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":119,"context_line":"        \u0027is_shared_instance_path\u0027: fields.BooleanField(),"},{"line_number":120,"context_line":"        \u0027is_shared_block_storage\u0027: fields.BooleanField(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_d5098f96","line":117,"in_reply_to":"bae84128_2bb5067d","updated":"2016-02-24 14:02:05.000000000","message":"hi John, I used to make them as nullable\u003dtrue in previous patch set, but I split this patch to libvirt/xen, so sorry about that you may miss Dan\u0027s comment.\n\ncan you please check https://review.openstack.org/#/c/254101/9/nova/objects/migrate_data.py","commit_id":"3ce0c2ac8b4fbd13e1f211c3181b11161a574b23"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5f1bc17ffba34dd8c25669f63b6a1ffe87479b1c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # FIXME: image_type should be enum?"},{"line_number":115,"context_line":"        \u0027image_type\u0027: fields.StringField(),"},{"line_number":116,"context_line":"        \u0027block_migration\u0027: fields.BooleanField(),"},{"line_number":117,"context_line":"        \u0027disk_over_commit\u0027: fields.BooleanField(),"},{"line_number":118,"context_line":"        \u0027disk_available_mb\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":119,"context_line":"        \u0027is_shared_instance_path\u0027: fields.BooleanField(),"},{"line_number":120,"context_line":"        \u0027is_shared_block_storage\u0027: fields.BooleanField(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_ee9006ef","line":117,"in_reply_to":"bae84128_d5098f96","updated":"2016-02-26 10:11:45.000000000","message":"hmm, he is correct. that sucks.","commit_id":"3ce0c2ac8b4fbd13e1f211c3181b11161a574b23"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7e906b8e40d05c1951bed143c0bda4aeaf887ea4","unresolved":false,"context_lines":[{"line_number":5491,"context_line":"        data.filename \u003d filename"},{"line_number":5492,"context_line":"        data.image_type \u003d CONF.libvirt.images_type"},{"line_number":5493,"context_line":"        # Notes(eliqiao): block_migration and disk_over_commit are not"},{"line_number":5494,"context_line":"        # nullable, so just don\u0027t set them if they are None"},{"line_number":5495,"context_line":"        if block_migration is not None:"},{"line_number":5496,"context_line":"            data.block_migration \u003d block_migration"},{"line_number":5497,"context_line":"        if disk_over_commit is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_2b9ea606","line":5494,"updated":"2016-02-24 12:18:24.000000000","message":"if we are using them as nullable, doesn\u0027t that mean we need to change the object?","commit_id":"3ce0c2ac8b4fbd13e1f211c3181b11161a574b23"}]}