)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"49c8ec4511f9f80f3f390955bc964a1816eec685","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix key error when create lpar instance failed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In function spawn in file nova/nova/virt/powervm/operator.py:"},{"line_number":10,"context_line":"try:"},{"line_number":11,"context_line":"    host_stats \u003d self.get_host_stats(refresh\u003dTrue)"},{"line_number":12,"context_line":"    lpar_inst \u003d self._create_lpar_instance(instance,"},{"line_number":13,"context_line":"                network_info, host_stats)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAOn%2F%2FtXg%3D","line":10,"updated":"2013-04-26 18:15:41.000000000","message":"I suggest to simplify this commit message to not include code snippet and just mention module and exception that needs to be passed the instance_name in the raise call","commit_id":"95226d189db18531bb79c7275202bef0186a91b8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"786807e53df1917a65b7e76c74899f775fa52359","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With existing code, when create lpar instance"},{"line_number":10,"context_line":"failed, it throws a key error because the parameter"},{"line_number":11,"context_line":"is not being passed to PowerVMLPARCreationFailed("},{"line_number":12,"context_line":"exception.NovaException) function in exception module"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The fix for this is that in module operator,  passing"},{"line_number":15,"context_line":"the \u0027instance_name\u0027 to the called function in exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAOn%2F%2Fs7s%3D","line":12,"updated":"2013-04-26 23:13:41.000000000","message":"Missing period at the end of this sentence. Also, I don\u0027t think specifying the base class in parenthesis after the exception name adds anything but confusion here.","commit_id":"dc5cdf7128c24efec9994b937f3c250de1ba51cd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"786807e53df1917a65b7e76c74899f775fa52359","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is not being passed to PowerVMLPARCreationFailed("},{"line_number":12,"context_line":"exception.NovaException) function in exception module"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The fix for this is that in module operator,  passing"},{"line_number":15,"context_line":"the \u0027instance_name\u0027 to the called function in exception"},{"line_number":16,"context_line":"module."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAOn%2F%2Fs7g%3D","line":14,"updated":"2013-04-26 23:13:41.000000000","message":"Two spaces after this comma.","commit_id":"dc5cdf7128c24efec9994b937f3c250de1ba51cd"}],"nova/tests/test_powervm.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c1c4f5af59ddb3d436846260ef18413cdecb6956","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            self.powervm_connection._powervm,"},{"line_number":227,"context_line":"            \u0027get_host_stats\u0027,"},{"line_number":228,"context_line":"            lambda *x, **y: raise_("},{"line_number":229,"context_line":"                (exception.PowerVMLPARCreationFailed(\u0027instance_name\u0027))))"},{"line_number":230,"context_line":"        fake_net_info \u003d network_model.NetworkInfo(["},{"line_number":231,"context_line":"                                     fake_network_cache_model.new_vif()])"},{"line_number":232,"context_line":"        self.assertRaises(exception.PowerVMLPARCreationFailed,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fp7I%3D","line":229,"updated":"2013-04-30 13:39:35.000000000","message":"This will cause the first line of the try..except block that you modified to raise a PowerVMLPARCreationFailed. However, the code you added is checking for a ProcessExecutionError and raising the former as a result. Thus, this test does not test the code you added.","commit_id":"e80d236f1034904ba6158790580f7ce2ab9e7113"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b57b1969280d2494d55b4b94b9050171a7f246fc","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            self.powervm_connection._powervm,"},{"line_number":227,"context_line":"            \u0027get_host_stats\u0027,"},{"line_number":228,"context_line":"            lambda *x, **y: raise_("},{"line_number":229,"context_line":"                (exception.PowerVMLPARCreationFailed(\u0027instance_name\u0027))))"},{"line_number":230,"context_line":"        fake_net_info \u003d network_model.NetworkInfo(["},{"line_number":231,"context_line":"                                     fake_network_cache_model.new_vif()])"},{"line_number":232,"context_line":"        self.assertRaises(exception.PowerVMLPARCreationFailed,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FneE%3D","line":229,"in_reply_to":"AAAAOn%2F%2Fp7I%3D","updated":"2013-05-01 18:33:10.000000000","message":"I think here we need to raise ProcessExecutionError in the stub that you currently have that raises PowerVMLPARCreationFailed. That way we know the test is asserting PowerVMLPARCreationFailed is raised after the ProcessExecutionError has been \u0027excepted\u0027.","commit_id":"e80d236f1034904ba6158790580f7ce2ab9e7113"}],"nova/virt/powervm/operator.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"73cd40893236571c8a31b39077b46ac98caa5eab","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            except nova_exception.ProcessExecutionError:"},{"line_number":203,"context_line":"                LOG.exception(_(\"LPAR instance \u0027%s\u0027 creation failed\") %"},{"line_number":204,"context_line":"                        instance[\u0027name\u0027])"},{"line_number":205,"context_line":"                raise exception.PowerVMLPARCreationFailed(instance_name\u003dinstance[\u0027name\u0027] )"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"            _create_image(context, instance, image_id)"},{"line_number":208,"context_line":"            LOG.debug(_(\"Activating the LPAR instance \u0027%s\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FtPE%3D","line":205,"updated":"2013-04-26 19:28:23.000000000","message":"Actually I think it was just pep8 complains:\n2013-04-26 18:23:17.472 | ./nova/virt/powervm/operator.py:205:80: E501 line too long (90 \u003e 79 characters)\n2013-04-26 18:23:17.472 | ./nova/virt/powervm/operator.py:205:89: E202 whitespace before \u0027)\u0027","commit_id":"e62874230ff34a577d39ab819a1148c551a2922d"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"bca765a71b3f03da725afbc49e73a4f84871eede","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            except nova_exception.ProcessExecutionError:"},{"line_number":203,"context_line":"                LOG.exception(_(\"LPAR instance \u0027%s\u0027 creation failed\") %"},{"line_number":204,"context_line":"                        instance[\u0027name\u0027])"},{"line_number":205,"context_line":"                raise exception.PowerVMLPARCreationFailed(instance_name\u003dinstance[\u0027name\u0027] )"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"            _create_image(context, instance, image_id)"},{"line_number":208,"context_line":"            LOG.debug(_(\"Activating the LPAR instance \u0027%s\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FtVA%3D","line":205,"updated":"2013-04-26 18:33:07.000000000","message":"I didn\u0027t find this exception PowerVMLPARCreationFailed..","commit_id":"e62874230ff34a577d39ab819a1148c551a2922d"}]}